Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorUwe Stieber2011-12-04 08:15:21 -0500
committerUwe Stieber2011-12-04 08:15:21 -0500
commit4b8218fb63d221ee6e869510ef2eb9ef2acdc84d (patch)
tree20270a545daa04cf8e32d0278a8154215fa02cd5 /target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler
parent5074dafdd71e2905db0160f82326900aa1a60215 (diff)
downloadorg.eclipse.tcf-4b8218fb63d221ee6e869510ef2eb9ef2acdc84d.tar.gz
org.eclipse.tcf-4b8218fb63d221ee6e869510ef2eb9ef2acdc84d.tar.xz
org.eclipse.tcf-4b8218fb63d221ee6e869510ef2eb9ef2acdc84d.zip
Target Explorer: Added step bindings extension point manager and fixed bugs revealed by the unit tests for the stepper engine
Diffstat (limited to 'target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler')
-rw-r--r--target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/plugin.properties4
-rw-r--r--target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/bindings.exsd4
-rw-r--r--target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/handlers.exsd2
-rw-r--r--target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/src/org/eclipse/tcf/te/runtime/statushandler/internal/StatusHandlerBindingExtensionPointManager.java10
4 files changed, 9 insertions, 11 deletions
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/plugin.properties b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/plugin.properties
index 3399d316b..ee1c54216 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/plugin.properties
+++ b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/plugin.properties
@@ -13,5 +13,5 @@ providerName = Eclipse.org
# ***** Extension Points *****
-ExtensionPoint.handlers.name=Target Explorer Status Handlers Extension Point
-ExtensionPoint.bindings.name=Target Explorer Status Handler Bindings Extension Point
+ExtensionPoint.handlers.name=Status Handlers Extension Point
+ExtensionPoint.bindings.name=Status Handler Bindings Extension Point
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/bindings.exsd b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/bindings.exsd
index ba81a8563..1265f1a70 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/bindings.exsd
+++ b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/bindings.exsd
@@ -3,7 +3,7 @@
<schema targetNamespace="org.eclipse.tcf.te.runtime.statushandler" xmlns="http://www.w3.org/2001/XMLSchema">
<annotation>
<appinfo>
- <meta.schema plugin="org.eclipse.tcf.te.runtime.statushandler" id="bindings" name="%ExtensionPoint.handlers.name"/>
+ <meta.schema plugin="org.eclipse.tcf.te.runtime.statushandler" id="bindings" name="Status Handler Bindings Extension Point"/>
</appinfo>
<documentation>
This extension point is used to declare the Target Explorer status handler bindings.
@@ -99,7 +99,7 @@
&lt;extension point=&quot;org.eclipse.tcf.te.runtime.statushandler.bindings&quot;&gt;
&lt;binding
id=&quot;org.eclipse.tcf.te.ui.statushandler.binding.NotificationPopupStatusHandler&quot;
- pageId=&quot;org.eclipse.tcf.te.ui.statushandler.NotificationPopupStatusHandler&quot;&gt;
+ handlerId=&quot;org.eclipse.tcf.te.ui.statushandler.NotificationPopupStatusHandler&quot;&gt;
&lt;enablement&gt;
...
&lt;/enablement&gt;
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/handlers.exsd b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/handlers.exsd
index 59c3afaf4..faf5d9fb4 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/handlers.exsd
+++ b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/schema/handlers.exsd
@@ -3,7 +3,7 @@
<schema targetNamespace="org.eclipse.tcf.te.runtime.statushandler" xmlns="http://www.w3.org/2001/XMLSchema">
<annotation>
<appinfo>
- <meta.schema plugin="org.eclipse.tcf.te.runtime.statushandler" id="handlers" name="Target Explorer Status Handler Extension Point"/>
+ <meta.schema plugin="org.eclipse.tcf.te.runtime.statushandler" id="handlers" name="Status Handler Extension Point"/>
</appinfo>
<documentation>
This extension point is used to allow the contribution of new Target Explorer status handler.
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/src/org/eclipse/tcf/te/runtime/statushandler/internal/StatusHandlerBindingExtensionPointManager.java b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/src/org/eclipse/tcf/te/runtime/statushandler/internal/StatusHandlerBindingExtensionPointManager.java
index 897747e35..fe8fd2462 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/src/org/eclipse/tcf/te/runtime/statushandler/internal/StatusHandlerBindingExtensionPointManager.java
+++ b/target_explorer/plugins/org.eclipse.tcf.te.runtime.statushandler/src/org/eclipse/tcf/te/runtime/statushandler/internal/StatusHandlerBindingExtensionPointManager.java
@@ -21,9 +21,9 @@ import org.eclipse.core.runtime.IConfigurationElement;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Status;
-import org.eclipse.tcf.te.runtime.statushandler.activator.CoreBundleActivator;
import org.eclipse.tcf.te.runtime.extensions.AbstractExtensionPointManager;
import org.eclipse.tcf.te.runtime.extensions.ExecutableExtensionProxy;
+import org.eclipse.tcf.te.runtime.statushandler.activator.CoreBundleActivator;
/**
@@ -104,8 +104,7 @@ public class StatusHandlerBindingExtensionPointManager extends AbstractExtension
for (StatusHandlerBinding binding : getBindings()) {
Expression enablement = binding.getEnablement();
- // The page binding is applicable by default if no expression
- // is specified.
+ // The binding is applicable by default if no expression is specified.
boolean isApplicable = enablement == null;
if (enablement != null) {
@@ -121,13 +120,12 @@ public class StatusHandlerBindingExtensionPointManager extends AbstractExtension
Platform.getLog(CoreBundleActivator.getContext().getBundle()).log(status);
}
} else {
- // The enablement is false by definition if no
- // handler context is not given.
+ // The enablement is false by definition if no handler context is given.
isApplicable = false;
}
}
- // Add the page if applicable
+ // Add the binding if applicable
if (isApplicable) applicable.add(binding);
}

Back to the top