Target Explorer: add possibility to get current data from sections and

global validation

1 files changed, 16 insertions, 6 deletions

diff --git a/target_explorer/plugins/org.eclipse.tcf.te.ui/src/org/eclipse/tcf/te/ui/dialogs/AbstractSectionDialog.java b/target_explorer/plugins/org.eclipse.tcf.te.ui/src/org/eclipse/tcf/te/ui/dialogs/AbstractSectionDialog.java
index bdf5fb1eb..f66a0e05f 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.ui/src/org/eclipse/tcf/te/ui/dialogs/AbstractSectionDialog.java
+++ b/target_explorer/plugins/org.eclipse.tcf.te.ui/src/org/eclipse/tcf/te/ui/dialogs/AbstractSectionDialog.java
@@ -227,12 +227,7 @@ public abstract class AbstractSectionDialog extends CustomTitleAreaDialog implem
 		IPropertiesContainer workingData = new PropertiesContainer();
 		if (sections != null) {
 			// get working data
-			for (AbstractSection section : sections) {
-				if (section instanceof IDataExchangeNode) {
-					((IDataExchangeNode)section).extractData(workingData);
-				}
-			}
-
+			internalExtractData(workingData);
 			// update sections
 			for (AbstractSection section : sections) {
 				if (section instanceof IUpdatable) {
@@ -252,6 +247,14 @@ public abstract class AbstractSectionDialog extends CustomTitleAreaDialog implem
 		data.setProperties(this.data.getProperties());
 	}
 
+	protected void internalExtractData(IPropertiesContainer data) {
+		for (AbstractSection section : sections) {
+			if (section instanceof IDataExchangeNode) {
+				((IDataExchangeNode)section).extractData(data);
+			}
+		}
+	}
+
 	/* (non-Javadoc)
 	 * @see org.eclipse.tcf.te.ui.jface.dialogs.CustomTitleAreaDialog#dispose()
 	 */
@@ -330,6 +333,9 @@ public abstract class AbstractSectionDialog extends CustomTitleAreaDialog implem
 				valid &= section.isValid();
 				result.setResult(section);
 			}
+
+			valid &= doAdditionalValidation(result);
+
 			setMessage(result.getMessage(), result.getMessageType());
 			if (!isMessageSet()) {
 				setMessage(message);
@@ -339,4 +345,8 @@ public abstract class AbstractSectionDialog extends CustomTitleAreaDialog implem
 			getButton(IDialogConstants.OK_ID).setEnabled(!readOnly && valid);
 		}
 	}
+
+	protected boolean doAdditionalValidation(ValidationResult result) {
+		return true;
+	}
 }