Bug 517609 - TCFNumberFormat toByteArray method does not perform sign extension properly in big endian mode

1 files changed, 3 insertions, 2 deletions

diff --git a/plugins/org.eclipse.tcf.debug.ui/src/org/eclipse/tcf/internal/debug/ui/model/TCFNumberFormat.java b/plugins/org.eclipse.tcf.debug.ui/src/org/eclipse/tcf/internal/debug/ui/model/TCFNumberFormat.java
index 11ce576a2..76fc092cb 100644
--- a/plugins/org.eclipse.tcf.debug.ui/src/org/eclipse/tcf/internal/debug/ui/model/TCFNumberFormat.java
+++ b/plugins/org.eclipse.tcf.debug.ui/src/org/eclipse/tcf/internal/debug/ui/model/TCFNumberFormat.java
@@ -78,7 +78,7 @@ public class TCFNumberFormat {
         boolean sign_extention = false;
         if (!fp) {
             BigInteger n = new BigInteger(s, radix);
-            sign_extention =  n.signum() < 0;
+            sign_extention = n.signum() < 0;
             bf = n.toByteArray();
         }
         else if (size == 4) {
@@ -188,7 +188,8 @@ public class TCFNumberFormat {
         }
         byte[] rs = new byte[size];
         if (rs.length > bf.length && sign_extention) {
-            for (int i = bf.length; i < rs.length; i++) rs[i] = (byte)0xff;
+            // It is easier to fill all bytes instead of checking big_endian
+            for (int i = 0; i < rs.length; i++) rs[i] = (byte)0xff;
         }
         for (int i = 0; i < bf.length; i++) {
             // i == 0 -> least significant byte