Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorUwe Stieber2012-04-25 15:26:28 +0000
committerUwe Stieber2012-04-25 15:26:28 +0000
commit422c0633487a8bc5b3e27acaba1d1e99832df006 (patch)
tree90e0b683c24fe0d040631c1bb497416e70a3fe03
parent45c374773adf6196ad239a74944b529125e53e0b (diff)
downloadorg.eclipse.tcf-422c0633487a8bc5b3e27acaba1d1e99832df006.tar.gz
org.eclipse.tcf-422c0633487a8bc5b3e27acaba1d1e99832df006.tar.xz
org.eclipse.tcf-422c0633487a8bc5b3e27acaba1d1e99832df006.zip
Target Explorer: Fix FindBugs warnings
-rw-r--r--admin/findbugs-exclude.xml9
-rw-r--r--target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java2
2 files changed, 10 insertions, 1 deletions
diff --git a/admin/findbugs-exclude.xml b/admin/findbugs-exclude.xml
index 63c70c87a..509fddd77 100644
--- a/admin/findbugs-exclude.xml
+++ b/admin/findbugs-exclude.xml
@@ -23,4 +23,13 @@
<Match>
<Bug category="I18N"/>
</Match>
+
+ <!-- Ignore LI_LAZY_INIT_UPDATE_STATIC in Model.java -->
+ <Match>
+ <Bug pattern="LI_LAZY_INIT_UPDATE_STATIC"/>
+ <And>
+ <Class name="org.eclipse.tcf.te.tcf.locator.model.Model"/>
+ <Method name="initialize"/>
+ </And>
+ </Match>
</FindBugsFilter>
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java b/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java
index 2f24f1d06..0a16f32ac 100644
--- a/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java
+++ b/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java
@@ -339,7 +339,7 @@ public abstract class AbstractServiceManager {
boolean isInterface = serviceType.isInterface();
for (ServiceProxy proxy : proxies) {
if (proxy.isMatching(serviceType) && proxy.isEnabled(context)) {
- if (!isInterface && proxy.equals(serviceType)) {
+ if (!isInterface) {
V service = (V)proxy.getService(unique);
service.setId(proxy.getId());
return service;

Back to the top