diff options
author | Uwe Stieber | 2012-04-25 15:26:28 +0000 |
---|---|---|
committer | Uwe Stieber | 2012-04-25 15:26:28 +0000 |
commit | 422c0633487a8bc5b3e27acaba1d1e99832df006 (patch) | |
tree | 90e0b683c24fe0d040631c1bb497416e70a3fe03 | |
parent | 45c374773adf6196ad239a74944b529125e53e0b (diff) | |
download | org.eclipse.tcf-422c0633487a8bc5b3e27acaba1d1e99832df006.tar.gz org.eclipse.tcf-422c0633487a8bc5b3e27acaba1d1e99832df006.tar.xz org.eclipse.tcf-422c0633487a8bc5b3e27acaba1d1e99832df006.zip |
Target Explorer: Fix FindBugs warnings
-rw-r--r-- | admin/findbugs-exclude.xml | 9 | ||||
-rw-r--r-- | target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java | 2 |
2 files changed, 10 insertions, 1 deletions
diff --git a/admin/findbugs-exclude.xml b/admin/findbugs-exclude.xml index 63c70c87a..509fddd77 100644 --- a/admin/findbugs-exclude.xml +++ b/admin/findbugs-exclude.xml @@ -23,4 +23,13 @@ <Match> <Bug category="I18N"/> </Match> + + <!-- Ignore LI_LAZY_INIT_UPDATE_STATIC in Model.java --> + <Match> + <Bug pattern="LI_LAZY_INIT_UPDATE_STATIC"/> + <And> + <Class name="org.eclipse.tcf.te.tcf.locator.model.Model"/> + <Method name="initialize"/> + </And> + </Match> </FindBugsFilter> diff --git a/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java b/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java index 2f24f1d06..0a16f32ac 100644 --- a/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java +++ b/target_explorer/plugins/org.eclipse.tcf.te.runtime.services/src/org/eclipse/tcf/te/runtime/services/AbstractServiceManager.java @@ -339,7 +339,7 @@ public abstract class AbstractServiceManager { boolean isInterface = serviceType.isInterface(); for (ServiceProxy proxy : proxies) { if (proxy.isMatching(serviceType) && proxy.isEnabled(context)) { - if (!isInterface && proxy.equals(serviceType)) { + if (!isInterface) { V service = (V)proxy.getService(unique); service.setId(proxy.getId()); return service; |