Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRainer Niedermayr2015-02-03 15:22:52 +0000
committerJudith Gull2015-02-04 15:03:39 +0000
commit94338d9ad40d5b1bdcae1963f3ef7d2a490188d5 (patch)
tree629978ca9ad4891f019eb13d25b79a74c1e5c5cc
parent2012d29799f0e4f2c2c7b1fe8348ff971f0c0596 (diff)
downloadorg.eclipse.scout.rt-94338d9ad40d5b1bdcae1963f3ef7d2a490188d5.tar.gz
org.eclipse.scout.rt-94338d9ad40d5b1bdcae1963f3ef7d2a490188d5.tar.xz
org.eclipse.scout.rt-94338d9ad40d5b1bdcae1963f3ef7d2a490188d5.zip
Bug 459040 - Incomplete Logging in ConfigIniUtility
https://bugs.eclipse.org/bugs/show_bug.cgi?id=459040 Fix. Change-Id: I09d49d2046497ed1cba894fd5931a01bec38c758 Signed-off-by: Rainer Niedermayr <rainer.niedermayr@bsiag.com> Reviewed-on: https://git.eclipse.org/r/41080 Tested-by: Hudson CI Reviewed-by: Judith Gull <jgu@bsiag.com>
-rw-r--r--org.eclipse.scout.commons/src/org/eclipse/scout/commons/ConfigIniUtility.java12
1 files changed, 4 insertions, 8 deletions
diff --git a/org.eclipse.scout.commons/src/org/eclipse/scout/commons/ConfigIniUtility.java b/org.eclipse.scout.commons/src/org/eclipse/scout/commons/ConfigIniUtility.java
index 28ce529a16..81d9e4bcb3 100644
--- a/org.eclipse.scout.commons/src/org/eclipse/scout/commons/ConfigIniUtility.java
+++ b/org.eclipse.scout.commons/src/org/eclipse/scout/commons/ConfigIniUtility.java
@@ -39,7 +39,7 @@ import org.eclipse.scout.commons.logger.ScoutLogManager;
* <li>com.myapp.MyService/query#realm=QueryRealm</li>
* <p>
* Supports for config.ini files in an external area
- *
+ *
* <pre>
* <code>
* external.configuration.area=[url | file | ${variable}]
@@ -49,7 +49,7 @@ import org.eclipse.scout.commons.logger.ScoutLogManager;
* ...
* </code>
* </pre>
- *
+ *
* where ${variable} is a system property or an environment variable containing an url or a file path to the FOLDER
* containing the config.ini
*/
@@ -132,9 +132,7 @@ public final class ConfigIniUtility {
}
}
catch (Throwable t) {
- if (in != null) {
- LOG.error("parsing " + file, t);
- }
+ LOG.error("parsing " + file, t);
}
finally {
if (in != null) {
@@ -198,9 +196,7 @@ public final class ConfigIniUtility {
}
}
catch (Throwable t) {
- if (in != null) {
- LOG.error("parsing external file " + path + " (" + resolvedPath + ")", t);
- }
+ LOG.error("parsing external file " + path + " (" + resolvedPath + ")", t);
}
finally {
if (in != null) {

Back to the top