summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Liebig2008-03-06 03:08:00 (EST)
committerStefan Liebig2008-03-06 03:08:00 (EST)
commite7f6469deb770ed2533935038014c867566fe3a4 (patch)
treecaa35589772748c74c77b875126768bb47877aa9
parent4d69213bc2c869230db095d9b3cc48286dda082e (diff)
downloadorg.eclipse.riena-e7f6469deb770ed2533935038014c867566fe3a4.zip
org.eclipse.riena-e7f6469deb770ed2533935038014c867566fe3a4.tar.gz
org.eclipse.riena-e7f6469deb770ed2533935038014c867566fe3a4.tar.bz2
avoid using literal "true"
-rw-r--r--org.eclipse.riena.security.server/src/org/eclipse/riena/internal/security/server/SecurityServiceHook.java2
-rw-r--r--org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/ClientRemoteLoginModule.java5
-rw-r--r--org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/LocalLoginModule.java5
3 files changed, 7 insertions, 5 deletions
diff --git a/org.eclipse.riena.security.server/src/org/eclipse/riena/internal/security/server/SecurityServiceHook.java b/org.eclipse.riena.security.server/src/org/eclipse/riena/internal/security/server/SecurityServiceHook.java
index 8273226..cb8a7d4 100644
--- a/org.eclipse.riena.security.server/src/org/eclipse/riena/internal/security/server/SecurityServiceHook.java
+++ b/org.eclipse.riena.security.server/src/org/eclipse/riena/internal/security/server/SecurityServiceHook.java
@@ -192,7 +192,7 @@ public class SecurityServiceHook implements IServiceHook {
LOGGER.log(LogService.LOG_ERROR, "error in call to webservice {" + callback.getInterfaceName()
+ "} since it is not in the list of webservices that do not require a session but SSOID=null !!!");
if (System.getProperty("spirit.secure.webservices") == null
- || System.getProperty("spirit.secure.webservices").equals("true")) {
+ || Boolean.getBoolean("spirit.secure.webservices")) {
throw new NotAuthorizedFailure("call to webservice " + callback.getInterfaceName()
+ " failed, no valid session was given but is required.");
}
diff --git a/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/ClientRemoteLoginModule.java b/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/ClientRemoteLoginModule.java
index 615d7b3..09224b9 100644
--- a/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/ClientRemoteLoginModule.java
+++ b/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/ClientRemoteLoginModule.java
@@ -70,7 +70,8 @@ public class ClientRemoteLoginModule implements LoginModule {
* javax.security.auth.callback.CallbackHandler, java.util.Map,
* java.util.Map)
*/
- public void initialize(Subject subject, CallbackHandler callbackHandler, Map<String, ?> sharedState, Map<String, ?> options) {
+ public void initialize(Subject subject, CallbackHandler callbackHandler, Map<String, ?> sharedState,
+ Map<String, ?> options) {
this.subject = subject;
this.callbackHandler = callbackHandler;
this.sharedState = sharedState;
@@ -78,7 +79,7 @@ public class ClientRemoteLoginModule implements LoginModule {
this.clientLogin = new ClientLogin("Test", subject);
// initialize any configured options
- debug = "true".equalsIgnoreCase((String) options.get("debug"));
+ debug = Boolean.valueOf((String) options.get("debug"));
}
/*
diff --git a/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/LocalLoginModule.java b/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/LocalLoginModule.java
index fcde012..d79529f 100644
--- a/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/LocalLoginModule.java
+++ b/org.eclipse.riena.tests/src/org/eclipse/riena/security/services/itest/module/LocalLoginModule.java
@@ -68,14 +68,15 @@ public class LocalLoginModule implements LoginModule {
* javax.security.auth.callback.CallbackHandler, java.util.Map,
* java.util.Map)
*/
- public void initialize(Subject subject, CallbackHandler callbackHandler, Map<String, ?> sharedState, Map<String, ?> options) {
+ public void initialize(Subject subject, CallbackHandler callbackHandler, Map<String, ?> sharedState,
+ Map<String, ?> options) {
this.subject = subject;
this.callbackHandler = callbackHandler;
this.sharedState = sharedState;
this.options = options;
// initialize any configured options
- debug = "true".equalsIgnoreCase((String) options.get("debug"));
+ debug = Boolean.valueOf((String) options.get("debug"));
}
/*