summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCarsten Drossel2009-01-22 05:02:01 (EST)
committerCarsten Drossel2009-01-22 05:02:01 (EST)
commitd84ecc6bfb6cbce9342a68c0cf5747000ede82a4 (patch)
tree1d27ce3da9f1385ceb4d424b7695bf949990d188
parentda03e5bc4859d458e4c0284965c4c40780442efe (diff)
downloadorg.eclipse.riena-d84ecc6bfb6cbce9342a68c0cf5747000ede82a4.zip
org.eclipse.riena-d84ecc6bfb6cbce9342a68c0cf5747000ede82a4.tar.gz
org.eclipse.riena-d84ecc6bfb6cbce9342a68c0cf5747000ede82a4.tar.bz2
handling TODOs and typos
-rw-r--r--org.eclipse.riena.navigation.ui.swt/src/org/eclipse/riena/navigation/ui/swt/application/SwtApplication.java9
-rw-r--r--org.eclipse.riena.navigation.ui/src/org/eclipse/riena/navigation/ui/application/AbstractApplication.java8
2 files changed, 10 insertions, 7 deletions
diff --git a/org.eclipse.riena.navigation.ui.swt/src/org/eclipse/riena/navigation/ui/swt/application/SwtApplication.java b/org.eclipse.riena.navigation.ui.swt/src/org/eclipse/riena/navigation/ui/swt/application/SwtApplication.java
index 7fca3f6..26773ed 100644
--- a/org.eclipse.riena.navigation.ui.swt/src/org/eclipse/riena/navigation/ui/swt/application/SwtApplication.java
+++ b/org.eclipse.riena.navigation.ui.swt/src/org/eclipse/riena/navigation/ui/swt/application/SwtApplication.java
@@ -279,7 +279,10 @@ public abstract class SwtApplication extends AbstractApplication {
return null;
}
- // TODO: bugzilla request?!
+ // Use the splash handler of the workbench both for the login and for
+ // a later re-login after inactivity timeout. Unfortunately it is not
+ // accessible and an enhancement request to change that was rejected:
+ // https://bugs.eclipse.org/bugs/show_bug.cgi?id=260736.
AbstractSplashHandler loginSplashHandler = ReflectionUtils.invokeHidden(Workbench.class, "getSplash"); //$NON-NLS-1$
if (loginSplashHandler instanceof AbstractLoginSplashHandler) {
return (AbstractLoginSplashHandler) loginSplashHandler;
@@ -299,9 +302,9 @@ public abstract class SwtApplication extends AbstractApplication {
}
@Override
- protected void initialzeLoginViewDefinition() {
+ protected void initializeLoginViewDefinition() {
- super.initialzeLoginViewDefinition();
+ super.initializeLoginViewDefinition();
initialzeLoginSplashViewDefinition();
}
diff --git a/org.eclipse.riena.navigation.ui/src/org/eclipse/riena/navigation/ui/application/AbstractApplication.java b/org.eclipse.riena.navigation.ui/src/org/eclipse/riena/navigation/ui/application/AbstractApplication.java
index 6cf3889..b5c2c45 100644
--- a/org.eclipse.riena.navigation.ui/src/org/eclipse/riena/navigation/ui/application/AbstractApplication.java
+++ b/org.eclipse.riena.navigation.ui/src/org/eclipse/riena/navigation/ui/application/AbstractApplication.java
@@ -49,7 +49,7 @@ public abstract class AbstractApplication implements IApplication {
public Object start(IApplicationContext context) throws Exception {
- Object result = initialzePerformLogin(context);
+ Object result = initializePerformLogin(context);
if (!EXIT_OK.equals(result)) {
return result;
}
@@ -182,9 +182,9 @@ public abstract class AbstractApplication implements IApplication {
abstract protected Object createView(IApplicationContext context, IApplicationNode pNode) throws Exception;
- protected Object initialzePerformLogin(IApplicationContext context) throws Exception {
+ protected Object initializePerformLogin(IApplicationContext context) throws Exception {
- initialzeLoginViewDefinition();
+ initializeLoginViewDefinition();
if (isDialogLogin(context)) {
return performLogin(context);
@@ -227,7 +227,7 @@ public abstract class AbstractApplication implements IApplication {
}
}
- protected void initialzeLoginViewDefinition() {
+ protected void initializeLoginViewDefinition() {
Inject.extension(ILoginDialogViewDefinition.EP_TYPE).useType(ILoginDialogViewDefinition.class).into(this)
.andStart(Activator.getDefault().getContext());