diff options
author | Olivier Prouvost | 2015-04-23 15:35:03 +0000 |
---|---|---|
committer | Lars Vogel | 2015-08-17 21:47:11 +0000 |
commit | e59968c4739b901833550e1f4fe71b33b64fa29f (patch) | |
tree | cbef586306dc776edf05d4ec86e097f09a07cb88 | |
parent | 43bf493b4e1fc3705abcd4d320548bec475ea5b9 (diff) | |
download | eclipse.platform.ui.tools-e59968c4739b901833550e1f4fe71b33b64fa29f.tar.gz eclipse.platform.ui.tools-e59968c4739b901833550e1f4fe71b33b64fa29f.tar.xz eclipse.platform.ui.tools-e59968c4739b901833550e1f4fe71b33b64fa29f.zip |
Bug 465271 - Icon enhancement in the application model editor
Simplify the icon management (compute automatically the grey image),
search for icon URI if set...
Change-Id: Ib21e4728fc10d52124d4274b9a48c3659e793e3c
Signed-off-by: Olivier Prouvost <olivier.prouvost@opcoach.com>
104 files changed, 1336 insertions, 1601 deletions
diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Addons.png b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Addons.png Binary files differdeleted file mode 100644 index 907e837f..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Addons.png +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Application.png b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Application.png Binary files differdeleted file mode 100644 index f4665b36..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Application.png +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Area.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Area.gif Binary files differdeleted file mode 100644 index 94bdda3e..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Area.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Area_vertical.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Area_vertical.gif Binary files differdeleted file mode 100644 index f6da4c7a..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Area_vertical.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/BindingContext.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/BindingContext.gif Binary files differdeleted file mode 100644 index 1d6aefeb..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/BindingContext.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/BindingTable.png b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/BindingTable.png Binary files differdeleted file mode 100644 index d572b27c..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/BindingTable.png +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/CommandParameter.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/CommandParameter.gif Binary files differdeleted file mode 100644 index 486f0251..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/CommandParameter.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Dialog.png b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Dialog.png Binary files differdeleted file mode 100644 index 4a4cbfe0..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Dialog.png +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DirectMenuItem.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DirectMenuItem.gif Binary files differdeleted file mode 100644 index ad4c980d..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DirectMenuItem.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DirectToolItem.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DirectToolItem.gif Binary files differdeleted file mode 100644 index 3e30ae05..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DirectToolItem.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DynamicMenuContribution.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DynamicMenuContribution.gif Binary files differdeleted file mode 100644 index b2caa8a1..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/DynamicMenuContribution.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/HandledMenuItem.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/HandledMenuItem.gif Binary files differdeleted file mode 100644 index 6465845d..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/HandledMenuItem.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/HandledToolItem.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/HandledToolItem.gif Binary files differdeleted file mode 100644 index 1a4a7436..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/HandledToolItem.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Menu.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Menu.gif Binary files differdeleted file mode 100644 index 0153af73..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Menu.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuContribution.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuContribution.gif Binary files differdeleted file mode 100644 index d2470194..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuContribution.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuItem.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuItem.gif Binary files differdeleted file mode 100644 index 790a5017..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuItem.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuSeparator.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuSeparator.gif Binary files differdeleted file mode 100644 index 52408e3e..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/MenuSeparator.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ModelFragments.png b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ModelFragments.png Binary files differdeleted file mode 100644 index ebf5a85e..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ModelFragments.png +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Parameter.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Parameter.gif Binary files differdeleted file mode 100644 index 044d786b..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Parameter.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Part.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Part.gif Binary files differdeleted file mode 100644 index 6f86ad5b..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Part.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartDescriptor.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartDescriptor.gif Binary files differdeleted file mode 100644 index cf28a00e..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartDescriptor.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartSashContainer.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartSashContainer.gif Binary files differdeleted file mode 100644 index 94bdda3e..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartSashContainer.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartSashContainer_vertical.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartSashContainer_vertical.gif Binary files differdeleted file mode 100644 index f6da4c7a..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartSashContainer_vertical.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartStack.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartStack.gif Binary files differdeleted file mode 100644 index 5d94ef32..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PartStack.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Perspective.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Perspective.gif Binary files differdeleted file mode 100644 index 6cc4e837..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Perspective.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PerspectiveStack.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PerspectiveStack.gif Binary files differdeleted file mode 100644 index c9dc7d45..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/PerspectiveStack.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Placeholder.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Placeholder.gif Binary files differdeleted file mode 100644 index 36c1a4b3..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Placeholder.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/StringModelFragment.png b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/StringModelFragment.png Binary files differdeleted file mode 100644 index 7a2780ba..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/StringModelFragment.png +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBar.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBar.gif Binary files differdeleted file mode 100644 index 0153af73..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBar.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBarContribution.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBarContribution.gif Binary files differdeleted file mode 100644 index 81e35f1c..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBarContribution.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBarSeparator.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBarSeparator.gif Binary files differdeleted file mode 100644 index 92c10a98..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolBarSeparator.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolControl.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolControl.gif Binary files differdeleted file mode 100644 index 2c309493..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/ToolControl.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/TrimContribution.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/TrimContribution.gif Binary files differdeleted file mode 100644 index 81e35f1c..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/TrimContribution.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Window.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Window.gif Binary files differdeleted file mode 100644 index ca9858df..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/Window.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/WindowTrim.gif b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/WindowTrim.gif Binary files differdeleted file mode 100644 index ca9858df..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/WindowTrim.gif +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/WizardDialog.png b/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/WizardDialog.png Binary files differdeleted file mode 100644 index 2ad3435e..00000000 --- a/bundles/org.eclipse.e4.tools.emf.ui/icons/full/modelelements/tbr/WizardDialog.png +++ /dev/null diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/common/component/AbstractComponentEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/common/component/AbstractComponentEditor.java index ef9f4a43..7d9b8c1e 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/common/component/AbstractComponentEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/common/component/AbstractComponentEditor.java @@ -13,7 +13,8 @@ ******************************************************************************/ package org.eclipse.e4.tools.emf.ui.common.component; -import java.net.MalformedURLException; +import java.io.IOException; +import java.io.InputStream; import java.net.URL; import java.util.Collections; import java.util.List; @@ -23,6 +24,7 @@ import javax.inject.Inject; import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.core.resources.IProject; +import org.eclipse.core.runtime.FileLocator; import org.eclipse.e4.core.di.annotations.Optional; import org.eclipse.e4.core.services.nls.Translation; import org.eclipse.e4.core.services.translation.TranslationService; @@ -36,6 +38,7 @@ import org.eclipse.e4.tools.services.IClipboardService.Handler; import org.eclipse.e4.tools.services.IResourcePool; import org.eclipse.e4.tools.services.impl.ResourceBundleTranslationProvider; import org.eclipse.e4.ui.model.application.MApplicationElement; +import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.MUILabel; import org.eclipse.emf.databinding.EMFDataBindingContext; import org.eclipse.emf.databinding.FeaturePath; @@ -58,9 +61,10 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; public abstract class AbstractComponentEditor { + private static final String GREY_SUFFIX = "Grey"; //$NON-NLS-1$ + private static final String CSS_CLASS_KEY = "org.eclipse.e4.ui.css.CssClassName"; //$NON-NLS-1$ private final WritableValue master = new WritableValue(); @@ -92,8 +96,6 @@ public abstract class AbstractComponentEditor { @Optional private ProjectOSGiTranslationProvider translationProvider; - /** An imageregistry for dynamic component images (see bug #403583) */ - private static ImageRegistry componentImages = new ImageRegistry(); private Composite editorControl; @@ -116,7 +118,7 @@ public abstract class AbstractComponentEditor { final MApplicationElement el = (MApplicationElement) element; if (el.getElementId() == null || el.getElementId().trim().length() == 0) { el.setElementId(Util.getDefaultElementId(((EObject) getMaster().getValue()).eResource(), el, - getEditor().getProject())); + getEditor().getProject())); } } } @@ -132,36 +134,187 @@ public abstract class AbstractComponentEditor { return ImageDescriptor.createFromImage(createImage(key)); } + private ImageRegistry getComponentImages() { + return editor.getComponentImages(); + } + /** * Get the image described in element if this is a MUILabel * - * @param element the element in tree to be displayed - * @return image of element if iconUri is correct, else returns null + * @param element + * the element in tree to be displayed + * @return image of element if iconUri is not empty (returns bad image if + * bad URI), else returns null */ - public Image getImageFromIconURI(Object element) { + public Image getImageFromIconURI(MUILabel element) { + Image img = null; + // Returns only an image if there is a non empty Icon URI + final String iconUri = element.getIconURI(); + if (iconUri != null && iconUri.length() > 0) { + final boolean greyVersion = shouldBeGrey(element); + // Is this image already loaded ? + img = getImage(iconUri, greyVersion); + if (img == null) { + // No image registered yet in ImageRegistry... + final ImageDescriptor desc = getImageDescriptorFromUri(iconUri); + + // Can now add this image in the image registry + getComponentImages().put(iconUri, desc); + img = getImage(iconUri, greyVersion); + } + } + + return img; + } + + /** @return true if the image of this element should be displayed in grey*/ + private boolean shouldBeGrey(Object element) + { + // It is grey if a MUIElement is not visible or not rendered + // It is not grey if this is not a MUIElement or if it is rendered and + // visible. + return element instanceof MUIElement + && !(((MUIElement) element).isToBeRendered() && ((MUIElement) element).isVisible()); + } + + /** + * + * @param key + * the key of image (can be a constants from ResourceProvider or + * a platform:/ uri location + * @param grey + * if true returns the grey version if original image exists + * @return the image with a give key or grey version. + */ + private Image getImage(String key, boolean grey) { + + // try to get image directly with right key and grey value + Image result = getComponentImages().get(key + (grey ? GREY_SUFFIX : "")); //$NON-NLS-1$ + + // may be image not yet created + if (result == null) { + result = getComponentImages().get(key); + // If no image found, ask the resource pool to create it... + if (result == null && !key.startsWith("platform:")) { //$NON-NLS-1$ + try { + result = createImage(key); + } catch (final Exception e) { + } + if (result != null) { + getComponentImages().put(key, result); + } + } + + // Create the grey version of image and put it in registry + if (result != null && grey) { + final Image greyImg = new Image(result.getDevice(), result, SWT.IMAGE_GRAY); + getComponentImages().put(key + GREY_SUFFIX, greyImg); + result = greyImg; + } + } + return result; + } + + /** + * Get image from an element Implements algorithm described in bug #465271 + * + * @param element + * the Application Element + * @param key + * the element image key if no icon URI + * @return Image or null if nothing found + */ + public Image getImage(Object element, String key) { + Image result = null; + if (element instanceof MUILabel) { - final String iconUri = ((MUILabel) element).getIconURI(); - if (iconUri != null) { - img = componentImages.get(iconUri); - if (img == null) { + result = getImageFromIconURI((MUILabel) element); + } + + if (result == null) { + // This is a model element with a key or a MUILabel without IconUri + final boolean greyVersion = shouldBeGrey(element); + result = getImage(key, greyVersion); + } + + return result; + + } + + /** + * Create a readable ImageDescriptor behind URI. + * + * @param uri + * @return + */ + private ImageDescriptor getImageDescriptorFromUri(String uri) { + + // SEVERAL CASES are possible here : + // * uri = platform:/plugin/myplugin/icons/image.gif + // * uri = platform:/resource/myplugin/icons/image.gif + // * uri : platform:/plugin/myplugin/$nl$/icons/image.gif + + // We must check if file exists before creating the ImageDescriptor + // because ImageRegistry will throw and print a DeviceResourceException + // With the E4 editors, the platform:/plugin/ is set for + // runtime, but the file can be in workspace during development In this + // case, we must rather use platform:/resource/. + // Used ideas from the ImageTooltip code around line 70 to fix this + + ImageDescriptor result = null; + InputStream stream = null; + URL url = null; + + try { + final URL uri2url = new URL(uri); + url = FileLocator.toFileURL(uri2url); + stream = url.openStream(); + } catch (final IOException e) { + // If no stream behind this URL, it is probably a platform:/plugin + // which must be found as a platform:/resource (this case occurs in + // the model editor when icon URI are set using the dialog) + url = null; + if (uri.startsWith("platform:/plugin")) //$NON-NLS-1$ + { + try { + // Try to get it using 'platform:/resource' + final URL resUrl = new URL(uri.replace("platform:/plugin", "platform:/resource")); //$NON-NLS-1$//$NON-NLS-2$ + url = FileLocator.toFileURL(resUrl); + stream = url.openStream(); + + } catch (final IOException e2) { + // No file behind, may be this is a $nl$ or a $ws$ path.. + // must use find on FileLocator which does not deal with + // platform:/resource ! try { - final URL url = new URL(iconUri); - final ImageDescriptor idesc = ImageDescriptor - .createFromURL(url); - componentImages.put(iconUri, idesc); - img = componentImages.get(iconUri); - } catch (final MalformedURLException e) { - // Nothing to do at this.. no image + url = FileLocator.find(new URL(uri)); + stream = url.openStream(); + } catch (final IOException ex) { + url = null; + // Can't do more ! } } + } + } + if (stream != null) { + try { + stream.close(); + } catch (final IOException ex) { } } - return img; + + if (url != null) { + result = ImageDescriptor.createFromURL(url); + } + + return result; } - public abstract Image getImage(Object element, Display display); + public Image getImage(Object element) { + return null; + } public abstract String getLabel(Object element); @@ -191,8 +344,8 @@ public abstract class AbstractComponentEditor { } /** - * Translates an input <code>String</code> using the current {@link ResourceBundleTranslationProvider} and - * <code>locale</code> from + * Translates an input <code>String</code> using the current + * {@link ResourceBundleTranslationProvider} and <code>locale</code> from * the {@link TranslationService}. * * @param string @@ -285,7 +438,7 @@ public abstract class AbstractComponentEditor { } protected void createContributedEditorTabs(CTabFolder folder, EMFDataBindingContext context, WritableValue master, - Class<?> clazz) { + Class<?> clazz) { final List<AbstractElementEditorContribution> contributionList = editor.getTabContributionsForClass(clazz); for (final AbstractElementEditorContribution eec : contributionList) { @@ -320,7 +473,8 @@ public abstract class AbstractComponentEditor { if (getEditor().isAutoCreateElementId()) { generator = new IdGenerator(); generator.bind(getMaster(), EMFEditProperties.value(getEditingDomain(), attSource), - EMFEditProperties.value(getEditingDomain(), attId), control); + EMFEditProperties.value(getEditingDomain(), attId), control); } } + } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/ResourceProvider.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/ResourceProvider.java index dffdc5d0..a9887428 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/ResourceProvider.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/ResourceProvider.java @@ -56,42 +56,6 @@ public class ResourceProvider extends BasicResourceProvider { public static final String IMG_WindowTrim = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.WindowTrim"; //$NON-NLS-1$ public static final String IMG_WizardDialog = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.WizardDialog"; //$NON-NLS-1$ - public static final String IMG_Tbr_Addons = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Addons"; //$NON-NLS-1$ - public static final String IMG_Tbr_Application = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Application"; //$NON-NLS-1$ - public static final String IMG_Tbr_Area_vertical = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Area_vertical"; //$NON-NLS-1$ - public static final String IMG_Tbr_Area = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Area"; //$NON-NLS-1$ - public static final String IMG_Tbr_BindingContext = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.BindingContext"; //$NON-NLS-1$ - public static final String IMG_Tbr_BindingTable = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.BindingTable"; //$NON-NLS-1$ - public static final String IMG_Tbr_CommandParameter = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.CommandParameter"; //$NON-NLS-1$ - public static final String IMG_Tbr_Dialog = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Dialog"; //$NON-NLS-1$ - public static final String IMG_Tbr_DirectMenuItem = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.DirectMenuItem"; //$NON-NLS-1$ - public static final String IMG_Tbr_DirectToolItem = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.DirectToolItem"; //$NON-NLS-1$ - public static final String IMG_Tbr_HandledMenuItem = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.HandledMenuItem"; //$NON-NLS-1$ - public static final String IMG_Tbr_HandledToolItem = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.HandledToolItem"; //$NON-NLS-1$ - public static final String IMG_Tbr_Menu = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Menu"; //$NON-NLS-1$ - public static final String IMG_Tbr_MenuContribution = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.MenuContribution"; //$NON-NLS-1$ - public static final String IMG_Tbr_MenuItem = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.MenuItem"; //$NON-NLS-1$ - public static final String IMG_Tbr_DynamicMenuContribution = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.DynamicMenuContribution"; //$NON-NLS-1$ - public static final String IMG_Tbr_MenuSeparator = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.MenuSeparator"; //$NON-NLS-1$ - public static final String IMG_Tbr_ModelFragments = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.ModelFragments"; //$NON-NLS-1$ - public static final String IMG_Tbr_Parameter = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Parameter"; //$NON-NLS-1$ - public static final String IMG_Tbr_Part = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Part"; //$NON-NLS-1$ - public static final String IMG_Tbr_PartDescriptor = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.PartDescriptor"; //$NON-NLS-1$ - public static final String IMG_Tbr_PartSashContainer_vertical = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.PartSashContainer_vertical"; //$NON-NLS-1$ - public static final String IMG_Tbr_PartSashContainer = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.PartSashContainer"; //$NON-NLS-1$ - public static final String IMG_Tbr_PartStack = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.PartStack"; //$NON-NLS-1$ - public static final String IMG_Tbr_Perspective = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Perspective"; //$NON-NLS-1$ - public static final String IMG_Tbr_PerspectiveStack = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.PerspectiveStack"; //$NON-NLS-1$ - public static final String IMG_Tbr_Placeholder = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Placeholder"; //$NON-NLS-1$ - public static final String IMG_Tbr_StringModelFragment = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.StringModelFragment"; //$NON-NLS-1$ - public static final String IMG_Tbr_ToolBar = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.ToolBar"; //$NON-NLS-1$ - public static final String IMG_Tbr_ToolBarContribution = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.ToolBarContribution"; //$NON-NLS-1$ - public static final String IMG_Tbr_ToolBarSeparator = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.ToolBarSeparator"; //$NON-NLS-1$ - public static final String IMG_Tbr_ToolControl = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.ToolControl"; //$NON-NLS-1$ - public static final String IMG_Tbr_TrimContribution = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.TrimContribution"; //$NON-NLS-1$ - public static final String IMG_Tbr_Window = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.Window"; //$NON-NLS-1$ - public static final String IMG_Tbr_WindowTrim = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.WindowTrim"; //$NON-NLS-1$ - public static final String IMG_Tbr_WizardDialog = "IMG_org.eclipse.e4.tools.emf.ui.modelelements.tbr.WizardDialog"; //$NON-NLS-1$ public static final String IMG_Obj16_arrow_down = "IMG_org.eclipse.e4.tools.emf.ui.obj16.arrow_down"; //$NON-NLS-1$ public static final String IMG_Obj16_arrow_up = "IMG_org.eclipse.e4.tools.emf.ui.obj16.arrow_up"; //$NON-NLS-1$ @@ -156,5 +120,5 @@ public class ResourceProvider extends BasicResourceProvider { public static final String COLOR_PROC_INSTR = "COLOR_org.eclipse.e4.tools.emf.ui.PROC_INSTR"; //$NON-NLS-1$ public static final String COLOR_STRING = "COLOR_org.eclipse.e4.tools.emf.ui.STRING"; //$NON-NLS-1$ public static final String COLOR_DEFAULT = "COLOR_org.eclipse.e4.tools.emf.ui.DEFAULT"; //$NON-NLS-1$ - public static final String COLOR_TAG = "COLOR_org.eclipse.e4.tools.emf.ui.TAG"; //$NON-NLS-1$ + public static final String COLOR_TAG = "COLOR_org.eclipse.e4.tools.emf.ui.TAG"; //$NON-NLS-1$ }
\ No newline at end of file diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ComponentLabelProvider.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ComponentLabelProvider.java index 187d5d08..045928c9 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ComponentLabelProvider.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ComponentLabelProvider.java @@ -26,7 +26,7 @@ import org.eclipse.swt.graphics.TextStyle; public class ComponentLabelProvider extends StyledCellLabelProvider { - private ModelEditor editor; + private final ModelEditor editor; public static final String NOT_RENDERED_KEY = "NOT_RENDERED_STYLER";//$NON-NLS-1$ @@ -36,7 +36,7 @@ public class ComponentLabelProvider extends StyledCellLabelProvider { private Font font; - private Messages Messages; + private final Messages Messages; private static Styler BOTH_STYLER = new Styler() { @Override @@ -70,11 +70,11 @@ public class ComponentLabelProvider extends StyledCellLabelProvider { public void update(final ViewerCell cell) { if (cell.getElement() instanceof EObject) { - EObject o = (EObject) cell.getElement(); - AbstractComponentEditor elementEditor = editor.getEditor(o.eClass()); + final EObject o = (EObject) cell.getElement(); + final AbstractComponentEditor elementEditor = editor.getEditor(o.eClass()); if (elementEditor != null) { String label = elementEditor.getLabel(o); - String detailText = elementEditor.getDetailLabel(o); + final String detailText = elementEditor.getDetailLabel(o); Styler styler = null; if (o instanceof MUIElement) { @@ -92,23 +92,23 @@ public class ComponentLabelProvider extends StyledCellLabelProvider { } if (detailText == null) { - StyledString styledString = new StyledString(label, styler); + final StyledString styledString = new StyledString(label, styler); cell.setText(styledString.getString()); cell.setStyleRanges(styledString.getStyleRanges()); } else { - StyledString styledString = new StyledString(label, styler); + final StyledString styledString = new StyledString(label, styler); styledString.append(" - " + detailText, StyledString.DECORATIONS_STYLER); //$NON-NLS-1$ cell.setText(styledString.getString()); cell.setStyleRanges(styledString.getStyleRanges()); } - cell.setImage(elementEditor.getImage(o, cell.getControl().getDisplay())); + cell.setImage(elementEditor.getImage(o)); } else { cell.setText(cell.getElement().toString()); } } else if (cell.getElement() instanceof VirtualEntry<?>) { - String s = cell.getElement().toString(); + final String s = cell.getElement().toString(); if (font == null) { - FontData[] data = cell.getControl().getFont().getFontData(); + final FontData[] data = cell.getControl().getFont().getFontData(); font = new Font(cell.getControl().getDisplay(), new FontData(data[0].getName(), data[0].getHeight(), SWT.ITALIC)); } cell.setFont(font); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ModelEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ModelEditor.java index 941c9df2..386da632 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ModelEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ModelEditor.java @@ -190,6 +190,7 @@ import org.eclipse.jface.databinding.viewers.ObservableListTreeContentProvider; import org.eclipse.jface.databinding.viewers.TreeStructureAdvisor; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.resource.ImageDescriptor; +import org.eclipse.jface.resource.ImageRegistry; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.resource.StringConverter; import org.eclipse.jface.viewers.AbstractTreeViewer; @@ -246,23 +247,23 @@ public class ModelEditor implements IGotoObject { public static final String VIRTUAL_BINDING_TABLE = ModelEditor.class.getName() + ".VIRTUAL_BINDING_TABLE"; //$NON-NLS-1$ public static final String VIRTUAL_COMMAND = ModelEditor.class.getName() + ".VIRTUAL_COMMAND"; //$NON-NLS-1$ public static final String VIRTUAL_APPLICATION_WINDOWS = ModelEditor.class.getName() - + ".VIRTUAL_APPLICATION_WINDOWS"; //$NON-NLS-1$ + + ".VIRTUAL_APPLICATION_WINDOWS"; //$NON-NLS-1$ public static final String VIRTUAL_PERSPECTIVE_WINDOWS = ModelEditor.class.getName() - + ".VIRTUAL_PERSPECTIVE_WINDOWS"; //$NON-NLS-1$ + + ".VIRTUAL_PERSPECTIVE_WINDOWS"; //$NON-NLS-1$ public static final String VIRTUAL_WINDOW_WINDOWS = ModelEditor.class.getName() + ".VIRTUAL_WINDOW_WINDOWS"; //$NON-NLS-1$ public static final String VIRTUAL_WINDOW_CONTROLS = ModelEditor.class.getName() + ".VIRTUAL_WINDOW_CONTROLS"; //$NON-NLS-1$ public static final String VIRTUAL_PART_DESCRIPTORS = ModelEditor.class.getName() + ".VIRTUAL_PART_DESCRIPTORS"; //$NON-NLS-1$ public static final String VIRTUAL_PARTDESCRIPTOR_MENU = ModelEditor.class.getName() - + ".VIRTUAL_PARTDESCRIPTOR_MENU"; //$NON-NLS-1$ + + ".VIRTUAL_PARTDESCRIPTOR_MENU"; //$NON-NLS-1$ public static final String VIRTUAL_TRIMMED_WINDOW_TRIMS = ModelEditor.class.getName() - + ".VIRTUAL_TRIMMED_WINDOW_TRIMS"; //$NON-NLS-1$ + + ".VIRTUAL_TRIMMED_WINDOW_TRIMS"; //$NON-NLS-1$ public static final String VIRTUAL_ADDONS = ModelEditor.class.getName() + ".VIRTUAL_ADDONS"; //$NON-NLS-1$ public static final String VIRTUAL_MENU_CONTRIBUTIONS = ModelEditor.class.getName() + ".VIRTUAL_MENU_CONTRIBUTIONS"; //$NON-NLS-1$ public static final String VIRTUAL_TOOLBAR_CONTRIBUTIONS = ModelEditor.class.getName() - + ".VIRTUAL_TOOLBAR_CONTRIBUTIONS"; //$NON-NLS-1$ + + ".VIRTUAL_TOOLBAR_CONTRIBUTIONS"; //$NON-NLS-1$ public static final String VIRTUAL_TRIM_CONTRIBUTIONS = ModelEditor.class.getName() + ".VIRTUAL_TRIM_CONTRIBUTIONS"; //$NON-NLS-1$ public static final String VIRTUAL_WINDOW_SHARED_ELEMENTS = ModelEditor.class.getName() - + ".VIRTUAL_WINDOW_SHARED_ELEMENTS"; //$NON-NLS-1$ + + ".VIRTUAL_WINDOW_SHARED_ELEMENTS"; //$NON-NLS-1$ public static final String VIRTUAL_MODEL_FRAGEMENTS = ModelEditor.class.getName() + ".VIRTUAL_MODEL_FRAGEMENTS"; //$NON-NLS-1$ public static final String VIRTUAL_MODEL_IMPORTS = ModelEditor.class.getName() + ".VIRTUAL_MODEL_IMPORTS"; //$NON-NLS-1$ public static final String VIRTUAL_CATEGORIES = ModelEditor.class.getName() + ".VIRTUAL_CATEGORIES"; //$NON-NLS-1$ @@ -270,7 +271,7 @@ public class ModelEditor implements IGotoObject { public static final String VIRTUAL_MENUELEMENTS = ModelEditor.class.getName() + ".VIRTUAL_MENUELEMENTS"; //$NON-NLS-1$ public static final String VIRTUAL_ROOT_CONTEXTS = ModelEditor.class.getName() + ".VIRTUAL_ROOT_CONTEXTS"; //$NON-NLS-1$ public static final String VIRTUAL_PERSPECTIVE_CONTROLS = ModelEditor.class.getName() - + "VIRTUAL_PERSPECTIVE_CONTROLS"; //$NON-NLS-1$ + + "VIRTUAL_PERSPECTIVE_CONTROLS"; //$NON-NLS-1$ public static final String VIRTUAL_SNIPPETS = ModelEditor.class.getName() + "VIRTUAL_SNIPPETS"; //$NON-NLS-1$ public static final int TAB_FORM = 0; @@ -288,6 +289,10 @@ public class ModelEditor implements IGotoObject { private final IModelResource modelProvider; private final IProject project; + /** An imageRegistry for dynamic component images (see bug #403583) */ + private final ImageRegistry componentImages = new ImageRegistry(); + + @Inject ESelectionService selectionService; @@ -353,7 +358,7 @@ public class ModelEditor implements IGotoObject { private XmiTab xmiTab; public ModelEditor(Composite composite, IEclipseContext context, IModelResource modelProvider, IProject project, - final IResourcePool resourcePool) { + final IResourcePool resourcePool) { this.resourcePool = resourcePool; this.modelProvider = modelProvider; this.project = project; @@ -370,7 +375,7 @@ public class ModelEditor implements IGotoObject { localeString = object.toString(); } final ProjectOSGiTranslationProvider translationProvider = new ProjectOSGiTranslationProvider(project, - localeString) { + localeString) { @Override protected void updateResourceBundle() { super.updateResourceBundle(); @@ -510,7 +515,7 @@ public class ModelEditor implements IGotoObject { if (o instanceof MPart) { System.err.println(getClass().getName() + ".findAndHighLight: " + o); //$NON-NLS-1$ System.err.println(getClass().getName() - + ".findAndHighLight: " + ((EObject) o).eContainingFeature()); //$NON-NLS-1$ + + ".findAndHighLight: " + ((EObject) o).eContainingFeature()); //$NON-NLS-1$ } viewer.setSelection(new StructuredSelection(o)); @@ -605,7 +610,7 @@ public class ModelEditor implements IGotoObject { if (editor != null) { currentEditor = editor; sectionHeaderLabel.setText(editor.getLabel(obj)); - iconLabel.setImage(editor.getImage(obj, iconLabel.getDisplay())); + iconLabel.setImage(editor.getImage(obj)); obsManager.runAndCollect(new Runnable() { @Override @@ -623,7 +628,7 @@ public class ModelEditor implements IGotoObject { if (editor != null) { currentEditor = editor; sectionHeaderLabel.setText(editor.getLabel(entry)); - iconLabel.setImage(editor.getImage(entry, iconLabel.getDisplay())); + iconLabel.setImage(editor.getImage(entry)); obsManager.runAndCollect(new Runnable() { @Override @@ -669,7 +674,7 @@ public class ModelEditor implements IGotoObject { List<Action> actions; if (s.getFirstElement() instanceof VirtualEntry<?>) { actions = virtualEditors.get(((VirtualEntry<?>) s.getFirstElement()).getId()).getActions( - s.getFirstElement()); + s.getFirstElement()); if (actions.size() > 0) { final MenuManager addMenu = new MenuManager(messages.ModelEditor_AddChild); for (final Action a : actions) { @@ -680,7 +685,7 @@ public class ModelEditor implements IGotoObject { } actions = virtualEditors.get(((VirtualEntry<?>) s.getFirstElement()).getId()).getActionsImport( - s.getFirstElement()); + s.getFirstElement()); if (actions.size() > 0) { final MenuManager menu = new MenuManager(messages.ModelEditor_Import3x); for (final Action a : actions) { @@ -735,7 +740,7 @@ public class ModelEditor implements IGotoObject { if (o.eContainer() != null) { addSeparator = true; manager.add(new Action(messages.ModelEditor_Delete, ImageDescriptor - .createFromImage(resourcePool.getImageUnchecked(ResourceProvider.IMG_Obj16_cross))) { + .createFromImage(resourcePool.getImageUnchecked(ResourceProvider.IMG_Obj16_cross))) { @Override public void run() { final Command cmd = DeleteCommand.create(modelProvider.getEditingDomain(), o); @@ -751,7 +756,7 @@ public class ModelEditor implements IGotoObject { if (noSelected > 0) { if (!isModelFragment() && modelExtractor != null) { manager.add(new Action(messages.ModelEditor_ExtractFragment, ImageDescriptor - .createFromImage(resourcePool.getImageUnchecked(ResourceProvider.IMG_ModelFragments))) { + .createFromImage(resourcePool.getImageUnchecked(ResourceProvider.IMG_ModelFragments))) { @Override public void run() { final ArrayList<MApplicationElement> maes = new ArrayList<MApplicationElement>(); @@ -782,7 +787,7 @@ public class ModelEditor implements IGotoObject { final String containerId = ((MApplicationElement) container).getElementId(); if (containerId == null || containerId.length() == 0) { MessageDialog.openError(viewer.getControl().getShell(), null, - messages.ModelEditor_ExtractFragment_NoParentId); + messages.ModelEditor_ExtractFragment_NoParentId); return; } @@ -807,7 +812,7 @@ public class ModelEditor implements IGotoObject { final IConfigurationElement[] elements = extPoint.getConfigurationElements(); if (elements.length > 0 && !s.isEmpty() && s.getFirstElement() instanceof MApplicationElement - && noSelected == 1) { + && noSelected == 1) { if (addSeparator) { manager.add(new Separator()); } @@ -819,28 +824,28 @@ public class ModelEditor implements IGotoObject { for (final IConfigurationElement e : elements) { final IConfigurationElement le = e; scriptExecute.add(new Action(e.getAttribute("label")) { //$NON-NLS-1$ - @Override - public void run() { - try { - final MApplicationElement o = (MApplicationElement) s.getFirstElement(); - final IScriptingSupport support = (IScriptingSupport) le + @Override + public void run() { + try { + final MApplicationElement o = (MApplicationElement) s.getFirstElement(); + final IScriptingSupport support = (IScriptingSupport) le .createExecutableExtension("class"); //$NON-NLS-1$ - IEclipseContext ctx = null; - if (project == null) { - if (o instanceof MContext) { - ctx = ((MContext) o).getContext(); - } else { - ctx = ModelUtils.getContainingContext(o); - } + IEclipseContext ctx = null; + if (project == null) { + if (o instanceof MContext) { + ctx = ((MContext) o).getContext(); + } else { + ctx = ModelUtils.getContainingContext(o); } - - support.openEditor(viewer.getControl().getShell(), s.getFirstElement(), ctx); - } catch (final CoreException e) { - // TODO Auto-generated catch block - e.printStackTrace(); } + + support.openEditor(viewer.getControl().getShell(), s.getFirstElement(), ctx); + } catch (final CoreException e) { + // TODO Auto-generated catch block + e.printStackTrace(); } - }); + } + }); } } @@ -854,7 +859,7 @@ public class ModelEditor implements IGotoObject { @Override public void run() { final ExternalizeStringHandler h = ContextInjectionFactory.make( - ExternalizeStringHandler.class, context); + ExternalizeStringHandler.class, context); ContextInjectionFactory.invoke(h, Execute.class, context); } }; @@ -997,6 +1002,10 @@ public class ModelEditor implements IGotoObject { return project; } + public ImageRegistry getComponentImages() { + return componentImages; + } + public boolean isShowXMIId() { return showXMIId; } @@ -1074,21 +1083,21 @@ public class ModelEditor implements IGotoObject { TreeViewer tempViewer = null; final String property = System - .getProperty(ORG_ECLIPSE_E4_TOOLS_MODELEDITOR_FILTEREDTREE_ENABLED_XMITAB_DISABLED); + .getProperty(ORG_ECLIPSE_E4_TOOLS_MODELEDITOR_FILTEREDTREE_ENABLED_XMITAB_DISABLED); if (property != null || preferences.getBoolean(ModelEditorPreferences.TAB_FORM_SEARCH_SHOW, false)) { final FilteredTree viewParent = new FilteredTree(treeArea, SWT.MULTI | SWT.FULL_SELECTION | SWT.H_SCROLL - | SWT.V_SCROLL, new PatternFilter(), false); + | SWT.V_SCROLL, new PatternFilter(), false); tempViewer = viewParent.getViewer(); } else { tempViewer = new TreeViewerEx(treeArea, SWT.MULTI | SWT.FULL_SELECTION | SWT.H_SCROLL | SWT.V_SCROLL, - emfDocumentProvider, modelProvider); + emfDocumentProvider, modelProvider); } final TreeViewer viewer = tempViewer; viewer.setLabelProvider(new ComponentLabelProvider(this, messages)); final ObservableListTreeContentProvider contentProvider = new ObservableListTreeContentProvider( - new ObservableFactoryImpl(), new TreeStructureAdvisor() { - }); + new ObservableFactoryImpl(), new TreeStructureAdvisor() { + }); viewer.setContentProvider(contentProvider); final WritableSet clearedSet = new WritableSet(); @@ -1156,7 +1165,7 @@ public class ModelEditor implements IGotoObject { final int ops = DND.DROP_MOVE; viewer.addDragSupport(ops, new Transfer[] { MemoryTransfer.getInstance() }, new DragListener(viewer)); viewer.addDropSupport(ops, new Transfer[] { MemoryTransfer.getInstance() }, new DropListener(viewer, - modelProvider.getEditingDomain())); + modelProvider.getEditingDomain())); return viewer; } @@ -1172,7 +1181,7 @@ public class ModelEditor implements IGotoObject { final IContributionFactory fact = context.get(IContributionFactory.class); final AbstractComponentEditor editor = (AbstractComponentEditor) fact.create( - "bundleclass://" + el.getContributor().getName() + "/" + el.getAttribute("class"), context); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ + "bundleclass://" + el.getContributor().getName() + "/" + el.getAttribute("class"), context); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ registerVirtualEditor(el.getAttribute("id"), editor); //$NON-NLS-1$ } } @@ -1183,35 +1192,35 @@ public class ModelEditor implements IGotoObject { registerVirtualEditor(VIRTUAL_BINDING_TABLE, ContextInjectionFactory.make(VBindingTableEditor.class, context)); registerVirtualEditor(VIRTUAL_COMMAND, ContextInjectionFactory.make(VCommandEditor.class, context)); registerVirtualEditor(VIRTUAL_APPLICATION_WINDOWS, - ContextInjectionFactory.make(VApplicationWindowEditor.class, context)); + ContextInjectionFactory.make(VApplicationWindowEditor.class, context)); registerVirtualEditor(VIRTUAL_WINDOW_WINDOWS, ContextInjectionFactory.make(VWindowWindowsEditor.class, context)); registerVirtualEditor(VIRTUAL_PERSPECTIVE_WINDOWS, - ContextInjectionFactory.make(VPerspectiveWindowsEditor.class, context)); + ContextInjectionFactory.make(VPerspectiveWindowsEditor.class, context)); registerVirtualEditor(VIRTUAL_WINDOW_CONTROLS, - ContextInjectionFactory.make(VWindowControlEditor.class, context)); + ContextInjectionFactory.make(VWindowControlEditor.class, context)); registerVirtualEditor(VIRTUAL_PART_DESCRIPTORS, ContextInjectionFactory.make(VPartDescriptor.class, context)); registerVirtualEditor(VIRTUAL_PARTDESCRIPTOR_MENU, - ContextInjectionFactory.make(VPartDescriptorMenuEditor.class, context)); + ContextInjectionFactory.make(VPartDescriptorMenuEditor.class, context)); registerVirtualEditor(VIRTUAL_TRIMMED_WINDOW_TRIMS, - ContextInjectionFactory.make(VWindowTrimEditor.class, context)); + ContextInjectionFactory.make(VWindowTrimEditor.class, context)); registerVirtualEditor(VIRTUAL_ADDONS, ContextInjectionFactory.make(VApplicationAddons.class, context)); registerVirtualEditor(VIRTUAL_MENU_CONTRIBUTIONS, - ContextInjectionFactory.make(VMenuContributionsEditor.class, context)); + ContextInjectionFactory.make(VMenuContributionsEditor.class, context)); registerVirtualEditor(VIRTUAL_TOOLBAR_CONTRIBUTIONS, - ContextInjectionFactory.make(VToolBarContributionsEditor.class, context)); + ContextInjectionFactory.make(VToolBarContributionsEditor.class, context)); registerVirtualEditor(VIRTUAL_TRIM_CONTRIBUTIONS, - ContextInjectionFactory.make(VTrimContributionsEditor.class, context)); + ContextInjectionFactory.make(VTrimContributionsEditor.class, context)); registerVirtualEditor(VIRTUAL_WINDOW_SHARED_ELEMENTS, - ContextInjectionFactory.make(VWindowSharedElementsEditor.class, context)); + ContextInjectionFactory.make(VWindowSharedElementsEditor.class, context)); registerVirtualEditor(VIRTUAL_MODEL_FRAGEMENTS, - ContextInjectionFactory.make(VModelFragmentsEditor.class, context)); + ContextInjectionFactory.make(VModelFragmentsEditor.class, context)); registerVirtualEditor(VIRTUAL_MODEL_IMPORTS, ContextInjectionFactory.make(VModelImportsEditor.class, context)); registerVirtualEditor(VIRTUAL_CATEGORIES, - ContextInjectionFactory.make(VApplicationCategoriesEditor.class, context)); + ContextInjectionFactory.make(VApplicationCategoriesEditor.class, context)); registerVirtualEditor(VIRTUAL_PARAMETERS, ContextInjectionFactory.make(VItemParametersEditor.class, context)); registerVirtualEditor(VIRTUAL_ROOT_CONTEXTS, ContextInjectionFactory.make(VRootBindingContexts.class, context)); registerVirtualEditor(VIRTUAL_PERSPECTIVE_CONTROLS, - ContextInjectionFactory.make(VPerspectiveControlEditor.class, context)); + ContextInjectionFactory.make(VPerspectiveControlEditor.class, context)); registerVirtualEditor(VIRTUAL_SNIPPETS, ContextInjectionFactory.make(VSnippetsEditor.class, context)); } @@ -1237,7 +1246,7 @@ public class ModelEditor implements IGotoObject { final EClass eClass = desc.getEClass(); final IContributionFactory fact = context.get(IContributionFactory.class); final AbstractComponentEditor editor = (AbstractComponentEditor) fact.create( - "bundleclass://" + el.getContributor().getName() + "/" + desc.getEditorClass().getName(), context); //$NON-NLS-1$ //$NON-NLS-2$ + "bundleclass://" + el.getContributor().getName() + "/" + desc.getEditorClass().getName(), context); //$NON-NLS-1$ //$NON-NLS-2$ registerEditor(eClass, editor); } catch (final CoreException e) { e.printStackTrace(); @@ -1288,86 +1297,86 @@ public class ModelEditor implements IGotoObject { // System.err.println(getClass().getName() + ".registerDefaultEditors: " + resourcePool); //$NON-NLS-1$ registerEditor(ApplicationPackageImpl.Literals.APPLICATION, - ContextInjectionFactory.make(ApplicationEditor.class, context)); + ContextInjectionFactory.make(ApplicationEditor.class, context)); registerEditor(ApplicationPackageImpl.Literals.ADDON, ContextInjectionFactory.make(AddonsEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.KEY_BINDING, - ContextInjectionFactory.make(KeyBindingEditor.class, context)); + ContextInjectionFactory.make(KeyBindingEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.HANDLER, ContextInjectionFactory.make(HandlerEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.COMMAND, ContextInjectionFactory.make(CommandEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.COMMAND_PARAMETER, - ContextInjectionFactory.make(CommandParameterEditor.class, context)); + ContextInjectionFactory.make(CommandParameterEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.PARAMETER, - ContextInjectionFactory.make(ParameterEditor.class, context)); + ContextInjectionFactory.make(ParameterEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.BINDING_TABLE, - ContextInjectionFactory.make(BindingTableEditor.class, context)); + ContextInjectionFactory.make(BindingTableEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.BINDING_CONTEXT, - ContextInjectionFactory.make(BindingContextEditor.class, context)); + ContextInjectionFactory.make(BindingContextEditor.class, context)); registerEditor(CommandsPackageImpl.Literals.CATEGORY, - ContextInjectionFactory.make(CategoryEditor.class, context)); + ContextInjectionFactory.make(CategoryEditor.class, context)); registerEditor(MenuPackageImpl.Literals.TOOL_BAR, ContextInjectionFactory.make(ToolBarEditor.class, context)); registerEditor(MenuPackageImpl.Literals.DIRECT_TOOL_ITEM, - ContextInjectionFactory.make(DirectToolItemEditor.class, context)); + ContextInjectionFactory.make(DirectToolItemEditor.class, context)); registerEditor(MenuPackageImpl.Literals.HANDLED_TOOL_ITEM, - ContextInjectionFactory.make(HandledToolItemEditor.class, context)); + ContextInjectionFactory.make(HandledToolItemEditor.class, context)); registerEditor(MenuPackageImpl.Literals.TOOL_BAR_SEPARATOR, - ContextInjectionFactory.make(ToolBarSeparatorEditor.class, context)); + ContextInjectionFactory.make(ToolBarSeparatorEditor.class, context)); registerEditor(MenuPackageImpl.Literals.TOOL_CONTROL, - ContextInjectionFactory.make(ToolControlEditor.class, context)); + ContextInjectionFactory.make(ToolControlEditor.class, context)); registerEditor(MenuPackageImpl.Literals.MENU, ContextInjectionFactory.make(MenuEditor.class, context)); registerEditor(MenuPackageImpl.Literals.POPUP_MENU, - ContextInjectionFactory.make(PopupMenuEditor.class, context)); + ContextInjectionFactory.make(PopupMenuEditor.class, context)); registerEditor(MenuPackageImpl.Literals.MENU_SEPARATOR, - ContextInjectionFactory.make(MenuSeparatorEditor.class, context)); + ContextInjectionFactory.make(MenuSeparatorEditor.class, context)); registerEditor(MenuPackageImpl.Literals.HANDLED_MENU_ITEM, - ContextInjectionFactory.make(HandledMenuItemEditor.class, context)); + ContextInjectionFactory.make(HandledMenuItemEditor.class, context)); registerEditor(MenuPackageImpl.Literals.DIRECT_MENU_ITEM, - ContextInjectionFactory.make(DirectMenuItemEditor.class, context)); + ContextInjectionFactory.make(DirectMenuItemEditor.class, context)); registerEditor(MenuPackageImpl.Literals.MENU_CONTRIBUTION, - ContextInjectionFactory.make(MenuContributionEditor.class, context)); + ContextInjectionFactory.make(MenuContributionEditor.class, context)); registerEditor(MenuPackageImpl.Literals.TOOL_BAR_CONTRIBUTION, - ContextInjectionFactory.make(ToolBarContributionEditor.class, context)); + ContextInjectionFactory.make(ToolBarContributionEditor.class, context)); registerEditor(MenuPackageImpl.Literals.TRIM_CONTRIBUTION, - ContextInjectionFactory.make(TrimContributionEditor.class, context)); + ContextInjectionFactory.make(TrimContributionEditor.class, context)); registerEditor(MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION, - ContextInjectionFactory.make(DynamicMenuContributionEditor.class, context)); + ContextInjectionFactory.make(DynamicMenuContributionEditor.class, context)); registerEditor(UiPackageImpl.Literals.CORE_EXPRESSION, - ContextInjectionFactory.make(CoreExpressionEditor.class, context)); + ContextInjectionFactory.make(CoreExpressionEditor.class, context)); registerEditor(BasicPackageImpl.Literals.COMPOSITE_PART, - ContextInjectionFactory.make(CompositePartEditor.class, context)); + ContextInjectionFactory.make(CompositePartEditor.class, context)); registerEditor(BasicPackageImpl.Literals.PART, ContextInjectionFactory.make(PartEditor.class, context)); registerEditor(BasicPackageImpl.Literals.WINDOW, ContextInjectionFactory.make(WindowEditor.class, context)); registerEditor(BasicPackageImpl.Literals.TRIMMED_WINDOW, - ContextInjectionFactory.make(TrimmedWindowEditor.class, context)); + ContextInjectionFactory.make(TrimmedWindowEditor.class, context)); registerEditor(BasicPackageImpl.Literals.PART_SASH_CONTAINER, - ContextInjectionFactory.make(PartSashContainerEditor.class, context)); + ContextInjectionFactory.make(PartSashContainerEditor.class, context)); registerEditor(AdvancedPackageImpl.Literals.AREA, ContextInjectionFactory.make(AreaEditor.class, context)); registerEditor(BasicPackageImpl.Literals.PART_STACK, - ContextInjectionFactory.make(PartStackEditor.class, context)); + ContextInjectionFactory.make(PartStackEditor.class, context)); registerEditor(BasicPackageImpl.Literals.TRIM_BAR, ContextInjectionFactory.make(TrimBarEditor.class, context)); registerEditor(BasicPackageImpl.Literals.DIALOG, ContextInjectionFactory.make(DialogEditor.class, context)); registerEditor(BasicPackageImpl.Literals.WIZARD_DIALOG, - ContextInjectionFactory.make(WizardDialogEditor.class, context)); + ContextInjectionFactory.make(WizardDialogEditor.class, context)); registerEditor( - org.eclipse.e4.ui.model.application.descriptor.basic.impl.BasicPackageImpl.Literals.PART_DESCRIPTOR, - ContextInjectionFactory.make(PartDescriptorEditor.class, context)); + org.eclipse.e4.ui.model.application.descriptor.basic.impl.BasicPackageImpl.Literals.PART_DESCRIPTOR, + ContextInjectionFactory.make(PartDescriptorEditor.class, context)); registerEditor(AdvancedPackageImpl.Literals.PERSPECTIVE_STACK, - ContextInjectionFactory.make(PerspectiveStackEditor.class, context)); + ContextInjectionFactory.make(PerspectiveStackEditor.class, context)); registerEditor(AdvancedPackageImpl.Literals.PERSPECTIVE, - ContextInjectionFactory.make(PerspectiveEditor.class, context)); + ContextInjectionFactory.make(PerspectiveEditor.class, context)); registerEditor(AdvancedPackageImpl.Literals.PLACEHOLDER, - ContextInjectionFactory.make(PlaceholderEditor.class, context)); + ContextInjectionFactory.make(PlaceholderEditor.class, context)); registerEditor(FragmentPackageImpl.Literals.MODEL_FRAGMENTS, - ContextInjectionFactory.make(ModelFragmentsEditor.class, context)); + ContextInjectionFactory.make(ModelFragmentsEditor.class, context)); registerEditor(FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT, - ContextInjectionFactory.make(StringModelFragment.class, context)); + ContextInjectionFactory.make(StringModelFragment.class, context)); } public void tab_list_show(Boolean show) { @@ -1400,7 +1409,7 @@ public class ModelEditor implements IGotoObject { if (current == null || !current.equals(color)) { JFaceResources.getColorRegistry().put(ComponentLabelProvider.NOT_VISIBLE_KEY, - StringConverter.asRGB(color, new RGB(200, 200, 200))); + StringConverter.asRGB(color, new RGB(200, 200, 200))); } if (viewer != null) { @@ -1415,7 +1424,7 @@ public class ModelEditor implements IGotoObject { if (current == null || !current.equals(color)) { JFaceResources.getColorRegistry().put(ComponentLabelProvider.NOT_RENDERED_KEY, - StringConverter.asRGB(color, new RGB(200, 200, 200))); + StringConverter.asRGB(color, new RGB(200, 200, 200))); } if (viewer != null) { @@ -1426,13 +1435,13 @@ public class ModelEditor implements IGotoObject { @Inject public void setNotVisibleRenderedColor( - @Preference(ModelEditorPreferences.NOT_VISIBLE_AND_RENDERED_COLOR) String color) { + @Preference(ModelEditorPreferences.NOT_VISIBLE_AND_RENDERED_COLOR) String color) { final RGB current = JFaceResources.getColorRegistry().getRGB( - ComponentLabelProvider.NOT_VISIBLE_AND_RENDERED_KEY); + ComponentLabelProvider.NOT_VISIBLE_AND_RENDERED_KEY); if (current == null || !current.equals(color)) { JFaceResources.getColorRegistry().put(ComponentLabelProvider.NOT_VISIBLE_AND_RENDERED_KEY, - StringConverter.asRGB(color, new RGB(200, 200, 200))); + StringConverter.asRGB(color, new RGB(200, 200, 200))); } if (viewer != null) { @@ -1634,7 +1643,7 @@ public class ModelEditor implements IGotoObject { if (o != null && o instanceof EObject) { final Clipboard clip = new Clipboard(viewer.getControl().getDisplay()); clip.setContents(new Object[] { EcoreUtil.copy((EObject) o) }, - new Transfer[] { MemoryTransfer.getInstance() }); + new Transfer[] { MemoryTransfer.getInstance() }); clip.dispose(); } } @@ -1660,7 +1669,7 @@ public class ModelEditor implements IGotoObject { clip.dispose(); final EObject eObj = (EObject) o; final Command cmd = RemoveCommand.create(getModelProvider().getEditingDomain(), eObj.eContainer(), - eObj.eContainingFeature(), eObj); + eObj.eContainingFeature(), eObj); if (cmd.canExecute()) { getModelProvider().getEditingDomain().getCommandStack().execute(cmd); } @@ -1876,7 +1885,7 @@ public class ModelEditor implements IGotoObject { if (isIndex || !container.getChildren().contains(instance)) { final EClassifier classifier = ModelUtils.getTypeArgument(((EObject) container).eClass(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN.getEGenericType()); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN.getEGenericType()); return classifier.isInstance(instance); } } else if (target instanceof VirtualEntry<?>) { @@ -1885,10 +1894,10 @@ public class ModelEditor implements IGotoObject { if (isIndex || !vTarget.getList().contains(instance)) { if (vTarget.getProperty() instanceof IEMFProperty) { final EStructuralFeature feature = ((IEMFProperty) vTarget.getProperty()) - .getStructuralFeature(); + .getStructuralFeature(); final EObject parent = (EObject) vTarget.getOriginalParent(); final EClassifier classifier = ModelUtils.getTypeArgument(parent.eClass(), - feature.getEGenericType()); + feature.getEGenericType()); return classifier.isInstance(instance); } @@ -1916,7 +1925,7 @@ public class ModelEditor implements IGotoObject { case TAB_FORM: // make sure tree node has been instantiated final ObservableListTreeContentProvider provider = (ObservableListTreeContentProvider) viewer - .getContentProvider(); + .getContentProvider(); getFirstMatchingItem(object, provider, provider.getChildren(viewer.getInput())); viewer.reveal(object); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AddonsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AddonsEditor.java index a4168da6..db5393e4 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AddonsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AddonsEditor.java @@ -53,7 +53,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; @@ -77,8 +76,8 @@ public class AddonsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_Addons); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Addons); } @Override @@ -134,7 +133,7 @@ public class AddonsEditor extends AbstractComponentEditor { } protected Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -156,13 +155,13 @@ public class AddonsEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); final Link lnk; // ------------------------------------------------------------ { final IContributionClassCreator c = getEditor().getContributionCreator( - ApplicationPackageImpl.Literals.ADDON); + ApplicationPackageImpl.Literals.ADDON); if (project != null && c != null) { lnk = new Link(parent, SWT.NONE); lnk.setText("<A>" + Messages.PartEditor_ClassURI + "</A>"); //$NON-NLS-1$//$NON-NLS-2$ @@ -171,7 +170,7 @@ public class AddonsEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { c.createOpen((MContribution) getMaster().getValue(), getEditingDomain(), project, - lnk.getShell()); + lnk.getShell()); } }); } else { @@ -194,11 +193,11 @@ public class AddonsEditor extends AbstractComponentEditor { } }); final Binding binding = context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(getMaster()), - new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), - new UpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(getMaster()), + new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), + new UpdateValueStrategy()); Util.addDecoration(t, binding); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -208,15 +207,15 @@ public class AddonsEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, - getEditingDomain(), (MContribution) getMaster().getValue(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); + getEditingDomain(), (MContribution) getMaster().getValue(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); dialog.open(); } }); } ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -225,7 +224,7 @@ public class AddonsEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.AddonsEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createInstanceInspection(folder); @@ -247,7 +246,7 @@ public class AddonsEditor extends AbstractComponentEditor { final ObjectViewer objectViewer = new ObjectViewer(); final TreeViewer viewer = objectViewer.createViewer(container, - ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); + ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ApplicationEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ApplicationEditor.java index 7ec370f3..36187e3d 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ApplicationEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ApplicationEditor.java @@ -38,7 +38,6 @@ import org.eclipse.e4.ui.model.application.commands.impl.CommandsFactoryImpl; import org.eclipse.e4.ui.model.application.commands.impl.CommandsPackageImpl; import org.eclipse.e4.ui.model.application.descriptor.basic.impl.BasicPackageImpl; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.ItemType; import org.eclipse.e4.ui.model.application.ui.menu.MMenu; @@ -80,7 +79,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -90,32 +88,32 @@ public class ApplicationEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty HANDLER_CONTAINER__HANDLERS = EMFProperties - .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); + .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); private final IListProperty BINDING_CONTAINER__BINDINGS = EMFProperties - .list(CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__BINDING_TABLES); + .list(CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__BINDING_TABLES); private final IListProperty APPLICATION__COMMANDS = EMFProperties - .list(ApplicationPackageImpl.Literals.APPLICATION__COMMANDS); + .list(ApplicationPackageImpl.Literals.APPLICATION__COMMANDS); // private IListProperty APPLICATION__DIALOGS = // EMFProperties.list(ApplicationPackageImpl.Literals.APPLICATION__DIALOGS); private final IListProperty PART_DESCRIPTOR_CONTAINER__DESCRIPTORS = EMFProperties - .list(BasicPackageImpl.Literals.PART_DESCRIPTOR_CONTAINER__DESCRIPTORS); + .list(BasicPackageImpl.Literals.PART_DESCRIPTOR_CONTAINER__DESCRIPTORS); private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private final IListProperty APPLICATION__ADDONS = EMFProperties - .list(ApplicationPackageImpl.Literals.APPLICATION__ADDONS); + .list(ApplicationPackageImpl.Literals.APPLICATION__ADDONS); private final IListProperty MENU_CONTRIBUTIONS = EMFProperties - .list(MenuPackageImpl.Literals.MENU_CONTRIBUTIONS__MENU_CONTRIBUTIONS); + .list(MenuPackageImpl.Literals.MENU_CONTRIBUTIONS__MENU_CONTRIBUTIONS); private final IListProperty TOOLBAR_CONTRIBUTIONS = EMFProperties - .list(MenuPackageImpl.Literals.TOOL_BAR_CONTRIBUTIONS__TOOL_BAR_CONTRIBUTIONS); + .list(MenuPackageImpl.Literals.TOOL_BAR_CONTRIBUTIONS__TOOL_BAR_CONTRIBUTIONS); private final IListProperty TRIM_CONTRIBUTIONS = EMFProperties - .list(MenuPackageImpl.Literals.TRIM_CONTRIBUTIONS__TRIM_CONTRIBUTIONS); + .list(MenuPackageImpl.Literals.TRIM_CONTRIBUTIONS__TRIM_CONTRIBUTIONS); private final IListProperty APPLICATION__SNIPPETS = EMFProperties - .list(UiPackageImpl.Literals.SNIPPET_CONTAINER__SNIPPETS); + .list(UiPackageImpl.Literals.SNIPPET_CONTAINER__SNIPPETS); private final IListProperty APPLICATION__CATEGORIES = EMFProperties - .list(ApplicationPackageImpl.Literals.APPLICATION__CATEGORIES); + .list(ApplicationPackageImpl.Literals.APPLICATION__CATEGORIES); private final IListProperty BINDING_TABLE_CONTAINER__ROOT_CONTEXT = EMFProperties - .list(CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__ROOT_CONTEXT); + .list(CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__ROOT_CONTEXT); @Inject @Optional @@ -145,19 +143,13 @@ public class ApplicationEditor extends AbstractComponentEditor { void doCreateCommandWizard() { final WizardDialog dialog = new WizardDialog(composite.getShell(), new CommandWizard((MApplication) getMaster() - .getValue())); + .getValue())); dialog.open(); } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - if (((MUIElement) element).isToBeRendered()) { - return createImage(ResourceProvider.IMG_Application); - } - return createImage(ResourceProvider.IMG_Tbr_Application); - } - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Application); } @Override @@ -197,17 +189,17 @@ public class ApplicationEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, getMaster(), context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createBindingContextWiget(parent, Messages, this, Messages.ApplicationEditor_BindingContexts); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -216,14 +208,14 @@ public class ApplicationEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createStringListWidget(parent, Messages, this, Messages.ModelTooling_Context_Variables, - UiPackageImpl.Literals.CONTEXT__VARIABLES, VERTICAL_LIST_WIDGET_INDENT); + UiPackageImpl.Literals.CONTEXT__VARIABLES, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createStringListWidget(parent, Messages, this, Messages.AddonsEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -245,7 +237,7 @@ public class ApplicationEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -253,7 +245,7 @@ public class ApplicationEditor extends AbstractComponentEditor { public IObservableList getChildList(final Object element) { final WritableList list = new WritableList(); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_ADDONS, APPLICATION__ADDONS, element, - Messages.ApplicationEditor_Addons) { + Messages.ApplicationEditor_Addons) { @Override protected boolean accepted(Object o) { @@ -263,7 +255,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_ROOT_CONTEXTS, BINDING_TABLE_CONTAINER__ROOT_CONTEXT, - element, Messages.ApplicationEditor_RootContexts) { + element, Messages.ApplicationEditor_RootContexts) { @Override protected boolean accepted(Object o) { @@ -273,7 +265,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_BINDING_TABLE, BINDING_CONTAINER__BINDINGS, element, - Messages.ApplicationEditor_BindingTables) { + Messages.ApplicationEditor_BindingTables) { @Override protected boolean accepted(Object o) { @@ -283,7 +275,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_HANDLER, HANDLER_CONTAINER__HANDLERS, element, - Messages.ApplicationEditor_Handlers) { + Messages.ApplicationEditor_Handlers) { @Override protected boolean accepted(Object o) { @@ -293,7 +285,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_COMMAND, APPLICATION__COMMANDS, element, - Messages.ApplicationEditor_Commands) { + Messages.ApplicationEditor_Commands) { @Override protected boolean accepted(Object o) { @@ -302,7 +294,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_CATEGORIES, APPLICATION__CATEGORIES, element, - Messages.ApplicationEditor_Categories) { + Messages.ApplicationEditor_Categories) { @Override protected boolean accepted(Object o) { @@ -311,7 +303,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_APPLICATION_WINDOWS, ELEMENT_CONTAINER__CHILDREN, - element, Messages.ApplicationEditor_Windows) { + element, Messages.ApplicationEditor_Windows) { @Override protected boolean accepted(Object o) { @@ -321,7 +313,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_PART_DESCRIPTORS, PART_DESCRIPTOR_CONTAINER__DESCRIPTORS, - element, Messages.ApplicationEditor_PartDescriptors) { + element, Messages.ApplicationEditor_PartDescriptors) { @Override protected boolean accepted(Object o) { @@ -331,7 +323,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_MENU_CONTRIBUTIONS, MENU_CONTRIBUTIONS, element, - Messages.ApplicationEditor_MenuContributions) { + Messages.ApplicationEditor_MenuContributions) { @Override protected boolean accepted(Object o) { return true; @@ -339,7 +331,7 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_TOOLBAR_CONTRIBUTIONS, TOOLBAR_CONTRIBUTIONS, element, - Messages.ApplicationEditor_ToolBarContributions) { + Messages.ApplicationEditor_ToolBarContributions) { @Override protected boolean accepted(Object o) { return true; @@ -347,14 +339,14 @@ public class ApplicationEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_TRIM_CONTRIBUTIONS, TRIM_CONTRIBUTIONS, element, - Messages.ApplicationEditor_TrimContributions) { + Messages.ApplicationEditor_TrimContributions) { @Override protected boolean accepted(Object o) { return true; } }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_SNIPPETS, APPLICATION__SNIPPETS, element, - Messages.ApplicationEditor_Snippets) { + Messages.ApplicationEditor_Snippets) { @Override protected boolean accepted(Object o) { return true; @@ -415,7 +407,7 @@ public class ApplicationEditor extends AbstractComponentEditor { public void addPages() { getShell().setText(Messages.CommandWizard_ShellTitle); setDefaultPageImageDescriptor(ImageDescriptor.createFromImage(resourcePool - .getImageUnchecked(ResourceProvider.IMG_Wizban16_newexp_wiz))); + .getImageUnchecked(ResourceProvider.IMG_Wizban16_newexp_wiz))); handlerPage = new HandlerCommandPage(Messages.ApplicationEditor_HandlerAndCommand); addPage(handlerPage); @@ -459,14 +451,14 @@ public class ApplicationEditor extends AbstractComponentEditor { final CompoundCommand cmd = new CompoundCommand(); cmd.append(AddCommand.create(getEditingDomain(), application, - ApplicationPackageImpl.Literals.APPLICATION__COMMANDS, command)); + ApplicationPackageImpl.Literals.APPLICATION__COMMANDS, command)); cmd.append(AddCommand.create(getEditingDomain(), application, - CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS, handler)); + CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS, handler)); if (keyBinding != null) { cmd.append(AddCommand.create(getEditingDomain(), - ((IStructuredSelection) keyPage.bindtableViewer.getSelection()).getFirstElement(), - CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS, keyBinding)); + ((IStructuredSelection) keyPage.bindtableViewer.getSelection()).getFirstElement(), + CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS, keyBinding)); } if (cmd.canExecute()) { @@ -801,7 +793,7 @@ public class ApplicationEditor extends AbstractComponentEditor { if (elementEditor != null) { label = elementEditor.getDetailLabel(o); label = label == null ? elementEditor.getLabel(o) : label; - img = elementEditor.getImage(o, composite.getDisplay()); + img = elementEditor.getImage(o); } final List<String> parentPath = new ArrayList<String>(); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AreaEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AreaEditor.java index dea1d51b..8c069fa8 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AreaEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/AreaEditor.java @@ -35,7 +35,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.AreaIconDia import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.MApplicationElement; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.MUILabel; import org.eclipse.e4.ui.model.application.ui.advanced.MArea; import org.eclipse.e4.ui.model.application.ui.advanced.impl.AdvancedPackageImpl; @@ -77,7 +76,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -87,7 +85,7 @@ public class AreaEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -107,35 +105,35 @@ public class AreaEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.PartSashContainerEditor_AddPartSashContainer, - createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { + createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART_SASH_CONTAINER); } }); actions.add(new Action(Messages.PartSashContainerEditor_AddPartStack, - createImageDescriptor(ResourceProvider.IMG_PartStack)) { + createImageDescriptor(ResourceProvider.IMG_PartStack)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART_STACK); } }); actions.add(new Action(Messages.PartSashContainerEditor_AddPart, - createImageDescriptor(ResourceProvider.IMG_Part)) { + createImageDescriptor(ResourceProvider.IMG_Part)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART); } }); actions.add(new Action(Messages.PartSashContainerEditor_AddArea, - createImageDescriptor(ResourceProvider.IMG_Area)) { + createImageDescriptor(ResourceProvider.IMG_Area)) { @Override public void run() { handleAddChild(AdvancedPackageImpl.Literals.AREA); } }); actions.add(new Action(Messages.PartSashContainerEditor_AddPlaceholder, - createImageDescriptor(ResourceProvider.IMG_Placeholder)) { + createImageDescriptor(ResourceProvider.IMG_Placeholder)) { @Override public void run() { handleAddChild(AdvancedPackageImpl.Literals.PLACEHOLDER); @@ -144,25 +142,11 @@ public class AreaEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { + public Image getImage(Object element) { final boolean horizontal = ((MPartSashContainer) element).isHorizontal(); - if (!horizontal) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_Area_vertical); - } - return createImage(ResourceProvider.IMG_Tbr_Area_vertical); - } - - if (horizontal) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_Area); - } - return createImage(ResourceProvider.IMG_Tbr_Area); - } - return null; + return horizontal ? getImage(element, ResourceProvider.IMG_Area) + : getImage(element, ResourceProvider.IMG_Area_vertical); } @Override @@ -209,7 +193,7 @@ public class AreaEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -231,12 +215,12 @@ public class AreaEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, getMaster(), context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.AreaEditor_LabelLabel, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL)); ControlFactory.createTextField(parent, Messages.AreaEditor_Tooltip, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP)); // ------------------------------------------------------------ { @@ -248,9 +232,9 @@ public class AreaEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -273,7 +257,7 @@ public class AreaEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final AreaIconDialogEditor dialog = new AreaIconDialogEditor(b.getShell(), eclipseContext, project, - getEditingDomain(), (MApplicationElement) getMaster().getValue(), Messages); + getEditingDomain(), (MApplicationElement) getMaster().getValue(), Messages); dialog.open(); } }); @@ -294,23 +278,23 @@ public class AreaEditor extends AbstractComponentEditor { @Override public String getText(Object element) { return ((Boolean) element).booleanValue() ? Messages.AreaEditor_Horizontal - : Messages.AreaEditor_Vertical; + : Messages.AreaEditor_Vertical; } }); viewer.setInput(new Boolean[] { Boolean.TRUE, Boolean.FALSE }); final IViewerValueProperty vProp = ViewerProperties.singleSelection(); context.bindValue(vProp.observe(viewer), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL) - .observeDetail(getMaster())); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL) + .observeDetail(getMaster())); } ControlFactory.createSelectedElement(parent, this, context, Messages.AreaEditor_SelectedElement); ControlFactory.createTextField(parent, Messages.AreaEditor_ContainerData, getMaster(), context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); @@ -327,18 +311,18 @@ public class AreaEditor extends AbstractComponentEditor { pickList.setLabelProvider(new EClassLabelProvider(getEditor())); pickList.setInput(new EClass[] { BasicPackageImpl.Literals.PART_SASH_CONTAINER, - BasicPackageImpl.Literals.PART_STACK, BasicPackageImpl.Literals.PART, - BasicPackageImpl.Literals.INPUT_PART, AdvancedPackageImpl.Literals.AREA, - AdvancedPackageImpl.Literals.PLACEHOLDER }); + BasicPackageImpl.Literals.PART_STACK, BasicPackageImpl.Literals.PART, + BasicPackageImpl.Literals.INPUT_PART, AdvancedPackageImpl.Literals.AREA, + AdvancedPackageImpl.Literals.PLACEHOLDER }); pickList.setSelection(new StructuredSelection(BasicPackageImpl.Literals.PART_SASH_CONTAINER)); } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -347,12 +331,12 @@ public class AreaEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createStringListWidget(parent, Messages, this, Messages.ModelTooling_ApplicationElement_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -374,7 +358,7 @@ public class AreaEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -383,7 +367,7 @@ public class AreaEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -404,8 +388,8 @@ public class AreaEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.UI_LABEL__LABEL), - FeaturePath.fromList(UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL), + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } @Override diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingContextEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingContextEditor.java index b036df18..07194fcb 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingContextEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingContextEditor.java @@ -51,7 +51,6 @@ import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; public class BindingContextEditor extends AbstractComponentEditor { private Composite composite; @@ -59,7 +58,7 @@ public class BindingContextEditor extends AbstractComponentEditor { private StackLayout stackLayout; private final IListProperty BINDING_CONTEXT__CHILDREN = EMFProperties - .list(CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN); + .list(CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN); private final List<Action> actions = new ArrayList<Action>(); @@ -71,7 +70,7 @@ public class BindingContextEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.BindingContextEditor_AddContext, - createImageDescriptor(ResourceProvider.IMG_BindingContext)) { + createImageDescriptor(ResourceProvider.IMG_BindingContext)) { @Override public void run() { handleAddContext(); @@ -80,8 +79,8 @@ public class BindingContextEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_BindingContext); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_BindingContext); } @Override @@ -103,7 +102,7 @@ public class BindingContextEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(CommandsPackageImpl.Literals.BINDING_CONTEXT__NAME), - FeaturePath.fromList(ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID) }; + FeaturePath.fromList(ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID) }; } @Override @@ -142,7 +141,7 @@ public class BindingContextEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(CommandsPackageImpl.Literals.BINDING_CONTEXT__NAME, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } @@ -168,16 +167,16 @@ public class BindingContextEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.BindingContextEditor_Name, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.BINDING_CONTEXT__NAME), - Messages.BindingContextEditor_NameWarning); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.BINDING_CONTEXT__NAME), + Messages.BindingContextEditor_NameWarning); ControlFactory.createTextField(parent, Messages.BindingContextEditor_Description, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.BINDING_CONTEXT__DESCRIPTION)); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.BINDING_CONTEXT__DESCRIPTION)); final E4PickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), - Messages, this, CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN) { + Messages, this, CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN) { @Override protected void addPressed() { handleAddContext(); @@ -193,7 +192,7 @@ public class BindingContextEditor extends AbstractComponentEditor { final TableViewer viewer = pickList.getList(); final IEMFListProperty prop = EMFEditProperties.list(getEditingDomain(), - CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN); + CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN); viewer.setInput(prop.observeDetail(master)); item = new CTabItem(folder, SWT.NONE); @@ -203,9 +202,9 @@ public class BindingContextEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.ModelTooling_ApplicationElement_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MBindingContext.class); @@ -224,7 +223,7 @@ public class BindingContextEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN, eObject); + CommandsPackageImpl.Literals.BINDING_CONTEXT__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingTableEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingTableEditor.java index 68f99664..c0ed63da 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingTableEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/BindingTableEditor.java @@ -58,7 +58,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -68,7 +67,7 @@ public class BindingTableEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty BINDING_TABLE__BINDINGS = EMFProperties - .list(CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS); + .list(CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -80,7 +79,7 @@ public class BindingTableEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.BindingTableEditor_AddKeyBinding, - createImageDescriptor(ResourceProvider.IMG_KeyBinding)) { + createImageDescriptor(ResourceProvider.IMG_KeyBinding)) { @Override public void run() { handleAddKeyBinding(); @@ -89,8 +88,8 @@ public class BindingTableEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_BindingTable); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_BindingTable); } @Override @@ -137,7 +136,7 @@ public class BindingTableEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -168,9 +167,9 @@ public class BindingTableEditor extends AbstractComponentEditor { gd.horizontalSpan = 2; t.setLayoutData(gd); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID).observeDetail(getMaster())); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID).observeDetail(getMaster())); } { @@ -182,11 +181,11 @@ public class BindingTableEditor extends AbstractComponentEditor { t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); t.setEditable(false); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value( - getEditingDomain(), - FeaturePath.fromList(CommandsPackageImpl.Literals.BINDING_TABLE__BINDING_CONTEXT, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)).observeDetail(getMaster())); + textProp.observeDelayed(200, t), + EMFEditProperties.value( + getEditingDomain(), + FeaturePath.fromList(CommandsPackageImpl.Literals.BINDING_TABLE__BINDING_CONTEXT, + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)).observeDetail(getMaster())); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); b.setLayoutData(new GridData(GridData.FILL, GridData.CENTER, false, false)); @@ -196,10 +195,10 @@ public class BindingTableEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final BindingContextSelectionDialog dialog = new BindingContextSelectionDialog(b.getShell(), - getEditor().getModelProvider(), Messages); + getEditor().getModelProvider(), Messages); if (dialog.open() == Window.OK) { final Command cmd = SetCommand.create(getEditingDomain(), getMaster().getValue(), - CommandsPackageImpl.Literals.BINDING_TABLE__BINDING_CONTEXT, dialog.getSelectedContext()); + CommandsPackageImpl.Literals.BINDING_TABLE__BINDING_CONTEXT, dialog.getSelectedContext()); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -210,7 +209,7 @@ public class BindingTableEditor extends AbstractComponentEditor { { final E4PickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), - Messages, this, CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS) { + Messages, this, CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS) { @Override protected void addPressed() { handleAddKeyBinding(); @@ -237,9 +236,9 @@ public class BindingTableEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.ModelTooling_ApplicationElement_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MBindingTable.class); @@ -257,7 +256,7 @@ public class BindingTableEditor extends AbstractComponentEditor { public String getDetailLabel(Object element) { final MBindingTable cmd = (MBindingTable) element; if (cmd.getBindingContext() != null && cmd.getBindingContext().getName() != null - && cmd.getBindingContext().getName().trim().length() > 0) { + && cmd.getBindingContext().getName().trim().length() > 0) { return cmd.getBindingContext().getName(); } @@ -267,7 +266,7 @@ public class BindingTableEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(CommandsPackageImpl.Literals.BINDING_TABLE__BINDING_CONTEXT, - CommandsPackageImpl.Literals.BINDING_CONTEXT__NAME) }; + CommandsPackageImpl.Literals.BINDING_CONTEXT__NAME) }; } @Override @@ -280,7 +279,7 @@ public class BindingTableEditor extends AbstractComponentEditor { protected void handleAddKeyBinding() { final MKeyBinding handler = MCommandsFactory.INSTANCE.createKeyBinding(); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS, handler); + CommandsPackageImpl.Literals.BINDING_TABLE__BINDINGS, handler); setElementId(handler); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CategoryEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CategoryEditor.java index 147b1d21..e42a7423 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CategoryEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CategoryEditor.java @@ -34,7 +34,6 @@ import org.eclipse.swt.custom.StackLayout; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; public class CategoryEditor extends AbstractComponentEditor { @@ -48,8 +47,8 @@ public class CategoryEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_Category); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Category); } @Override @@ -98,12 +97,12 @@ public class CategoryEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(CommandsPackageImpl.Literals.CATEGORY__NAME, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -125,12 +124,12 @@ public class CategoryEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.CategoryEditor_Name, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.CATEGORY__NAME)); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.CATEGORY__NAME)); ControlFactory.createTextField(parent, Messages.CategoryEditor_Description, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.CATEGORY__DESCRIPTION)); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.CATEGORY__DESCRIPTION)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -139,9 +138,9 @@ public class CategoryEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MCategory.class); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandEditor.java index c5645349..af0c2fd1 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandEditor.java @@ -56,7 +56,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -69,7 +68,7 @@ public class CommandEditor extends AbstractComponentEditor { private MessageFormat newCommandParameterName; private final IEMFEditListProperty COMMAND__PARAMETERS = EMFEditProperties.list(getEditingDomain(), - CommandsPackageImpl.Literals.COMMAND__PARAMETERS); + CommandsPackageImpl.Literals.COMMAND__PARAMETERS); @Inject public CommandEditor() { @@ -79,7 +78,7 @@ public class CommandEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.CommandEditor_AddCommandParameter, - createImageDescriptor(ResourceProvider.IMG_CommandParameter)) { + createImageDescriptor(ResourceProvider.IMG_CommandParameter)) { @Override public void run() { handleAddCommandParameter(); @@ -90,8 +89,8 @@ public class CommandEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_Command); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Command); } @Override @@ -135,12 +134,12 @@ public class CommandEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(CommandsPackageImpl.Literals.COMMAND__COMMAND_NAME, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -162,13 +161,13 @@ public class CommandEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, - Messages.ModelTooling_CommandId_tooltip, master, context, textProp, EMFEditProperties.value( - getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID), - Messages.ModelTooling_Empty_Warning); + Messages.ModelTooling_CommandId_tooltip, master, context, textProp, EMFEditProperties.value( + getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID), + Messages.ModelTooling_Empty_Warning); ControlFactory.createTextField(parent, Messages.CommandEditor_Name, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND__COMMAND_NAME)); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND__COMMAND_NAME)); ControlFactory.createTextField(parent, Messages.CommandEditor_LabelDescription, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND__DESCRIPTION)); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND__DESCRIPTION)); // ------------------------------------------------------------ { @@ -182,11 +181,11 @@ public class CommandEditor extends AbstractComponentEditor { t.setLayoutData(gd); t.setEditable(false); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value( - getEditingDomain(), - FeaturePath.fromList(CommandsPackageImpl.Literals.COMMAND__CATEGORY, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)).observeDetail(getMaster())); + textProp.observeDelayed(200, t), + EMFEditProperties.value( + getEditingDomain(), + FeaturePath.fromList(CommandsPackageImpl.Literals.COMMAND__CATEGORY, + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)).observeDetail(getMaster())); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); b.setText(Messages.ModelTooling_Common_FindEllipsis); @@ -196,7 +195,7 @@ public class CommandEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final CommandCategorySelectionDialog dialog = new CommandCategorySelectionDialog(b.getShell(), - getEditor().getModelProvider(), (MCommand) getMaster().getValue(), Messages); + getEditor().getModelProvider(), (MCommand) getMaster().getValue(), Messages); dialog.open(); } }); @@ -205,7 +204,7 @@ public class CommandEditor extends AbstractComponentEditor { // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), - Messages, this, CommandsPackageImpl.Literals.COMMAND__PARAMETERS) { + Messages, this, CommandsPackageImpl.Literals.COMMAND__PARAMETERS) { @Override protected void addPressed() { handleAddCommandParameter(); @@ -223,7 +222,7 @@ public class CommandEditor extends AbstractComponentEditor { final TableViewer viewer = pickList.getList(); final IEMFEditListProperty mProp = EMFEditProperties.list(getEditingDomain(), - CommandsPackageImpl.Literals.COMMAND__PARAMETERS); + CommandsPackageImpl.Literals.COMMAND__PARAMETERS); viewer.setInput(mProp.observeDetail(getMaster())); } @@ -234,9 +233,9 @@ public class CommandEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.ModelTooling_ApplicationElement_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MCommand.class); @@ -270,7 +269,7 @@ public class CommandEditor extends AbstractComponentEditor { param.setName(newCommandParameterName.format(new Object[] { getParameterCount() })); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - CommandsPackageImpl.Literals.COMMAND__PARAMETERS, param); + CommandsPackageImpl.Literals.COMMAND__PARAMETERS, param); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandParameterEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandParameterEditor.java index 3db9f0a8..5abd04f0 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandParameterEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CommandParameterEditor.java @@ -37,7 +37,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; public class CommandParameterEditor extends AbstractComponentEditor { @@ -54,12 +53,12 @@ public class CommandParameterEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(CommandsPackageImpl.Literals.COMMAND_PARAMETER__NAME), - FeaturePath.fromList(ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID) }; + FeaturePath.fromList(ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID) }; } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_CommandParameter); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_CommandParameter); } @Override @@ -138,14 +137,14 @@ public class CommandParameterEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID), - Messages.ModelTooling_Empty_Warning); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID), + Messages.ModelTooling_Empty_Warning); ControlFactory.createTextField(parent, Messages.CommandParameterEditor_Name, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND_PARAMETER__NAME), - Messages.ModelTooling_Empty_Warning); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND_PARAMETER__NAME), + Messages.ModelTooling_Empty_Warning); ControlFactory.createTextField(parent, Messages.CommandParameterEditor_TypeId, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND_PARAMETER__TYPE_ID)); + EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.COMMAND_PARAMETER__TYPE_ID)); { final Label l = new Label(parent, SWT.NONE); @@ -156,7 +155,7 @@ public class CommandParameterEditor extends AbstractComponentEditor { checkbox.setLayoutData(new GridData(GridData.BEGINNING, GridData.BEGINNING, false, false, 2, 1)); final IEMFEditValueProperty mprop = EMFEditProperties.value(getEditingDomain(), - CommandsPackageImpl.Literals.COMMAND_PARAMETER__OPTIONAL); + CommandsPackageImpl.Literals.COMMAND_PARAMETER__OPTIONAL); final IWidgetValueProperty uiProp = WidgetProperties.selection(); context.bindValue(uiProp.observe(checkbox), mprop.observeDetail(master)); @@ -169,9 +168,9 @@ public class CommandParameterEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MCommandParameter.class); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CompositePartEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CompositePartEditor.java index 9e47c634..cf480368 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CompositePartEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CompositePartEditor.java @@ -73,7 +73,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Text; @@ -84,7 +83,7 @@ public class CompositePartEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); private final List<Action> actionsImport = new ArrayList<Action>(); @@ -107,14 +106,14 @@ public class CompositePartEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.CompositePartEditor_AddPartSashContainer, - createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { + createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.COMPOSITE_PART); } }); actions.add(new Action(Messages.CompositePartEditor_AddPartStack, - createImageDescriptor(ResourceProvider.IMG_PartStack)) { + createImageDescriptor(ResourceProvider.IMG_PartStack)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART_STACK); @@ -134,14 +133,14 @@ public class CompositePartEditor extends AbstractComponentEditor { } }); actions.add(new Action(Messages.CompositePartEditor_AddPlaceholder, - createImageDescriptor(ResourceProvider.IMG_Placeholder)) { + createImageDescriptor(ResourceProvider.IMG_Placeholder)) { @Override public void run() { handleAddChild(AdvancedPackageImpl.Literals.PLACEHOLDER); } }); for (final FeatureClass c : getEditor().getFeatureClasses(BasicPackageImpl.Literals.PART_STACK, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)) { final EClass ec = c.eClass; actions.add(new Action(c.label, createImageDescriptor(c.iconId)) { @Override @@ -168,25 +167,12 @@ public class CompositePartEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { + public Image getImage(Object element) { final boolean horizontal = ((MCompositePart) element).isHorizontal(); - if (!horizontal) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_PartSashContainer_vertical); - } - return createImage(ResourceProvider.IMG_Tbr_PartSashContainer_vertical); - } + return horizontal ? getImage(element, ResourceProvider.IMG_PartSashContainer) + : getImage(element, ResourceProvider.IMG_PartSashContainer_vertical); - if (horizontal) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_PartSashContainer); - } - return createImage(ResourceProvider.IMG_Tbr_PartSashContainer); - } - return null; } @Override @@ -233,7 +219,7 @@ public class CompositePartEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -255,15 +241,15 @@ public class CompositePartEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createTextField(parent, Messages.CompositePartEditor_LabelLabel, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL)); ControlFactory.createTextField(parent, Messages.CompositePartEditor_Tooltip, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP)); // ------------------------------------------------------------ { @@ -276,9 +262,9 @@ public class CompositePartEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -301,7 +287,7 @@ public class CompositePartEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final PartIconDialogEditor dialog = new PartIconDialogEditor(b.getShell(), eclipseContext, project, - getEditingDomain(), (MPart) getMaster().getValue(), Messages); + getEditingDomain(), (MPart) getMaster().getValue(), Messages); dialog.open(); } }); @@ -322,19 +308,19 @@ public class CompositePartEditor extends AbstractComponentEditor { @Override public String getText(Object element) { return ((Boolean) element).booleanValue() ? Messages.CompositePartEditor_Horizontal - : Messages.CompositePartEditor_Vertical; + : Messages.CompositePartEditor_Vertical; } }); viewer.setInput(new Boolean[] { Boolean.TRUE, Boolean.FALSE }); final IViewerValueProperty vProp = ViewerProperties.singleSelection(); context.bindValue(vProp.observe(viewer), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL) - .observeDetail(getMaster())); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL) + .observeDetail(getMaster())); } ControlFactory.createSelectedElement(parent, this, context, Messages.CompositePartEditor_SelectedElement); ControlFactory.createTextField(parent, Messages.CompositePartEditor_ContainerData, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); { @@ -364,7 +350,7 @@ public class CompositePartEditor extends AbstractComponentEditor { eClassList.add(new FeatureClass("Area", AdvancedPackageImpl.Literals.AREA)); //$NON-NLS-1$ eClassList.add(new FeatureClass("Placeholder", AdvancedPackageImpl.Literals.PLACEHOLDER)); //$NON-NLS-1$ eClassList.addAll(getEditor().getFeatureClasses(BasicPackageImpl.Literals.COMPOSITE_PART, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)); childrenDropDown.setInput(eClassList); childrenDropDown.setSelection(new StructuredSelection(eClassList.get(0))); @@ -377,7 +363,7 @@ public class CompositePartEditor extends AbstractComponentEditor { public void widgetSelected(SelectionEvent e) { if (!childrenDropDown.getSelection().isEmpty()) { final EClass eClass = ((FeatureClass) ((IStructuredSelection) childrenDropDown.getSelection()) - .getFirstElement()).eClass; + .getFirstElement()).eClass; handleAddChild(eClass); } } @@ -415,7 +401,7 @@ public class CompositePartEditor extends AbstractComponentEditor { final int idx = container.getChildren().indexOf(obj) - 1; if (idx >= 0) { if (Util.moveElementByIndex(getEditingDomain(), (MUIElement) obj, getEditor() - .isLiveModel(), idx)) { + .isLiveModel(), idx)) { viewer.setSelection(new StructuredSelection(obj)); } } @@ -439,7 +425,7 @@ public class CompositePartEditor extends AbstractComponentEditor { final int idx = container.getChildren().indexOf(obj) + 1; if (idx < container.getChildren().size()) { if (Util.moveElementByIndex(getEditingDomain(), (MUIElement) obj, getEditor() - .isLiveModel(), idx)) { + .isLiveModel(), idx)) { viewer.setSelection(new StructuredSelection(obj)); } } @@ -459,7 +445,7 @@ public class CompositePartEditor extends AbstractComponentEditor { final List<?> elements = ((IStructuredSelection) viewer.getSelection()).toList(); final Command cmd = RemoveCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, elements); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, elements); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -469,11 +455,11 @@ public class CompositePartEditor extends AbstractComponentEditor { } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -482,9 +468,9 @@ public class CompositePartEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -506,7 +492,7 @@ public class CompositePartEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -523,7 +509,7 @@ public class CompositePartEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } protected void handleAddChild(EClass eClass) { @@ -535,7 +521,7 @@ public class CompositePartEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CoreExpressionEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CoreExpressionEditor.java index 0c81147f..e36f7e3a 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CoreExpressionEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/CoreExpressionEditor.java @@ -35,7 +35,6 @@ import org.eclipse.swt.layout.FillLayout; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -49,8 +48,8 @@ public class CoreExpressionEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_CoreExpression); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_CoreExpression); } @Override @@ -61,7 +60,7 @@ public class CoreExpressionEditor extends AbstractComponentEditor { @Override public String getDetailLabel(Object element) { if (((MCoreExpression) element).getCoreExpressionId() != null - && ((MCoreExpression) element).getCoreExpressionId().trim().length() > 0) { + && ((MCoreExpression) element).getCoreExpressionId().trim().length() > 0) { return ((MCoreExpression) element).getCoreExpressionId(); } return null; @@ -109,8 +108,8 @@ public class CoreExpressionEditor extends AbstractComponentEditor { final GridData gd = new GridData(GridData.FILL_HORIZONTAL); t.setLayoutData(gd); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.CORE_EXPRESSION__CORE_EXPRESSION_ID) - .observeDetail(getMaster())); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.CORE_EXPRESSION__CORE_EXPRESSION_ID) + .observeDetail(getMaster())); if (getEditor().getExtensionLookup() == null) { gd.horizontalSpan = 2; @@ -122,8 +121,8 @@ public class CoreExpressionEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final ExpressionIdDialog dialog = new ExpressionIdDialog(t.getShell(), getEditor() - .getExtensionLookup(), (MCoreExpression) getMaster().getValue(), getEditingDomain(), - getEditor().isLiveModel(), Messages); + .getExtensionLookup(), (MCoreExpression) getMaster().getValue(), getEditingDomain(), + getEditor().isLiveModel(), Messages); dialog.open(); } }); @@ -137,9 +136,9 @@ public class CoreExpressionEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MCoreExpression.class); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DefaultEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DefaultEditor.java index 78485075..caf78604 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DefaultEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DefaultEditor.java @@ -5,12 +5,11 @@ import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class DefaultEditor extends AbstractComponentEditor { @Override - public Image getImage(Object element, Display display) { + public Image getImage(Object element) { // no image return null; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DialogEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DialogEditor.java index 4f531b0e..40a4aa8c 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DialogEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DialogEditor.java @@ -14,26 +14,15 @@ import java.util.ArrayList; import java.util.List; import org.eclipse.e4.tools.emf.ui.internal.ResourceProvider; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.basic.MDialog; import org.eclipse.jface.action.Action; import org.eclipse.swt.graphics.Image; -import org.eclipse.swt.widgets.Display; public class DialogEditor extends WindowEditor { @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - final Image img = getImageFromIconURI(uiElement); - return img != null ? img : createImage(ResourceProvider.IMG_Dialog); - } - return createImage(ResourceProvider.IMG_Tbr_Dialog); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Dialog); } @Override diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectMenuItemEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectMenuItemEditor.java index 4298b057..37d73006 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectMenuItemEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectMenuItemEditor.java @@ -30,7 +30,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.Contributio import org.eclipse.e4.tools.emf.ui.internal.common.objectdata.ObjectViewer; import org.eclipse.e4.ui.model.application.MContribution; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MDirectMenuItem; import org.eclipse.e4.ui.model.application.ui.menu.impl.MenuPackageImpl; @@ -53,14 +52,13 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; public class DirectMenuItemEditor extends MenuItemEditor { private final IEMFValueProperty UI_ELEMENT__VISIBLE_WHEN = EMFProperties - .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); + .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); @Inject IEclipseContext eclipseContext; @@ -71,21 +69,13 @@ public class DirectMenuItemEditor extends MenuItemEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_DirectMenuItem); - } - return createImage(ResourceProvider.IMG_Tbr_DirectMenuItem); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_DirectMenuItem); } @Override protected CTabFolder createForm(Composite parent, EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { if (!isImport) { final CTabFolder folder = super.createForm(parent, context, master, isImport); createInstanceInspection(folder); @@ -103,7 +93,7 @@ public class DirectMenuItemEditor extends MenuItemEditor { final ObjectViewer objectViewer = new ObjectViewer(); final TreeViewer viewer = objectViewer.createViewer(container, - ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); + ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -126,7 +116,7 @@ public class DirectMenuItemEditor extends MenuItemEditor { final Link lnk; { final IContributionClassCreator c = getEditor().getContributionCreator( - MenuPackageImpl.Literals.DIRECT_MENU_ITEM); + MenuPackageImpl.Literals.DIRECT_MENU_ITEM); if (project != null && c != null) { lnk = new Link(parent, SWT.NONE); lnk.setText("<A>" + Messages.DirectMenuItemEditor_ClassURI + "</A>"); //$NON-NLS-1$//$NON-NLS-2$ @@ -135,7 +125,7 @@ public class DirectMenuItemEditor extends MenuItemEditor { @Override public void widgetSelected(SelectionEvent e) { c.createOpen((MContribution) getMaster().getValue(), getEditingDomain(), project, - lnk.getShell()); + lnk.getShell()); } }); } else { @@ -158,11 +148,11 @@ public class DirectMenuItemEditor extends MenuItemEditor { } }); final Binding binding = context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(master), - new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), - new UpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(master), + new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), + new UpdateValueStrategy()); Util.addDecoration(t, binding); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -173,8 +163,8 @@ public class DirectMenuItemEditor extends MenuItemEditor { @Override public void widgetSelected(SelectionEvent e) { final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, - getEditingDomain(), (MContribution) getMaster().getValue(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); + getEditingDomain(), (MContribution) getMaster().getValue(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); dialog.open(); } }); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectToolItemEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectToolItemEditor.java index 59fffc23..871646f3 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectToolItemEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DirectToolItemEditor.java @@ -29,7 +29,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.Contributio import org.eclipse.e4.tools.emf.ui.internal.common.objectdata.ObjectViewer; import org.eclipse.e4.ui.model.application.MContribution; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MDirectToolItem; import org.eclipse.e4.ui.model.application.ui.menu.impl.MenuPackageImpl; @@ -52,14 +51,13 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; public class DirectToolItemEditor extends ToolItemEditor { private final IEMFValueProperty UI_ELEMENT__VISIBLE_WHEN = EMFProperties - .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); + .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); @Inject IEclipseContext eclipseContext; @@ -70,17 +68,8 @@ public class DirectToolItemEditor extends ToolItemEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - final Image img = getImageFromIconURI(uiElement); - return img != null ? img : createImage(ResourceProvider.IMG_DirectToolItem); - } - return createImage(ResourceProvider.IMG_Tbr_DirectToolItem); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_DirectToolItem); } @Override @@ -88,7 +77,7 @@ public class DirectToolItemEditor extends ToolItemEditor { final IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); final IContributionClassCreator c = getEditor().getContributionCreator( - MenuPackageImpl.Literals.DIRECT_TOOL_ITEM); + MenuPackageImpl.Literals.DIRECT_TOOL_ITEM); final Link lnk; if (project != null && c != null) { lnk = new Link(parent, SWT.NONE); @@ -120,9 +109,9 @@ public class DirectToolItemEditor extends ToolItemEditor { } }); final Binding binding = context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI) - .observeDetail(master), new UpdateValueStrategy() - .setAfterConvertValidator(new ContributionURIValidator()), new UpdateValueStrategy()); + EMFEditProperties.value(getEditingDomain(), ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI) + .observeDetail(master), new UpdateValueStrategy() + .setAfterConvertValidator(new ContributionURIValidator()), new UpdateValueStrategy()); Util.addDecoration(t, binding); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -133,8 +122,8 @@ public class DirectToolItemEditor extends ToolItemEditor { @Override public void widgetSelected(SelectionEvent e) { final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, - getEditingDomain(), (MContribution) getMaster().getValue(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); + getEditingDomain(), (MContribution) getMaster().getValue(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); dialog.open(); } }); @@ -142,7 +131,7 @@ public class DirectToolItemEditor extends ToolItemEditor { @Override protected CTabFolder createForm(Composite parent, EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { if (!isImport) { final CTabFolder folder = super.createForm(parent, context, master, isImport); createInstanceInspection(folder); @@ -160,7 +149,7 @@ public class DirectToolItemEditor extends ToolItemEditor { final ObjectViewer objectViewer = new ObjectViewer(); final TreeViewer viewer = objectViewer.createViewer(container, - ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); + ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DynamicMenuContributionEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DynamicMenuContributionEditor.java index 216c817d..abdd78aa 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DynamicMenuContributionEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/DynamicMenuContributionEditor.java @@ -30,7 +30,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.ControlFactory.Text import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.ContributionClassDialog; import org.eclipse.e4.ui.model.application.MContribution; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.MUILabel; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MDynamicMenuContribution; @@ -53,7 +52,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; @@ -87,15 +85,8 @@ public class DynamicMenuContributionEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - if (((MUIElement) element).isToBeRendered()) { - return createImage(ResourceProvider.IMG_DynamicMenuContribution); - } - return createImage(ResourceProvider.IMG_Tbr_DynamicMenuContribution); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_DynamicMenuContribution); } @Override @@ -137,7 +128,7 @@ public class DynamicMenuContributionEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); final CTabItem item = new CTabItem(folder, SWT.NONE); @@ -159,17 +150,17 @@ public class DynamicMenuContributionEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTranslatedTextField(parent, Messages.DynamicMenuContributionEditor_LabelLabel, - getMaster(), context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, project); + getMaster(), context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, project); // ------------------------------------------------------------ final Link lnk; { final IContributionClassCreator c = getEditor().getContributionCreator( - MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION); + MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION); if (project != null && c != null) { lnk = new Link(parent, SWT.NONE); lnk.setText("<A>" + Messages.DynamicMenuContributionEditor_ClassURI + "</A>"); //$NON-NLS-1$//$NON-NLS-2$ @@ -178,7 +169,7 @@ public class DynamicMenuContributionEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { c.createOpen((MContribution) getMaster().getValue(), getEditingDomain(), project, - lnk.getShell()); + lnk.getShell()); } }); } else { @@ -201,11 +192,11 @@ public class DynamicMenuContributionEditor extends AbstractComponentEditor { } }); final Binding binding = context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(getMaster()), - new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), - new UpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(getMaster()), + new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), + new UpdateValueStrategy()); Util.addDecoration(t, binding); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -216,8 +207,8 @@ public class DynamicMenuContributionEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, - getEditingDomain(), (MContribution) getMaster().getValue(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); + getEditingDomain(), (MContribution) getMaster().getValue(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); dialog.open(); } }); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledMenuItemEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledMenuItemEditor.java index fcafdf98..9c65ccf5 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledMenuItemEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledMenuItemEditor.java @@ -26,7 +26,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.VirtualEntry; import org.eclipse.e4.tools.emf.ui.internal.common.component.ControlFactory.TextPasteHandler; import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.HandledMenuItemCommandSelectionDialog; import org.eclipse.e4.ui.model.application.commands.MParameter; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MHandledItem; import org.eclipse.e4.ui.model.application.ui.menu.MHandledMenuItem; @@ -45,16 +44,15 @@ import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; public class HandledMenuItemEditor extends MenuItemEditor { private final IEMFEditListProperty HANDLED_ITEM__PARAMETERS = EMFEditProperties.list(getEditingDomain(), - MenuPackageImpl.Literals.HANDLED_ITEM__PARAMETERS); + MenuPackageImpl.Literals.HANDLED_ITEM__PARAMETERS); private final IEMFValueProperty UI_ELEMENT__VISIBLE_WHEN = EMFProperties - .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); + .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); @Inject private IModelResource resource; @@ -65,17 +63,8 @@ public class HandledMenuItemEditor extends MenuItemEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - final Image img = getImageFromIconURI(uiElement); - return img != null ? img : createImage(ResourceProvider.IMG_HandledMenuItem); - } - return createImage(ResourceProvider.IMG_Tbr_HandledMenuItem); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_HandledMenuItem); } @Override @@ -103,9 +92,9 @@ public class HandledMenuItemEditor extends MenuItemEditor { t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); t.setEditable(false); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.HANDLED_ITEM__COMMAND) - .observeDetail(master), new UpdateValueStrategy(), new UpdateValueStrategy() - .setConverter(new CommandToStringConverter(Messages))); + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.HANDLED_ITEM__COMMAND) + .observeDetail(master), new UpdateValueStrategy(), new UpdateValueStrategy() + .setConverter(new CommandToStringConverter(Messages))); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); b.setText(Messages.ModelTooling_Common_FindEllipsis); @@ -115,7 +104,7 @@ public class HandledMenuItemEditor extends MenuItemEditor { @Override public void widgetSelected(SelectionEvent e) { final HandledMenuItemCommandSelectionDialog dialog = new HandledMenuItemCommandSelectionDialog(b - .getShell(), (MHandledItem) getMaster().getValue(), resource, Messages); + .getShell(), (MHandledItem) getMaster().getValue(), resource, Messages); dialog.open(); } }); @@ -145,7 +134,7 @@ public class HandledMenuItemEditor extends MenuItemEditor { }); list.add(new VirtualEntry<MParameter>(ModelEditor.VIRTUAL_PARAMETERS, HANDLED_ITEM__PARAMETERS, element, - Messages.HandledMenuItemEditor_Parameters) { + Messages.HandledMenuItemEditor_Parameters) { @Override protected boolean accepted(MParameter o) { return true; diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledToolItemEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledToolItemEditor.java index 5c4258f7..2287f6c9 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledToolItemEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandledToolItemEditor.java @@ -25,7 +25,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.VirtualEntry; import org.eclipse.e4.tools.emf.ui.internal.common.component.ControlFactory.TextPasteHandler; import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.HandledToolItemCommandSelectionDialog; import org.eclipse.e4.ui.model.application.commands.MParameter; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MHandledItem; import org.eclipse.e4.ui.model.application.ui.menu.MHandledToolItem; @@ -44,16 +43,15 @@ import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; public class HandledToolItemEditor extends ToolItemEditor { private final IEMFEditListProperty HANDLED_ITEM__PARAMETERS = EMFEditProperties.list(getEditingDomain(), - MenuPackageImpl.Literals.HANDLED_ITEM__PARAMETERS); + MenuPackageImpl.Literals.HANDLED_ITEM__PARAMETERS); private final IEMFValueProperty UI_ELEMENT__VISIBLE_WHEN = EMFProperties - .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); + .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); @Inject private IModelResource resource; @@ -64,17 +62,8 @@ public class HandledToolItemEditor extends ToolItemEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - final Image img = getImageFromIconURI(uiElement); - return img != null ? img : createImage(ResourceProvider.IMG_HandledToolItem); - } - return createImage(ResourceProvider.IMG_Tbr_HandledToolItem); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_HandledToolItem); } @Override @@ -91,9 +80,9 @@ public class HandledToolItemEditor extends ToolItemEditor { t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); t.setEditable(false); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.HANDLED_ITEM__COMMAND) - .observeDetail(master), new UpdateValueStrategy(), new UpdateValueStrategy() - .setConverter(new CommandToStringConverter(Messages))); + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.HANDLED_ITEM__COMMAND) + .observeDetail(master), new UpdateValueStrategy(), new UpdateValueStrategy() + .setConverter(new CommandToStringConverter(Messages))); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); b.setText(Messages.ModelTooling_Common_FindEllipsis); @@ -103,7 +92,7 @@ public class HandledToolItemEditor extends ToolItemEditor { @Override public void widgetSelected(SelectionEvent e) { final HandledToolItemCommandSelectionDialog dialog = new HandledToolItemCommandSelectionDialog(b - .getShell(), (MHandledItem) getMaster().getValue(), resource, Messages); + .getShell(), (MHandledItem) getMaster().getValue(), resource, Messages); dialog.open(); } }); @@ -144,7 +133,7 @@ public class HandledToolItemEditor extends ToolItemEditor { }); list.add(new VirtualEntry<MParameter>(ModelEditor.VIRTUAL_PARAMETERS, HANDLED_ITEM__PARAMETERS, element, - Messages.HandledToolItemEditor_Parameters) { + Messages.HandledToolItemEditor_Parameters) { @Override protected boolean accepted(MParameter o) { return true; diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandlerEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandlerEditor.java index 02482734..ab936eeb 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandlerEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/HandlerEditor.java @@ -13,6 +13,7 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component; import javax.inject.Inject; + import org.eclipse.core.databinding.Binding; import org.eclipse.core.databinding.UpdateValueStrategy; import org.eclipse.core.databinding.observable.list.IObservableList; @@ -56,7 +57,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; @@ -82,8 +82,8 @@ public class HandlerEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_Handler); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Handler); } @Override @@ -130,7 +130,7 @@ public class HandlerEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, boolean isImport) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); @@ -138,7 +138,7 @@ public class HandlerEditor extends AbstractComponentEditor { parent = createScrollableContainer(folder); item.setControl(parent.getParent()); - IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); + final IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); if (getEditor().isShowXMIId() || getEditor().isLiveModel()) { ControlFactory.createXMIId(parent, this); @@ -154,11 +154,11 @@ public class HandlerEditor extends AbstractComponentEditor { // ------------------------------------------------------------ { - Label l = new Label(parent, SWT.NONE); + final Label l = new Label(parent, SWT.NONE); l.setText(Messages.HandlerEditor_Command); l.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_END)); - Text t = new Text(parent, SWT.BORDER); + final Text t = new Text(parent, SWT.BORDER); TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); t.setEditable(false); @@ -171,7 +171,7 @@ public class HandlerEditor extends AbstractComponentEditor { b.addSelectionListener(new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) { - HandlerCommandSelectionDialog dialog = new HandlerCommandSelectionDialog(b.getShell(), (MHandler) getMaster().getValue(), resource, Messages); + final HandlerCommandSelectionDialog dialog = new HandlerCommandSelectionDialog(b.getShell(), (MHandler) getMaster().getValue(), resource, Messages); dialog.open(); } }); @@ -193,12 +193,12 @@ public class HandlerEditor extends AbstractComponentEditor { }); } else { lnk = null; - Label l = new Label(parent, SWT.NONE); + final Label l = new Label(parent, SWT.NONE); l.setText(Messages.HandlerEditor_ClassURI); l.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_END)); } - Text t = new Text(parent, SWT.BORDER); + final Text t = new Text(parent, SWT.BORDER); TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); t.addModifyListener(new ModifyListener() { @@ -206,11 +206,11 @@ public class HandlerEditor extends AbstractComponentEditor { @Override public void modifyText(ModifyEvent e) { if (lnk != null) { - lnk.setToolTipText(((Text) (e.getSource())).getText()); + lnk.setToolTipText(((Text) e.getSource()).getText()); } } }); - Binding binding = context.bindValue(textProp.observeDelayed(200, t), EMFEditProperties.value(getEditingDomain(), ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(getMaster()), new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), new UpdateValueStrategy()); + final Binding binding = context.bindValue(textProp.observeDelayed(200, t), EMFEditProperties.value(getEditingDomain(), ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(getMaster()), new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), new UpdateValueStrategy()); Util.addDecoration(t, binding); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -220,7 +220,7 @@ public class HandlerEditor extends AbstractComponentEditor { b.addSelectionListener(new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) { - ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, getEditingDomain(), (MContribution) getMaster().getValue(), ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); + final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, getEditingDomain(), (MContribution) getMaster().getValue(), ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); dialog.open(); } }); @@ -246,14 +246,14 @@ public class HandlerEditor extends AbstractComponentEditor { } private void createInstanceInspection(CTabFolder folder) { - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_RuntimeContributionInstance); - Composite container = new Composite(folder, SWT.NONE); + final Composite container = new Composite(folder, SWT.NONE); container.setLayout(new GridLayout()); item.setControl(container); - ObjectViewer objectViewer = new ObjectViewer(); - TreeViewer viewer = objectViewer.createViewer(container, ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); + final ObjectViewer objectViewer = new ObjectViewer(); + final TreeViewer viewer = objectViewer.createViewer(container, ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -265,7 +265,7 @@ public class HandlerEditor extends AbstractComponentEditor { @Override public String getDetailLabel(Object element) { - MHandler handler = (MHandler) element; + final MHandler handler = (MHandler) element; if (handler.getCommand() != null && handler.getCommand().getCommandName() != null && handler.getCommand().getCommandName().trim().length() > 0) { return handler.getCommand().getCommandName(); } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/KeyBindingEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/KeyBindingEditor.java index 79c3ec80..33780ec2 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/KeyBindingEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/KeyBindingEditor.java @@ -12,13 +12,13 @@ ******************************************************************************/ package org.eclipse.e4.tools.emf.ui.internal.common.component; -import org.eclipse.e4.tools.emf.ui.common.Plugin; - import java.util.ArrayList; import java.util.Arrays; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.Binding; import org.eclipse.core.databinding.UpdateValueStrategy; import org.eclipse.core.databinding.observable.list.IObservableList; @@ -28,6 +28,7 @@ import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Status; import org.eclipse.e4.tools.emf.ui.common.CommandToStringConverter; import org.eclipse.e4.tools.emf.ui.common.IModelResource; +import org.eclipse.e4.tools.emf.ui.common.Plugin; import org.eclipse.e4.tools.emf.ui.common.Util; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; import org.eclipse.e4.tools.emf.ui.internal.ResourceProvider; @@ -65,7 +66,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -74,9 +74,9 @@ public class KeyBindingEditor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private StackLayout stackLayout; - private List<Action> actions = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); - private IEMFEditListProperty KEY_BINDING__PARAMETERS = EMFEditProperties.list(getEditingDomain(), CommandsPackageImpl.Literals.KEY_BINDING__PARAMETERS); + private final IEMFEditListProperty KEY_BINDING__PARAMETERS = EMFEditProperties.list(getEditingDomain(), CommandsPackageImpl.Literals.KEY_BINDING__PARAMETERS); @Inject private IModelResource resource; @@ -97,8 +97,8 @@ public class KeyBindingEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_KeyBinding); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_KeyBinding); } @Override @@ -145,7 +145,7 @@ public class KeyBindingEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, boolean isImport) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); @@ -157,7 +157,7 @@ public class KeyBindingEditor extends AbstractComponentEditor { ControlFactory.createXMIId(parent, this); } - IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); + final IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); if (isImport) { ControlFactory.createFindImport(parent, Messages, this, context); @@ -169,26 +169,26 @@ public class KeyBindingEditor extends AbstractComponentEditor { // ------------------------------------------------------------ { - Label l = new Label(parent, SWT.NONE); + final Label l = new Label(parent, SWT.NONE); l.setText(Messages.KeyBindingEditor_Sequence); l.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_END)); final Text t = new Text(parent, SWT.BORDER); TextPasteHandler.createFor(t); - GridData gd = new GridData(GridData.FILL_HORIZONTAL); + final GridData gd = new GridData(GridData.FILL_HORIZONTAL); gd.horizontalSpan = 2; t.setLayoutData(gd); - Binding binding = context.bindValue(textProp.observeDelayed(200, t), EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.KEY_SEQUENCE__KEY_SEQUENCE).observeDetail(getMaster()), new UpdateValueStrategy().setBeforeSetValidator(new BindingValidator()), new UpdateValueStrategy()); + final Binding binding = context.bindValue(textProp.observeDelayed(200, t), EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.KEY_SEQUENCE__KEY_SEQUENCE).observeDetail(getMaster()), new UpdateValueStrategy().setBeforeSetValidator(new BindingValidator()), new UpdateValueStrategy()); Util.addDecoration(t, binding); } // ------------------------------------------------------------ { - Label l = new Label(parent, SWT.NONE); + final Label l = new Label(parent, SWT.NONE); l.setText(Messages.KeyBindingEditor_Command); l.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_END)); - Text t = new Text(parent, SWT.BORDER); + final Text t = new Text(parent, SWT.BORDER); TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); t.setEditable(false); @@ -201,14 +201,14 @@ public class KeyBindingEditor extends AbstractComponentEditor { b.addSelectionListener(new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) { - KeyBindingCommandSelectionDialog dialog = new KeyBindingCommandSelectionDialog(b.getShell(), (MKeyBinding) getMaster().getValue(), resource, Messages); + final KeyBindingCommandSelectionDialog dialog = new KeyBindingCommandSelectionDialog(b.getShell(), (MKeyBinding) getMaster().getValue(), resource, Messages); dialog.open(); } }); } { - E4PickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, CommandsPackageImpl.Literals.KEY_BINDING__PARAMETERS) { + final E4PickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, CommandsPackageImpl.Literals.KEY_BINDING__PARAMETERS) { @Override protected void addPressed() { handleAddParameter(); @@ -251,7 +251,7 @@ public class KeyBindingEditor extends AbstractComponentEditor { @Override public String getDetailLabel(Object element) { - MKeySequence seq = (MKeySequence) element; + final MKeySequence seq = (MKeySequence) element; if (seq.getKeySequence() != null && seq.getKeySequence().trim().length() > 0) { return seq.getKeySequence(); } @@ -267,36 +267,36 @@ public class KeyBindingEditor extends AbstractComponentEditor { @Override public IStatus validate(Object value) { - int statusCode = getEditor().isLiveModel() ? IStatus.ERROR : IStatus.WARNING; + final int statusCode = getEditor().isLiveModel() ? IStatus.ERROR : IStatus.WARNING; if (value != null && value.toString().trim().length() > 0) { try { - KeySequence keySequence = KeySequence.getInstance(value.toString()); + final KeySequence keySequence = KeySequence.getInstance(value.toString()); if (!keySequence.isComplete()) { - return new Status(statusCode, Plugin.ID, Messages.KeyBindingEditor_SequenceNotComplete); + return new Status(statusCode, Plugin.ID, Messages.KeyBindingEditor_SequenceNotComplete); } if (keySequence.isEmpty()) { - return new Status(statusCode, Plugin.ID, Messages.KeyBindingEditor_SequenceEmpty); + return new Status(statusCode, Plugin.ID, Messages.KeyBindingEditor_SequenceEmpty); } if (!value.toString().toUpperCase().equals(value.toString())) { - return new Status(IStatus.ERROR, Plugin.ID, Messages.KeyBindingEditor_SequenceLowercase); + return new Status(IStatus.ERROR, Plugin.ID, Messages.KeyBindingEditor_SequenceLowercase); } return Status.OK_STATUS; - } catch (Exception e) { - return new Status(statusCode, Plugin.ID, e.getMessage(), e); + } catch (final Exception e) { + return new Status(statusCode, Plugin.ID, e.getMessage(), e); } } - return new Status(statusCode, Plugin.ID, Messages.KeyBindingEditor_SequenceEmpty); + return new Status(statusCode, Plugin.ID, Messages.KeyBindingEditor_SequenceEmpty); } } protected void handleAddParameter() { - MKeyBinding item = (MKeyBinding) getMaster().getValue(); - MParameter param = MCommandsFactory.INSTANCE.createParameter(); + final MKeyBinding item = (MKeyBinding) getMaster().getValue(); + final MParameter param = MCommandsFactory.INSTANCE.createParameter(); setElementId(param); - Command cmd = AddCommand.create(getEditingDomain(), item, CommandsPackageImpl.Literals.KEY_BINDING__PARAMETERS, param); + final Command cmd = AddCommand.create(getEditingDomain(), item, CommandsPackageImpl.Literals.KEY_BINDING__PARAMETERS, param); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -304,7 +304,7 @@ public class KeyBindingEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuContributionEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuContributionEditor.java index 2f16ac52..1b0b4f50 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuContributionEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuContributionEditor.java @@ -32,7 +32,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.E4PickList.Struct; import org.eclipse.e4.tools.emf.ui.internal.common.component.ControlFactory.TextPasteHandler; import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.MenuIdDialog; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MMenuContribution; import org.eclipse.e4.ui.model.application.ui.menu.MMenuElement; @@ -65,7 +64,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -74,7 +72,7 @@ public class MenuContributionEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -92,7 +90,7 @@ public class MenuContributionEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.MenuEditor_AddHandledMenuItem, - createImageDescriptor(ResourceProvider.IMG_HandledMenuItem)) { + createImageDescriptor(ResourceProvider.IMG_HandledMenuItem)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.HANDLED_MENU_ITEM, false); @@ -105,21 +103,21 @@ public class MenuContributionEditor extends AbstractComponentEditor { } }); actions.add(new Action(Messages.MenuEditor_AddDirectMenuItem, - createImageDescriptor(ResourceProvider.IMG_DirectMenuItem)) { + createImageDescriptor(ResourceProvider.IMG_DirectMenuItem)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.DIRECT_MENU_ITEM, false); } }); actions.add(new Action(Messages.MenuEditor_AddSeparator, - createImageDescriptor(ResourceProvider.IMG_MenuSeparator)) { + createImageDescriptor(ResourceProvider.IMG_MenuSeparator)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.MENU_SEPARATOR, true); } }); actions.add(new Action(Messages.MenuEditor_AddDynamicMenuContribution, - createImageDescriptor(ResourceProvider.IMG_DynamicMenuContribution)) { + createImageDescriptor(ResourceProvider.IMG_DynamicMenuContribution)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION, false); @@ -128,15 +126,8 @@ public class MenuContributionEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - if (((MUIElement) element).isToBeRendered()) { - return createImage(ResourceProvider.IMG_MenuContribution); - } - return createImage(ResourceProvider.IMG_Tbr_MenuContribution); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_MenuContribution); } @Override @@ -209,11 +200,11 @@ public class MenuContributionEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); { final Label l = new Label(parent, SWT.NONE); @@ -225,7 +216,7 @@ public class MenuContributionEditor extends AbstractComponentEditor { final GridData gd = new GridData(GridData.FILL_HORIZONTAL); t.setLayoutData(gd); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.MENU_CONTRIBUTION__PARENT_ID) + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.MENU_CONTRIBUTION__PARENT_ID) .observeDetail(getMaster())); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -236,7 +227,7 @@ public class MenuContributionEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final MenuIdDialog dialog = new MenuIdDialog(t.getShell(), resource, - (MMenuContribution) getMaster().getValue(), getEditingDomain(), modelService, Messages); + (MMenuContribution) getMaster().getValue(), getEditingDomain(), modelService, Messages); dialog.open(); } }); @@ -244,14 +235,14 @@ public class MenuContributionEditor extends AbstractComponentEditor { } ControlFactory - .createTextField(parent, Messages.MenuContributionEditor_Position, master, context, textProp, + .createTextField(parent, Messages.MenuContributionEditor_Position, master, context, textProp, EMFEditProperties.value(getEditingDomain(), - MenuPackageImpl.Literals.MENU_CONTRIBUTION__POSITION_IN_PARENT)); + MenuPackageImpl.Literals.MENU_CONTRIBUTION__POSITION_IN_PARENT)); // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final Struct struct = (Struct) ((IStructuredSelection) getSelection()).getFirstElement(); @@ -259,7 +250,7 @@ public class MenuContributionEditor extends AbstractComponentEditor { final MMenuElement eObject = (MMenuElement) EcoreUtil.create(eClass); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -274,29 +265,29 @@ public class MenuContributionEditor extends AbstractComponentEditor { final TableViewer viewer = pickList.getList(); final IEMFListProperty prop = EMFEditProperties.list(getEditingDomain(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); viewer.setInput(prop.observeDetail(master)); final Struct defaultStruct = new Struct(Messages.MenuContributionEditor_HandledMenuItem, - MenuPackageImpl.Literals.HANDLED_MENU_ITEM, false); + MenuPackageImpl.Literals.HANDLED_MENU_ITEM, false); pickList.setInput(new Struct[] { - new Struct(Messages.MenuContributionEditor_Separator, MenuPackageImpl.Literals.MENU_SEPARATOR, true), - new Struct(Messages.MenuContributionEditor_Menu, MenuPackageImpl.Literals.MENU, false), - defaultStruct, - new Struct(Messages.MenuContributionEditor_DirectMenuItem, MenuPackageImpl.Literals.DIRECT_MENU_ITEM, - false), - new Struct(Messages.MenuContributionEditor_DynamicMenuContribution, - MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION, false) }); + new Struct(Messages.MenuContributionEditor_Separator, MenuPackageImpl.Literals.MENU_SEPARATOR, true), + new Struct(Messages.MenuContributionEditor_Menu, MenuPackageImpl.Literals.MENU, false), + defaultStruct, + new Struct(Messages.MenuContributionEditor_DirectMenuItem, MenuPackageImpl.Literals.DIRECT_MENU_ITEM, + false), + new Struct(Messages.MenuContributionEditor_DynamicMenuContribution, + MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION, false) }); pickList.setSelection(new StructuredSelection(defaultStruct)); } ControlFactory - .createCheckBox( + .createCheckBox( parent, "To Be Rendered", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); //$NON-NLS-1$ ControlFactory - .createCheckBox( + .createCheckBox( parent, "Visible", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); //$NON-NLS-1$ @@ -307,9 +298,9 @@ public class MenuContributionEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MMenuContribution.class); @@ -332,7 +323,7 @@ public class MenuContributionEditor extends AbstractComponentEditor { final MMenuElement eObject = (MMenuElement) EcoreUtil.create(eClass); setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuEditor.java index e8e0f63c..b235e4f5 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuEditor.java @@ -88,7 +88,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -98,9 +97,9 @@ public class MenuEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private final IEMFValueProperty UI_ELEMENT__VISIBLE_WHEN = EMFProperties - .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); + .value(UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -121,7 +120,7 @@ public class MenuEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.MenuEditor_AddHandledMenuItem, - createImageDescriptor(ResourceProvider.IMG_HandledMenuItem)) { + createImageDescriptor(ResourceProvider.IMG_HandledMenuItem)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.HANDLED_MENU_ITEM, false); @@ -134,33 +133,33 @@ public class MenuEditor extends AbstractComponentEditor { } }); actions.add(new Action(Messages.MenuEditor_AddDirectMenuItem, - createImageDescriptor(ResourceProvider.IMG_DirectMenuItem)) { + createImageDescriptor(ResourceProvider.IMG_DirectMenuItem)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.DIRECT_MENU_ITEM, false); } }); actions.add(new Action(Messages.MenuEditor_AddSeparator, - createImageDescriptor(ResourceProvider.IMG_MenuSeparator)) { + createImageDescriptor(ResourceProvider.IMG_MenuSeparator)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.MENU_SEPARATOR, true); } }); actions.add(new Action(Messages.MenuEditor_AddDynamicMenuContribution, - createImageDescriptor(ResourceProvider.IMG_DynamicMenuContribution)) { + createImageDescriptor(ResourceProvider.IMG_DynamicMenuContribution)) { @Override public void run() { handleAdd(MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION, false); } }); addExpression = new Action(Messages.MenuEditor_AddCoreExpression, - createImageDescriptor(ResourceProvider.IMG_CoreExpression)) { + createImageDescriptor(ResourceProvider.IMG_CoreExpression)) { @Override public void run() { final MUIElement e = (MUIElement) getMaster().getValue(); final Command cmd = SetCommand.create(getEditingDomain(), e, - UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN, MUiFactory.INSTANCE.createCoreExpression()); + UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN, MUiFactory.INSTANCE.createCoreExpression()); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -169,17 +168,8 @@ public class MenuEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - final Image img = getImageFromIconURI(uiElement); - return img != null ? img : createImage(ResourceProvider.IMG_Menu); - } - return createImage(ResourceProvider.IMG_Tbr_Menu); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Menu); } @Override @@ -218,12 +208,12 @@ public class MenuEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(UiPackageImpl.Literals.UI_LABEL__LABEL, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } protected Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master, - boolean rootMenu, boolean isImport) { + boolean rootMenu, boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -245,18 +235,18 @@ public class MenuEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); // ------------------------------------------------------------ if (!rootMenu) { ControlFactory.createTranslatedTextField(parent, Messages.MenuEditor_LabelLabel, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, - project); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, + project); } ControlFactory.createTextField(parent, Messages.MenuEditor_Mnemonics, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.MENU_ELEMENT__MNEMONICS)); + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.MENU_ELEMENT__MNEMONICS)); { @@ -269,23 +259,23 @@ public class MenuEditor extends AbstractComponentEditor { // new Label(parent, SWT.NONE); final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); pickList.setText(Messages.MenuEditor_Children); pickList.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true, 3, 1)); final Struct defaultStruct = new Struct(Messages.MenuEditor_HandledMenuItem, - MenuPackageImpl.Literals.HANDLED_MENU_ITEM, false); + MenuPackageImpl.Literals.HANDLED_MENU_ITEM, false); pickList.setInput(new Struct[] { - new Struct(Messages.MenuEditor_Separator, MenuPackageImpl.Literals.MENU_SEPARATOR, true), - new Struct(Messages.MenuEditor_Menu, MenuPackageImpl.Literals.MENU, false), - defaultStruct, - new Struct(Messages.MenuEditor_DirectMenuItem, MenuPackageImpl.Literals.DIRECT_MENU_ITEM, false), - new Struct(Messages.MenuEditor_DynamicMenuContribution, - MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION, false) }); + new Struct(Messages.MenuEditor_Separator, MenuPackageImpl.Literals.MENU_SEPARATOR, true), + new Struct(Messages.MenuEditor_Menu, MenuPackageImpl.Literals.MENU, false), + defaultStruct, + new Struct(Messages.MenuEditor_DirectMenuItem, MenuPackageImpl.Literals.DIRECT_MENU_ITEM, false), + new Struct(Messages.MenuEditor_DynamicMenuContribution, + MenuPackageImpl.Literals.DYNAMIC_MENU_CONTRIBUTION, false) }); pickList.setSelection(new StructuredSelection(defaultStruct)); final IEMFListProperty prop = EMFEditProperties.list(getEditingDomain(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); pickList.getList().setInput(prop.observeDetail(master)); } @@ -293,8 +283,8 @@ public class MenuEditor extends AbstractComponentEditor { // ------------------------------------------------------------ if (!rootMenu) { ControlFactory.createTranslatedTextField(parent, Messages.MenuEditor_Tooltip, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), resourcePool, - project); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), resourcePool, + project); } // ------------------------------------------------------------ @@ -307,9 +297,9 @@ public class MenuEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -332,7 +322,7 @@ public class MenuEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final MenuIconDialogEditor dialog = new MenuIconDialogEditor(b.getShell(), eclipseContext, project, - getEditingDomain(), (MMenu) getMaster().getValue(), Messages); + getEditingDomain(), (MMenu) getMaster().getValue(), Messages); dialog.open(); } }); @@ -361,20 +351,20 @@ public class MenuEditor extends AbstractComponentEditor { list.add(Messages.MenuItemEditor_NoExpression); list.add(UiPackageImpl.Literals.CORE_EXPRESSION); list.addAll(getEditor().getFeatureClasses(UiPackageImpl.Literals.EXPRESSION, - UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN)); + UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN)); combo.setInput(list); context.bindValue(ViewerProperties.singleSelection().observe(combo), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN) - .observeDetail(getMaster()), new UpdateValueStrategy().setConverter(new EClass2EObject(Messages)), - new UpdateValueStrategy().setConverter(new EObject2EClass(Messages))); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN) + .observeDetail(getMaster()), new UpdateValueStrategy().setConverter(new EClass2EObject(Messages)), + new UpdateValueStrategy().setConverter(new EObject2EClass(Messages))); } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -383,12 +373,12 @@ public class MenuEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -410,7 +400,7 @@ public class MenuEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -499,7 +489,7 @@ public class MenuEditor extends AbstractComponentEditor { final MMenuElement eObject = (MMenuElement) EcoreUtil.create(eClass); setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuItemEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuItemEditor.java index 3bdcd1b6..7db857de 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuItemEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuItemEditor.java @@ -71,7 +71,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -98,12 +97,12 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { @PostConstruct void init() { addExpression = new Action(Messages.MenuItemEditor_AddCoreExpression, - createImageDescriptor(ResourceProvider.IMG_CoreExpression)) { + createImageDescriptor(ResourceProvider.IMG_CoreExpression)) { @Override public void run() { final MUIElement e = (MUIElement) getMaster().getValue(); final Command cmd = SetCommand.create(getEditingDomain(), e, - UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN, MUiFactory.INSTANCE.createCoreExpression()); + UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN, MUiFactory.INSTANCE.createCoreExpression()); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -112,16 +111,8 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - if (((MUIElement) element).isToBeRendered()) { - final Image img = getImageFromIconURI(element); - return img != null ? img : createImage(ResourceProvider.IMG_MenuItem); - } - return createImage(ResourceProvider.IMG_Tbr_MenuItem); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_MenuItem); } @Override @@ -155,12 +146,12 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(UiPackageImpl.Literals.UI_LABEL__LABEL, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } protected CTabFolder createForm(Composite parent, EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -184,8 +175,8 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); if (this.getClass() != MenuItemEditor.class) { // ------------------------------------------------------------ @@ -201,18 +192,18 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { gd.horizontalSpan = 2; viewer.getControl().setLayoutData(gd); final IObservableValue itemTypeObs = EMFEditProperties.value(getEditingDomain(), - MenuPackageImpl.Literals.ITEM__TYPE).observeDetail(master); + MenuPackageImpl.Literals.ITEM__TYPE).observeDetail(master); context.bindValue(ViewerProperties.singleSelection().observe(viewer), itemTypeObs); } } ControlFactory.createTranslatedTextField(parent, Messages.MenuItemEditor_Label, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, project); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, project); ControlFactory.createTextField(parent, Messages.MenuItemEditor_Mnemonics, getMaster(), context, textProp, - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.MENU_ELEMENT__MNEMONICS)); + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.MENU_ELEMENT__MNEMONICS)); ControlFactory.createTranslatedTextField(parent, Messages.MenuItemEditor_Tooltip, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), resourcePool, - project); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), resourcePool, + project); // ------------------------------------------------------------ { @@ -224,9 +215,9 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -249,7 +240,7 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final MenuItemIconDialogEditor dialog = new MenuItemIconDialogEditor(b.getShell(), eclipseContext, - project, getEditingDomain(), (MMenuItem) getMaster().getValue(), Messages); + project, getEditingDomain(), (MMenuItem) getMaster().getValue(), Messages); dialog.open(); } }); @@ -263,9 +254,9 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { final Button b = new Button(parent, SWT.CHECK); b.setLayoutData(new GridData(GridData.BEGINNING, GridData.CENTER, false, false, 2, 1)); context.bindValue( - checkProp.observe(b), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.ITEM__ENABLED).observeDetail( - getMaster())); + checkProp.observe(b), + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.ITEM__ENABLED).observeDetail( + getMaster())); } { @@ -276,9 +267,9 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { final Button b = new Button(parent, SWT.CHECK); b.setLayoutData(new GridData(GridData.BEGINNING, GridData.CENTER, false, false, 2, 1)); context.bindValue( - checkProp.observe(b), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.ITEM__SELECTED).observeDetail( - getMaster())); + checkProp.observe(b), + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.ITEM__SELECTED).observeDetail( + getMaster())); final UpdateValueStrategy t2m = new UpdateValueStrategy(); t2m.setConverter(new Converter(boolean.class, ItemType.class) { @@ -298,9 +289,9 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { }); context.bindValue( - enabled.observe(b), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.ITEM__TYPE).observeDetail( - getMaster()), t2m, m2t); + enabled.observe(b), + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.ITEM__TYPE).observeDetail( + getMaster()), t2m, m2t); } @@ -327,22 +318,22 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { list.add(Messages.MenuItemEditor_NoExpression); list.add(UiPackageImpl.Literals.CORE_EXPRESSION); list.addAll(getEditor().getFeatureClasses(UiPackageImpl.Literals.EXPRESSION, - UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN)); + UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN)); combo.setInput(list); context.bindValue(ViewerProperties.singleSelection().observe(combo), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN) - .observeDetail(getMaster()), new UpdateValueStrategy().setConverter(new EClass2EObject(Messages)), - new UpdateValueStrategy().setConverter(new EObject2EClass(Messages))); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE_WHEN) + .observeDetail(getMaster()), new UpdateValueStrategy().setConverter(new EClass2EObject(Messages)), + new UpdateValueStrategy().setConverter(new EObject2EClass(Messages))); } createFormSubTypeForm(parent, context, master); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -351,13 +342,13 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -381,7 +372,7 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -398,7 +389,7 @@ public abstract class MenuItemEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.UI_LABEL__LABEL), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } @Override diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuSeparatorEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuSeparatorEditor.java index 8afaa3a7..351dbe6a 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuSeparatorEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/MenuSeparatorEditor.java @@ -12,6 +12,7 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.core.resources.IProject; @@ -38,7 +39,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; public class MenuSeparatorEditor extends AbstractComponentEditor { private Composite composite; @@ -55,8 +55,8 @@ public class MenuSeparatorEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_MenuSeparator); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_MenuSeparator); } @Override @@ -108,7 +108,7 @@ public class MenuSeparatorEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master, boolean isImport) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); @@ -120,7 +120,7 @@ public class MenuSeparatorEditor extends AbstractComponentEditor { ControlFactory.createXMIId(parent, this); } - IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); + final IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); if (isImport) { ControlFactory.createFindImport(parent, Messages, this, context); @@ -154,14 +154,14 @@ public class MenuSeparatorEditor extends AbstractComponentEditor { } private void createUITreeInspection(CTabFolder folder) { - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_RuntimeWidgetTree); - Composite container = new Composite(folder, SWT.NONE); + final Composite container = new Composite(folder, SWT.NONE); container.setLayout(new GridLayout()); item.setControl(container); - UIViewer objectViewer = new UIViewer(); - TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, getMaster(), resourcePool, Messages); + final UIViewer objectViewer = new UIViewer(); + final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ModelFragmentsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ModelFragmentsEditor.java index 413f698a..d0c764e2 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ModelFragmentsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ModelFragmentsEditor.java @@ -56,14 +56,13 @@ import org.eclipse.swt.custom.CTabItem; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class ModelFragmentsEditor extends AbstractComponentEditor { private final IListProperty MODEL_FRAGMENTS__FRAGMENTS = EMFProperties - .list(FragmentPackageImpl.Literals.MODEL_FRAGMENTS__FRAGMENTS); + .list(FragmentPackageImpl.Literals.MODEL_FRAGMENTS__FRAGMENTS); private final IListProperty MODEL_FRAGMENTS__IMPORTS = EMFProperties - .list(FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS); + .list(FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS); private Composite composite; @@ -76,8 +75,8 @@ public class ModelFragmentsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_ModelFragments); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_ModelFragments); } @Override @@ -118,14 +117,14 @@ public class ModelFragmentsEditor extends AbstractComponentEditor { { final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, - Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, - FragmentPackageImpl.Literals.MODEL_FRAGMENTS__FRAGMENTS) { + Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, + FragmentPackageImpl.Literals.MODEL_FRAGMENTS__FRAGMENTS) { @Override protected void addPressed() { final MModelFragment component = MFragmentFactory.INSTANCE.createStringModelFragment(); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - FragmentPackageImpl.Literals.MODEL_FRAGMENTS__FRAGMENTS, component); + FragmentPackageImpl.Literals.MODEL_FRAGMENTS__FRAGMENTS, component); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -163,14 +162,14 @@ public class ModelFragmentsEditor extends AbstractComponentEditor { } final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS) { + FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS) { @Override protected void addPressed() { final EClass eClass = ((FeatureClass) ((IStructuredSelection) getSelection()).getFirstElement()).eClass; final EObject eObject = EcoreUtil.create(eClass); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS, eObject); + FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -210,7 +209,7 @@ public class ModelFragmentsEditor extends AbstractComponentEditor { final List<FeatureClass> list = new ArrayList<FeatureClass>(); Util.addClasses(ApplicationPackageImpl.eINSTANCE, list); list.addAll(getEditor().getFeatureClasses(FragmentPackageImpl.Literals.MODEL_FRAGMENT, - FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS)); + FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS)); pickList.setInput(list); if (list.size() > 0) { @@ -226,8 +225,8 @@ public class ModelFragmentsEditor extends AbstractComponentEditor { if (c instanceof EClass) { final EClass eclass = (EClass) c; if (eclass != ApplicationPackageImpl.Literals.APPLICATION && !eclass.isAbstract() - && !eclass.isInterface() - && eclass.getEAllSuperTypes().contains(ApplicationPackageImpl.Literals.APPLICATION_ELEMENT)) { + && !eclass.isInterface() + && eclass.getEAllSuperTypes().contains(ApplicationPackageImpl.Literals.APPLICATION_ELEMENT)) { list.add(new FeatureClass(eclass.getName(), eclass)); } } @@ -242,14 +241,14 @@ public class ModelFragmentsEditor extends AbstractComponentEditor { public IObservableList getChildList(Object element) { final WritableList list = new WritableList(); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_MODEL_IMPORTS, MODEL_FRAGMENTS__IMPORTS, element, - Messages.ModelFragmentsEditor_Imports) { + Messages.ModelFragmentsEditor_Imports) { @Override protected boolean accepted(Object o) { return true; } }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_MODEL_FRAGEMENTS, MODEL_FRAGMENTS__FRAGMENTS, element, - Messages.ModelFragmentsEditor_ModelFragments) { + Messages.ModelFragmentsEditor_ModelFragments) { @Override protected boolean accepted(Object o) { return true; diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ParameterEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ParameterEditor.java index d198fe1c..7b5b9166 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ParameterEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ParameterEditor.java @@ -43,7 +43,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -62,8 +61,8 @@ public class ParameterEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_Parameter); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Parameter); } @Override @@ -73,7 +72,7 @@ public class ParameterEditor extends AbstractComponentEditor { @Override public String getDetailLabel(Object element) { - MParameter param = (MParameter) element; + final MParameter param = (MParameter) element; if (param.getName() != null && param.getName().trim().length() > 0) { return param.getName().trim(); } else if (param.getElementId() != null && param.getElementId().trim().length() > 0) { @@ -121,7 +120,7 @@ public class ParameterEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master, boolean isImport) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); @@ -133,7 +132,7 @@ public class ParameterEditor extends AbstractComponentEditor { ControlFactory.createXMIId(parent, this); } - IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); + final IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); if (isImport) { ControlFactory.createFindImport(parent, Messages, this, context); @@ -168,19 +167,19 @@ public class ParameterEditor extends AbstractComponentEditor { private void createParameterNameRow(Composite parent, IWidgetValueProperty textProp) { { - Label commandParameterIdLabel = new Label(parent, SWT.NONE); + final Label commandParameterIdLabel = new Label(parent, SWT.NONE); commandParameterIdLabel.setText(Messages.ParameterEditor_Command_Parameter_ID); commandParameterIdLabel.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_END)); - Text commandParameterIdValue = new Text(parent, SWT.BORDER); - GridData gd = new GridData(GridData.FILL_HORIZONTAL); + final Text commandParameterIdValue = new Text(parent, SWT.BORDER); + final GridData gd = new GridData(GridData.FILL_HORIZONTAL); commandParameterIdValue.setLayoutData(gd); TextPasteHandler.createFor(commandParameterIdValue); - IEMFEditValueProperty modelProp = EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.PARAMETER__NAME); + final IEMFEditValueProperty modelProp = EMFEditProperties.value(getEditingDomain(), CommandsPackageImpl.Literals.PARAMETER__NAME); context.bindValue(textProp.observeDelayed(200, commandParameterIdValue), modelProp.observeDetail(getMaster())); } - Button chooseParameterButton = new Button(parent, SWT.PUSH | SWT.FLAT); + final Button chooseParameterButton = new Button(parent, SWT.PUSH | SWT.FLAT); chooseParameterButton.setText(Messages.ModelTooling_Common_FindEllipsis); chooseParameterButton.setImage(createImage(ResourceProvider.IMG_Obj16_zoom)); chooseParameterButton.addSelectionListener(new ChooseParameterButtonSelectionListener()); @@ -190,14 +189,14 @@ public class ParameterEditor extends AbstractComponentEditor { private final class ChooseParameterButtonSelectionListener extends SelectionAdapter { @Override public void widgetSelected(SelectionEvent e) { - WritableValue master = getMaster(); + final WritableValue master = getMaster(); if (master == null || !(master.getValue() instanceof MParameter)) { return; } - IEclipseContext staticContext = EclipseContextFactory.create("ParameterIdSelectionDialog static context"); //$NON-NLS-1$ + final IEclipseContext staticContext = EclipseContextFactory.create("ParameterIdSelectionDialog static context"); //$NON-NLS-1$ staticContext.set(MParameter.class, (MParameter) master.getValue()); - ParameterIdSelectionDialog dialog = ContextInjectionFactory.make(ParameterIdSelectionDialog.class, eclipseContext, staticContext); + final ParameterIdSelectionDialog dialog = ContextInjectionFactory.make(ParameterIdSelectionDialog.class, eclipseContext, staticContext); dialog.open(); } } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartDescriptorEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartDescriptorEditor.java index f46d7c6f..dac4001c 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartDescriptorEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartDescriptorEditor.java @@ -65,7 +65,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; @@ -84,9 +83,9 @@ public class PartDescriptorEditor extends AbstractComponentEditor { private final IListProperty PART__MENUS = EMFProperties.list(BasicPackageImpl.Literals.PART_DESCRIPTOR__MENUS); private final IListProperty HANDLER_CONTAINER__HANDLERS = EMFProperties - .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); + .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); private final IValueProperty PART__TOOLBAR = EMFProperties - .value(BasicPackageImpl.Literals.PART_DESCRIPTOR__TOOLBAR); + .value(BasicPackageImpl.Literals.PART_DESCRIPTOR__TOOLBAR); private Button createRemoveToolBar; private StackLayout stackLayout; @@ -96,9 +95,8 @@ public class PartDescriptorEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - final Image img = getImageFromIconURI(element); - return img != null ? img : createImage(ResourceProvider.IMG_PartDescriptor); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_PartDescriptor); } @Override @@ -146,12 +144,12 @@ public class PartDescriptorEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(UiPackageImpl.Literals.UI_LABEL__LABEL, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } protected Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -173,14 +171,14 @@ public class PartDescriptorEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTranslatedTextField(parent, Messages.PartDescriptorEditor_LabelLabel, master, context, - textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), - resourcePool, project); + textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), + resourcePool, project); ControlFactory.createTranslatedTextField(parent, Messages.PartDescriptorEditor_Tooltip, master, context, - textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), - resourcePool, project); + textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), + resourcePool, project); // ------------------------------------------------------------ { @@ -192,9 +190,9 @@ public class PartDescriptorEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -217,7 +215,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final PartDescriptorIconDialogEditor dialog = new PartDescriptorIconDialogEditor(b.getShell(), - eclipseContext, project, getEditingDomain(), (MPartDescriptor) getMaster().getValue(), Messages); + eclipseContext, project, getEditingDomain(), (MPartDescriptor) getMaster().getValue(), Messages); dialog.open(); } }); @@ -233,7 +231,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { */ // final IContributionClassCreator c = getEditor().getContributionCreator( - org.eclipse.e4.ui.model.application.ui.basic.impl.BasicPackageImpl.Literals.PART); + org.eclipse.e4.ui.model.application.ui.basic.impl.BasicPackageImpl.Literals.PART); if (project != null && c != null) { lnk = new Link(parent, SWT.NONE); lnk.setText("<A>" + Messages.PartEditor_ClassURI + "</A>"); //$NON-NLS-1$//$NON-NLS-2$ @@ -261,9 +259,9 @@ public class PartDescriptorEditor extends AbstractComponentEditor { final Text t = new Text(parent, SWT.BORDER); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties - .value(getEditingDomain(), BasicPackageImpl.Literals.PART_DESCRIPTOR__CONTRIBUTION_URI) - .observeDetail(master)); + EMFEditProperties + .value(getEditingDomain(), BasicPackageImpl.Literals.PART_DESCRIPTOR__CONTRIBUTION_URI) + .observeDetail(master)); TextPasteHandler.createFor(t); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -274,8 +272,8 @@ public class PartDescriptorEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, - getEditingDomain(), (MPartDescriptor) getMaster().getValue(), - BasicPackageImpl.Literals.PART_DESCRIPTOR__CONTRIBUTION_URI, Messages); + getEditingDomain(), (MPartDescriptor) getMaster().getValue(), + BasicPackageImpl.Literals.PART_DESCRIPTOR__CONTRIBUTION_URI, Messages); dialog.open(); } }); @@ -313,8 +311,8 @@ public class PartDescriptorEditor extends AbstractComponentEditor { gd.horizontalSpan = 2; t.setLayoutData(gd); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA) - .observeDetail(master)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA) + .observeDetail(master)); } // ------------------------------------------------------------ @@ -327,7 +325,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { checkbox.setLayoutData(new GridData(GridData.BEGINNING, GridData.BEGINNING, false, false, 2, 1)); final IEMFEditValueProperty mprop = EMFEditProperties.value(getEditingDomain(), - BasicPackageImpl.Literals.PART_DESCRIPTOR__DIRTYABLE); + BasicPackageImpl.Literals.PART_DESCRIPTOR__DIRTYABLE); final IWidgetValueProperty uiProp = WidgetProperties.selection(); context.bindValue(uiProp.observe(checkbox), mprop.observeDetail(master)); @@ -343,7 +341,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { checkbox.setLayoutData(new GridData(GridData.BEGINNING, GridData.BEGINNING, false, false, 2, 1)); final IEMFEditValueProperty mprop = EMFEditProperties.value(getEditingDomain(), - BasicPackageImpl.Literals.PART_DESCRIPTOR__CLOSEABLE); + BasicPackageImpl.Literals.PART_DESCRIPTOR__CLOSEABLE); final IWidgetValueProperty uiProp = WidgetProperties.selection(); context.bindValue(uiProp.observe(checkbox), mprop.observeDetail(master)); @@ -359,7 +357,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { checkbox.setLayoutData(new GridData(GridData.BEGINNING, GridData.BEGINNING, false, false, 2, 1)); final IEMFEditValueProperty mprop = EMFEditProperties.value(getEditingDomain(), - BasicPackageImpl.Literals.PART_DESCRIPTOR__ALLOW_MULTIPLE); + BasicPackageImpl.Literals.PART_DESCRIPTOR__ALLOW_MULTIPLE); final IWidgetValueProperty uiProp = WidgetProperties.selection(); context.bindValue(uiProp.observe(checkbox), mprop.observeDetail(master)); @@ -374,8 +372,8 @@ public class PartDescriptorEditor extends AbstractComponentEditor { final Text t = new Text(parent, SWT.BORDER); t.setLayoutData(new GridData(GridData.FILL, GridData.BEGINNING, true, false, 2, 1)); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.PART_DESCRIPTOR__CATEGORY) - .observeDetail(master)); + EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.PART_DESCRIPTOR__CATEGORY) + .observeDetail(master)); } ControlFactory.createBindingContextWiget(parent, Messages, this, Messages.PartEditor_BindingContexts); @@ -387,9 +385,9 @@ public class PartDescriptorEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MPartDescriptor.class); @@ -403,7 +401,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { setElementId(menu); final Command cmd = SetCommand.create(getEditingDomain(), getMaster().getValue(), - BasicPackageImpl.Literals.PART_DESCRIPTOR__TOOLBAR, menu); + BasicPackageImpl.Literals.PART_DESCRIPTOR__TOOLBAR, menu); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -411,7 +409,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { private void removeToolBar() { final Command cmd = SetCommand.create(getEditingDomain(), getMaster().getValue(), - BasicPackageImpl.Literals.PART_DESCRIPTOR__TOOLBAR, null); + BasicPackageImpl.Literals.PART_DESCRIPTOR__TOOLBAR, null); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -426,7 +424,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { } list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_PARTDESCRIPTOR_MENU, PART__MENUS, element, - Messages.PartDescriptorEditor_Menus) { + Messages.PartDescriptorEditor_Menus) { @Override protected boolean accepted(Object o) { @@ -436,7 +434,7 @@ public class PartDescriptorEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_HANDLER, HANDLER_CONTAINER__HANDLERS, element, - Messages.PartDescriptorEditor_Handlers) { + Messages.PartDescriptorEditor_Handlers) { @Override protected boolean accepted(Object o) { diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartEditor.java index fcdb972c..d6f84108 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartEditor.java @@ -41,7 +41,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.MContribution; import org.eclipse.e4.ui.model.application.commands.impl.CommandsPackageImpl; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.MUILabel; import org.eclipse.e4.ui.model.application.ui.basic.MPart; import org.eclipse.e4.ui.model.application.ui.basic.impl.BasicPackageImpl; @@ -73,7 +72,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; @@ -85,7 +83,7 @@ public class PartEditor extends AbstractComponentEditor { private final IListProperty PART__MENUS = EMFProperties.list(BasicPackageImpl.Literals.PART__MENUS); private final IListProperty HANDLER_CONTAINER__HANDLERS = EMFProperties - .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); + .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); private final IValueProperty PART__TOOLBAR = EMFProperties.value(BasicPackageImpl.Literals.PART__TOOLBAR); private Button createRemoveToolBar; private StackLayout stackLayout; @@ -103,16 +101,8 @@ public class PartEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - if (((MUIElement) element).isToBeRendered()) { - final Image img = getImageFromIconURI(element); - return img != null ? img : createImage(ResourceProvider.IMG_Part); - } - return createImage(ResourceProvider.IMG_Tbr_Part); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Part); } @Override @@ -163,13 +153,13 @@ public class PartEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(UiPackageImpl.Literals.UI_LABEL__LABEL, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } protected Composite createForm(Composite parent, EMFDataBindingContext context, IObservableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.BORDER); @@ -191,15 +181,15 @@ public class PartEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.PartEditor_LabelLabel, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, master, context, - textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createTextField(parent, Messages.PartEditor_Tooltip, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP)); // ------------------------------------------------------------ { @@ -212,9 +202,9 @@ public class PartEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -237,7 +227,7 @@ public class PartEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final PartIconDialogEditor dialog = new PartIconDialogEditor(b.getShell(), eclipseContext, project, - getEditingDomain(), (MPart) getMaster().getValue(), Messages); + getEditingDomain(), (MPart) getMaster().getValue(), Messages); dialog.open(); } }); @@ -255,7 +245,7 @@ public class PartEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { c.createOpen((MContribution) getMaster().getValue(), getEditingDomain(), project, - lnk.getShell()); + lnk.getShell()); } }); } else { @@ -282,11 +272,11 @@ public class PartEditor extends AbstractComponentEditor { } }); final Binding binding = context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(master), - new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), - new UpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(master), + new UpdateValueStrategy().setAfterConvertValidator(new ContributionURIValidator()), + new UpdateValueStrategy()); Util.addDecoration(t, binding); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -297,8 +287,8 @@ public class PartEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, - getEditingDomain(), (MContribution) getMaster().getValue(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); + getEditingDomain(), (MContribution) getMaster().getValue(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); dialog.open(); } }); @@ -306,7 +296,7 @@ public class PartEditor extends AbstractComponentEditor { // ------------------------------------------------------------ ControlFactory.createTextField(parent, Messages.PartEditor_ContainerData, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); createSubformElements(parent, context, master); @@ -331,22 +321,22 @@ public class PartEditor extends AbstractComponentEditor { } ControlFactory.createCheckBox(parent, Messages.PartEditor_Closeable, Messages.PartEditor_Closeable_Tooltip, - getMaster(), context, WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.PART__CLOSEABLE)); + getMaster(), context, WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.PART__CLOSEABLE)); // ------------------------------------------------------------ ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); ControlFactory.createBindingContextWiget(parent, Messages, this, Messages.PartEditor_BindingContexts); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Context_Properties, - UiPackageImpl.Literals.CONTEXT__PROPERTIES, VERTICAL_LIST_WIDGET_INDENT); + UiPackageImpl.Literals.CONTEXT__PROPERTIES, VERTICAL_LIST_WIDGET_INDENT); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -355,10 +345,10 @@ public class PartEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.ModelTooling_Context_Variables, - Messages.ModelTooling_Context_Variables_Tooltip, UiPackageImpl.Literals.CONTEXT__VARIABLES, - VERTICAL_LIST_WIDGET_INDENT); + Messages.ModelTooling_Context_Variables_Tooltip, UiPackageImpl.Literals.CONTEXT__VARIABLES, + VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createInstanceInspection(folder); @@ -381,7 +371,7 @@ public class PartEditor extends AbstractComponentEditor { final ObjectViewer objectViewer = new ObjectViewer(); final TreeViewer viewer = objectViewer.createViewer(container, - ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); + ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -394,7 +384,7 @@ public class PartEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -403,7 +393,7 @@ public class PartEditor extends AbstractComponentEditor { setElementId(menu); final Command cmd = SetCommand.create(getEditingDomain(), getMaster().getValue(), - BasicPackageImpl.Literals.PART__TOOLBAR, menu); + BasicPackageImpl.Literals.PART__TOOLBAR, menu); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -411,7 +401,7 @@ public class PartEditor extends AbstractComponentEditor { private void removeToolBar() { final Command cmd = SetCommand.create(getEditingDomain(), getMaster().getValue(), - BasicPackageImpl.Literals.PART__TOOLBAR, null); + BasicPackageImpl.Literals.PART__TOOLBAR, null); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -430,7 +420,7 @@ public class PartEditor extends AbstractComponentEditor { } list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_PART_MENU, PART__MENUS, element, - Messages.PartEditor_Menus) { + Messages.PartEditor_Menus) { @Override protected boolean accepted(Object o) { @@ -440,7 +430,7 @@ public class PartEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_HANDLER, HANDLER_CONTAINER__HANDLERS, element, - Messages.PartEditor_Handlers) { + Messages.PartEditor_Handlers) { @Override protected boolean accepted(Object o) { @@ -486,6 +476,6 @@ public class PartEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.UI_LABEL__LABEL), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } }
\ No newline at end of file diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartSashContainerEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartSashContainerEditor.java index 275dc823..ad440d85 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartSashContainerEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartSashContainerEditor.java @@ -32,7 +32,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.tools.emf.ui.internal.imp.ModelImportWizard; import org.eclipse.e4.tools.emf.ui.internal.imp.RegistryUtil; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.advanced.impl.AdvancedPackageImpl; import org.eclipse.e4.ui.model.application.ui.basic.MPart; import org.eclipse.e4.ui.model.application.ui.basic.MPartSashContainer; @@ -71,7 +70,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; @@ -81,7 +79,7 @@ public class PartSashContainerEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); private final List<Action> actionsImport = new ArrayList<Action>(); @@ -101,21 +99,21 @@ public class PartSashContainerEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.PartSashContainerEditor_AddPartSashContainer, - createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { + createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART_SASH_CONTAINER); } }); actions.add(new Action(Messages.PartSashContainerEditor_AddPartStack, - createImageDescriptor(ResourceProvider.IMG_PartStack)) { + createImageDescriptor(ResourceProvider.IMG_PartStack)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART_STACK); } }); actions.add(new Action(Messages.PartSashContainerEditor_AddPart, - createImageDescriptor(ResourceProvider.IMG_Part)) { + createImageDescriptor(ResourceProvider.IMG_Part)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART); @@ -123,21 +121,21 @@ public class PartSashContainerEditor extends AbstractComponentEditor { }); actions.add(new Action(Messages.PartSashContainerEditor_AddArea, - createImageDescriptor(ResourceProvider.IMG_Area)) { + createImageDescriptor(ResourceProvider.IMG_Area)) { @Override public void run() { handleAddChild(AdvancedPackageImpl.Literals.AREA); } }); actions.add(new Action(Messages.PartSashContainerEditor_AddPlaceholder, - createImageDescriptor(ResourceProvider.IMG_Placeholder)) { + createImageDescriptor(ResourceProvider.IMG_Placeholder)) { @Override public void run() { handleAddChild(AdvancedPackageImpl.Literals.PLACEHOLDER); } }); for (final FeatureClass c : getEditor().getFeatureClasses(BasicPackageImpl.Literals.PART_STACK, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)) { final EClass ec = c.eClass; actions.add(new Action(c.label, createImageDescriptor(c.iconId)) { @Override @@ -164,25 +162,11 @@ public class PartSashContainerEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { + public Image getImage(Object element) { final boolean horizontal = ((MPartSashContainer) element).isHorizontal(); - if (!horizontal) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_PartSashContainer_vertical); - } - return createImage(ResourceProvider.IMG_Tbr_PartSashContainer_vertical); - } - - if (horizontal) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_PartSashContainer); - } - return createImage(ResourceProvider.IMG_Tbr_PartSashContainer); - } - return null; + return horizontal ? getImage(element, ResourceProvider.IMG_PartSashContainer) + : getImage(element, ResourceProvider.IMG_PartSashContainer_vertical); } @Override @@ -229,7 +213,7 @@ public class PartSashContainerEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -251,11 +235,11 @@ public class PartSashContainerEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); // ------------------------------------------------------------ { @@ -272,23 +256,23 @@ public class PartSashContainerEditor extends AbstractComponentEditor { @Override public String getText(Object element) { return ((Boolean) element).booleanValue() ? Messages.PartSashContainerEditor_Horizontal - : Messages.PartSashContainerEditor_Vertical; + : Messages.PartSashContainerEditor_Vertical; } }); viewer.setInput(new Boolean[] { Boolean.TRUE, Boolean.FALSE }); final IViewerValueProperty vProp = ViewerProperties.singleSelection(); context.bindValue(vProp.observe(viewer), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL) - .observeDetail(getMaster())); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL) + .observeDetail(getMaster())); } ControlFactory.createSelectedElement(parent, this, context, Messages.PartSashContainerEditor_SelectedElement); ControlFactory.createTextField(parent, Messages.PartSashContainerEditor_ContainerData, master, context, - textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); + textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final EClass eClass = ((FeatureClass) ((IStructuredSelection) getSelection()).getFirstElement()).eClass; @@ -308,7 +292,7 @@ public class PartSashContainerEditor extends AbstractComponentEditor { eClassList.add(new FeatureClass("Area", AdvancedPackageImpl.Literals.AREA)); //$NON-NLS-1$ eClassList.add(new FeatureClass("Placeholder", AdvancedPackageImpl.Literals.PLACEHOLDER)); //$NON-NLS-1$ eClassList.addAll(getEditor().getFeatureClasses(BasicPackageImpl.Literals.PART_SASH_CONTAINER, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)); pickList.setInput(eClassList); pickList.setSelection(new StructuredSelection(eClassList.get(0))); @@ -318,11 +302,11 @@ public class PartSashContainerEditor extends AbstractComponentEditor { } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -331,9 +315,9 @@ public class PartSashContainerEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -355,7 +339,7 @@ public class PartSashContainerEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -372,7 +356,7 @@ public class PartSashContainerEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.GENERIC_TILE__HORIZONTAL), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } protected void handleAddChild(EClass eClass) { @@ -384,7 +368,7 @@ public class PartSashContainerEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartStackEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartStackEditor.java index aa35b8d0..0b79c1d4 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartStackEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PartStackEditor.java @@ -31,7 +31,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.FeatureClassLabelProvider; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.tools.emf.ui.internal.imp.ModelImportWizard; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.advanced.impl.AdvancedPackageImpl; import org.eclipse.e4.ui.model.application.ui.basic.MInputPart; import org.eclipse.e4.ui.model.application.ui.basic.MPart; @@ -66,7 +65,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; @SuppressWarnings("deprecation") public class PartStackEditor extends AbstractComponentEditor { @@ -75,7 +73,7 @@ public class PartStackEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); private final List<Action> actionsImport = new ArrayList<Action>(); @@ -99,14 +97,14 @@ public class PartStackEditor extends AbstractComponentEditor { } }); actions.add(new Action(Messages.PartStackEditor_AddCompositePart, - createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { + createImageDescriptor(ResourceProvider.IMG_PartSashContainer)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.COMPOSITE_PART); } }); actions.add(new Action(Messages.PartStackEditor_AddPlaceholder, - createImageDescriptor(ResourceProvider.IMG_Placeholder)) { + createImageDescriptor(ResourceProvider.IMG_Placeholder)) { @Override public void run() { handleAddChild(AdvancedPackageImpl.Literals.PLACEHOLDER); @@ -114,7 +112,7 @@ public class PartStackEditor extends AbstractComponentEditor { }); final List<FeatureClass> list = getEditor().getFeatureClasses(BasicPackageImpl.Literals.PART_STACK, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); if (!list.isEmpty()) { for (final FeatureClass c : list) { @@ -136,25 +134,19 @@ public class PartStackEditor extends AbstractComponentEditor { } }); actionsImport - .add(new Action(Messages.PartStackEditor_Editors, createImageDescriptor(ResourceProvider.IMG_Part)) { - @Override - public void run() { - handleImportChild(BasicPackageImpl.Literals.INPUT_PART); - } - }); + .add(new Action(Messages.PartStackEditor_Editors, createImageDescriptor(ResourceProvider.IMG_Part)) { + @Override + public void run() { + handleImportChild(BasicPackageImpl.Literals.INPUT_PART); + } + }); } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - if (((MUIElement) element).isToBeRendered()) { - return createImage(ResourceProvider.IMG_Part); - } - return createImage(ResourceProvider.IMG_Tbr_Part); - } + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Part); - return null; } @Override @@ -202,7 +194,7 @@ public class PartStackEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -224,20 +216,20 @@ public class PartStackEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createSelectedElement(parent, this, context, Messages.PartStackEditor_SelectedElement); ControlFactory.createTextField(parent, Messages.PartStackEditor_ContainerData, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final EClass eClass = ((FeatureClass) ((IStructuredSelection) getSelection()).getFirstElement()).eClass; @@ -256,22 +248,22 @@ public class PartStackEditor extends AbstractComponentEditor { final List<FeatureClass> eClassList = new ArrayList<FeatureClass>(); eClassList.add(new FeatureClass(Messages.PartStackEditor_Part, BasicPackageImpl.Literals.PART)); eClassList.add(new FeatureClass(Messages.PartStackEditor_CompositePart, - BasicPackageImpl.Literals.COMPOSITE_PART)); + BasicPackageImpl.Literals.COMPOSITE_PART)); eClassList.add(new FeatureClass(Messages.PartStackEditor_Placeholder, - AdvancedPackageImpl.Literals.PLACEHOLDER)); + AdvancedPackageImpl.Literals.PLACEHOLDER)); eClassList.addAll(getEditor().getFeatureClasses(BasicPackageImpl.Literals.PART_STACK, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN)); pickList.setInput(eClassList); pickList.setSelection(new StructuredSelection(eClassList.get(0))); } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -280,9 +272,9 @@ public class PartStackEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -304,7 +296,7 @@ public class PartStackEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -332,7 +324,7 @@ public class PartStackEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveEditor.java index 6a769476..b48420d0 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveEditor.java @@ -34,7 +34,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.ControlFactory.Text import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.PerspectiveIconDialogEditor; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.MUILabel; import org.eclipse.e4.ui.model.application.ui.advanced.MPerspective; import org.eclipse.e4.ui.model.application.ui.advanced.impl.AdvancedPackageImpl; @@ -66,7 +65,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -75,9 +73,9 @@ public class PerspectiveEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private final IListProperty PERSPECTIVE__WINDOWS = EMFProperties - .list(AdvancedPackageImpl.Literals.PERSPECTIVE__WINDOWS); + .list(AdvancedPackageImpl.Literals.PERSPECTIVE__WINDOWS); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -96,14 +94,14 @@ public class PerspectiveEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.PerspectiveEditor_AddPartSashContainer, - createImageDescriptor(ResourceProvider.IMG_Perspective)) { + createImageDescriptor(ResourceProvider.IMG_Perspective)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART_SASH_CONTAINER); } }); actions.add(new Action(Messages.PerspectiveEditor_AddPartStack, - createImageDescriptor(ResourceProvider.IMG_PartStack)) { + createImageDescriptor(ResourceProvider.IMG_PartStack)) { @Override public void run() { handleAddChild(BasicPackageImpl.Literals.PART_STACK); @@ -122,7 +120,7 @@ public class PerspectiveEditor extends AbstractComponentEditor { } }); actions.add(new Action(Messages.PerspectiveEditor_AddPlaceholder, - createImageDescriptor(ResourceProvider.IMG_Placeholder)) { + createImageDescriptor(ResourceProvider.IMG_Placeholder)) { @Override public void run() { handleAddChild(AdvancedPackageImpl.Literals.PLACEHOLDER); @@ -131,17 +129,8 @@ public class PerspectiveEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - final Image img = getImageFromIconURI(uiElement); - return img != null ? img : createImage(ResourceProvider.IMG_Perspective); - } - return createImage(ResourceProvider.IMG_Tbr_Perspective); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Perspective); } @Override @@ -157,7 +146,7 @@ public class PerspectiveEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.UI_LABEL__LABEL), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } @Override @@ -196,12 +185,12 @@ public class PerspectiveEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(UiPackageImpl.Literals.UI_LABEL__LABEL, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -223,18 +212,18 @@ public class PerspectiveEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createSelectedElement(parent, this, context, Messages.PerspectiveEditor_SelectedElement); ControlFactory.createTranslatedTextField(parent, Messages.PerspectiveEditor_LabelLabel, getMaster(), context, - textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), - resourcePool, project); + textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), + resourcePool, project); ControlFactory.createTranslatedTextField(parent, Messages.PerspectiveEditor_Tooltip, getMaster(), context, - textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), - resourcePool, project); + textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), + resourcePool, project); // ------------------------------------------------------------ { @@ -246,9 +235,9 @@ public class PerspectiveEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -270,27 +259,27 @@ public class PerspectiveEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final PerspectiveIconDialogEditor dialog = new PerspectiveIconDialogEditor(b.getShell(), - eclipseContext, project, getEditingDomain(), (MPerspective) getMaster().getValue(), Messages); + eclipseContext, project, getEditingDomain(), (MPerspective) getMaster().getValue(), Messages); dialog.open(); } }); } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); final Composite comp0 = ControlFactory.createMapProperties(parent, Messages, this, - Messages.ModelTooling_Context_Properties, UiPackageImpl.Literals.CONTEXT__PROPERTIES, - VERTICAL_LIST_WIDGET_INDENT); + Messages.ModelTooling_Context_Properties, UiPackageImpl.Literals.CONTEXT__PROPERTIES, + VERTICAL_LIST_WIDGET_INDENT); comp0.setLayoutData(new GridData(SWT.FILL, SWT.TOP, true, false, 3, 1)); final Composite comp = ControlFactory.createStringListWidget(parent, Messages, this, - Messages.ModelTooling_Context_Variables, UiPackageImpl.Literals.CONTEXT__VARIABLES, - VERTICAL_LIST_WIDGET_INDENT); + Messages.ModelTooling_Context_Variables, UiPackageImpl.Literals.CONTEXT__VARIABLES, + VERTICAL_LIST_WIDGET_INDENT); comp.setLayoutData(new GridData(SWT.FILL, SWT.TOP, true, false, 3, 1)); item = new CTabItem(folder, SWT.NONE); @@ -300,9 +289,9 @@ public class PerspectiveEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -324,7 +313,7 @@ public class PerspectiveEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -332,7 +321,7 @@ public class PerspectiveEditor extends AbstractComponentEditor { public IObservableList getChildList(Object element) { final WritableList list = new WritableList(); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_PERSPECTIVE_WINDOWS, PERSPECTIVE__WINDOWS, element, - Messages.WindowEditor_Windows) { + Messages.WindowEditor_Windows) { @Override protected boolean accepted(Object o) { @@ -341,7 +330,7 @@ public class PerspectiveEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_PERSPECTIVE_CONTROLS, ELEMENT_CONTAINER__CHILDREN, - element, Messages.PerspectiveEditor_Controls) { + element, Messages.PerspectiveEditor_Controls) { @Override protected boolean accepted(Object o) { @@ -357,7 +346,7 @@ public class PerspectiveEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveStackEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveStackEditor.java index 5c316be2..ae851ab2 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveStackEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PerspectiveStackEditor.java @@ -32,7 +32,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.E4PickList; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.tools.emf.ui.internal.imp.ModelImportWizard; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.advanced.MAdvancedFactory; import org.eclipse.e4.ui.model.application.ui.advanced.MPerspective; import org.eclipse.e4.ui.model.application.ui.advanced.MPerspectiveStack; @@ -62,7 +61,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; public class PerspectiveStackEditor extends AbstractComponentEditor { @@ -70,7 +68,7 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); private final List<Action> actionsImport = new ArrayList<Action>(); @@ -90,7 +88,7 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.PerspectiveStackEditor_AddPerspective, - createImageDescriptor(ResourceProvider.IMG_Perspective)) { + createImageDescriptor(ResourceProvider.IMG_Perspective)) { @Override public void run() { handleAddPerspective(); @@ -99,7 +97,7 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { // --- import --- actionsImport.add(new Action(Messages.PerspectiveStackEditor_AddPerspective, - createImageDescriptor(ResourceProvider.IMG_Perspective)) { + createImageDescriptor(ResourceProvider.IMG_Perspective)) { @Override public void run() { handleImportPerspective(); @@ -108,16 +106,8 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_PerspectiveStack); - } - return createImage(ResourceProvider.IMG_Tbr_PerspectiveStack); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_PerspectiveStack); } @Override @@ -169,7 +159,7 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, - boolean isImport) { + boolean isImport) { final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); @@ -191,18 +181,18 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createSelectedElement(parent, this, context, Messages.PerspectiveStackEditor_SelectedElement); // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), - Messages, this, UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + Messages, this, UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { handleAddPerspective(); @@ -219,11 +209,11 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -232,9 +222,9 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -256,7 +246,7 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -289,7 +279,7 @@ public class PerspectiveStackEditor extends AbstractComponentEditor { private void addToModel(MPerspective perspective) { setElementId(perspective); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, perspective); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, perspective); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); getEditor().setSelection(perspective); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PlaceholderEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PlaceholderEditor.java index e76ee33f..ebc250f2 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PlaceholderEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/PlaceholderEditor.java @@ -11,6 +11,7 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component; import javax.inject.Inject; + import org.eclipse.core.databinding.UpdateValueStrategy; import org.eclipse.core.databinding.conversion.Converter; import org.eclipse.core.databinding.observable.list.IObservableList; @@ -48,7 +49,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -70,8 +70,8 @@ public class PlaceholderEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_Placeholder); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Placeholder); } @Override @@ -81,14 +81,14 @@ public class PlaceholderEditor extends AbstractComponentEditor { @Override public String getDetailLabel(Object element) { - MPlaceholder pl = (MPlaceholder) element; + final MPlaceholder pl = (MPlaceholder) element; if (pl.getRef() != null) { - StringBuilder b = new StringBuilder(); + final StringBuilder b = new StringBuilder(); b.append(((EObject) pl.getRef()).eClass().getName()); if (pl.getRef() instanceof MUILabel) { - MUILabel label = (MUILabel) pl.getRef(); - String l = getLocalizedLabel(label); + final MUILabel label = (MUILabel) pl.getRef(); + final String l = getLocalizedLabel(label); if (l != null && l.trim().length() > 0) { b.append(" (" + l + ")"); //$NON-NLS-1$//$NON-NLS-2$ @@ -150,7 +150,7 @@ public class PlaceholderEditor extends AbstractComponentEditor { } private Composite createForm(Composite parent, final EMFDataBindingContext context, WritableValue master, boolean isImport) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); @@ -162,7 +162,7 @@ public class PlaceholderEditor extends AbstractComponentEditor { ControlFactory.createXMIId(parent, this); } - IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); + final IWidgetValueProperty textProp = WidgetProperties.text(SWT.Modify); if (isImport) { ControlFactory.createFindImport(parent, Messages, this, context); @@ -175,17 +175,17 @@ public class PlaceholderEditor extends AbstractComponentEditor { ControlFactory.createTextField(parent, Messages.PlaceholderEditor_ContainerData, master, context, textProp, EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__CONTAINER_DATA)); // ------------------------------------------------------------ { - Label l = new Label(parent, SWT.NONE); + final Label l = new Label(parent, SWT.NONE); l.setText(Messages.PlaceholderEditor_Reference); l.setLayoutData(new GridData(GridData.HORIZONTAL_ALIGN_END)); - Text t = new Text(parent, SWT.BORDER); + final Text t = new Text(parent, SWT.BORDER); TextPasteHandler.createFor(t); t.setEditable(false); - GridData gd = new GridData(GridData.FILL_HORIZONTAL); + final GridData gd = new GridData(GridData.FILL_HORIZONTAL); t.setLayoutData(gd); - UpdateValueStrategy t2m = new UpdateValueStrategy(); + final UpdateValueStrategy t2m = new UpdateValueStrategy(); t2m.setConverter(new Converter(String.class, MUIElement.class) { @Override @@ -193,16 +193,16 @@ public class PlaceholderEditor extends AbstractComponentEditor { return null; } }); - UpdateValueStrategy m2t = new UpdateValueStrategy(); + final UpdateValueStrategy m2t = new UpdateValueStrategy(); m2t.setConverter(new Converter(MUIElement.class, String.class) { @Override public Object convert(Object fromObject) { if (fromObject != null) { - EObject o = (EObject) fromObject; + final EObject o = (EObject) fromObject; if (o instanceof MUILabel) { - MUILabel label = (MUILabel) o; - String l = getLocalizedLabel(label); + final MUILabel label = (MUILabel) o; + final String l = getLocalizedLabel(label); if (!Util.isNullOrEmpty(l)) { return o.eClass().getName() + " - " + l; //$NON-NLS-1$ } @@ -222,7 +222,7 @@ public class PlaceholderEditor extends AbstractComponentEditor { b.addSelectionListener(new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) { - SharedElementsDialog dialog = new SharedElementsDialog(b.getShell(), getEditor(), (MPlaceholder) getMaster().getValue(), resource, Messages); + final SharedElementsDialog dialog = new SharedElementsDialog(b.getShell(), getEditor(), (MPlaceholder) getMaster().getValue(), resource, Messages); dialog.open(); } }); @@ -254,14 +254,14 @@ public class PlaceholderEditor extends AbstractComponentEditor { } private void createUITreeInspection(CTabFolder folder) { - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_RuntimeWidgetTree); - Composite container = new Composite(folder, SWT.NONE); + final Composite container = new Composite(folder, SWT.NONE); container.setLayout(new GridLayout()); item.setControl(container); - UIViewer objectViewer = new UIViewer(); - TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, getMaster(), resourcePool, Messages); + final UIViewer objectViewer = new UIViewer(); + final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/StringModelFragment.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/StringModelFragment.java index fcfd9c0c..7063fcd4 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/StringModelFragment.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/StringModelFragment.java @@ -63,7 +63,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -72,7 +71,7 @@ public class StringModelFragment extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty MODEL_FRAGMENT__ELEMENTS = EMFProperties - .list(FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS); + .list(FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS); private final List<Action> actions = new ArrayList<Action>(); @@ -89,7 +88,7 @@ public class StringModelFragment extends AbstractComponentEditor { final List<FeatureClass> list = new ArrayList<FeatureClass>(); Util.addClasses(ApplicationPackageImpl.eINSTANCE, list); list.addAll(getEditor().getFeatureClasses(FragmentPackageImpl.Literals.MODEL_FRAGMENT, - FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS)); + FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS)); for (final FeatureClass featureClass : list) { actions.add(new Action(featureClass.label) { @@ -102,8 +101,8 @@ public class StringModelFragment extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return createImage(ResourceProvider.IMG_StringModelFragment); + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_StringModelFragment); } @Override @@ -114,8 +113,8 @@ public class StringModelFragment extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { - FeaturePath.fromList(FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__FEATURENAME), - FeaturePath.fromList(FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__PARENT_ELEMENT_ID) }; + FeaturePath.fromList(FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__FEATURENAME), + FeaturePath.fromList(FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__PARENT_ELEMENT_ID) }; } @Override @@ -184,9 +183,9 @@ public class StringModelFragment extends AbstractComponentEditor { gd = new GridData(GridData.FILL_HORIZONTAL); t.setLayoutData(gd); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__PARENT_ELEMENT_ID).observeDetail(getMaster())); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__PARENT_ELEMENT_ID).observeDetail(getMaster())); final Button b = new Button(comp, SWT.PUSH | SWT.FLAT); b.setText(Messages.ModelTooling_Common_FindEllipsis); @@ -194,7 +193,7 @@ public class StringModelFragment extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final FindParentReferenceElementDialog dialog = new FindParentReferenceElementDialog(b.getShell(), - StringModelFragment.this, (MStringModelFragment) getMaster().getValue(), Messages); + StringModelFragment.this, (MStringModelFragment) getMaster().getValue(), Messages); dialog.open(); } }); @@ -220,9 +219,9 @@ public class StringModelFragment extends AbstractComponentEditor { gd = new GridData(GridData.FILL_HORIZONTAL); t.setLayoutData(gd); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__FEATURENAME).observeDetail(getMaster())); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__FEATURENAME).observeDetail(getMaster())); final Button button = new Button(comp, SWT.PUSH | SWT.FLAT); button.setText(Messages.ModelTooling_Common_FindEllipsis); @@ -230,7 +229,7 @@ public class StringModelFragment extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final FeatureSelectionDialog dialog = new FeatureSelectionDialog(button.getShell(), - getEditingDomain(), (MStringModelFragment) getMaster().getValue(), Messages); + getEditingDomain(), (MStringModelFragment) getMaster().getValue(), Messages); dialog.open(); } }); @@ -238,14 +237,14 @@ public class StringModelFragment extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.StringModelFragment_PositionInList, getMaster(), context, - textProp, EMFEditProperties.value(getEditingDomain(), - FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__POSITION_IN_LIST)); + textProp, EMFEditProperties.value(getEditingDomain(), + FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__POSITION_IN_LIST)); // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS) { + FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS) { @Override protected void addPressed() { final EClass eClass = ((FeatureClass) ((IStructuredSelection) getSelection()).getFirstElement()).eClass; @@ -281,7 +280,7 @@ public class StringModelFragment extends AbstractComponentEditor { final List<FeatureClass> list = new ArrayList<FeatureClass>(); Util.addClasses(ApplicationPackageImpl.eINSTANCE, list); list.addAll(getEditor().getFeatureClasses(FragmentPackageImpl.Literals.MODEL_FRAGMENT, - FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS)); + FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS)); pickList.setInput(list); if (list.size() > 0) { @@ -321,7 +320,7 @@ public class StringModelFragment extends AbstractComponentEditor { final EObject eObject = EcoreUtil.create(eClass); setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS, eObject); + FragmentPackageImpl.Literals.MODEL_FRAGMENT__ELEMENTS, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarContributionEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarContributionEditor.java index 57072d7c..f4f2bb6b 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarContributionEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarContributionEditor.java @@ -35,7 +35,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.ControlFactory.Text import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.ToolBarIdDialog; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MToolBarContribution; import org.eclipse.e4.ui.model.application.ui.menu.MToolBarElement; @@ -70,7 +69,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -79,7 +77,7 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -101,28 +99,28 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.ToolBarEditor_AddHandledToolItem, - createImageDescriptor(ResourceProvider.IMG_HandledToolItem)) { + createImageDescriptor(ResourceProvider.IMG_HandledToolItem)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.HANDLED_TOOL_ITEM, false); } }); actions.add(new Action(Messages.ToolBarEditor_AddDirectToolItem, - createImageDescriptor(ResourceProvider.IMG_DirectToolItem)) { + createImageDescriptor(ResourceProvider.IMG_DirectToolItem)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.DIRECT_TOOL_ITEM, false); } }); actions.add(new Action(Messages.ToolBarEditor_AddToolControl, - createImageDescriptor(ResourceProvider.IMG_ToolControl)) { + createImageDescriptor(ResourceProvider.IMG_ToolControl)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.TOOL_CONTROL, false); } }); actions.add(new Action(Messages.ToolBarEditor_AddToolBarSeparator, - createImageDescriptor(ResourceProvider.IMG_ToolBarSeparator)) { + createImageDescriptor(ResourceProvider.IMG_ToolBarSeparator)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.TOOL_BAR_SEPARATOR, true); @@ -131,16 +129,8 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_ToolBarContribution); - } - return createImage(ResourceProvider.IMG_Tbr_ToolBarContribution); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_ToolBarContribution); } @Override @@ -213,11 +203,11 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); { final Label l = new Label(parent, SWT.NONE); @@ -229,7 +219,7 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { final GridData gd = new GridData(GridData.FILL_HORIZONTAL); t.setLayoutData(gd); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.TOOL_BAR_CONTRIBUTION__PARENT_ID) + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.TOOL_BAR_CONTRIBUTION__PARENT_ID) .observeDetail(getMaster())); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -240,20 +230,20 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final ToolBarIdDialog dialog = new ToolBarIdDialog(t.getShell(), resource, - (MToolBarContribution) getMaster().getValue(), getEditingDomain(), modelService, Messages); + (MToolBarContribution) getMaster().getValue(), getEditingDomain(), modelService, Messages); dialog.open(); } }); } ControlFactory.createTextField(parent, Messages.MenuContributionEditor_Position, master, context, textProp, - EMFEditProperties.value(getEditingDomain(), - MenuPackageImpl.Literals.TOOL_BAR_CONTRIBUTION__POSITION_IN_PARENT)); + EMFEditProperties.value(getEditingDomain(), + MenuPackageImpl.Literals.TOOL_BAR_CONTRIBUTION__POSITION_IN_PARENT)); // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final Struct struct = (Struct) ((IStructuredSelection) getSelection()).getFirstElement(); @@ -262,7 +252,7 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -277,24 +267,24 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { final TableViewer viewer = pickList.getList(); final IEMFListProperty prop = EMFEditProperties.list(getEditingDomain(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); viewer.setInput(prop.observeDetail(master)); final Struct defaultStruct = new Struct(Messages.ToolBarEditor_HandledToolItem, - MenuPackageImpl.Literals.HANDLED_TOOL_ITEM, false); + MenuPackageImpl.Literals.HANDLED_TOOL_ITEM, false); pickList.setInput(new Struct[] { defaultStruct, - new Struct(Messages.ToolBarEditor_DirectToolItem, MenuPackageImpl.Literals.DIRECT_TOOL_ITEM, false), - new Struct(Messages.ToolBarEditor_ToolControl, MenuPackageImpl.Literals.TOOL_CONTROL, false), - new Struct(Messages.ToolBarEditor_Separator, MenuPackageImpl.Literals.TOOL_BAR_SEPARATOR, true) }); + new Struct(Messages.ToolBarEditor_DirectToolItem, MenuPackageImpl.Literals.DIRECT_TOOL_ITEM, false), + new Struct(Messages.ToolBarEditor_ToolControl, MenuPackageImpl.Literals.TOOL_CONTROL, false), + new Struct(Messages.ToolBarEditor_Separator, MenuPackageImpl.Literals.TOOL_BAR_SEPARATOR, true) }); pickList.setSelection(new StructuredSelection(defaultStruct)); } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -303,9 +293,9 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -327,7 +317,7 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -353,7 +343,7 @@ public class ToolBarContributionEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarEditor.java index 82e887f7..8ac6b803 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarEditor.java @@ -27,7 +27,6 @@ import org.eclipse.e4.tools.emf.ui.internal.ResourceProvider; import org.eclipse.e4.tools.emf.ui.internal.common.E4PickList; import org.eclipse.e4.tools.emf.ui.internal.common.E4PickList.Struct; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MToolBar; import org.eclipse.e4.ui.model.application.ui.menu.MToolBarElement; @@ -56,7 +55,6 @@ import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; public class ToolBarEditor extends AbstractComponentEditor { @@ -64,7 +62,7 @@ public class ToolBarEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -76,28 +74,28 @@ public class ToolBarEditor extends AbstractComponentEditor { @PostConstruct void init() { actions.add(new Action(Messages.ToolBarEditor_AddHandledToolItem, - createImageDescriptor(ResourceProvider.IMG_HandledToolItem)) { + createImageDescriptor(ResourceProvider.IMG_HandledToolItem)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.HANDLED_TOOL_ITEM, false); } }); actions.add(new Action(Messages.ToolBarEditor_AddDirectToolItem, - createImageDescriptor(ResourceProvider.IMG_DirectToolItem)) { + createImageDescriptor(ResourceProvider.IMG_DirectToolItem)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.DIRECT_TOOL_ITEM, false); } }); actions.add(new Action(Messages.ToolBarEditor_AddToolControl, - createImageDescriptor(ResourceProvider.IMG_ToolControl)) { + createImageDescriptor(ResourceProvider.IMG_ToolControl)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.TOOL_CONTROL, false); } }); actions.add(new Action(Messages.ToolBarEditor_AddToolBarSeparator, - createImageDescriptor(ResourceProvider.IMG_ToolBarSeparator)) { + createImageDescriptor(ResourceProvider.IMG_ToolBarSeparator)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.TOOL_BAR_SEPARATOR, true); @@ -106,16 +104,8 @@ public class ToolBarEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_ToolBar); - } - return createImage(ResourceProvider.IMG_Tbr_ToolBar); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_ToolBar); } @Override @@ -183,16 +173,16 @@ public class ToolBarEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final Struct struct = (Struct) ((IStructuredSelection) getSelection()).getFirstElement(); @@ -205,24 +195,24 @@ public class ToolBarEditor extends AbstractComponentEditor { final TableViewer viewer = pickList.getList(); final IEMFListProperty prop = EMFEditProperties.list(getEditingDomain(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); viewer.setInput(prop.observeDetail(master)); final Struct defaultStruct = new Struct(Messages.ToolBarEditor_HandledToolItem, - MenuPackageImpl.Literals.HANDLED_TOOL_ITEM, false); + MenuPackageImpl.Literals.HANDLED_TOOL_ITEM, false); pickList.setInput(new Struct[] { defaultStruct, - new Struct(Messages.ToolBarEditor_DirectToolItem, MenuPackageImpl.Literals.DIRECT_TOOL_ITEM, false), - new Struct(Messages.ToolBarEditor_ToolControl, MenuPackageImpl.Literals.TOOL_CONTROL, false), - new Struct(Messages.ToolBarEditor_Separator, MenuPackageImpl.Literals.TOOL_BAR_SEPARATOR, true) }); + new Struct(Messages.ToolBarEditor_DirectToolItem, MenuPackageImpl.Literals.DIRECT_TOOL_ITEM, false), + new Struct(Messages.ToolBarEditor_ToolControl, MenuPackageImpl.Literals.TOOL_CONTROL, false), + new Struct(Messages.ToolBarEditor_Separator, MenuPackageImpl.Literals.TOOL_BAR_SEPARATOR, true) }); pickList.setSelection(new StructuredSelection(defaultStruct)); } ControlFactory - .createCheckBox( + .createCheckBox( parent, "To Be Rendered", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); //$NON-NLS-1$ ControlFactory - .createCheckBox( + .createCheckBox( parent, "Visible", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); //$NON-NLS-1$ @@ -233,9 +223,9 @@ public class ToolBarEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); createContributedEditorTabs(folder, context, getMaster(), MToolBar.class); @@ -271,7 +261,7 @@ public class ToolBarEditor extends AbstractComponentEditor { setElementId(eObject); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarSeparatorEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarSeparatorEditor.java index 7e91c337..09f6d0bb 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarSeparatorEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolBarSeparatorEditor.java @@ -22,7 +22,6 @@ import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; import org.eclipse.e4.tools.emf.ui.internal.ResourceProvider; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MToolBarSeparator; import org.eclipse.emf.databinding.EMFDataBindingContext; @@ -41,7 +40,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; public class ToolBarSeparatorEditor extends AbstractComponentEditor { private Composite composite; @@ -58,16 +56,8 @@ public class ToolBarSeparatorEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_ToolBarSeparator); - } - return createImage(ResourceProvider.IMG_Tbr_ToolBarSeparator); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_ToolBarSeparator); } @Override @@ -140,17 +130,17 @@ public class ToolBarSeparatorEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -159,9 +149,9 @@ public class ToolBarSeparatorEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -183,7 +173,7 @@ public class ToolBarSeparatorEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolControlEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolControlEditor.java index 89bd7f14..db85f52e 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolControlEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/ToolControlEditor.java @@ -30,7 +30,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.objectdata.ObjectViewer; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.MContribution; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MToolControl; import org.eclipse.e4.ui.model.application.ui.menu.impl.MenuPackageImpl; @@ -53,7 +52,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Link; import org.eclipse.swt.widgets.Text; @@ -86,16 +84,8 @@ public class ToolControlEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_ToolControl); - } - return createImage(ResourceProvider.IMG_Tbr_ToolControl); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_ToolControl); } @Override @@ -159,16 +149,16 @@ public class ToolControlEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); // ------------------------------------------------------------ { final IContributionClassCreator c = getEditor().getContributionCreator( - MenuPackageImpl.Literals.TOOL_CONTROL); + MenuPackageImpl.Literals.TOOL_CONTROL); if (project != null && c != null) { final Link lnk = new Link(parent, SWT.NONE); lnk.setText("<A>" + Messages.ToolControlEditor_ClassURI + "</A>"); //$NON-NLS-1$//$NON-NLS-2$ @@ -177,7 +167,7 @@ public class ToolControlEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { c.createOpen((MContribution) getMaster().getValue(), getEditingDomain(), project, - lnk.getShell()); + lnk.getShell()); } }); } else { @@ -190,9 +180,9 @@ public class ToolControlEditor extends AbstractComponentEditor { TextPasteHandler.createFor(t); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI).observeDetail(master)); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); b.setLayoutData(new GridData(GridData.FILL, GridData.CENTER, false, false)); @@ -202,22 +192,22 @@ public class ToolControlEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final ContributionClassDialog dialog = new ContributionClassDialog(b.getShell(), eclipseContext, - getEditingDomain(), (MContribution) getMaster().getValue(), - ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); + getEditingDomain(), (MContribution) getMaster().getValue(), + ApplicationPackageImpl.Literals.CONTRIBUTION__CONTRIBUTION_URI, Messages); dialog.open(); } }); } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -226,9 +216,9 @@ public class ToolControlEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createInstanceInspection(folder); @@ -251,7 +241,7 @@ public class ToolControlEditor extends AbstractComponentEditor { final ObjectViewer objectViewer = new ObjectViewer(); final TreeViewer viewer = objectViewer.createViewer(container, - ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); + ApplicationPackageImpl.Literals.CONTRIBUTION__OBJECT, getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -265,7 +255,7 @@ public class ToolControlEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimBarEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimBarEditor.java index f1988b47..7f7f554c 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimBarEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimBarEditor.java @@ -37,7 +37,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.ModelEditor; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; import org.eclipse.e4.ui.model.application.ui.MGenericTrimContainer; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.SideValue; import org.eclipse.e4.ui.model.application.ui.basic.MTrimBar; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; @@ -71,7 +70,6 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; public class TrimBarEditor extends AbstractComponentEditor { @@ -80,7 +78,7 @@ public class TrimBarEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -109,7 +107,7 @@ public class TrimBarEditor extends AbstractComponentEditor { } }); actions.add(new Action(Messages.TrimBarEditor_AddToolControl, - createImageDescriptor(ResourceProvider.IMG_ToolControl)) { + createImageDescriptor(ResourceProvider.IMG_ToolControl)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.TOOL_CONTROL); @@ -118,16 +116,8 @@ public class TrimBarEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_WindowTrim); - } - return createImage(ResourceProvider.IMG_Tbr_WindowTrim); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_WindowTrim); } @Override @@ -195,11 +185,11 @@ public class TrimBarEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); // ------------------------------------------------------------ { @@ -214,14 +204,14 @@ public class TrimBarEditor extends AbstractComponentEditor { gd.horizontalSpan = 2; viewer.getControl().setLayoutData(gd); final IObservableValue sideValueObs = EMFEditProperties.value(getEditingDomain(), - UiPackageImpl.Literals.GENERIC_TRIM_CONTAINER__SIDE).observeDetail(master); + UiPackageImpl.Literals.GENERIC_TRIM_CONTAINER__SIDE).observeDetail(master); context.bindValue(ViewerProperties.singleSelection().observe(viewer), sideValueObs); } // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), - Messages, this, UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + Messages, this, UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); @@ -235,7 +225,7 @@ public class TrimBarEditor extends AbstractComponentEditor { pickList.setLabelProvider(new EClassLabelProvider(getEditor())); pickList - .setInput(new Object[] { MenuPackageImpl.Literals.TOOL_BAR, MenuPackageImpl.Literals.TOOL_CONTROL }); + .setInput(new Object[] { MenuPackageImpl.Literals.TOOL_BAR, MenuPackageImpl.Literals.TOOL_CONTROL }); pickList.setSelection(new StructuredSelection(MenuPackageImpl.Literals.TOOL_BAR)); final IEMFListProperty prop = EMFProperties.list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); @@ -243,11 +233,11 @@ public class TrimBarEditor extends AbstractComponentEditor { } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -256,9 +246,9 @@ public class TrimBarEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -280,7 +270,7 @@ public class TrimBarEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -303,7 +293,7 @@ public class TrimBarEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.GENERIC_TRIM_CONTAINER__SIDE), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } protected void handleAddChild(EClass eClass) { @@ -311,7 +301,7 @@ public class TrimBarEditor extends AbstractComponentEditor { setElementId(toolbar); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, toolbar); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, toolbar); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimContributionEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimContributionEditor.java index ca14152c..a33c7214 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimContributionEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/TrimContributionEditor.java @@ -36,7 +36,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.ControlFactory.Text import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.TrimIdDialog; import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.impl.UiPackageImpl; import org.eclipse.e4.ui.model.application.ui.menu.MTrimContribution; import org.eclipse.e4.ui.model.application.ui.menu.impl.MenuPackageImpl; @@ -73,7 +72,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -82,7 +80,7 @@ public class TrimContributionEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private StackLayout stackLayout; private final List<Action> actions = new ArrayList<Action>(); @@ -110,7 +108,7 @@ public class TrimContributionEditor extends AbstractComponentEditor { } }); actions.add(new Action(Messages.TrimBarEditor_AddToolControl, - createImageDescriptor(ResourceProvider.IMG_ToolControl)) { + createImageDescriptor(ResourceProvider.IMG_ToolControl)) { @Override public void run() { handleAddChild(MenuPackageImpl.Literals.TOOL_CONTROL); @@ -119,16 +117,8 @@ public class TrimContributionEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_TrimContribution); - } - return createImage(ResourceProvider.IMG_Tbr_TrimContribution); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_TrimContribution); } @Override @@ -201,11 +191,11 @@ public class TrimContributionEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, master, context, textProp, - EMFEditProperties + EMFEditProperties .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); ControlFactory.createTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, getMaster(), - context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); + context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE)); { final Label l = new Label(parent, SWT.NONE); l.setText(Messages.MenuContributionEditor_ParentId); @@ -216,7 +206,7 @@ public class TrimContributionEditor extends AbstractComponentEditor { final GridData gd = new GridData(GridData.FILL_HORIZONTAL); t.setLayoutData(gd); context.bindValue(textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.TRIM_CONTRIBUTION__PARENT_ID) + EMFEditProperties.value(getEditingDomain(), MenuPackageImpl.Literals.TRIM_CONTRIBUTION__PARENT_ID) .observeDetail(getMaster())); final Button b = new Button(parent, SWT.PUSH | SWT.FLAT); @@ -227,7 +217,7 @@ public class TrimContributionEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final TrimIdDialog dialog = new TrimIdDialog(t.getShell(), resource, - (MTrimContribution) getMaster().getValue(), getEditingDomain(), modelService, Messages); + (MTrimContribution) getMaster().getValue(), getEditingDomain(), modelService, Messages); dialog.open(); } }); @@ -235,14 +225,14 @@ public class TrimContributionEditor extends AbstractComponentEditor { } ControlFactory - .createTextField(parent, Messages.TrimContributionEditor_Position, master, context, textProp, + .createTextField(parent, Messages.TrimContributionEditor_Position, master, context, textProp, EMFEditProperties.value(getEditingDomain(), - MenuPackageImpl.Literals.TRIM_CONTRIBUTION__POSITION_IN_PARENT)); + MenuPackageImpl.Literals.TRIM_CONTRIBUTION__POSITION_IN_PARENT)); // ------------------------------------------------------------ { final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { final EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); @@ -266,16 +256,16 @@ public class TrimContributionEditor extends AbstractComponentEditor { } }); pickList - .setInput(new Object[] { MenuPackageImpl.Literals.TOOL_BAR, MenuPackageImpl.Literals.TOOL_CONTROL }); + .setInput(new Object[] { MenuPackageImpl.Literals.TOOL_BAR, MenuPackageImpl.Literals.TOOL_CONTROL }); pickList.setSelection(new StructuredSelection(MenuPackageImpl.Literals.TOOL_BAR)); } ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_ToBeRendered, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); ControlFactory.createCheckBox(parent, Messages.ModelTooling_UIElement_Visible, getMaster(), context, - WidgetProperties.selection(), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); + WidgetProperties.selection(), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -284,9 +274,9 @@ public class TrimContributionEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -308,7 +298,7 @@ public class TrimContributionEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } @@ -327,7 +317,7 @@ public class TrimContributionEditor extends AbstractComponentEditor { setElementId(toolbar); final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), - UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, toolbar); + UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, toolbar); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WindowEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WindowEditor.java index f153ba7a..bbbc5e7c 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WindowEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WindowEditor.java @@ -38,7 +38,6 @@ import org.eclipse.e4.tools.emf.ui.internal.common.component.dialogs.WindowIconD import org.eclipse.e4.tools.emf.ui.internal.common.uistructure.UIViewer; import org.eclipse.e4.ui.model.application.commands.impl.CommandsPackageImpl; import org.eclipse.e4.ui.model.application.impl.ApplicationPackageImpl; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.MUILabel; import org.eclipse.e4.ui.model.application.ui.basic.MWindow; import org.eclipse.e4.ui.model.application.ui.basic.impl.BasicPackageImpl; @@ -69,7 +68,6 @@ import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Text; @@ -79,10 +77,10 @@ public class WindowEditor extends AbstractComponentEditor { private EMFDataBindingContext context; private final IListProperty HANDLER_CONTAINER__HANDLERS = EMFProperties - .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); + .list(CommandsPackageImpl.Literals.HANDLER_CONTAINER__HANDLERS); private final IListProperty WINDOW__WINDOWS = EMFProperties.list(BasicPackageImpl.Literals.WINDOW__WINDOWS); private final IListProperty ELEMENT_CONTAINER__CHILDREN = EMFProperties - .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); + .list(UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN); private final IListProperty SHARED_ELEMENTS = EMFProperties.list(BasicPackageImpl.Literals.WINDOW__SHARED_ELEMENTS); private final IValueProperty WINDOW__MAIN_MENU = EMFProperties.value(BasicPackageImpl.Literals.WINDOW__MAIN_MENU); @@ -113,17 +111,8 @@ public class WindowEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - final Image img = getImageFromIconURI(uiElement); - return img != null ? img : createImage(ResourceProvider.IMG_Window); - } - return createImage(ResourceProvider.IMG_Tbr_Window); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_Window); } @Override @@ -171,7 +160,7 @@ public class WindowEditor extends AbstractComponentEditor { getMaster().setValue(object); enableIdGenerator(UiPackageImpl.Literals.UI_LABEL__LABEL, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, null); return composite; } @@ -198,8 +187,8 @@ public class WindowEditor extends AbstractComponentEditor { } ControlFactory.createTextField(parent, Messages.ModelTooling_Common_Id, getMaster(), context, textProp, - EMFEditProperties - .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); + EMFEditProperties + .value(getEditingDomain(), ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID)); // ------------------------------------------------------------ { @@ -219,37 +208,37 @@ public class WindowEditor extends AbstractComponentEditor { Text t = new Text(comp, SWT.BORDER | SWT.TRAIL); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__X).observeDetail( - getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__X).observeDetail( + getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); t = new Text(comp, SWT.BORDER | SWT.TRAIL); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__Y).observeDetail( - getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__Y).observeDetail( + getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); t = new Text(comp, SWT.BORDER | SWT.TRAIL); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__WIDTH).observeDetail( - getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__WIDTH).observeDetail( + getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); t = new Text(comp, SWT.BORDER | SWT.TRAIL); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__HEIGHT).observeDetail( - getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__HEIGHT).observeDetail( + getMaster()), new UnsettableUpdateValueStrategy(), new UnsettableUpdateValueStrategy()); } ControlFactory.createTranslatedTextField(parent, Messages.WindowEditor_Label, getMaster(), context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, project); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__LABEL), resourcePool, project); ControlFactory.createTranslatedTextField(parent, Messages.WindowEditor_Tooltip, getMaster(), context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), resourcePool, - project); + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__TOOLTIP), resourcePool, + project); // ------------------------------------------------------------ { @@ -260,9 +249,9 @@ public class WindowEditor extends AbstractComponentEditor { final Text t = new Text(parent, SWT.BORDER); t.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); context.bindValue( - textProp.observeDelayed(200, t), - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( - master)); + textProp.observeDelayed(200, t), + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_LABEL__ICON_URI).observeDetail( + master)); new ImageTooltip(t, Messages) { @@ -285,7 +274,7 @@ public class WindowEditor extends AbstractComponentEditor { @Override public void widgetSelected(SelectionEvent e) { final WindowIconDialogEditor dialog = new WindowIconDialogEditor(b.getShell(), eclipseContext, - project, getEditingDomain(), (MWindow) getMaster().getValue(), Messages); + project, getEditingDomain(), (MWindow) getMaster().getValue(), Messages); dialog.open(); } }); @@ -313,17 +302,17 @@ public class WindowEditor extends AbstractComponentEditor { ControlFactory .createCheckBox( - parent, - "To Be Rendered", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); //$NON-NLS-1$ + parent, + "To Be Rendered", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED)); //$NON-NLS-1$ ControlFactory .createCheckBox( - parent, - "Visible", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); //$NON-NLS-1$ + parent, + "Visible", getMaster(), context, WidgetProperties.selection(), EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__VISIBLE)); //$NON-NLS-1$ ControlFactory.createSelectedElement(parent, this, context, Messages.WindowEditor_SelectedElement); ControlFactory.createBindingContextWiget(parent, Messages, this, Messages.WindowEditor_BindingContexts); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Context_Properties, - UiPackageImpl.Literals.CONTEXT__PROPERTIES, VERTICAL_LIST_WIDGET_INDENT); + UiPackageImpl.Literals.CONTEXT__PROPERTIES, VERTICAL_LIST_WIDGET_INDENT); item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabSupplementary); @@ -332,15 +321,15 @@ public class WindowEditor extends AbstractComponentEditor { item.setControl(parent.getParent()); ControlFactory.createTranslatedTextField(parent, Messages.ModelTooling_UIElement_AccessibilityPhrase, - getMaster(), context, textProp, - EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE), - resourcePool, project); + getMaster(), context, textProp, + EMFEditProperties.value(getEditingDomain(), UiPackageImpl.Literals.UI_ELEMENT__ACCESSIBILITY_PHRASE), + resourcePool, project); ControlFactory.createStringListWidget(parent, Messages, this, Messages.ModelTooling_Context_Variables, - UiPackageImpl.Literals.CONTEXT__VARIABLES, VERTICAL_LIST_WIDGET_INDENT); + UiPackageImpl.Literals.CONTEXT__VARIABLES, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createStringListWidget(parent, Messages, this, Messages.CategoryEditor_Tags, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__TAGS, VERTICAL_LIST_WIDGET_INDENT); ControlFactory.createMapProperties(parent, Messages, this, Messages.ModelTooling_Contribution_PersistedState, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__PERSISTED_STATE, VERTICAL_LIST_WIDGET_INDENT); if (project == null) { createUITreeInspection(folder); @@ -362,13 +351,13 @@ public class WindowEditor extends AbstractComponentEditor { final UIViewer objectViewer = new UIViewer(); final TreeViewer viewer = objectViewer.createViewer(container, UiPackageImpl.Literals.UI_ELEMENT__WIDGET, - getMaster(), resourcePool, Messages); + getMaster(), resourcePool, Messages); viewer.getControl().setLayoutData(new GridData(GridData.FILL_BOTH)); } void removeMenu() { final Command cmd = SetCommand.create(getEditingDomain(), getMaster().getValue(), - BasicPackageImpl.Literals.WINDOW__MAIN_MENU, null); + BasicPackageImpl.Literals.WINDOW__MAIN_MENU, null); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -379,7 +368,7 @@ public class WindowEditor extends AbstractComponentEditor { setElementId(menu); final Command cmd = SetCommand.create(getEditingDomain(), getMaster().getValue(), - BasicPackageImpl.Literals.WINDOW__MAIN_MENU, menu); + BasicPackageImpl.Literals.WINDOW__MAIN_MENU, menu); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); } @@ -393,7 +382,7 @@ public class WindowEditor extends AbstractComponentEditor { } list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_HANDLER, HANDLER_CONTAINER__HANDLERS, element, - Messages.WindowEditor_Handlers) { + Messages.WindowEditor_Handlers) { @Override protected boolean accepted(Object o) { @@ -403,7 +392,7 @@ public class WindowEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_WINDOW_WINDOWS, WINDOW__WINDOWS, element, - Messages.WindowEditor_Windows) { + Messages.WindowEditor_Windows) { @Override protected boolean accepted(Object o) { @@ -413,7 +402,7 @@ public class WindowEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_WINDOW_CONTROLS, ELEMENT_CONTAINER__CHILDREN, element, - Messages.WindowEditor_Controls) { + Messages.WindowEditor_Controls) { @Override protected boolean accepted(Object o) { @@ -423,7 +412,7 @@ public class WindowEditor extends AbstractComponentEditor { }); list.add(new VirtualEntry<Object>(ModelEditor.VIRTUAL_WINDOW_SHARED_ELEMENTS, SHARED_ELEMENTS, element, - Messages.WindowEditor_SharedElements) { + Messages.WindowEditor_SharedElements) { @Override protected boolean accepted(Object o) { return true; @@ -466,7 +455,7 @@ public class WindowEditor extends AbstractComponentEditor { @Override public FeaturePath[] getLabelProperties() { return new FeaturePath[] { FeaturePath.fromList(UiPackageImpl.Literals.UI_LABEL__LABEL), - FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; + FeaturePath.fromList(UiPackageImpl.Literals.UI_ELEMENT__TO_BE_RENDERED) }; } @Override diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WizardDialogEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WizardDialogEditor.java index ebabc7ae..60b464b7 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WizardDialogEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/WizardDialogEditor.java @@ -14,25 +14,15 @@ import java.util.ArrayList; import java.util.List; import org.eclipse.e4.tools.emf.ui.internal.ResourceProvider; -import org.eclipse.e4.ui.model.application.ui.MUIElement; import org.eclipse.e4.ui.model.application.ui.basic.MWizardDialog; import org.eclipse.jface.action.Action; import org.eclipse.swt.graphics.Image; -import org.eclipse.swt.widgets.Display; public class WizardDialogEditor extends WindowEditor { @Override - public Image getImage(Object element, Display display) { - if (element instanceof MUIElement) { - final MUIElement uiElement = (MUIElement) element; - if (uiElement.isToBeRendered() && uiElement.isVisible()) { - return createImage(ResourceProvider.IMG_WizardDialog); - } - return createImage(ResourceProvider.IMG_Tbr_WizardDialog); - } - - return null; + public Image getImage(Object element) { + return getImage(element, ResourceProvider.IMG_WizardDialog); } @Override diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindImportElementDialog.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindImportElementDialog.java index e0e4c007..bf62e9fe 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindImportElementDialog.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindImportElementDialog.java @@ -71,7 +71,7 @@ public class FindImportElementDialog extends SaveDialogBoundsSettingsDialog { final Composite comp = (Composite) super.createDialogArea(parent); final Image titleImage = new Image(parent.getDisplay(), getClass().getClassLoader().getResourceAsStream( - "/icons/full/wizban/import_wiz.png")); //$NON-NLS-1$ + "/icons/full/wizban/import_wiz.png")); //$NON-NLS-1$ setTitleImage(titleImage); getShell().addDisposeListener(new DisposeListener() { @@ -106,11 +106,11 @@ public class FindImportElementDialog extends SaveDialogBoundsSettingsDialog { @Override public void update(ViewerCell cell) { final EObject o = (EObject) cell.getElement(); - cell.setImage(editor.getImage(o, searchText.getDisplay())); + cell.setImage(editor.getImage(o)); final MApplicationElement appEl = (MApplicationElement) o; final StyledString styledString = new StyledString( - editor.getLabel(o) + editor.getLabel(o) + " (" + (appEl.getElementId() == null ? "<" + Messages.FindImportElementDialog_noId + ">" : appEl.getElementId()) + ")", null); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ final String detailLabel = editor.getDetailLabel(o); if (detailLabel != null && !detailLabel.equals(appEl.getElementId())) { @@ -171,7 +171,7 @@ public class FindImportElementDialog extends SaveDialogBoundsSettingsDialog { final MApplicationElement el = (MApplicationElement) s.getFirstElement(); if (el.getElementId() != null && el.getElementId().trim().length() > 0) { final Command cmd = SetCommand.create(editor.getEditingDomain(), element, - ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, el.getElementId()); + ApplicationPackageImpl.Literals.APPLICATION_ELEMENT__ELEMENT_ID, el.getElementId()); if (cmd.canExecute()) { editor.getEditingDomain().getCommandStack().execute(cmd); super.okPressed(); @@ -200,7 +200,7 @@ public class FindImportElementDialog extends SaveDialogBoundsSettingsDialog { private final Resource resource; public ModelResultHandlerImpl(IObservableList list, Filter filter, AbstractComponentEditor editor, - Resource resource) { + Resource resource) { this.list = list; this.filter = filter; this.editor = editor; diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindParentReferenceElementDialog.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindParentReferenceElementDialog.java index ddef9008..033f36cd 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindParentReferenceElementDialog.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/FindParentReferenceElementDialog.java @@ -84,7 +84,7 @@ public class FindParentReferenceElementDialog extends TitleAreaDialog { private Text searchText; public FindParentReferenceElementDialog(Shell parentShell, AbstractComponentEditor editor, - MStringModelFragment fragment, Messages Messages) { + MStringModelFragment fragment, Messages Messages) { super(parentShell); this.fragment = fragment; this.editor = editor; @@ -101,7 +101,7 @@ public class FindParentReferenceElementDialog extends TitleAreaDialog { final Composite comp = (Composite) super.createDialogArea(parent); final Image titleImage = new Image(parent.getDisplay(), getClass().getClassLoader().getResourceAsStream( - "/icons/full/wizban/import_wiz.png")); //$NON-NLS-1$ + "/icons/full/wizban/import_wiz.png")); //$NON-NLS-1$ setTitleImage(titleImage); getShell().addDisposeListener(new DisposeListener() { @@ -188,13 +188,13 @@ public class FindParentReferenceElementDialog extends TitleAreaDialog { public void update(ViewerCell cell) { final EObject o = (EObject) cell.getElement(); final AbstractComponentEditor editor = FindParentReferenceElementDialog.this.editor.getEditor() - .getEditor(o.eClass()); - cell.setImage(editor.getImage(o, searchText.getDisplay())); + .getEditor(o.eClass()); + cell.setImage(editor.getImage(o)); final MApplicationElement appEl = (MApplicationElement) o; final StyledString styledString = new StyledString( - editor.getLabel(o) + editor.getLabel(o) + " (" + (appEl.getElementId() == null ? "<" + Messages.FindParentReferenceElementDialog_NoId + ">" : appEl.getElementId()) + ")", null); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ final String detailLabel = editor.getDetailLabel(o); if (detailLabel != null && !detailLabel.equals(appEl.getElementId())) { @@ -247,7 +247,7 @@ public class FindParentReferenceElementDialog extends TitleAreaDialog { list.clear(); final Filter filter = new Filter( - (EClass) ((IStructuredSelection) eClassViewer.getSelection()).getFirstElement(), searchText.getText()); + (EClass) ((IStructuredSelection) eClassViewer.getSelection()).getFirstElement(), searchText.getText()); currentResultHandler = new ModelResultHandlerImpl(list, filter, editor, ((EObject) fragment).eResource()); getCollector().findModelElements(filter, currentResultHandler); @@ -261,7 +261,7 @@ public class FindParentReferenceElementDialog extends TitleAreaDialog { final MApplicationElement el = (MApplicationElement) s.getFirstElement(); if (el.getElementId() != null && el.getElementId().trim().length() > 0) { final Command cmd = SetCommand.create(editor.getEditingDomain(), fragment, - FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__PARENT_ELEMENT_ID, el.getElementId()); + FragmentPackageImpl.Literals.STRING_MODEL_FRAGMENT__PARENT_ELEMENT_ID, el.getElementId()); if (cmd.canExecute()) { editor.getEditingDomain().getCommandStack().execute(cmd); super.okPressed(); @@ -290,7 +290,7 @@ public class FindParentReferenceElementDialog extends TitleAreaDialog { private final Resource resource; public ModelResultHandlerImpl(IObservableList list, Filter filter, AbstractComponentEditor editor, - Resource resource) { + Resource resource) { this.list = list; this.filter = filter; this.editor = editor; diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/SharedElementsDialog.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/SharedElementsDialog.java index 9ba04e58..1a3e3488 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/SharedElementsDialog.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/SharedElementsDialog.java @@ -67,7 +67,7 @@ public class SharedElementsDialog extends SaveDialogBoundsSettingsDialog { private final Messages Messages; public SharedElementsDialog(Shell parentShell, ModelEditor editor, MPlaceholder placeholder, - IModelResource resource, Messages Messages) { + IModelResource resource, Messages Messages) { super(parentShell); this.editor = editor; this.placeholder = placeholder; @@ -150,7 +150,7 @@ public class SharedElementsDialog extends SaveDialogBoundsSettingsDialog { if (!viewer.getSelection().isEmpty()) { final IStructuredSelection s = (IStructuredSelection) viewer.getSelection(); final Command cmd = SetCommand.create(resource.getEditingDomain(), placeholder, - AdvancedPackageImpl.Literals.PLACEHOLDER__REF, s.getFirstElement()); + AdvancedPackageImpl.Literals.PLACEHOLDER__REF, s.getFirstElement()); if (cmd.canExecute()) { resource.getEditingDomain().getCommandStack().execute(cmd); super.okPressed(); @@ -210,9 +210,9 @@ public class SharedElementsDialog extends SaveDialogBoundsSettingsDialog { @Override public Image getImage(Object element) { final AbstractComponentEditor editor = SharedElementsDialog.this.editor.getEditor(((EObject) element) - .eClass()); + .eClass()); if (editor != null) { - return editor.getImage(element, getShell().getDisplay()); + return editor.getImage(element); } return null; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationAddons.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationAddons.java index 6c67aae0..c22facce 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationAddons.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationAddons.java @@ -39,10 +39,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VApplicationAddons extends AbstractComponentEditor { private Composite composite; @@ -67,10 +65,6 @@ public class VApplicationAddons extends AbstractComponentEditor { }); } - @Override - public Image getImage(Object element, Display display) { - return null; - } @Override public String getLabel(Object element) { diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationCategoriesEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationCategoriesEditor.java index 2debfdd7..cc349c14 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationCategoriesEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VApplicationCategoriesEditor.java @@ -14,8 +14,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.Arrays; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; @@ -39,18 +41,16 @@ import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VApplicationCategoriesEditor extends AbstractComponentEditor { private Composite composite; private TableViewer viewer; private EMFDataBindingContext context; - private List<Action> actions = new ArrayList<Action>(); - private List<Action> actionsImport = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); + private final List<Action> actionsImport = new ArrayList<Action>(); @Inject public VApplicationCategoriesEditor() { @@ -74,20 +74,16 @@ public class VApplicationCategoriesEditor extends AbstractComponentEditor { } protected void handleImport() { - ModelImportWizard wizard = new ModelImportWizard(MCategory.class, this, resourcePool); - WizardDialog wizardDialog = new WizardDialog(viewer.getControl().getShell(), wizard); + final ModelImportWizard wizard = new ModelImportWizard(MCategory.class, this, resourcePool); + final WizardDialog wizardDialog = new WizardDialog(viewer.getControl().getShell(), wizard); if (wizardDialog.open() == Window.OK) { - MCategory[] elements = (MCategory[]) wizard.getElements(MCategory.class); - for (MCategory category : elements) { + final MCategory[] elements = (MCategory[]) wizard.getElements(MCategory.class); + for (final MCategory category : elements) { addCategory(category); } } } - @Override - public Image getImage(Object element, Display display) { - return null; - } @Override public String getLabel(Object element) { @@ -110,23 +106,23 @@ public class VApplicationCategoriesEditor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); { - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, ApplicationPackageImpl.Literals.APPLICATION__CATEGORIES) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, ApplicationPackageImpl.Literals.APPLICATION__CATEGORIES) { @Override protected void addPressed() { handleAdd(); @@ -152,14 +148,14 @@ public class VApplicationCategoriesEditor extends AbstractComponentEditor { } protected void handleAdd() { - MCategory category = CommandsFactoryImpl.eINSTANCE.createCategory(); + final MCategory category = CommandsFactoryImpl.eINSTANCE.createCategory(); addCategory(category); } private void addCategory(MCategory category) { setElementId(category); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), ApplicationPackageImpl.Literals.APPLICATION__CATEGORIES, category); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), ApplicationPackageImpl.Literals.APPLICATION__CATEGORIES, category); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -169,14 +165,14 @@ public class VApplicationCategoriesEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } @Override public List<Action> getActionsImport(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actionsImport); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VBindingTableEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VBindingTableEditor.java index 32824bdf..597c23be 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VBindingTableEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VBindingTableEditor.java @@ -14,8 +14,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.Arrays; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; @@ -36,16 +38,14 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VBindingTableEditor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private TableViewer viewer; - private List<Action> actions = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); @Inject public VBindingTableEditor() { @@ -62,10 +62,6 @@ public class VBindingTableEditor extends AbstractComponentEditor { }); } - @Override - public Image getImage(Object element, Display display) { - return null; - } @Override public String getLabel(Object element) { @@ -89,23 +85,23 @@ public class VBindingTableEditor extends AbstractComponentEditor { composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); { - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__BINDING_TABLES) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__BINDING_TABLES) { @Override protected void addPressed() { handleAdd(); @@ -126,10 +122,10 @@ public class VBindingTableEditor extends AbstractComponentEditor { } protected void handleAdd() { - MBindingTable command = MCommandsFactory.INSTANCE.createBindingTable(); + final MBindingTable command = MCommandsFactory.INSTANCE.createBindingTable(); setElementId(command); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__BINDING_TABLES, command); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__BINDING_TABLES, command); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -144,7 +140,7 @@ public class VBindingTableEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VCommandEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VCommandEditor.java index 95d4ce8c..ff725822 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VCommandEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VCommandEditor.java @@ -44,10 +44,8 @@ import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VCommandEditor extends AbstractComponentEditor { private Composite composite; @@ -88,11 +86,6 @@ public class VCommandEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VCommandEditor_TreeLabel; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VHandlerEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VHandlerEditor.java index 97e6c338..4a5136b4 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VHandlerEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VHandlerEditor.java @@ -41,10 +41,8 @@ import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VHandlerEditor extends AbstractComponentEditor { private Composite composite; @@ -79,11 +77,6 @@ public class VHandlerEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VHandlerEditor_TreeLabel; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VItemParametersEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VItemParametersEditor.java index f0ea6bba..273c9fdb 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VItemParametersEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VItemParametersEditor.java @@ -40,10 +40,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VItemParametersEditor extends AbstractComponentEditor { private Composite composite; @@ -70,10 +68,6 @@ public class VItemParametersEditor extends AbstractComponentEditor { }); } - @Override - public Image getImage(Object element, Display display) { - return null; - } @Override public String getLabel(Object element) { diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuContributionsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuContributionsEditor.java index e66ebaa8..6d3f3863 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuContributionsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuContributionsEditor.java @@ -14,8 +14,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.Arrays; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; @@ -36,17 +38,15 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VMenuContributionsEditor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private TableViewer viewer; - private List<Action> actions = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); @Inject public VMenuContributionsEditor() { @@ -63,10 +63,6 @@ public class VMenuContributionsEditor extends AbstractComponentEditor { }); } - @Override - public Image getImage(Object element, Display display) { - return null; - } @Override public String getLabel(Object element) { @@ -89,23 +85,23 @@ public class VMenuContributionsEditor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); { - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, MenuPackageImpl.Literals.MENU_CONTRIBUTIONS__MENU_CONTRIBUTIONS) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, MenuPackageImpl.Literals.MENU_CONTRIBUTIONS__MENU_CONTRIBUTIONS) { @Override protected void addPressed() { handleAdd(); @@ -132,10 +128,10 @@ public class VMenuContributionsEditor extends AbstractComponentEditor { } protected void handleAdd() { - MMenuContribution command = MMenuFactory.INSTANCE.createMenuContribution(); + final MMenuContribution command = MMenuFactory.INSTANCE.createMenuContribution(); setElementId(command); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), MenuPackageImpl.Literals.MENU_CONTRIBUTIONS__MENU_CONTRIBUTIONS, command); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), MenuPackageImpl.Literals.MENU_CONTRIBUTIONS__MENU_CONTRIBUTIONS, command); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -145,7 +141,7 @@ public class VMenuContributionsEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuEditor.java index c0cbeefc..4df8c08e 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VMenuEditor.java @@ -13,8 +13,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.core.contexts.IEclipseContext; @@ -44,17 +46,15 @@ import org.eclipse.jface.viewers.StructuredViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VMenuEditor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private StructuredViewer viewer; - private List<Action> actions = new ArrayList<Action>(); - private EStructuralFeature feature; + private final List<Action> actions = new ArrayList<Action>(); + private final EStructuralFeature feature; @Inject IEclipseContext eclipseContext; @@ -93,11 +93,6 @@ public class VMenuEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VMenuEditor_TreeLabel; } @@ -118,25 +113,25 @@ public class VMenuEditor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, feature) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, feature) { @Override protected void addPressed() { - Types t = (Types) ((IStructuredSelection) getSelection()).getFirstElement(); + final Types t = (Types) ((IStructuredSelection) getSelection()).getFirstElement(); if (t == Types.MENU) { handleAdd(MenuPackageImpl.Literals.MENU); } else if (t == Types.POPUP_MENU) { @@ -186,10 +181,10 @@ public class VMenuEditor extends AbstractComponentEditor { } protected void handleAdd(EClass eClass) { - EObject handler = EcoreUtil.create(eClass); + final EObject handler = EcoreUtil.create(eClass); setElementId(handler); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), feature, handler); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), feature, handler); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -198,11 +193,11 @@ public class VMenuEditor extends AbstractComponentEditor { } protected void handleAddViewMenu() { - MMenu menu = MenuFactoryImpl.eINSTANCE.createMenu(); + final MMenu menu = MenuFactoryImpl.eINSTANCE.createMenu(); menu.getTags().add(VIEW_MENU_TAG); setElementId(menu); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), feature, menu); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), feature, menu); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -212,7 +207,7 @@ public class VMenuEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelFragmentsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelFragmentsEditor.java index 46a7d539..3f62ab43 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelFragmentsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelFragmentsEditor.java @@ -38,10 +38,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VModelFragmentsEditor extends AbstractComponentEditor { private Composite composite; @@ -66,11 +64,6 @@ public class VModelFragmentsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VModelFragmentsEditor_TreeLabel; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelImportsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelImportsEditor.java index 5b2b71c6..4e2fd716 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelImportsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VModelImportsEditor.java @@ -13,7 +13,9 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.List; + import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.core.contexts.IEclipseContext; @@ -40,10 +42,8 @@ import org.eclipse.jface.viewers.ViewerComparator; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VModelImportsEditor extends AbstractComponentEditor { private Composite composite; @@ -59,11 +59,6 @@ public class VModelImportsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VModelImportsEditor_TreeLabel; } @@ -84,34 +79,34 @@ public class VModelImportsEditor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); composite = folder; - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); - E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS) { + final E4PickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS) { @Override protected void addPressed() { - Object firstElement = ((IStructuredSelection) getSelection()).getFirstElement(); + final Object firstElement = ((IStructuredSelection) getSelection()).getFirstElement(); if (firstElement != null) { - FeatureClass featureClass = (FeatureClass) firstElement; - EClass eClass = featureClass.eClass; - EObject eObject = EcoreUtil.create(eClass); + final FeatureClass featureClass = (FeatureClass) firstElement; + final EClass eClass = featureClass.eClass; + final EObject eObject = EcoreUtil.create(eClass); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS, eObject); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -133,7 +128,7 @@ public class VModelImportsEditor extends AbstractComponentEditor { pickList.setLabelProvider(new LabelProvider() { @Override public String getText(Object element) { - FeatureClass eclass = (FeatureClass) element; + final FeatureClass eclass = (FeatureClass) element; return eclass.label; } }); @@ -141,13 +136,13 @@ public class VModelImportsEditor extends AbstractComponentEditor { pickList.setComparator(new ViewerComparator() { @Override public int compare(Viewer viewer, Object e1, Object e2) { - FeatureClass eClass1 = (FeatureClass) e1; - FeatureClass eClass2 = (FeatureClass) e2; + final FeatureClass eClass1 = (FeatureClass) e1; + final FeatureClass eClass2 = (FeatureClass) e2; return eClass1.label.compareTo(eClass2.label); } }); - List<FeatureClass> list = new ArrayList<FeatureClass>(); + final List<FeatureClass> list = new ArrayList<FeatureClass>(); Util.addClasses(ApplicationPackageImpl.eINSTANCE, list); list.addAll(getEditor().getFeatureClasses(FragmentPackageImpl.Literals.MODEL_FRAGMENT, FragmentPackageImpl.Literals.MODEL_FRAGMENTS__IMPORTS)); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPartDescriptor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPartDescriptor.java index 34478f62..97132846 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPartDescriptor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPartDescriptor.java @@ -14,8 +14,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.Arrays; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; @@ -41,17 +43,15 @@ import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VPartDescriptor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private TableViewer viewer; - private List<Action> actions = new ArrayList<Action>(); - private List<Action> actionsImport = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); + private final List<Action> actionsImport = new ArrayList<Action>(); @Inject public VPartDescriptor() { @@ -90,11 +90,6 @@ public class VPartDescriptor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VPartDescriptor_TreeLabel; } @@ -115,23 +110,23 @@ public class VPartDescriptor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); { - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, BasicPackageImpl.Literals.PART_DESCRIPTOR_CONTAINER__DESCRIPTORS) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, BasicPackageImpl.Literals.PART_DESCRIPTOR_CONTAINER__DESCRIPTORS) { @Override protected void addPressed() { handleAdd(); @@ -139,7 +134,7 @@ public class VPartDescriptor extends AbstractComponentEditor { @Override protected List<?> getContainerChildren(Object container) { - MPartDescriptorContainer c = (MPartDescriptorContainer) container; + final MPartDescriptorContainer c = (MPartDescriptorContainer) container; return c.getDescriptors(); } }; @@ -158,14 +153,14 @@ public class VPartDescriptor extends AbstractComponentEditor { } protected void handleAdd() { - MPartDescriptor partDescription = MBasicFactory.INSTANCE.createPartDescriptor(); + final MPartDescriptor partDescription = MBasicFactory.INSTANCE.createPartDescriptor(); addToModel(partDescription); } private void addToModel(MPartDescriptor partDescription) { setElementId(partDescription); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), BasicPackageImpl.Literals.PART_DESCRIPTOR_CONTAINER__DESCRIPTORS, partDescription); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), BasicPackageImpl.Literals.PART_DESCRIPTOR_CONTAINER__DESCRIPTORS, partDescription); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -176,11 +171,11 @@ public class VPartDescriptor extends AbstractComponentEditor { protected void handleImport(EClass eClass, String hint) { if (eClass == BasicPackageImpl.Literals.PART_DESCRIPTOR) { - ModelImportWizard wizard = new ModelImportWizard(MPartDescriptor.class, this, hint, resourcePool); - WizardDialog wizardDialog = new WizardDialog(viewer.getControl().getShell(), wizard); + final ModelImportWizard wizard = new ModelImportWizard(MPartDescriptor.class, this, hint, resourcePool); + final WizardDialog wizardDialog = new WizardDialog(viewer.getControl().getShell(), wizard); if (wizardDialog.open() == Window.OK) { - MPartDescriptor[] parts = (MPartDescriptor[]) wizard.getElements(MPartDescriptor.class); - for (MPartDescriptor part : parts) { + final MPartDescriptor[] parts = (MPartDescriptor[]) wizard.getElements(MPartDescriptor.class); + for (final MPartDescriptor part : parts) { addToModel(part); } } @@ -189,14 +184,14 @@ public class VPartDescriptor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } @Override public List<Action> getActionsImport(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActionsImport(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActionsImport(element)); l.addAll(actionsImport); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPerspectiveControlEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPerspectiveControlEditor.java index b174e765..0c871582 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPerspectiveControlEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VPerspectiveControlEditor.java @@ -13,8 +13,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; @@ -40,16 +42,14 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VPerspectiveControlEditor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private TableViewer viewer; - private List<Action> actions = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); @Inject public VPerspectiveControlEditor() { @@ -93,10 +93,6 @@ public class VPerspectiveControlEditor extends AbstractComponentEditor { }); } - @Override - public Image getImage(Object element, Display display) { - return null; - } @Override public String getLabel(Object element) { @@ -119,26 +115,26 @@ public class VPerspectiveControlEditor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); { - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN) { @Override protected void addPressed() { - EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); + final EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); handleAdd(eClass); } }; @@ -162,11 +158,11 @@ public class VPerspectiveControlEditor extends AbstractComponentEditor { } private void handleAdd(EClass eClass) { - EObject eObject = EcoreUtil.create(eClass); + final EObject eObject = EcoreUtil.create(eClass); setElementId(eObject); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), UiPackageImpl.Literals.ELEMENT_CONTAINER__CHILDREN, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -176,7 +172,7 @@ public class VPerspectiveControlEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VRootBindingContexts.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VRootBindingContexts.java index c0eacbd3..3e09e6df 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VRootBindingContexts.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VRootBindingContexts.java @@ -14,8 +14,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.Arrays; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; @@ -36,17 +38,15 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VRootBindingContexts extends AbstractComponentEditor { private Composite composite; private TableViewer viewer; private EMFDataBindingContext context; - private List<Action> actions = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); @Inject public VRootBindingContexts() { @@ -64,11 +64,6 @@ public class VRootBindingContexts extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VRootBindingContexts_TreeLabel; } @@ -89,23 +84,23 @@ public class VRootBindingContexts extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); { - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__ROOT_CONTEXT) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, Arrays.asList(PickListFeatures.NO_PICKER), Messages, this, CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__ROOT_CONTEXT) { @Override protected void addPressed() { handleAddContext(); @@ -126,10 +121,10 @@ public class VRootBindingContexts extends AbstractComponentEditor { } private void handleAddContext() { - MBindingContext context = MCommandsFactory.INSTANCE.createBindingContext(); + final MBindingContext context = MCommandsFactory.INSTANCE.createBindingContext(); setElementId(context); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__ROOT_CONTEXT, context); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), CommandsPackageImpl.Literals.BINDING_TABLE_CONTAINER__ROOT_CONTEXT, context); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -144,7 +139,7 @@ public class VRootBindingContexts extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VSnippetsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VSnippetsEditor.java index 3540865c..1c4e2aad 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VSnippetsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VSnippetsEditor.java @@ -36,10 +36,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VSnippetsEditor extends AbstractComponentEditor { private Composite composite; @@ -156,11 +154,6 @@ public class VSnippetsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VWindowControlEditor_TreeLabel; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VToolBarContributionsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VToolBarContributionsEditor.java index 39d6a578..c429a0ad 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VToolBarContributionsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VToolBarContributionsEditor.java @@ -38,10 +38,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VToolBarContributionsEditor extends AbstractComponentEditor { private Composite composite; @@ -66,11 +64,6 @@ public class VToolBarContributionsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VToolBarContributionsEditor_TreeLabel; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VTrimContributionsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VTrimContributionsEditor.java index 2588e523..84194caa 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VTrimContributionsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VTrimContributionsEditor.java @@ -38,10 +38,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VTrimContributionsEditor extends AbstractComponentEditor { private Composite composite; @@ -66,11 +64,6 @@ public class VTrimContributionsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VTrimContributionsEditor_TreeLabel; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowControlEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowControlEditor.java index 1a0753a7..e977593a 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowControlEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowControlEditor.java @@ -44,10 +44,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VWindowControlEditor extends AbstractComponentEditor { private Composite composite; @@ -114,11 +112,6 @@ public class VWindowControlEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VWindowControlEditor_TreeLabel; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowEditor.java index 9a5c0bec..74c943b3 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowEditor.java @@ -13,7 +13,9 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.List; + import javax.annotation.PostConstruct; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.tools.emf.ui.common.component.AbstractComponentEditor; @@ -38,17 +40,15 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public abstract class VWindowEditor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private TableViewer viewer; - private List<Action> actions = new ArrayList<Action>(); - private EStructuralFeature targetFeature; + private final List<Action> actions = new ArrayList<Action>(); + private final EStructuralFeature targetFeature; public VWindowEditor(EStructuralFeature targetFeature) { super(); @@ -84,11 +84,6 @@ public abstract class VWindowEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VWindowEditor_TreeLabel; } @@ -109,25 +104,25 @@ public abstract class VWindowEditor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); item.setControl(parent.getParent()); - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, targetFeature) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, targetFeature) { @Override protected void addPressed() { - EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); + final EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); handleAdd(eClass); } @@ -176,16 +171,16 @@ public abstract class VWindowEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } protected void handleAdd(EClass eClass) { - EObject handler = EcoreUtil.create(eClass); + final EObject handler = EcoreUtil.create(eClass); setElementId(handler); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), targetFeature, handler); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), targetFeature, handler); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowSharedElementsEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowSharedElementsEditor.java index 4d8e1ea0..277a5f7e 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowSharedElementsEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowSharedElementsEditor.java @@ -14,8 +14,10 @@ package org.eclipse.e4.tools.emf.ui.internal.common.component.virtual; import java.util.ArrayList; import java.util.List; + import javax.annotation.PostConstruct; import javax.inject.Inject; + import org.eclipse.core.databinding.observable.list.IObservableList; import org.eclipse.core.databinding.observable.value.WritableValue; import org.eclipse.e4.core.contexts.IEclipseContext; @@ -48,17 +50,15 @@ import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VWindowSharedElementsEditor extends AbstractComponentEditor { private Composite composite; private EMFDataBindingContext context; private StructuredViewer viewer; - private List<Action> actions = new ArrayList<Action>(); - private List<Action> actionsImport = new ArrayList<Action>(); + private final List<Action> actions = new ArrayList<Action>(); + private final List<Action> actionsImport = new ArrayList<Action>(); @Inject IEclipseContext eclipseContext; @@ -122,11 +122,6 @@ public class VWindowSharedElementsEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VWindowSharedElementsEditor_TreeLabel; } @@ -147,16 +142,16 @@ public class VWindowSharedElementsEditor extends AbstractComponentEditor { context = new EMFDataBindingContext(); composite = createForm(parent, context, getMaster()); } - VirtualEntry<?> o = (VirtualEntry<?>) object; + final VirtualEntry<?> o = (VirtualEntry<?>) object; viewer.setInput(o.getList()); getMaster().setValue(o.getOriginalParent()); return composite; } private Composite createForm(Composite parent, EMFDataBindingContext context, WritableValue master) { - CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); + final CTabFolder folder = new CTabFolder(parent, SWT.BOTTOM); - CTabItem item = new CTabItem(folder, SWT.NONE); + final CTabItem item = new CTabItem(folder, SWT.NONE); item.setText(Messages.ModelTooling_Common_TabDefault); parent = createScrollableContainer(folder); @@ -164,10 +159,10 @@ public class VWindowSharedElementsEditor extends AbstractComponentEditor { { - AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, BasicPackageImpl.Literals.WINDOW__SHARED_ELEMENTS) { + final AbstractPickList pickList = new E4PickList(parent, SWT.NONE, null, Messages, this, BasicPackageImpl.Literals.WINDOW__SHARED_ELEMENTS) { @Override protected void addPressed() { - EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); + final EClass eClass = (EClass) ((IStructuredSelection) getSelection()).getFirstElement(); handleAdd(eClass); } @@ -179,7 +174,7 @@ public class VWindowSharedElementsEditor extends AbstractComponentEditor { pickList.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true, 3, 1)); viewer = pickList.getList(); - IEMFEditListProperty prop = EMFEditProperties.list(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__SHARED_ELEMENTS); + final IEMFEditListProperty prop = EMFEditProperties.list(getEditingDomain(), BasicPackageImpl.Literals.WINDOW__SHARED_ELEMENTS); viewer.setInput(prop.observeDetail(getMaster())); pickList.setLabelProvider(new EClassLabelProvider(getEditor())); @@ -198,14 +193,14 @@ public class VWindowSharedElementsEditor extends AbstractComponentEditor { } protected void handleAdd(EClass eClass) { - EObject eObject = EcoreUtil.create(eClass); + final EObject eObject = EcoreUtil.create(eClass); addToModel(eObject); } private void addToModel(EObject eObject) { setElementId(eObject); - Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), BasicPackageImpl.Literals.WINDOW__SHARED_ELEMENTS, eObject); + final Command cmd = AddCommand.create(getEditingDomain(), getMaster().getValue(), BasicPackageImpl.Literals.WINDOW__SHARED_ELEMENTS, eObject); if (cmd.canExecute()) { getEditingDomain().getCommandStack().execute(cmd); @@ -215,11 +210,11 @@ public class VWindowSharedElementsEditor extends AbstractComponentEditor { protected void handleImport(EClass eClass, String hint) { if (eClass == BasicPackageImpl.Literals.PART) { - ModelImportWizard wizard = new ModelImportWizard(MPart.class, this, hint, resourcePool); - WizardDialog wizardDialog = new WizardDialog(viewer.getControl().getShell(), wizard); + final ModelImportWizard wizard = new ModelImportWizard(MPart.class, this, hint, resourcePool); + final WizardDialog wizardDialog = new WizardDialog(viewer.getControl().getShell(), wizard); if (wizardDialog.open() == Window.OK) { - MPart[] parts = (MPart[]) wizard.getElements(MPart.class); - for (MPart part : parts) { + final MPart[] parts = (MPart[]) wizard.getElements(MPart.class); + for (final MPart part : parts) { addToModel((EObject) part); } } @@ -228,14 +223,14 @@ public class VWindowSharedElementsEditor extends AbstractComponentEditor { @Override public List<Action> getActions(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActions(element)); l.addAll(actions); return l; } @Override public List<Action> getActionsImport(Object element) { - ArrayList<Action> l = new ArrayList<Action>(super.getActionsImport(element)); + final ArrayList<Action> l = new ArrayList<Action>(super.getActionsImport(element)); l.addAll(actionsImport); return l; } diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowTrimEditor.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowTrimEditor.java index bd9f1e2d..d0ef5796 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowTrimEditor.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/virtual/VWindowTrimEditor.java @@ -38,10 +38,8 @@ import org.eclipse.jface.viewers.TableViewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabItem; -import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; -import org.eclipse.swt.widgets.Display; public class VWindowTrimEditor extends AbstractComponentEditor { private Composite composite; @@ -66,11 +64,6 @@ public class VWindowTrimEditor extends AbstractComponentEditor { } @Override - public Image getImage(Object element, Display display) { - return null; - } - - @Override public String getLabel(Object element) { return Messages.VWindowTrimEditor_TreeLabel; } |