From fcb702818ec1dee00c5af2fe745e30355e039dc0 Mon Sep 17 00:00:00 2001 From: Marco Descher Date: Mon, 18 Mar 2013 12:54:32 -0400 Subject: Bug 403433 - Fix for Bug397677 does not consider logger being optional --- .../e4/ui/workbench/renderers/swt/HandledContributionItem.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/HandledContributionItem.java b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/HandledContributionItem.java index ef1baf0d727..89db4262093 100644 --- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/HandledContributionItem.java +++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/HandledContributionItem.java @@ -280,8 +280,11 @@ public class HandledContributionItem extends ContributionItem { model = item; setId(model.getElementId()); generateCommand(); - if (model.getCommand() == null) - logger.error("Element " + model.getElementId() + " invalid, no command defined."); //$NON-NLS-1$ //$NON-NLS-2$ + if (model.getCommand() == null) { + if (logger != null) { + logger.error("Element " + model.getElementId() + " invalid, no command defined."); //$NON-NLS-1$ //$NON-NLS-2$ + } + } updateVisible(); } -- cgit v1.2.3