Bug 196856 [EditorMgmt] 'Switch to Editor' dialog should persist dialog bounds even if the dialog has been closed regularly

1 files changed, 5 insertions, 2 deletions

diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkbenchEditorsDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkbenchEditorsDialog.java
index 5e95035..71ed94a 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkbenchEditorsDialog.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkbenchEditorsDialog.java
@@ -617,8 +617,6 @@ public class WorkbenchEditorsDialog extends SelectionDialog {
             return;
         }
 
-        saveDialogSettings();
-
         Adapter selection = (Adapter) items[0].getData();
         //It would be better to activate before closing the
         //dialog but it does not work when the editor is in other
@@ -627,6 +625,11 @@ public class WorkbenchEditorsDialog extends SelectionDialog {
         selection.activate();
     }
 
+	public boolean close() {
+		saveDialogSettings();
+		return super.close();
+	}
+
     /**
      * Saves the dialog settings.
      */