Fixes suggested by FindBugs:

* StringBuilder instead of String "+" (performances)
* Removed useless instanceof

Signed-off-by: Mickael Istria <mistria@redhat.com>
Change-Id: I1684e140863b08abf5432f617ada9b6f996334a9

2 files changed, 12 insertions, 12 deletions

diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java
index 0f439228db1..42ff07a0a02 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2012 Angelo Zerr and others.
+ * Copyright (c) 2008, 2013 Angelo Zerr and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -8,6 +8,7 @@
  * Contributors:
  *     Angelo Zerr <angelo.zerr@gmail.com> - initial API and implementation
  *     IBM Corporation - ongoing development
+ *     Red Hat Inc. (mistria) - Fixes suggested by FindBugs
  *******************************************************************************/
 package org.eclipse.e4.ui.css.core.dom.properties.providers;
 
@@ -131,15 +132,15 @@ public class CSSPropertyHandlerLazyProviderImpl extends
 	 * @return
 	 */
 	protected String getHandlerClassName(String property) {
-		String handlerClassName = "CSSProperty";
-		String[] s = StringUtils.split(property, "-");
+		StringBuilder handlerClassName = new StringBuilder("CSSProperty"); //$NON-NLS-1$
+		String[] s = StringUtils.split(property, "-"); //$NON-NLS-1$
 		for (int i = 0; i < s.length; i++) {
 			String p = s[i];
-			p = p.substring(0, 1).toUpperCase() + p.substring(1, p.length());
-			handlerClassName += p;
+			handlerClassName.append(p.substring(0, 1).toUpperCase());
+			handlerClassName.append(p.substring(1));
 		}
-		handlerClassName += "Handler";
-		return handlerClassName;
+		handlerClassName.append("Handler"); //$NON-NLS-1$
+		return handlerClassName.toString();
 	}
 
 	/*
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java
index 2c130e3918b..d5670e46fa2 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2012 Angelo Zerr and others.
+ * Copyright (c) 2008, 2013 Angelo Zerr and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -8,6 +8,7 @@
  * Contributors:
  *     Angelo Zerr <angelo.zerr@gmail.com> - initial API and implementation
  *     IBM Corporation - ongoing development
+ *     Red Hat Inc. (mistria) - Fixes suggested by FindBugs
  *******************************************************************************/
 package org.eclipse.e4.ui.css.core.impl.engine;
 
@@ -222,10 +223,8 @@ public abstract class AbstractCSSEngine implements CSSEngine {
 		//final stylesheet
 		CSSStyleSheetImpl s = new CSSStyleSheetImpl();
 		s.setRuleList(masterList);
-		if (documentCSS instanceof ExtendedDocumentCSS) {
-			if (!parseImport) {
-				documentCSS.addStyleSheet(s);
-			}
+		if (!parseImport) {
+			documentCSS.addStyleSheet(s);
 		}
 		return s;
 	}