summaryrefslogtreecommitdiffstatsabout
diff options
context:
space:
mode:
authorKaren Butzke2012-09-24 07:49:33 (EDT)
committer Paul Webster2012-09-24 07:49:33 (EDT)
commit5eebee131d1a422b291cd7b7115c76459f99da39 (patch)
tree21bb90349d5fd2dae64208be4cc4960634f1224b
parentc50d62e0e5dbd753e6560440392780b7fdcd6707 (diff)
downloadeclipse.platform.ui-5eebee131d1a422b291cd7b7115c76459f99da39.zip
eclipse.platform.ui-5eebee131d1a422b291cd7b7115c76459f99da39.tar.gz
eclipse.platform.ui-5eebee131d1a422b291cd7b7115c76459f99da39.tar.bz2
Bug 390050 - Quick Access performance could be improved
Don't call out to a method twice that can do calculations.
-rw-r--r--bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/WorkbenchActivityHelper.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/WorkbenchActivityHelper.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/WorkbenchActivityHelper.java
index f786c13..ed98b5b 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/WorkbenchActivityHelper.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/WorkbenchActivityHelper.java
@@ -177,8 +177,9 @@ public final class WorkbenchActivityHelper {
* @return the unified id
*/
public static final String createUnifiedId(IPluginContribution contribution) {
- if (contribution.getPluginId() != null) {
- return contribution.getPluginId() + '/' + contribution.getLocalId();
+ final String pluginId = contribution.getPluginId();
+ if (pluginId != null) {
+ return pluginId + '/' + contribution.getLocalId();
}
return contribution.getLocalId();
}