Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2013-11-12 22:37:00 +0000
committerLars Vogel2013-11-12 22:37:00 +0000
commit56baf71c47432dbacee1e55e5f2ef681af4f5d42 (patch)
tree9fceeaa118c03f699729566066f2900b87e35a8f
parente87fdf2a88174651d15643dc17f69324d89175f0 (diff)
downloadeclipse.platform.ui-56baf71c47432dbacee1e55e5f2ef681af4f5d42.tar.gz
eclipse.platform.ui-56baf71c47432dbacee1e55e5f2ef681af4f5d42.tar.xz
eclipse.platform.ui-56baf71c47432dbacee1e55e5f2ef681af4f5d42.zip
Bug 414565 - [JFace][snippets] Update JFace snippets general cleanup
Change-Id: Ia98901073ee6ce02f4e9e25d8bf84557b6a8af68 Signed-off-by: Lars Vogel <Lars.Vogel@gmail.com>
-rw-r--r--examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet001TableViewer.java2
-rw-r--r--examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet005TreeCustomMenu.java3
-rw-r--r--examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java49
3 files changed, 7 insertions, 47 deletions
diff --git a/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet001TableViewer.java b/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet001TableViewer.java
index 50c67a377ed..cf3e929826d 100644
--- a/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet001TableViewer.java
+++ b/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet001TableViewer.java
@@ -7,7 +7,7 @@
*
* Contributors:
* Tom Schindl <tom.schindl@bestsolution.at> - initial API and implementation
- * Lars Vogel <Lars.Vogel@gmail.com> -
+ * Lars Vogel <Lars.Vogel@gmail.com> - Bug 414565
*******************************************************************************/
package org.eclipse.jface.snippets.viewers;
diff --git a/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet005TreeCustomMenu.java b/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet005TreeCustomMenu.java
index ffa7895028c..3bb7b254280 100644
--- a/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet005TreeCustomMenu.java
+++ b/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet005TreeCustomMenu.java
@@ -109,9 +109,6 @@ public class Snippet005TreeCustomMenu {
mgr.addMenuListener(new IMenuListener() {
- /* (non-Javadoc)
- * @see org.eclipse.jface.action.IMenuListener#menuAboutToShow(org.eclipse.jface.action.IMenuManager)
- */
@Override
public void menuAboutToShow(IMenuManager manager) {
IStructuredSelection selection = (IStructuredSelection) v
diff --git a/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java b/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java
index 0f26c0aa7f0..df1501270d0 100644
--- a/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java
+++ b/examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java
@@ -7,17 +7,17 @@
*
* Contributors:
* Hendrik Still<hendrik.still@gammas.de> - initial implementation
+ * Lars Vogel <lars.vogel@gmail.com> - Bug 414565
*******************************************************************************/
package org.eclipse.jface.snippets.viewers;
import org.eclipse.jface.layout.GridLayoutFactory;
import org.eclipse.jface.layout.LayoutConstants;
+import org.eclipse.jface.viewers.ArrayContentProvider;
import org.eclipse.jface.viewers.ComboViewer;
-import org.eclipse.jface.viewers.IStructuredContentProvider;
import org.eclipse.jface.viewers.LabelProvider;
import org.eclipse.jface.viewers.StructuredSelection;
-import org.eclipse.jface.viewers.Viewer;
import org.eclipse.swt.SWT;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Label;
@@ -25,45 +25,10 @@ import org.eclipse.swt.widgets.Shell;
/**
* A simple ComboViewer to demonstrate usage
- *
- * @author Hendrik Still <hendrik.still@gammas.de>
- *
+ *
*/
-public class Snippet063ComboViewer {
- private class MyContentProvider implements IStructuredContentProvider {
-
- /*
- * (non-Javadoc)
- *
- * @see
- * org.eclipse.jface.viewers.IStructuredContentProvider#getElements(
- * java.lang.Object)
- */
- public Object[] getElements(Object inputElement) {
- return (MyModel[]) inputElement;
- }
-
- /*
- * (non-Javadoc)
- *
- * @see org.eclipse.jface.viewers.IContentProvider#dispose()
- */
- public void dispose() {
-
- }
- /*
- * (non-Javadoc)
- *
- * @see
- * org.eclipse.jface.viewers.IContentProvider#inputChanged(org.eclipse
- * .jface.viewers.Viewer, java.lang.Object, java.lang.Object)
- */
- public void inputChanged(Viewer viewer, Object oldInput, Object newInput) {
-
- }
-
- }
+public class Snippet063ComboViewer {
public class MyModel {
public int counter;
@@ -72,6 +37,7 @@ public class Snippet063ComboViewer {
this.counter = counter;
}
+ @Override
public String toString() {
return "Item " + this.counter;
}
@@ -86,7 +52,7 @@ public class Snippet063ComboViewer {
l.setText("Choose Item:");
final ComboViewer v = new ComboViewer(shell);
v.setLabelProvider(new LabelProvider());
- v.setContentProvider(new MyContentProvider());
+ v.setContentProvider(ArrayContentProvider.getInstance());
MyModel[] model = createModel();
v.setInput(model);
@@ -108,9 +74,6 @@ public class Snippet063ComboViewer {
return elements;
}
- /**
- * @param args
- */
public static void main(String[] args) {
Display display = new Display();
Shell shell = new Shell(display);

Back to the top