Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Bumann2015-09-18 17:37:54 +0000
committerLars Vogel2015-09-18 19:11:52 +0000
commit1e3b606a94b73aa2f11acb728f8bfe47c85100d3 (patch)
tree1c9ee285688203dddfd7da48dd7c09a05283aba4
parent676fc45f8eedec9aa361fae20acd5ba3ea2c0b73 (diff)
downloadeclipse.platform.ui-1e3b606a94b73aa2f11acb728f8bfe47c85100d3.tar.gz
eclipse.platform.ui-1e3b606a94b73aa2f11acb728f8bfe47c85100d3.tar.xz
eclipse.platform.ui-1e3b606a94b73aa2f11acb728f8bfe47c85100d3.zip
Bug 477602 - Unnecessary cast in org.eclipse.e4.ui.progress
Change-Id: Ice5bda2b770fc75505dfbd6954c9ce4c8ddd4ca7 Signed-off-by: Philipp Bumann<bumannp@gmail.com>
-rw-r--r--bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java4
-rw-r--r--bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressAnimationItem.java3
-rw-r--r--bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java4
-rw-r--r--bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressServiceImpl.java4
-rw-r--r--bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressViewUpdater.java7
5 files changed, 11 insertions, 11 deletions
diff --git a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java
index 1132d8fa3d2..509b0125717 100644
--- a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java
+++ b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java
@@ -7,6 +7,7 @@
*
* Contributors:
* IBM Corporation - initial API and implementation
+ * Philipp Bumann <bumannp@gmail.com> - Bug 477602
*******************************************************************************/
package org.eclipse.e4.ui.progress.internal;
@@ -306,8 +307,7 @@ public class FinishedJobs extends EventManager {
if (job != null) {
IStatus status = job.getResult();
if (status != null && status.getSeverity() == IStatus.ERROR) {
- JobTreeElement topElement = (JobTreeElement) info1
- .getParent();
+ JobTreeElement topElement = info1.getParent();
if (topElement == null) {
topElement = info1;
}
diff --git a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressAnimationItem.java b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressAnimationItem.java
index a3fd627d84e..da970f72506 100644
--- a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressAnimationItem.java
+++ b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressAnimationItem.java
@@ -7,6 +7,7 @@
*
* Contributors:
* IBM Corporation - initial API and implementation
+ * Philipp Bumann <bumannp@gmail.com> - Bug 477602
*******************************************************************************/
package org.eclipse.e4.ui.progress.internal;
@@ -158,7 +159,7 @@ public class ProgressAnimationItem extends AnimationItem implements
* @param ji
*/
private void removeTopElement(JobInfo ji) {
- JobTreeElement topElement = (JobTreeElement) ji.getParent();
+ JobTreeElement topElement = ji.getParent();
if (topElement == null) {
topElement = ji;
}
diff --git a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java
index bbdde727b16..67ddc6c92f3 100644
--- a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java
+++ b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java
@@ -10,6 +10,7 @@
* Teddy Walker <teddy.walker@googlemail.com>
* - Fix for Bug 151204 [Progress] Blocked status of jobs are not applied/reported
* Lars Vogel <Lars.Vogel@gmail.com> - Bug 422040
+ * Philipp Bumann <bumannp@gmail.com> - Bug 477602
*******************************************************************************/
package org.eclipse.e4.ui.progress.internal;
@@ -403,8 +404,7 @@ public class ProgressManager extends ProgressProvider {
Iterator<IJobBusyListener> startListeners = busyListenersForJob(event.getJob())
.iterator();
while (startListeners.hasNext()) {
- IJobBusyListener next = (IJobBusyListener) startListeners
- .next();
+ IJobBusyListener next = startListeners.next();
next.incrementBusy(event.getJob());
}
}
diff --git a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressServiceImpl.java b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressServiceImpl.java
index e5c6cc46844..fd4dd9ed516 100644
--- a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressServiceImpl.java
+++ b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressServiceImpl.java
@@ -7,6 +7,7 @@
*
* Contributors:
* IBM Corporation - initial API and implementation
+ * Philipp Bumann <bumannp@gmail.com> - Bug 477602
******************************************************************************/
package org.eclipse.e4.ui.progress.internal;
@@ -115,8 +116,7 @@ public class ProgressServiceImpl implements IProgressService {
while (families.hasMoreElements()) {
Object next = families.nextElement();
if (job.belongsTo(next)) {
- return JFaceResources.getImageRegistry().get(
- (String) imageKeyTable.get(next));
+ return JFaceResources.getImageRegistry().get(imageKeyTable.get(next));
}
}
return null;
diff --git a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressViewUpdater.java b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressViewUpdater.java
index fbb6e62d925..a065c552df2 100644
--- a/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressViewUpdater.java
+++ b/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressViewUpdater.java
@@ -7,6 +7,7 @@
*
* Contributors:
* IBM Corporation - initial API and implementation
+ * Philipp Bumann <bumannp@gmail.com> - Bug 477602
*******************************************************************************/
package org.eclipse.e4.ui.progress.internal;
@@ -117,8 +118,7 @@ public class ProgressViewUpdater implements IJobProgressManagerListener {
Iterator<JobTreeElement> additionsIterator = additions.iterator();
while (additionsIterator.hasNext()) {
- JobTreeElement treeElement = (JobTreeElement) additionsIterator
- .next();
+ JobTreeElement treeElement = additionsIterator.next();
if (!treeElement.isActive()) {
if (deletions.contains(treeElement)) {
staleAdditions.add(treeElement);
@@ -131,8 +131,7 @@ public class ProgressViewUpdater implements IJobProgressManagerListener {
HashSet<JobTreeElement> obsoleteRefresh = new HashSet<>();
Iterator<JobTreeElement> refreshIterator = refreshes.iterator();
while (refreshIterator.hasNext()) {
- JobTreeElement treeElement = (JobTreeElement) refreshIterator
- .next();
+ JobTreeElement treeElement = refreshIterator.next();
if (deletions.contains(treeElement)
|| additions.contains(treeElement)) {
obsoleteRefresh.add(treeElement);

Back to the top