aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLouis-Michel Mathurin2014-03-18 23:33:38 (EDT)
committerPaul Webster2014-03-19 00:18:22 (EDT)
commit1112f01ddfb92605fb2dbdced050539e95981953 (patch)
tree95667a54e27a3f69addf51a232b7699c9da3e873
parent74f5a45cf82d7e23d1718437b6ccd8333f66f57f (diff)
downloadeclipse.platform.ui-1112f01ddfb92605fb2dbdced050539e95981953.zip
eclipse.platform.ui-1112f01ddfb92605fb2dbdced050539e95981953.tar.gz
eclipse.platform.ui-1112f01ddfb92605fb2dbdced050539e95981953.tar.bz2
Bug 425962 - [New Contributors] Remove (non-Javadoc) @see statements ifrefs/changes/78/23578/2
@Override is used Change-Id: I8c22b49aa13c35303915e9e0294851a623d60ffa Signed-off-by: Louis-Michel Mathurin <mathurin.lm@agiledss.com>
-rw-r--r--bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/BindingServiceImpl.java80
-rw-r--r--bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/keys/CancelOnModifyListener.java6
2 files changed, 13 insertions, 73 deletions
diff --git a/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/BindingServiceImpl.java b/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/BindingServiceImpl.java
index 9d5f11e..f8b50d6 100644
--- a/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/BindingServiceImpl.java
+++ b/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/BindingServiceImpl.java
@@ -48,13 +48,7 @@ public class BindingServiceImpl implements EBindingService {
private ContextSet contextSet = ContextSet.EMPTY;
- /*
- * (non-Javadoc)
- *
- * @see org.eclipse.e4.ui.bindings.EBindingService#createBinding(org.eclipse.jface.bindings.
- * TriggerSequence, org.eclipse.core.commands.ParameterizedCommand, java.lang.String,
- * java.lang.String, java.util.Map)
- */
+ @Override
public Binding createBinding(TriggerSequence sequence, ParameterizedCommand command,
String contextId, Map<String, String> attributes) {
@@ -81,13 +75,7 @@ public class BindingServiceImpl implements EBindingService {
return null;
}
- /*
- * (non-Javadoc)
- *
- * @see
- * org.eclipse.e4.ui.bindings.EBindingService#activateBinding(org.eclipse.jface.bindings.Binding
- * )
- */
+ @Override
public void activateBinding(Binding binding) {
String contextId = binding.getContextId();
BindingTable table = manager.getTable(contextId);
@@ -97,13 +85,7 @@ public class BindingServiceImpl implements EBindingService {
table.addBinding(binding);
}
- /*
- * (non-Javadoc)
- *
- * @see
- * org.eclipse.e4.ui.bindings.EBindingService#deactivateBinding(org.eclipse.jface.bindings.Binding
- * )
- */
+ @Override
public void deactivateBinding(Binding binding) {
String contextId = binding.getContextId();
BindingTable table = manager.getTable(contextId);
@@ -114,11 +96,7 @@ public class BindingServiceImpl implements EBindingService {
table.removeBinding(binding);
}
- /*
- * (non-Javadoc)
- *
- * @see org.eclipse.e4.ui.bindings.EBindingService#createSequence(java.lang.String)
- */
+ @Override
public TriggerSequence createSequence(String sequence) {
try {
return KeySequence.getInstance(sequence);
@@ -128,12 +106,7 @@ public class BindingServiceImpl implements EBindingService {
return null;
}
- /*
- * (non-Javadoc)
- *
- * @seeorg.eclipse.e4.ui.bindings.EBindingService#getConflictsFor(org.eclipse.e4.ui.bindings.
- * TriggerSequence)
- */
+ @Override
public Collection<Binding> getConflictsFor(TriggerSequence sequence) {
return manager.getConflictsFor(contextSet, sequence);
}
@@ -142,43 +115,23 @@ public class BindingServiceImpl implements EBindingService {
return manager.getAllConflicts();
}
- /*
- * (non-Javadoc)
- *
- * @seeorg.eclipse.e4.ui.bindings.EBindingService#getPerfectMatch(org.eclipse.e4.ui.bindings.
- * TriggerSequence)
- */
+ @Override
public Binding getPerfectMatch(TriggerSequence trigger) {
return manager.getPerfectMatch(contextSet, trigger);
}
- /*
- * (non-Javadoc)
- *
- * @seeorg.eclipse.e4.ui.bindings.EBindingService#isPartialMatch(org.eclipse.e4.ui.bindings.
- * TriggerSequence)
- */
+ @Override
public boolean isPartialMatch(TriggerSequence keySequence) {
return manager.isPartialMatch(contextSet, keySequence);
}
- /*
- * (non-Javadoc)
- *
- * @seeorg.eclipse.e4.ui.bindings.EBindingService#getBestSequenceFor(org.eclipse.core.commands.
- * ParameterizedCommand)
- */
+ @Override
public TriggerSequence getBestSequenceFor(ParameterizedCommand command) {
Binding binding = manager.getBestSequenceFor(contextSet, command);
return binding == null ? null : binding.getTriggerSequence();
}
- /*
- * (non-Javadoc)
- *
- * @seeorg.eclipse.e4.ui.bindings.EBindingService#getSequencesFor(org.eclipse.core.commands.
- * ParameterizedCommand)
- */
+ @Override
public Collection<TriggerSequence> getSequencesFor(ParameterizedCommand command) {
Collection<Binding> bindings = manager.getSequencesFor(contextSet, command);
ArrayList<TriggerSequence> sequences = new ArrayList<TriggerSequence>(bindings.size());
@@ -192,22 +145,12 @@ public class BindingServiceImpl implements EBindingService {
return manager.getBindingsFor(contextSet, command);
}
- /*
- * (non-Javadoc)
- *
- * @seeorg.eclipse.e4.ui.bindings.EBindingService#isPerfectMatch(org.eclipse.e4.ui.bindings.
- * TriggerSequence)
- */
+ @Override
public boolean isPerfectMatch(TriggerSequence sequence) {
return getPerfectMatch(sequence) != null;
}
- /*
- * (non-Javadoc)
- *
- * @seeorg.eclipse.e4.ui.bindings.EBindingService#getPartialMatches(org.eclipse.e4.ui.bindings.
- * TriggerSequence)
- */
+ @Override
public Collection<Binding> getPartialMatches(TriggerSequence sequence) {
return manager.getPartialMatches(contextSet, sequence);
}
@@ -232,6 +175,7 @@ public class BindingServiceImpl implements EBindingService {
contextSet = manager.createContextSet(contexts);
}
+ @Override
public Collection<Binding> getActiveBindings() {
return manager.getActiveBindings();
}
diff --git a/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/keys/CancelOnModifyListener.java b/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/keys/CancelOnModifyListener.java
index cbd9e57..50dbb33 100644
--- a/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/keys/CancelOnModifyListener.java
+++ b/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/keys/CancelOnModifyListener.java
@@ -40,11 +40,7 @@ final class CancelOnModifyListener implements Listener {
chainedListener = listener;
}
- /*
- * (non-Javadoc)
- *
- * @see org.eclipse.swt.widgets.Listener#handleEvent(org.eclipse.swt.widgets.Event)
- */
+ @Override
public void handleEvent(Event event) {
Widget widget = event.widget;
widget.removeListener(SWT.Modify, this);