Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeanderson Candido2014-02-28 23:31:53 +0000
committerJeanderson Candido2014-02-28 23:31:53 +0000
commitb0173b10befc7bddd922522268c97cf070643dc8 (patch)
tree54a38abd52a8e7de2b3c6d9a5de6dd6852e7470b
parent281074c0a2ce5a6ce90dbc2e8eff0fad004ce18a (diff)
downloadeclipse.platform.ui-b0173b10befc7bddd922522268c97cf070643dc8.tar.gz
eclipse.platform.ui-b0173b10befc7bddd922522268c97cf070643dc8.tar.xz
eclipse.platform.ui-b0173b10befc7bddd922522268c97cf070643dc8.zip
Bug 425962 - [New Contributors] Remove (non-Javadoc) statements if
@Override is used Removed unnecessary javadoc on the following classes: - preference/PreferenceStore.java - viewers/deferred/BackgroundContentProvider.java - viewers/deferred/DeferredContentProvider.java - viewers/deferred/SetModel.java Change-Id: Ibfabe232769a59f7e8a82ef2dab02257554ac522 Signed-off-by: Jeanderson Candido <jeandersonbc@gmail.com>
-rw-r--r--bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceStore.java96
-rw-r--r--bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java17
-rw-r--r--bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/DeferredContentProvider.java30
-rw-r--r--bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/SetModel.java3
4 files changed, 3 insertions, 143 deletions
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceStore.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceStore.java
index 0ce0cea4c7c..cf6e91d9892 100644
--- a/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceStore.java
+++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceStore.java
@@ -102,26 +102,17 @@ public class PreferenceStore extends EventManager implements
this.filename = filename;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void addPropertyChangeListener(IPropertyChangeListener listener) {
addListenerObject(listener);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public boolean contains(String name) {
return (properties.containsKey(name) || defaultProperties
.containsKey(name));
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void firePropertyChangeEvent(String name, Object oldValue,
Object newValue) {
@@ -144,9 +135,6 @@ public class PreferenceStore extends EventManager implements
}
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public boolean getBoolean(String name) {
return getBoolean(properties, name);
@@ -170,57 +158,36 @@ public class PreferenceStore extends EventManager implements
return false;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public boolean getDefaultBoolean(String name) {
return getBoolean(defaultProperties, name);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public double getDefaultDouble(String name) {
return getDouble(defaultProperties, name);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public float getDefaultFloat(String name) {
return getFloat(defaultProperties, name);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public int getDefaultInt(String name) {
return getInt(defaultProperties, name);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public long getDefaultLong(String name) {
return getLong(defaultProperties, name);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public String getDefaultString(String name) {
return getString(defaultProperties, name);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public double getDouble(String name) {
return getDouble(properties, name);
@@ -246,9 +213,6 @@ public class PreferenceStore extends EventManager implements
return ival;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public float getFloat(String name) {
return getFloat(properties, name);
@@ -274,9 +238,6 @@ public class PreferenceStore extends EventManager implements
return ival;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public int getInt(String name) {
return getInt(properties, name);
@@ -302,9 +263,6 @@ public class PreferenceStore extends EventManager implements
return ival;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public long getLong(String name) {
return getLong(properties, name);
@@ -338,9 +296,6 @@ public class PreferenceStore extends EventManager implements
return ival;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public String getString(String name) {
return getString(properties, name);
@@ -369,9 +324,6 @@ public class PreferenceStore extends EventManager implements
return value;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public boolean isDefault(String name) {
return (!properties.containsKey(name) && defaultProperties
@@ -429,9 +381,6 @@ public class PreferenceStore extends EventManager implements
dirty = false;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public boolean needsSaving() {
return dirty;
@@ -452,9 +401,6 @@ public class PreferenceStore extends EventManager implements
return list.toArray(new String[list.size()]);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void putValue(String name, String value) {
String oldValue = getString(name);
@@ -464,9 +410,6 @@ public class PreferenceStore extends EventManager implements
}
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void removePropertyChangeListener(IPropertyChangeListener listener) {
removeListenerObject(listener);
@@ -511,49 +454,31 @@ public class PreferenceStore extends EventManager implements
dirty = false;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setDefault(String name, double value) {
setValue(defaultProperties, name, value);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setDefault(String name, float value) {
setValue(defaultProperties, name, value);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setDefault(String name, int value) {
setValue(defaultProperties, name, value);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setDefault(String name, long value) {
setValue(defaultProperties, name, value);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setDefault(String name, String value) {
setValue(defaultProperties, name, value);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setDefault(String name, boolean value) {
setValue(defaultProperties, name, value);
@@ -576,9 +501,6 @@ public class PreferenceStore extends EventManager implements
filename = name;
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setToDefault(String name) {
if (!properties.containsKey(name))
@@ -593,9 +515,6 @@ public class PreferenceStore extends EventManager implements
firePropertyChangeEvent(name, oldValue, newValue);
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setValue(String name, double value) {
double oldValue = getDouble(name);
@@ -607,9 +526,6 @@ public class PreferenceStore extends EventManager implements
}
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setValue(String name, float value) {
float oldValue = getFloat(name);
@@ -620,9 +536,6 @@ public class PreferenceStore extends EventManager implements
}
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setValue(String name, int value) {
int oldValue = getInt(name);
@@ -634,9 +547,6 @@ public class PreferenceStore extends EventManager implements
}
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setValue(String name, long value) {
long oldValue = getLong(name);
@@ -647,9 +557,6 @@ public class PreferenceStore extends EventManager implements
}
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setValue(String name, String value) {
String oldValue = getString(name);
@@ -660,9 +567,6 @@ public class PreferenceStore extends EventManager implements
}
}
- /*
- * (non-Javadoc) Method declared on IPreferenceStore.
- */
@Override
public void setValue(String name, boolean value) {
boolean oldValue = getBoolean(name);
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java
index afacf709b8c..01c110e73e2 100644
--- a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java
+++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java
@@ -27,7 +27,7 @@ import org.eclipse.jface.viewers.deferred.ConcurrentTableUpdator.Range;
* rather than being tied to a <code>TableViewer</code>.
*
* <p>
- * This is package visiblity since it currently only needs to be used in one place,
+ * This is package visibility since it currently only needs to be used in one place,
* but it could potentially be made public if there was a need to use the same background
* sorting algorithm for something other than a TableViewer.
* </p>
@@ -89,33 +89,22 @@ import org.eclipse.jface.viewers.deferred.ConcurrentTableUpdator.Range;
* Listener that gets callbacks from the model
*/
private IConcurrentModelListener listener = new IConcurrentModelListener() {
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.IConcurrentModelListener#add(java.lang.Object[])
- */
+
@Override
public void add(Object[] added) {
BackgroundContentProvider.this.add(added);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.IConcurrentModelListener#remove(java.lang.Object[])
- */
@Override
public void remove(Object[] removed) {
BackgroundContentProvider.this.remove(removed);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.IConcurrentModelListener#setContents(java.lang.Object[])
- */
@Override
public void setContents(Object[] newContents) {
BackgroundContentProvider.this.setContents(newContents);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.IConcurrentModelListener#update(java.lang.Object[])
- */
@Override
public void update(Object[] changed) {
BackgroundContentProvider.this.update(changed);
@@ -508,7 +497,7 @@ import org.eclipse.jface.viewers.deferred.ConcurrentTableUpdator.Range;
/**
* Cancels any sort in progress. Note that we try to use the
* FastProgresReporter if possible since this is more responsive than
- * cancelling the sort job. However, it is not a problem to cancel in both
+ * canceling the sort job. However, it is not a problem to cancel in both
* ways.
*/
private void cancelSortJob() {
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/DeferredContentProvider.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/DeferredContentProvider.java
index 8cc9e061876..debcdbd4395 100644
--- a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/DeferredContentProvider.java
+++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/DeferredContentProvider.java
@@ -58,49 +58,31 @@ public class DeferredContentProvider implements ILazyContentProvider {
this.viewer = viewer;
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.AbstractVirtualTable#flushCache(java.lang.Object)
- */
@Override
public void clear(int index) {
viewer.clear(index);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.AbstractVirtualTable#replace(java.lang.Object, int)
- */
@Override
public void replace(Object element, int itemIndex) {
viewer.replace(element, itemIndex);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.AbstractVirtualTable#setItemCount(int)
- */
@Override
public void setItemCount(int total) {
viewer.setItemCount(total);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.AbstractVirtualTable#getItemCount()
- */
@Override
public int getItemCount() {
return viewer.getTable().getItemCount();
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.AbstractVirtualTable#getTopIndex()
- */
@Override
public int getTopIndex() {
return Math.max(viewer.getTable().getTopIndex() - 1, 0);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.AbstractVirtualTable#getVisibleItemCount()
- */
@Override
public int getVisibleItemCount() {
Table table = viewer.getTable();
@@ -110,9 +92,6 @@ public class DeferredContentProvider implements ILazyContentProvider {
return (rect.height - headerHeight + itemHeight - 1) / (itemHeight + table.getGridLineWidth());
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.AbstractVirtualTable#getControl()
- */
@Override
public Control getControl() {
return viewer.getControl();
@@ -128,17 +107,11 @@ public class DeferredContentProvider implements ILazyContentProvider {
this.sortOrder = sortOrder;
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.IContentProvider#dispose()
- */
@Override
public void dispose() {
setProvider(null);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.IContentProvider#inputChanged(org.eclipse.jface.viewers.Viewer, java.lang.Object, java.lang.Object)
- */
@Override
public void inputChanged(Viewer viewer, Object oldInput, Object newInput) {
if (newInput == null) {
@@ -214,9 +187,6 @@ public class DeferredContentProvider implements ILazyContentProvider {
return limit;
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.ILazyContentProvider#updateElement(int)
- */
@Override
public void updateElement(int element) {
if (provider != null) {
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/SetModel.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/SetModel.java
index 3a9cd2dc3b2..8da5e4b2e01 100644
--- a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/SetModel.java
+++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/SetModel.java
@@ -120,9 +120,6 @@ public class SetModel extends AbstractConcurrentModel {
fireRemove(toRemove);
}
- /* (non-Javadoc)
- * @see org.eclipse.jface.viewers.deferred.IConcurrentModel#requestUpdate(org.eclipse.jface.viewers.deferred.IConcurrentModelListener)
- */
@Override
public void requestUpdate(IConcurrentModelListener listener) {
Assert.isNotNull(listener);

Back to the top