Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilippe Marschall2014-03-31 20:06:31 +0000
committerPaul Webster2014-04-01 13:32:43 +0000
commit833920011392b47b0fe0629164e3c19d3ade3064 (patch)
treebbfa16f45d0006630c806f9900312015972404d6
parent780cc5208443e1d64d0c63635b5b8425608d60d8 (diff)
downloadeclipse.platform.ui-833920011392b47b0fe0629164e3c19d3ade3064.tar.gz
eclipse.platform.ui-833920011392b47b0fe0629164e3c19d3ade3064.tar.xz
eclipse.platform.ui-833920011392b47b0fe0629164e3c19d3ade3064.zip
Bug 430903 - [Workbench] System summary should not be computed in the UI
thread Change-Id: I7f315679c31a62507eecf35cd77975ff08d03b20 Signed-off-by: Philippe Marschall <philippe.marschall@netcetera.ch>
-rw-r--r--bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java20
1 files changed, 14 insertions, 6 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java
index 636d7cf12ab..4bf1a27fce0 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java
@@ -15,6 +15,7 @@ import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Status;
+import org.eclipse.core.runtime.jobs.Job;
import org.eclipse.jface.dialogs.IDialogConstants;
import org.eclipse.jface.resource.JFaceResources;
import org.eclipse.swt.SWT;
@@ -29,7 +30,6 @@ import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.internal.ConfigurationInfo;
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
import org.eclipse.ui.internal.WorkbenchMessages;
-import org.eclipse.ui.progress.WorkbenchJob;
/**
* Displays system information about the eclipse application. The content of
@@ -152,13 +152,21 @@ public final class AboutSystemPage extends ProductInfoPage {
private void fetchConfigurationInfo(final Text text) {
text.setText(WorkbenchMessages.AboutSystemPage_RetrievingSystemInfo);
- WorkbenchJob job = new WorkbenchJob(
+ Job job = new Job(
WorkbenchMessages.AboutSystemPage_FetchJobTitle) {
@Override
- public IStatus runInUIThread(IProgressMonitor monitor) {
- String info = ConfigurationInfo.getSystemSummary();
- if (!text.isDisposed())
- text.setText(info);
+ public IStatus run(IProgressMonitor monitor) {
+ final String info = ConfigurationInfo.getSystemSummary();
+ if (!text.isDisposed()) {
+ text.getDisplay().asyncExec(new Runnable() {
+ @Override
+ public void run() {
+ if (!text.isDisposed()) {
+ text.setText(info);
+ }
+ }
+ });
+ }
return Status.OK_STATUS;
}
};

Back to the top