Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/org.eclipse.ui.editors/src
AgeCommit message (Collapse)AuthorFilesLines
2018-07-18Don't use the deprecated FontMetrics.getAverageCharWidthAlexander Kurtakov1-3/+3
There is the new getAverageCharacterWidth which returns double instead of int now. Change-Id: Id0efec3051c2992faddb9c5f172043ea9b353212
2018-07-18Comparator to lambda.Alexander Kurtakov1-39/+16
And other lambda conversions done by the quick fix. Change-Id: Iba9da0ae5028783913f66c04eb3e7e221332b119 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-18Lambda conversions.Alexander Kurtakov10-257/+150
Converting Runnable to lambda and whatever the quick fix picked in the file too. Change-Id: I0cbd8ef4a7cab89dced199b44a5be3b32b6f8195 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-03Fixed bug 468307: [Preferences] Print margin's behavior is confusing to many ↵Dani Megert5-5/+33
users
2018-05-03Bug 533601 - Add Bookmark dialog should use verbsJonas Hungershausen2-1/+23
Change-Id: I52dedf5568747c3e055d7d2ac67c0131a0d8a9e7 Signed-off-by: Jonas Hungershausen <jonas.hungershausen@vogella.com>
2018-04-19Bug 533837 - Direct use of IStructuredSelectionAlexander Kurtakov5-16/+13
Instead of getSelection and cast. Enable save actions to automate cleanup actions. Change-Id: I94a0037f7af2fa9d213a00f2bc385507891ae8e4 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-12Bug 517393: Dark theme hyper-link text is dark blueMatthias Becker1-2/+2
Dark theme hyper-link text was dark blue on black background in JDT's Javadoc. The cause is that JDT's CSS contains hard-coded colors for the links. To solve this provide a mechanism in HTMLPrinter to replace symbolic color names with actual color values from the preferences. A consumer of HTMLPrinter now can you the symbolic names hyperlinkColor and activeHyperlinkColor in their stylesheets. These symbolic names are replaced with JFacePreferences.HYPERLINK_COLOR and JFacePreferences.ACTIVE_HYPERLINK_COLOR by HTMLPrinter automatically. Also fixed: If one changed the theme or color preferences the cached colors in HTMLPrinter were not updated. Change-Id: I386c0a7feff6da132b76bd3ff80c91b4fb919b67 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2017-12-11Bug 519783 - HTMLPrinter should migrate to StringBuilderShawn Kleese1-1/+1
Change-Id: I88fe6c20d4638cf4c15987ca05ec1c3a4a54c574 Signed-off-by: Shawn Kleese <shawn.kleese@wtnet.de>
2017-11-08Bug 527018 - [refactoring] Replace use of Number constructors by valueOfI20171113-2000I20171112-2000I20171111-1500I20171111-0410I20171111-0155I20171110-2000I20171109-2000Karsten Thoms1-3/+3
Change-Id: Ieb6a5450b76c7a5305678f09ecb3785a7fe90c47 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-09-15Bug 522212 - Resolve redundant null checksKarsten Thoms1-1/+1
Change-Id: Iaea3ee9df3771e40bc1d5bc58cd96b871c576406 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-08-24Fixed bug 521373: MarginPainter no longer needs to be initialized after font ↵I20170830-2000I20170830-0605I20170829-2345I20170829-2000I20170829-0940I20170829-0705I20170828-2000I20170828-1220I20170828-0730I20170827-2000I20170826-1500I20170825-2000I20170824-2000Dani Megert1-2/+1
change
2017-07-18Bug 519765 - org.eclipse.ui.editors should use try-with-resourcesI20170718-0355Arne Deutsch3-65/+19
Use try-with-resources consequently in org.eclipse.ui.editors. Change-Id: Ib58f5d12a365e109ee5d554d91af52eb00ce8e00 Signed-off-by: Arne Deutsch <arne@idedeluxe.com>
2017-07-17Bug 519656 - Replace StringBuffer with StringBuilder inLars Vogel3-3/+3
org.eclipse.ui.editors Using drop-in replacement Change-Id: I60aad302867611cc1e4cedf26b83bbe99e9b8d34 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-02-02Bug 493306 - Inefficient use of keySet iterator instead of entrySetLars Vogel2-9/+11
iterator in eclipse.text Change-Id: I5f43ac955ca602846b2f3680b2e63023e1c23368 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-01-11Bug 510312 - Replace usage of new Integer(int) with Integer.valueOf() inLars Vogel2-4/+4
eclipse.platform.text plug-ins - Part 2 Change-Id: I3d76285a2e3333114ba56b7cd0745d13440d5a44 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-01-11Bug 510312 - Replace usage of new Integer(int) with Integer.valueOf() inLars Vogel2-4/+4
eclipse.platform.text plug-ins - Part 1 Change-Id: I8cd43f97a0e3d4ea32e11a2b3cf8898b6be3bc5c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-11-07Bug 507106 - Don't ask strange questions before showing revision infoAndrey Loskutov1-1/+2
for the first time Flipping the default, so that the org.eclipse.ui.internal.texteditor.LineNumberColumn.ensureQuickDiffProvider(String) by default never opens a dialog asking strange question. Change-Id: I9deeff9cc408a9adb794b4955a3513ca7dbd25f0 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-10-20Bug 505940 - NPE on overview ruler on editor for IFileRevision on plainY20161020-1800Andrey Loskutov1-1/+4
text file Fixed regression in org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.findSelectedOverviewRulerAnnotationLabel(), introduced via commit b6ac8fd637f7fa7343820fdff40b9b2cfd6bc54b. Updated javadoc of ISourceViewer to make clear that null return is possible. Change-Id: I0fa6b83a79499b9b2b59edc2527166e8e1fa80b1 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-09-23Bug 482354 - SVN checkout deadlocks EclipseAndrey Loskutov1-6/+41
FileDocumentProvider.refreshFile(IFile) is called from UI thread but in worst case (if the IFile is out-of-sync with file system state) it acquires workspace lock for refreshing the resource state. If at same time any workspace job holding a lock on a parent project will try to use IOConsoleOutputStream.write(String) to report lot of data (> 160000 characters) to the console, the IOConsolePartitioner.streamAppended() call will block forever waiting for queue processed by the (locked) UI thread. Proposed solution: FileDocumentProvider.refreshFile(IFile) should run DocumentProviderOperation in providers runnable context to avoid such deadlocks. In the case the resource tree is locked, a "User Operation is Waiting" progress dialog will be shown, giving the user a chance to resolve the deadlock situation by canceling one of the affected tasks. To be consistent with existing API and to allow clients override the supplied refresh rule, new API is introduced in FileDocumentProvider: protected ISchedulingRule.getRefreshRule(Object element). Default implementation in FileDocumentProvider uses ResourceRuleFactory.refreshRule for given file. Change-Id: Id742d98403cc546fad4a21d25eb18ab7bef48776 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-09-20Bug 479523 - Replace usage of SubProgressMonitor with SubMonitor inLars Vogel3-45/+32
eclipse.platform.text Also using split for automatic cancelation checking Change-Id: I0d78f0071a0b1d25683bd4404b489dd4334c6b5a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-09-20Bug 428417 - ConcurrentModificationException inI20160920-0800Andrey Loskutov1-1/+2
AbstractMarkerAnnotationModel The fDeletedAnnotations field in AbstractMarkerAnnotationModel uses ArrayList, which is not thread safe and does not allow concurrent modification and iteration. Introducing new locks around fDeletedAnnotations seem to be dangerous. Replacing this with CopyOnWriteArrayList however seem to be a better solution - it does not add any new locks and should allow safe iteration while other thread modifies the list. Looking at the usage of fDeletedAnnotations, it should be OK to iterate on "old" state. Change-Id: I17fea70fcccf578212e9fdb557a9f0f68aa64dc4 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-09-09Revert "Bug 479523 - Replace usage of SubProgressMonitor with SubMonitor in ↵Lars Vogel3-31/+44
eclipse.platform.text" This was unintentially commited, I selected the wrong tab in the browser. Reverting. I want to commit this early M3 and not late M2. This reverts commit 17c9cb2d257048b6cbfc5a6c7afa89680da4864c. Change-Id: I7efae943288e94f34ca38b8b4bd87408dbea8208
2016-09-09Bug 479523 - Replace usage of SubProgressMonitor with SubMonitor inLars Vogel3-44/+31
eclipse.platform.text SubProgressMonitor has been deprecated and SubMonitor shows much better performance characteristics and has a simpler API This commit replaces the usage except for Progress which has internal methods for creating SubProgressMonitor, will be handled by another commit Change-Id: I8637366a18fa2f55c8993407f479ed454e0ffe01 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-05-05Bug 492973 - Avoid invoking inefficient new String() constructor inLars Vogel1-1/+1
eclipse.text Change-Id: I9a45a3bd1583ca517a124ea63d70b17d37305d6a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-02-22Bug 488162 - [word wrap] Hide WW preference to avoid unexpectedI20160223-0800Andrey Loskutov1-4/+10
performance impact Hide "Preferences->General->Editors->Text Editors->Enable word wrap when opening an editor" by default, unless the system property "eclipse.show.wrapByDefaultPreference" is set to "true". Users should not be able to persist this preference which can cause not acceptable editor performance slowdown while resizing/zooming. Change-Id: I459593edd731e3f6bb6f597583f5791f229a5cd9 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-01-20Fixes for bug 483340: ListenerList should be parameterizedMarkus Keller2-10/+8
2016-01-15Bug 485748 - Proactively call done() on progress monitors at the top levelStefan Xenos1-1/+6
Signed-off-by: Stefan Xenos <sxenos@gmail.com> Change-Id: Id1deda76707e000651043cae003359730fde1ba5
2016-01-13Bug 485746 - "Save As" for external files does not work as expectedAndrey Loskutov1-3/+3
Filter path for the FileDialog must be a directory, not the file path. Change-Id: Ia78fe8e561bdc672b7f3115b11a2130f98582625 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2015-12-01Bug 478673: generify codeI20151201-1100I20151201-0800Markus Keller45-612/+619
2015-12-01Bug 478673: remove unused castsMarkus Keller12-22/+22
2015-12-01Bug 478673: added @Override/@Deprecated and removed non-Javadoc boilerplateMarkus Keller95-1741/+974
2015-11-10Bug 35779 - [misc] Text Viewer and Editor needs to support word wrapAndrey Loskutov4-3/+11
Added "Enable word wrap when opening an editor" preference to "Text Editors" preference page, "Toggle Word Wrap" text editor action / toolbar button and ALT+SHIFT+Y shortcut for text editors extending AbstractTextEditor. Change-Id: Ibc4d64d0c76a31aff781726336d41b9ee1cbd659 Also-by: Florian Weßling <flo@cdhq.de> Also-by: Holger Voormann <eclipse@voormann.de> Also-by: Lars Vogel <Lars.Vogel@vogella.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2015-09-01Updated copyright dateDani Megert1-1/+1
2015-08-31Bug 394739 - Remove org.eclipse.core.runtime.compatibility* bundlesSopot Cela1-8/+3
Removed references to Platform#getPlugin. Change-Id: If3b071f52ba4f22a24734c4aa66a3251cfb27d5a Signed-off-by: Sopot Cela <scela@redhat.com>
2015-07-31Added note that concrete editors may override textual editor settingsI20150818-0800I20150811-1400I20150805-2000I20150805-0800I20150804-2000I20150804-0800I20150803-2000I20150803-0800I20150802-2000Dani Megert1-2/+4
2015-02-13Bug 459927: [templates] ContributionContextTypeRegistry#createResolver(..) ↵I20150310-0800I20150305-1200I20150303-0800I20150224-0800I20150217-0800Markus Keller1-1/+7
must not throw AFE
2014-11-18Fixed bug 440952: Basic Marker Updater should be executed before other ↵Sarika Sinha3-6/+71
contributed markers Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2013-05-13Updated copyright dateI20130513-2000Dani Megert1-1/+1
2012-12-21Fixed typov20121221-081121I20130101-0800I20121225-1600I20121225-0800Dani Megert1-3/+4
2012-11-08Fixed compile warningDani Megert1-1/+3
2012-10-05Bug 321306: Convert line delimiters should report ignored binary filesv20121005-141144I20121009-0800Markus Keller6-24/+107
2012-10-04Bug 390999: 'Convert Line Delimiters To > ...' action names confusing for MacMarkus Keller4-33/+2
Reverted to simpler names (Windows, Unix) and removed Mac OS 9.
2012-10-03Bug 390999: 'Convert Line Delimiters To > ...' action names confusingMarkus Keller1-3/+3
for Mac
2012-05-14Fixed bug 378603: Refresh on Access enabled -> still getting the popupv20120514-0947I20120514-2100I20120514-1900Dani Megert1-4/+2
dialog if I want to refresh
2012-04-18workaround for Bug 377109: Discrepancy between StyledText#getLineHeight() ↵v20120418-1702Markus Keller1-2/+2
and FontMetrics#getHeight()
2012-04-03Fixed bug 353025: [implementation] NPE during Save when "Refresh onv20120403-1303Dani Megert1-2/+2
Access" enabled
2012-03-29Fixed bug 375468: [preferences] Focus rectangle partially obscured forv20120329-1603I20120410-0320I20120410-0304I20120410-0252I20120410-0238I20120410-0216I20120410-0152I20120410-0136I20120410-0122I20120410-0102I20120410-0049I20120410-0027I20120409-2358I20120409-2119I20120409-2018I20120409-1957I20120409-1911I20120409-1708I20120409-1622I20120409-1353I20120409-0926I20120409-0904I20120409-0315I20120409-0131I20120408-2304I20120408-2000I20120408-1521I20120408-1324I20120408-1214I20120408-1110I20120408-0330I20120408-0246I20120408-0231I20120408-0216I20120408-0152I20120408-0036I20120408-0012I20120407-2339I20120407-2245I20120407-2106I20120407-1941I20120407-1904I20120407-1840I20120407-1826I20120407-1732I20120407-1717I20120407-1631I20120407-0358I20120407-0346I20120407-0329I20120407-0305I20120407-0217I20120407-0205I20120407-0138I20120407-0103I20120407-0040I20120407-0024I20120406-2327I20120406-0935I20120406-0915I20120406-0250I20120406-0231I20120406-0006I20120405-2131I20120405-1735I20120405-1114I20120405-0114I20120404-2228I20120404-2006I20120404-1351I20120404-0051I20120403-2231Dani Megert3-55/+16
checkboxes with links
2012-03-27Fixed bug 355834: NonExistingFileEditorInput should have an imageDani Megert1-2/+3
descriptor
2012-03-21Fixed bug 364695: [implementation] DelegatingAnnotationPreference doesv20120321-1705I20120328-2028I20120328-2020I20120328-2007I20120328-1956Dani Megert1-2/+25
not override all get-methods of AnnotationPreference
2012-03-21Fixed bug 345922: [preferences] Icon missing for 'Write occurrences'Dani Megert1-3/+4
initially

Back to the top