Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-07Bug 535964 - Move some non UI classes from jface.text to o.e.text.Y20180808-2200I20180811-1500I20180810-2000I20180810-0320I20180809-2000I20180808-2000Roland Grunberg5-794/+164
- Create TemplateReaderWriter, TemplatePersistenceData, and ContextTypeRegistry in org.eclipse.text which extend the corresponding classes from org.eclipse.jface.text in order the preserve the API for the latter - Make TemplateStore extend a new class TemplateStoreCore which will be located in org.eclipse.text, and contain the non-UI functionality from TemplateStore - Introduce new constructor to the deprecated TemplatePersistenceData, that takes an org.eclipse.text.templates.TemplatePersistenceData and delegates all API calls to it, if the object was constructed in this manner. Otherwise calls are handled by the inheritted class. In some cases, even though we use the new org.eclipse.text.templates.TemplatePersistenceData, the API requires us to return the deprecated version of TemplatePersistenceData. This satisfies the requirement while also ensuring the returned object can be modified by clients (unlike a copy). Change-Id: I4315693c8c557986d922106b7c1325e23de70725 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-07-18More deprecated getAverageCharWidth fixes.Alexander Kurtakov5-10/+10
Change-Id: I5a696c6973a78339afaf0323fd081e2b370d0a52 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-18DisposeListener to lambda.Alexander Kurtakov6-166/+88
And other lambda conversions as picked by the quick fix. Change-Id: I83d5318444387bf74ebea7e959d688588df6a53a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-18Lambda conversions.Alexander Kurtakov29-743/+442
Converting Runnable to lambda and whatever the quick fix picked in the file too. Change-Id: I0cbd8ef4a7cab89dced199b44a5be3b32b6f8195 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-18Bug 535865 - Fixed y offset computationI20180621-2000Karsten Thoms1-2/+1
On macOS the GC returns the font size, not the number of pixels used to display a character. This is different on Windows. Using TextWidget#getLineHeight fixes the issue. Change-Id: I5201b1614af81d3338f97ee957acea04fd31e677 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-06-14Bug 535899 - [code mining] Remove drawing of "deleted" annotation moreI20180615-0300I20180614-2045I20180614-2000angelozerr1-18/+28
fastly Change-Id: I67e89eb137ded9c2b19635c1a5a56127d217cc19 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-06-11[Sonar] Removes dead store to widgetLineI20180613-0440I20180613-0300Jonas Hungershausen2-2/+2
see https://sonar.eclipse.org/drilldown/issues/33533?rids%5B%5D=33541&rids%5B%5D=45869&rule=findbugs%3ADLS_DEAD_LOCAL_STORE&rule_sev=CRITICAL&severity=CRITICAL and https://sonar.eclipse.org/drilldown/issues/33533?rids%5B%5D=33541&rids%5B%5D=45869&rule=findbugs%3ADLS_DEAD_LOCAL_STORE&rule_sev=CRITICAL&severity=CRITICAL Change-Id: I6010a45fe5ffa6efc94016cef6be57fc2ea8460a Signed-off-by: Jonas Hungershausen <jonas.hungershausen@vogella.com>
2018-06-11[Sonar] Removes dead stored variablesJonas Hungershausen3-6/+0
see https://sonar.eclipse.org/drilldown/issues/33533?rids%5B%5D=33542&rule=findbugs%3ADLS_DEAD_LOCAL_STORE&rule_sev=CRITICAL&severity=CRITICAL Change-Id: I81091332e090cd8baa36204d25256d6df77bdf42 Signed-off-by: Jonas Hungershausen <jonas.hungershausen@vogella.com>
2018-05-27Bug 535162 - [content assist] Possible NPE during async computeFilteredProposalsDawid Pakuła1-1/+1
Change-Id: I7a323704706b10d8dde1e3e0fc75e1293d337e92 Signed-off-by: Dawid Pakuła <zulus@w3des.net>
2018-05-22Bug 534930 - [code mining] Inlined annotation is not drawn whenS4_8_0_RC2I20180527-2250I20180527-2000I20180527-0800I20180526-1500I20180526-0800I20180525-2000I20180524-0900I20180523-2000I20180523-0800I20180522-2000angelozerr1-6/+28
StyledText is resized Change-Id: Ib97f2f6ca0f03c50259686ef674eefa9df710330 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-05-22Bug 534395 - [content assist] Prefix autocompletion not work in async modeDawid Pakuła2-63/+117
Change-Id: I967d74001e8a07295946b43e41e99167aa1760c2 Signed-off-by: Dawid Pakuła <zulus@w3des.net>
2018-05-16Bug 534387 - Auto-insert randomly work with async completionS4_8_0_RC1I20180522-0800I20180521-2000I20180521-0800I20180520-2000I20180520-0800I20180519-1500I20180519-0800I20180518-2000I20180516-2000Dawid Pakuła1-6/+18
Change-Id: If52b8960ae1be26045ea715eb4726d80dbdfe05a Signed-off-by: Dawid Pakuła <zulus@w3des.net>
2018-05-16Bug 534402 - ContentAssistant#setStatusMessage isn't safe in async modeI20180516-0800Mickael Istria2-2/+3
Change-Id: I05ede1415ca42e6b39f38bed1856b71b43c6cca4 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-05-13Bug 532258 - Memory leaksI20180515-2000I20180515-1755I20180515-1620I20180515-1440I20180515-1300I20180515-0950I20180515-0800I20180514-2000Dawid Pakuła1-1/+1
Make sure line rules are already disposed before recreate on mac Signed-off-by: Dawid Pakuła <zulus@w3des.net>
2018-05-04Bug 534310 - [content assist] NPE in ↵I20180506-2000I20180506-0800Dawid Pakuła1-1/+3
AsyncCompletionProposalPopup#computeProposals Change-Id: I8840503fcfd2303658d38dacf45551e36536b8a1 Signed-off-by: Dawid Pakuła <zulus@w3des.net>
2018-05-03Bug 534328 - [code mining] Avoid delay to click on inlined annotationazerr1-29/+2
Change-Id: I73927a6593effb919910c144f274109c7f474be2 Change-Id: I6666dc7da2aa9fa79f1554ba58dff14114469a9d Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-05-03Bug 534318 - [code mining] Redraw of character has wrong y location forazerr1-1/+1
line header annotation Change-Id: Id076e383be92833b1add1ae02ea39d0b8bad9ef7 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-05-03Revert "Bug 534318 - [code mining] Redraw of character has wrong y location ↵Mickael Istria1-3/+3
for line header annotation" This reverts commit f9ef44ee8069742d002309b19fbd44ea60e8620d. Change-Id: I9e81cbdb2f6b6e6219401b71ef7349103e9fafab
2018-05-03Bug 534318 - [code mining] Redraw of character has wrong y location forazerr1-3/+3
line header annotation Change-Id: Ife2631df1fc90d98e5c03e210902940e4c5e1e72 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-05-03Bug 534314 - [code mining] Line numbering and collapse/expand alignedazerr1-1/+8
with code lines Change-Id: Ic8d18a00328dda9cb9970447bb3f38377fcf9cb6 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-05-03Bug 534297 - [code mining] click on inlined annotation must take care ofI20180503-0740azerr1-1/+1
visibility of annotation Change-Id: I62061c209220a11398be7d2220eea46fa6dc8b8c Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-05-03Bug 533072 - [code mining] Click on mining doesn't work when previousazerr3-31/+74
mining is not drawn Change-Id: I7c3a703366f9c42ffd70c0ed5deee6014040b7f5 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-05-02Bug 534276 - [code mining] Draw of line which have line headerI20180502-2000azerr1-1/+1
annotation are sometimes not drawn with Dark theme Change-Id: I8a546849af1498ab899587c82fae9930a7da043e Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-04-30Fix some bad int/double conversionsI20180502-0100I20180501-2000I20180430-2000Mickael Istria2-2/+2
Reported by SonarQube Change-Id: I612ffc9b459e8cdf9c0d043dfaa1633cdefc6c1d Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-04-27Bug 534156 - [code mining] Don't redraw character for line contentI20180430-0715I20180429-2000I20180428-2020I20180428-1500I20180427-2000azerr1-14/+16
annotation if character is a line delimiter Change-Id: I25ba2750f8d1616835b7bddf3d8bdd1e89a0b74e Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-04-25Bug 533811 - [code mining] Inlined content annotation cannot be clickedI20180426-2000I20180426-0500I20180425-2000azerr5-147/+96
when it is drawn at the end of the line Change-Id: If744f7692021fd04ee9169bac430ec6559f2eb56 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-04-24Bug 532706 - Update minings when code mining manager is initializedI20180425-1705I20180425-1650I20180425-1455I20180425-0910I20180425-0725I20180425-0505I20180425-0250I20180424-2000Karsten Thoms2-9/+10
After fCodeMiningManager is initialized in ensureCodeMiningManagerInstalled, it is not assured that updateCodeMinings() is called afterwards. The initial reconciling has already called before an annotation painter is set. But only when this has happened the code mining is properly installed and an initial mining has to be shown. Thus ensureCodeMiningManagerInstalled calls updateCodeMinings after initialization of the manager. Also changed guard conditions since it is intended to check that the code mining manager is set, but method hasCodeMiningProviders is from its name not so clear that this is implied by calling it. Change-Id: Ic79743178aa3302d38586770246ca7d749401e15 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-04-15Bug 533591 - [code mining] Inlined annotation support must removeI20180416-2000I20180416-0305azerr1-9/+10
annotations when it is uninstalled Change-Id: Ic77d99f31ae60fc3fcc592b990e1809d4515b256 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-04-04Bug 533192 - [CodeMining] Fix little bug with background of mining lineazerr1-1/+1
header when line is selected Change-Id: I9ddbc1b76f9f829a5bfd336b3fa168fed22efe09 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-04-03Bug 532091 - [CodeMining] Don't draw minings which are cancelledI20180403-2000azerr2-2/+2
Change-Id: I246847bd92cbd75e94ea6c75ef117e468c17ed55 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-03-30Bug 532924 - [CodeMining] wrong redraw artifacts showing upI20180402-2000I20180401-2000azerr1-2/+2
Change-Id: Ic2589ab19a8057ea9ee5aa483ca18bf859741158 Signed-off-by: azerr <angelo.zerr@gmail.com>
2018-03-27Bug 532587 - Inline Annotation can prevent editor from loadingangelozerr1-0/+4
Change-Id: Ia8a22f71598cb7935853aa530b09af19d21219d9 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-25Bug 532091 - [CodeMining] Don't draw minings which are canceledI20180326-2000I20180325-2000angelozerr4-37/+80
Change-Id: Ib14d8e39030ec9b9c593fcb0be8edb0e56cd1815 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-23Bug 532829 - [CodeMining] Eclipse IDE freezes when refactor is done forI20180324-1500I20180323-2000angelozerr1-3/+12
method parameter name Change-Id: I335ebf9ece550afb083fe63b4deb895963c8f877 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-23Bug 532682 - Too high bracket box when line height is biggerMickael Istria1-1/+2
Change-Id: I601f715ee8a47fba82c1233d80d12032877741e3 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-03-23Bug 531421: [CodeMining] Adapt the source viewer CodeMining API toNoopur Gupta1-5/+7
support CodeMining preferences Fixed Javadoc Change-Id: I23c6e7abf4724a989126d6328b192cc9db675983
2018-03-23Bug 531952 - [CodeMining] erroneous folding icons locationMickael Istria1-0/+16
Monitor the text change for modified line count to update the folding icons position. Change-Id: I0b4460be3c3b8ce8c30870cac92235d27c84a3ee Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-03-23Bug 529617 - TextListener for LineNumberRuler only manages digitsMickael Istria1-4/+0
The InternalListener is expected to only take care of the number of lines to compute the width of the column. Remove from it unrelated code which cause errors in JDT's MarkOccurrenceTest Change-Id: I676c7a83cfb7b73ddd903d093c44e45544ef3b88 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-03-22Revert "Bug 532091 - [CodeMining] Don't draw minings which are cancelled"I20180323-0355I20180322-2000Lars Vogel4-98/+27
This reverts commit 3743188767f8cef3a9854b23ff7569f335f53f70. Change-Id: I2cc958b6bd54af419906a96fcfbdeed7100151ed
2018-03-22Bug 532091 - [CodeMining] Don't draw minings which are cancelledangelozerr4-27/+98
Change-Id: Ieb3896c28c30116e7ccc30a2169e2bafdd5d4fed Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-21Bug 532679 - [CodeMining] should show an empty area before content isangelozerr1-6/+24
available Change-Id: I525c97be153c8d1f091ce4e9699be0a071ca03f7 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-20Bug 531761: Value suggestion popup has black background on light theme.I20180320-2000Roland Grunberg2-10/+28
Change-Id: I8692ccb8e97855115a72692abcb5c51a8eaccb80 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-03-20Bug 529617 - Fix line numbers in Compare EditorMickael Istria1-6/+34
Keeps text listener to update digits and column width + Remove useless field Change-Id: I12ed75aebe35495ee80d042c025a64e713eaf704 Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-03-19Bug 532604 - [CodeMining] Line header content can be drawn on the lineI20180319-2000angelozerr1-1/+5
text when mining resolve takes time Change-Id: Ibbecc1be6d7e47ef4a76e9615171adbcee354da3 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-19Bug 529617 - [CodeMining] Line number in vertical ruler can be notangelozerr3-72/+175
synchronized with line header annotation Change-Id: Idfb97cefe20d3fbdde0f8793f159d6c3cff2937b Signed-off-by: angelozerr <angelo.zerr@gmail.com> Also-By: Mickael Istria <mistria@redhat.com>
2018-03-18Bug 532130 - [CodeMining] Draw line header annotation with GlyphMetricsI20180318-2000angelozerr3-77/+131
ascent Change-Id: Icaca5e7d543569941663b0d73ea9f7fb5e15b3c8 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-16Bug 517393: Dark theme hyper-link text is dark blueMatthias Becker1-2/+9
Fix NPE in non-IDE use case Change-Id: Iae0e2397781e7ee08a0ce0312af4f3f539617858 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2018-03-13Bug 506166 - Print Margin painted at the wrong position on Retina MacI20180315-2000I20180314-2000I20180313-2000Till Brychcy1-2/+2
with Font Monaco 11 Change-Id: Id17009c1a47e010b02b0298c48d835ea8aed076d Signed-off-by: Till Brychcy <register.eclipse@brychcy.de>
2018-03-12Bug 531957 - [CodeMining] Line content annotation doesn't take theI20180312-2000angelozerr3-33/+72
expected space Change-Id: I62d89d7ba74a0409cb13dbce4844e8e14a6ee4ea Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-03-12Bug 532326 - Reduce field visibilityMickael Istria1-1/+1
Avoid introducing API at the moment. Change-Id: I6d6ff2ef6269a5b657329a494eabece6eb9654c3 Signed-off-by: Mickael Istria <mistria@redhat.com>

Back to the top