Skip to main content
summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-04-26Bug 512571 - Fix enablement of Zoom handlers for textY20170427-1000I20170430-2000I20170429-2000I20170429-1330I20170429-1230I20170428-2000I20170428-0830I20170428-0700I20170428-0550I20170428-0445I20170427-2000I20170426-2000Mickael Istria1-0/+14
Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-04-25Bug 507073: [content assist] Use fitting colors for Content assist'sI20170425-2000Leo Ufimtsev1-2/+3
additional info pane Part 1: HTMLPrinter should use default JFace colours suitable for presenting information rather than that of tooltips (INFO_*). The reason is on Gtk, tooltips have black background and white text, making it hard to read information. (See screenshot in bug). This makes Code-completion's javadoc window have suitable colours on gtk again (See screen shot in bug). On Windows/Cocoa, there is no change in behaviour. This is Gtk specific. Test (gtk): - Launch child Eclipse - Type "Obj", then ctrl+space (keep pressing ctrl+space till "Object" appears as an option) - Inspect javadoc popup. Before: Black background/white text After: White background/black text: NOTE: - This may make some darktheme elements appear white-ish in some cases. Part 2 (see bug) addresses the case for the javadoc info additional plane on Dark theme. For other elements, similar strategies should be used to call HTMLPrinter with colours suitable for darktheme. Change-Id: I8b11d1db9c472693d1322f7a714e0a4e60650c95 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=507073 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-04-24Bug 507062 - Fix black strip of color in JavaDocHover (patch 2)I20170425-0910Leo Ufimtsev1-10/+3
Use information colors api in JFaceColor instead of those in workbench. This makes the Javadoc dialogue's strip at the bottom have the same consistent color with all other dialogues in eclipse. (e.g same as in code completion in ctrl+space). See screenshot 'patch 2' in bug report. Tests: - Gtk: Javadoc hover, strip at the bottom looks like regular part of Eclipse. - Looks consistent on Dark and Light theme. - Win/Cocoa: Javadoc hover, strip at the bottom looks same as before. Note: The previous patch introduced ability to customize colour of this strip at the bottom. But this made it inconsistent with other eclipse dialogues like code-completion etc. This patch reverts customization in favour of keeping things simple and working. Patchset 4: - Removed null check as api never returns null. Change-Id: Ia6ebf0066b6f241675b2bcbac4c29824270f3415 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=507062 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-04-19Bug 511302 - More explicit message for async content assistY20170420-1000I20170425-0700I20170425-0240I20170425-0215I20170424-2000I20170423-2000I20170422-2000I20170422-0300I20170421-2000I20170420-2000I20170419-2000Mickael Istria2-4/+8
Change-Id: I1e8848a930453d3079363ea33d8c7c2917577b59 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-04-06Bug 514397 - Provide default autocompletion for generic editorY20170413-1000I20170419-0430I20170419-0130I20170418-2000I20170417-2000I20170416-2000I20170415-2000I20170414-2000I20170413-2000I20170412-2000I20170411-2000I20170411-0500I20170410-2000I20170409-2000I20170408-2000I20170407-2000I20170406-2000Sopot Cela1-1/+1
Removes 1-character proposals. Change-Id: I74c1a98299462918db63fd2f8357336d8972512b Signed-off-by: Sopot Cela <scela@redhat.com>
2017-04-05Bug 514397 - Provide default autocompletion for generic editorY20170406-1000I20170405-2000Sopot Cela2-0/+112
Change-Id: I113fe5ec4faf1fde579dc3400d42041d9e77c9a4 Signed-off-by: Sopot Cela <scela@redhat.com>
2017-04-04Bug 514642 - (async) completion sometimes missingMickael Istria1-1/+1
Change-Id: I89b9e146a4e478fa9e416782e199abd9b9280c30 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-03-25Bug 513314 - Example enabling spellcheck on generic editorY20170330-1000I20170405-0300I20170405-0200I20170405-0130I20170404-2000I20170404-0840I20170404-0245I20170403-2000I20170402-2000I20170401-2000I20170331-2000I20170330-2000I20170329-2000I20170328-2000I20170327-2000I20170326-2000I20170325-2000Alexander Kurtakov4-1/+84
Fix warning in the build in the examples and enable save actions so these get auto-fixed. Change-Id: I0463f3d9e1cfe0560383a5e72f292a2315f76d38 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-03-21Bug 513314 - Example enabling spellcheck on generic editorI20170324-2000I20170323-2000Mickael Istria6-2/+209
+ Enable quick fix for spelling issues by default Change-Id: I32973aa0e064547f1c5800e2503f43ef3c319078 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-03-16Bug 513314 - [Generic editor] disable spellchecker reconcilerY20170321-2315Y20170321-0120I20170322-2000I20170321-2000I20170320-2000I20170319-2000I20170318-2000I20170317-2000I20170316-2000Mickael Istria1-2/+8
Most clients of the Generic Editor so far don't want spellchecker to be on by default. Adding spellchecker should be opt-in. For the moment, fully disable it and adopters who need spellchecking implement it as a document listener. Change-Id: I6bbad50614ec19e05c447d2793e758793ae777d3 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-03-16Bug 512525 - Editor actions in menus and Generic EditorMickael Istria8-128/+151
* Add menus so commands are accessible via shortcut and quick-assist * Add images to commands so they look nice in menus * Test enablement of wordwrap, whitesplaces, block selection in Generic Editor... Bug: 512525 Bug: 512571 Change-Id: I95345a8eae45bec98f835614156d4037e7df4431 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-03-15Bug 513722 - Wrong dependency verision on org.eclipse.ui.genericeditorY20170316-0500I20170315-2000Mickael Istria1-1/+1
Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-03-15Bug 513304 - Setup API tools on Generic editor bundlesMickael Istria1-0/+6
Signed-off-by: Mickael Istria <mistria@redhat.com> Change-Id: I134454b61169d2a325a23af199504745370deda6
2017-03-11Bug 513517 - printStackTrace() should not be used in production codeI20170315-0500I20170314-2000I20170313-2000I20170312-2000Andrey Loskutov6-8/+7
Change-Id: I7b4a4d0a1af3979852269b1ee53fb9a8ba444e93 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-03-08Bug 513274: Real "Unlikely argument type" problem in SearchY20170309-1000S4_7_0_M6I20170311-2000I20170310-2000I20170308-2000Markus Keller2-2/+3
Change-Id: If4355d1fb5d59fa8f76d37f84b743e891e2ec611
2017-03-08Bug 511101: [Generic Editor] misses quick fix on error markersMarkus Keller5-44/+655
- improved HoverTest (no endless loop, better logging) - removed dependency on platform.ui test bundle - improved ScreenshotTest
2017-02-22Bug 511101 - [Generic Editor/Quick Fix] suppress warningsY20170302-1000Y20170223-1000I20170308-0800I20170307-2000I20170307-0800I20170307-0610I20170307-0450I20170307-0420I20170307-0410I20170307-0150I20170306-2000I20170306-0800I20170305-2000I20170304-2000I20170303-2000I20170302-2000I20170301-2000I20170228-2000I20170228-0330I20170228-0240I20170227-2000I20170226-2000I20170225-2000I20170224-2000I20170223-2000I20170222-2000Mickael Istria2-9/+6
Change-Id: Ic7c21de2fd9cb2e5e67addd23a80b64104343168 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-02-21Bug 511101 - Enable quick fix on generic editorI20170221-2000Mickael Istria15-27/+641
* Available for Quick-Fix command (Ctrl+1) * Hover on text editor Change-Id: I6576f109d6f2a1fdc6020ed6510b645e12dcf3f6 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-02-19Bug 320672 - added copyright header for new fileI20170220-2000I20170219-2000Andrey Loskutov1-0/+11
Change-Id: I3d2f4dfbe9d96ff1724bfdee67f8b303427c3029 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-02-19Bug 320672 - [WorkbenchParts] [Compatibility] SWTException whenAndrey Loskutov5-12/+182
activating an editor with stale content This is the second part of the fix for bug 320672, the first one is covered by bug 511873. Remember if we are in the middle of the focus state change. During this operation we should not attempt to call updatePartControl() from sanityCheckState() (which is called on part activation) because it can dispose widgets we are currently setting focus to. In theory, this can happen from other protected methods here too, but I'm trying to keep the patch as small as possible because this class is a base class for MANY other text editors. Change-Id: Ibb860eac30986b6ed3a155f809dc58c9db082ff1 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Also-by: Vasili Gulevich <vasili.gulevich@xored.com>
2017-02-17Revert "Bug 320672 - [WorkbenchParts] [Compatibility] SWTException when ↵I20170218-2000I20170217-2000Dani Megert4-194/+11
activating an editor with stale content" This reverts commit 919a0022e6f90d59d48982a7e42141187fc5c594. Change-Id: I3cde4056b10acd792362004259e98ecb663696f0
2017-02-16Bug 320672 - [WorkbenchParts] [Compatibility] SWTException whenY20170216-1515Y20170216-1450I20170216-2000Andrey Loskutov4-11/+194
activating an editor with stale content This is the second part of the fix for bug 320672, the first one is covered by bug 511873. Remember if we are in the middle of the focus state change. During this operation we should not attempt to call updatePartControl() from sanityCheckState() (which is called on part activation) because it can dispose widgets we are currently setting focus to. In theory, this can happen from other protected methods here too, but I'm trying to keep the patch as small as possible because this class is a base class for MANY other text editors. Change-Id: I86af3ed7463628f7476359f76be262ed2ddaf997 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Also-by: Vasili Gulevich <vasili.gulevich@xored.com>
2017-02-13Fixed bug 511542: [content assist] Incorrect default selection in proposals ↵Y20170216-1000I20170216-0140I20170215-2000I20170214-2200I20170214-2000I20170213-2000Dani Megert1-9/+5
list after filtering
2017-02-08Bug 511596: [painting][rulers] Rulers are forcing synchronous paints during ↵Y20170209-1000I20170212-2000I20170211-2000I20170210-2000I20170210-0615I20170210-0600I20170210-0550I20170210-0530I20170209-2000I20170208-2000Markus Keller1-9/+12
scroll
2017-02-08Bug 511596 - Rulers are forcing synchronous paints during scrollStefan Xenos3-3/+0
Change-Id: Ie3e614aba4377fa1cbbd77edbe97251fa8a871aa
2017-02-08Bug 511596 - Slow scrolling in editorI20170208-0700Stefan Xenos2-2/+0
Remove the synchronous forced repaints. The call to Canvas.redraw is sufficient to trigger an asynchronous repaint. Doing it asynchronously prevents input events from getting backed up if they arrive faster than SWT can paint the ruler. Change-Id: I4aaf9a18d78b8b59a5189a4651f4cb5c207fa9c9 Signed-off-by: Stefan Xenos <sxenos@gmail.com>
2017-02-07Bug 511863 - [regression] NPE inI20170207-2000Andrey Loskutov1-5/+7
CompletionProposalPopup.computeProposals Change-Id: I6fafe29a1ed3289f8d6a9e909d2cd2e3136305f2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-02-03Bug 511615 - Use enhanced for loops in org.eclipse.core.filebuffersI20170206-2000I20170205-2000I20170204-2000I20170203-2000Lars Vogel4-33/+31
Change-Id: Iaa50efc06006a4efd523f1c92026504fc851803a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-02-03Bug 493304 - Prefer usage of enhanced for loop in eclipse.platform.textLars Vogel22-150/+103
repo Part 2 for the org.eclipse.jface.text plug-in Change-Id: I183540f8ae58d1448de9607b6c462817a2f670a3 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-02-03Bug 511613 - Mark IHyperlinkDetector as functional interfaceLars Vogel1-0/+1
Change-Id: Iad4c8751552297a3c0f81359bb77cb255b3d8ea9 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-02-03Bug 493304 - Prefer usage of enhanced for loop in eclipse.platform.textLars Vogel22-114/+92
repo Part 1 for the org.eclipse.jface.text plug-in Change-Id: Ib037e06e3346e9ce50281bbc11b87bcbb962eb56 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-02-03Bug 493304 - Prefer usage of enhanced for loop in eclipse.platform.textLars Vogel15-130/+81
repo This change is for the for org.eclipse.text plug-in Change-Id: I9a02ba945e91d7e1361627239c3617010453c571 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-02-02Bug 325434 - [rulers] ArrayIndexOutOfBoundsException inI20170202-2000Andrey Loskutov1-1/+6
LineNumberRulerColumn.paintLine If the paint request has line with higher index, just don't paint, our internal state is not up-to-date with the document. Change-Id: I04c04d7030d790bfcf352182d596e883adde6779 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-02-02Bug 493306 - Inefficient use of keySet iterator instead of entrySetLars Vogel7-30/+33
iterator in eclipse.text Change-Id: I5f43ac955ca602846b2f3680b2e63023e1c23368 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-02-02Bug 511587 - Prefer explicit dependencies instead of org.eclipse.ui inLars Vogel1-2/+3
generic editor Change-Id: I8529f6bb477bd85b95822eb648a8ffbdd6d4f862 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-01-30Bug 511251 - Comparator errors in I20170127-2200Y20170202-1000I20170201-2000I20170131-2000I20170130-2000I20170130-0600Sopot Cela1-1/+2
Change-Id: I6b875f7ff1cbad4c763fe84761c13b3549e62207 Signed-off-by: Sopot Cela <scela@redhat.com>
2017-01-21Bug 510796 - Comparator errors in I20170120-2000Y20170126-1700Y20170126-1000S4_7_0_M5I20170129-2000I20170128-2000I20170127-2200I20170127-2000I20170126-1030I20170126-0505I20170125-2000I20170125-0800I20170124-2000I20170124-0800I20170123-2000I20170123-0830I20170123-0800I20170122-2000I20170121-2000I20170121-0950Alexander Kurtakov1-0/+1
Change-Id: Ie9745325275157916ef5637cb0f7eb7117aaad64 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-01-19Polish bug 251156: [content assist] Asynchronous code completion [with patch]I20170120-2000I20170119-2000Dani Megert7-94/+77
2017-01-19Bug 502399 - Create a better icon for extensible editorY20170119-1000I20170119-1010Matthias Becker4-1/+1
Change-Id: Ie81dae4371c9008781db4fd65a79a8133d5aeeb8 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2017-01-18Bug 251156 - Asynchronous content assistI20170119-0345I20170118-2000Markus Keller1-1/+0
removed bogus Bundle-ActivationPolicy for bundle without activator
2017-01-18Bug 508747 - Replace gifs in org.eclipse.ui.editors with png filesI20170118-1215Matthias Becker27-11/+11
Change-Id: Iedf6b652e27af4676003fd3d0ac9fde92dfcc443 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2017-01-17Bug 509032 - Support for em, strong, s, strike in HTML2TextRendererI20170117-2000Mickael Istria2-49/+87
Change-Id: I1d09f85107a3137af081200803f5c08d50eecb01 Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-01-17Bug 251156 - Asynchronous content assistMickael Istria21-136/+613
This provides a new AsyncContentAssistant, performaing computation and presentation of content assist proposals (and related operations) asynchronously whenever possible. Part of this change is also internally allowing the parent ContentAssistant to support multiple IConteantAssistProcessors (although this is not exposed through public API). The AsyncContentAssistant does expose the manipulation of multiple contentAssistProcessors though. Some fields and methods where also made more visible (usually from private to protected or package, to maximize the ability to reuse existing code from the current synchronous framework, in order to make the feature easier to write, and also to provide a consistent experience with aysnc and sync content assist. Change-Id: I3e80c6422eaababc165e955ddeb3539909bfcb9f Signed-off-by: Mickael Istria <mistria@redhat.com>
2017-01-11Bug 510313 - Remove unnecessary whitespace from org.eclipse.jface.textY20170112-1300Y20170112-1000I20170116-2000I20170115-2000I20170114-2000I20170113-2000I20170112-2000I20170112-0245I20170112-0200I20170111-2000Lars Vogel66-348/+348
Change-Id: I19139e6aba0aaa20eb06882a4b721298cdfe138b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-01-11Bug 510312 - Replace usage of new Integer(int) with Integer.valueOf() inLars Vogel10-18/+18
eclipse.platform.text plug-ins - Part 2 Change-Id: I3d76285a2e3333114ba56b7cd0745d13440d5a44 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-01-11Bug 510312 - Replace usage of new Integer(int) with Integer.valueOf() inLars Vogel15-28/+28
eclipse.platform.text plug-ins - Part 1 Change-Id: I8cd43f97a0e3d4ea32e11a2b3cf8898b6be3bc5c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-01-11Bug 510311 - Fix issues reported by Sonar Correctness - equals methodLars Vogel1-10/+0
always returns false Change-Id: I72caef22eb8d8a49d6133fe7f25e0ce4325d213c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2017-01-09Bug 510030 - Add toString() to Line and TextSelectionI20170111-0200I20170110-2000I20170109-2000Andrey Loskutov2-0/+30
Change-Id: Idc8d4bd0224d1a84932e02a9914bf1f59fe56580 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-01-05Added version problem filter due to API being added to 4.6.2Y20170105-1040Y20170105-1000I20170108-2000I20170107-2000I20170106-2000I20170105-2000Dani Megert1-5/+13
2017-01-05Bug 509973: Comparator errors in I20170105-0320Markus Keller4-2/+6

Back to the top