Skip to main content
summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-02-20Bug 511596: [painting][rulers] Rulers are forcing synchronous paints during ↵S4_6_3_RC4S4_6_3_RC3R4_6_3M20170301-0400M20170228-0545M20170222-0400R4_6_maintenanceMarkus Keller1-9/+12
scroll
2017-02-13Bug 511596 - Rulers are forcing synchronous paints during scrollS4_6_3_RC2M20170215-0400M20170214-1550M20170214-0330M20170213-1455Stefan Xenos5-5/+0
Change-Id: I3a6fd92939095a0c384130f5fc1714b1803bbfc1
2017-01-03Bug 509575: Update parent pom to 4.6.3S4_6_3_RC1M20170213-0955M20170212-0800M20170208-0400M20170205-0800M20170201-0400M20170126-1300M20170126-0400M20170125-0400M20170118-0830M20170118-0500M20170118-0430M20170111-0400M20170105-1300M20170104-1200M20170104-0545M20170104-0400M20170103-1700M20170103-1405Markus Keller15-17/+17
2016-11-13Increased bundle version for Neon.2R4_6_2M20161124-1400M20161123-0800M20161123-0400M20161122-0800M20161116-1100M20161116-1000M20161116-0400M20161115-1315M20161115-1245M20161115-0815Dani Megert4-5/+5
2016-11-06Bug 428417 - ConcurrentModificationException inM20161110-0200Andrey Loskutov1-1/+2
AbstractMarkerAnnotationModel The fDeletedAnnotations field in AbstractMarkerAnnotationModel uses ArrayList, which is not thread safe and does not allow concurrent modification and iteration. Introducing new locks around fDeletedAnnotations seem to be dangerous. Replacing this with CopyOnWriteArrayList however seem to be a better solution - it does not add any new locks and should allow safe iteration while other thread modifies the list. Looking at the usage of fDeletedAnnotations, it should be OK to iterate on "old" state. Change-Id: I17fea70fcccf578212e9fdb557a9f0f68aa64dc4 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> (cherry picked from commit 6540c4c82552458c680d5c01672d0c573db2efd7)
2016-11-06Bug 482354 - SVN checkout deadlocks EclipseM20161109-0400Andrey Loskutov8-16/+470
FileDocumentProvider.refreshFile(IFile) is called from UI thread but in worst case (if the IFile is out-of-sync with file system state) it acquires workspace lock for refreshing the resource state. If at same time any workspace job holding a lock on a parent project will try to use IOConsoleOutputStream.write(String) to report lot of data (> 160000 characters) to the console, the IOConsolePartitioner.streamAppended() call will block forever waiting for queue processed by the (locked) UI thread. Proposed solution: FileDocumentProvider.refreshFile(IFile) should run DocumentProviderOperation in providers runnable context to avoid such deadlocks. In the case the resource tree is locked, a "User Operation is Waiting" progress dialog will be shown, giving the user a chance to resolve the deadlock situation by canceling one of the affected tasks. To be consistent with existing API and to allow clients override the supplied refresh rule, new API is introduced in FileDocumentProvider: protected ISchedulingRule.getRefreshRule(Object element). Default implementation in FileDocumentProvider uses ResourceRuleFactory.refreshRule for given file. Conflicts: org.eclipse.ui.editors.tests/META-INF/MANIFEST.MF org.eclipse.ui.editors.tests/pom.xml org.eclipse.ui.editors/META-INF/MANIFEST.MF org.eclipse.ui.editors/pom.xml Change-Id: Id742d98403cc546fad4a21d25eb18ab7bef48776
2016-11-02Bug 498907 - IllegalStateException in ProjectionMapping.toImageLine Sergey Prigogin1-2/+16
Do not allow IllegalStateException to propagate outside of the MatchingCharacterPainter.paintControl method. This change does not fix the root cause of bug 498907 but makes the symptoms less severe. This solution is intended for the 4.6 maintenance stream. The 4.7 development stream contains a more general protection mechanism guarding against exceptions in SWT event listeners. Change-Id: Ic077d88997dbefb76abf9c8aadf6b57100d44518
2016-10-03Bug 502554: Update parent pom to 4.6.2M20161102-0400M20161026-0400M20161019-0640M20161019-0400M20161013-0730M20161012-1220M20161012-1050M20161012-0900M20161012-0600M20161006-1230M20161005-1200Markus Keller15-17/+17
2016-09-29Bug 497051 - Improve text search when multiple files have same locationMickael Istria1-45/+95
In case 2 files have the same location, we can assume their content are the same so search results would be the same. This change takes advantage of that assumption to reuse search result of a previous file if it has same location. To take advantage of this logic, the files to search are sorted by location (so we can simply compare with previous file rather than storing all search results). Signed-off-by: Mickael Istria <mistria@redhat.com> Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2016-08-19Increased bundle version for Neon.1R4_6_1M20160914-1200M20160907-1200M20160907-0400M20160831-0700M20160831-0400M20160829-0800M20160824-0059Dani Megert2-3/+3
2016-08-19Fixed bug 499980: [content assist] Potential NPE belowDani Megert1-0/+2
CompletionProposalPopup.computeProposals if no proposals possible
2016-08-18Increased bundle version for Neon.1Dani Megert2-2/+2
2016-08-16Bug 496754 - Providing generic way for editors to consume zoom in / out ↵Ilya Buziuk1-1/+1
functionality via Adapter Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com> Change-Id: Ib8a5e30591f1b3c640e164b37294263f1c70f537
2016-06-28Bug 496465: Prep for 4.6.1 (Neon.1) maintenance buildsM20160817-0420M20160810-1300M20160803-1700M20160803-1000M20160727-1700M20160727-1000M20160721-0445M20160720-1000M20160715-0900M20160713-1359M20160713-1000Markus Keller15-17/+17
2016-05-30Bug 494939: Do not let dialog scroll horizontallyR4_6I20160606-1100I20160603-1000I20160602-1000I20160601-2000I20160601-1000I20160531-2330I20160531-2000Christian Georgi1-2/+2
Otherwise very long search texts would make the dialog grow excessively wide. Change-Id: I10d57a96f792290fe7706fc18eb98bba2e7f54bf Signed-off-by: Christian Georgi <christian.georgi@sap.com>
2016-05-19Revert "Bug 493687 - UI slow to respond during file search"Y20160526-1000I20160530-2000I20160529-2000I20160528-1500I20160527-2000I20160525-2000I20160524-2000I20160523-2000I20160522-2000I20160521-1500I20160520-2000I20160519-1730I20160519-1100Dani Megert1-1/+1
This reverts commit 31453f940bb5a7a2a6e89c1c7b73500e1a306a24. Change-Id: I9e85a29da4873a6df1c1c29a0d542537b6e76b3f
2016-05-18Bug 382972: [HiDPI] Update UI for Retina display on Mac and other high ↵Y20160519-1000I20160518-2000Markus Keller29-0/+0
resolution displays Change-Id: I84299e48ee79ed20730cd04391b751002238782d
2016-05-17Bug 493687 - UI slow to respond during file searchI20160517-2000Sergey Prigogin1-1/+1
Change-Id: Ic1e9ce1415d6b19c7ea5e24ba8f30491bdb9bc08
2016-05-17Bug 489551 - File Search silently drops results on StackOverflowErrorSergey Prigogin1-83/+76
Change-Id: If4b23b87c6c60105e56befe4bafe0d3b36f905d6
2016-05-12Bug 492587: Autosave breaks Incremental FindMarkus Keller1-2/+13
Change-Id: I44fac280f24f2c97a67f3fd70781e4bd5dd86fda
2016-05-12Bug 492251 - Enable the gerrit.createchangeid propertyY20160513-1000I20160516-2000I20160515-2000I20160514-1500I20160513-2000I20160512-1000Stefan Xenos1-0/+6
Change-Id: I1eddfc91196c32526519967c63bb8e0734ee8eb7 Signed-off-by: Stefan Xenos <sxenos@gmail.com>
2016-05-05Fixed bug 466114: [content assist] Parameter Hints popup closes when ↵Y20160505-1000I20160511-2000I20160511-0400I20160510-2000I20160509-2000I20160508-2000I20160507-1500I20160506-2000I20160506-1030I20160506-0830I20160505-2000Markus Keller1-2/+2
attempting to resize on GTK Signed-off-by: Markus Keller <markus_keller@ch.ibm.com>
2016-05-05Bug 492973 - Avoid invoking inefficient new String() constructor inLars Vogel7-8/+8
eclipse.text Change-Id: I9a45a3bd1583ca517a124ea63d70b17d37305d6a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-05-04Bug 211767: [hovering] focus control in information controls not correctI20160504-2000Markus Keller1-0/+4
Javadoc fix
2016-05-03Bug 492875 - Remove the "strictly compatible JRE" per-project overrideI20160504-0035I20160503-2000Lars Vogel13-26/+0
in eclipse.platform.ui project Change-Id: Ifd4b4399d620c32f3ca9e52627f7b940c58557e8 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2016-04-25Bug 485757 - Zoom in and zoom out icons look bad on dark backgroundTony McCrary55-37/+37
Change-Id: I824c8a63ef9c5fe861cf09bb3c2d42ec2fe548a7 Signed-off-by: Tony McCrary <tmccrary@l33tlabs.com>
2016-04-25Bug 490951 - Overview ruler inverted when using themed scroll.Y20160428-1430Y20160428-1000I20160502-2000I20160501-2000I20160430-2000I20160429-2300I20160429-2000I20160428-0800I20160427-2000I20160427-1200I20160427-0800I20160427-0400I20160426-2330I20160426-2000I20160426-1615I20160426-1430I20160426-1245I20160426-1105I20160426-1045I20160426-1000I20160426-0800I20160426-0130I20160426-0030I20160425-2230I20160425-2000I20160425-1300Fabio Zadrozny2-11/+35
Makes the HeaderPainter invisible if there are no scroll bars. Fixes the computation of positions in the overview ruler. Change-Id: I5900ac1bf9e03069a23c971c1bf82f46ed3650f0 Signed-off-by: Fabio Zadrozny <fabiofz@gmail.com>
2016-04-25Bug 487357: Make find dialog content scrollableI20160425-0800Christian Georgi1-14/+25
Change-Id: Iaaff16e99ee34c72bca3b34d24858bfca31a3104 Signed-off-by: Christian Georgi <christian.georgi@sap.com>
2016-04-22Fixed bug 492177: Clean up the removal of "Enable word wrap when opening an ↵I20160424-2245I20160424-2000Dani Megert1-3/+1
editor" preferences option
2016-04-22Bug 492177 - Clean up the removal of "Enable word wrap when opening anAndrey Loskutov1-7/+2
editor" preferences option See also bug 488162 - [word wrap] Hide WW preference to avoid unexpected performance impact. Removed keywords pointing to the hidden preference. Change-Id: Ibcaf242004ee5971439a701738c5f00cb4b244b7 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-04-21Bug 324810: [block selection] specify a win7 font value for ↵Markus Keller1-1/+1
org.eclipse.ui.workbench.texteditor.blockSelectionModeFont
2016-04-21Updated copyright dateY20160421-1000Dani Megert1-1/+1
2016-04-21Bug 477471 - Search view: Remove 'Search Again' and 'Expand All' from ↵Robert Roth1-5/+2
context menu Removed 'Expand All' from the context menu Signed-off-by: Robert Roth <robert.roth.off@gmail.com>
2016-04-20Bug 477471 - Search view: Remove 'Search Again' from context menu Robert Roth1-1/+1
Removed Search Again from search result context menu. Change-Id: I2e5d1c3ea1a33d1640450834298dade89bcaf4ff Signed-off-by: Robert Roth <robert.roth.off@gmail.com>
2016-04-13Bug 485540: [rulers] Annotations in overview ruler scale incorrectly in ↵Y20160414-1000I20160419-0800I20160417-1112Markus Keller1-4/+7
regards to scrollbar thumb
2016-04-11Bug 233427: [find/replace] Shift+Click implementation doesn't work on GTKI20160412-0800Markus Keller1-3/+3
workaround for bug 380257, and probably the right solution anyway
2016-04-11Bug 489474: Add an oomph configuration for the platform.text repositoryMarkus Keller1-11/+0
removed wrong top-level .project file
2016-04-04Bug 487095: Move test bundles to JUnit 4Y20160407-1000I20160405-0800Markus Keller29-163/+253
- implement JUnitSourceSetup as ExternalResource - clean up test suites - update manifests - use @Rule TestName to access test method names FindReplaceDialogTest: - fix test order - fix wrong @Before tearDown() Change-Id: Ibae60f592ea81dbbf2fab0db8daf64f92301dcdd
2016-04-04Bug 45026: Document (?u) and (?U) flagsMarkus Keller1-16/+21
2016-04-02Bug 487262 - Remove the workaround for bug 123770Stefan Xenos1-9/+3
Please don't commit this until the fix for bug 123770 has been in place for at least one integration build. Change-Id: I72a7a8f027939601a130a7d667f9cd2a7022c858 Signed-off-by: Stefan Xenos <sxenos@gmail.com>
2016-03-29Polished fix for bug 382953: [implementation] FastPartitioner broken for ↵Y20160331-1000I20160330-1230I20160330-0930I20160329-0800Dani Megert1-4/+3
changes in the first partition
2016-03-25Bug 382953 - [implementation] FastPartitioner broken for changes in the ↵Tom Schindl1-2/+2
first partition Change-Id: I273573419f4de1ca80d32074be45634d592992cc Signed-off-by: Tom Schindl <tom.schindl@bestsolution.at>
2016-03-25Bug 382953 - [implementation] FastPartitioner broken for changes in the ↵Tom Schindl1-0/+3
first partition Change-Id: I3212683ac9117f19c636f950b105404861d3647a Signed-off-by: Tom Schindl <tom.schindl@bestsolution.at>
2016-03-21Fixed bug 489715: [templates] Insert template does not add default valueY20160324-1000I20160322-0800Noopur Gupta1-1/+1
of word_selection and line_selection templates Change-Id: Ib798ad28e296aed6d986b242368215f3776a60a5 Signed-off-by: Noopur Gupta <noopur_gupta@in.ibm.com>
2016-03-18Document that a document always has at least one lineDani Megert1-4/+7
2016-03-18Fixed bug 487671: [templates] Fix Javadoc for WordSelection template variableDani Megert1-2/+2
2016-03-14Bug 483937 - use new JFaceTextUtil.computeLineHeight() in DiffPainterY20160317-0800I20160317-0200I20160316-2000I20160316-1200I20160316-0800I20160315-2000I20160315-0800I20160314-2000Andrey Loskutov1-16/+3
For client interested in *full real* text line height (including all wrapped line segments) replaced call to StyledText.getLineHeight(int) with new JFaceTextUtil.computeLineHeight() API. Change-Id: I7df34cb98f00051367fd6b4680d1ead3499f5549 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-03-14Bug 483937 - add JFaceTextUtil.computeLineHeight(StyledText, int) APIAndrey Loskutov1-4/+32
Introduced the new "int computeLineHeight(StyledText, int)" API in JFaceTextUtil, which should provide clients the full line height for the text line corresponding to the given StyledText line, considering the possible line wrapping. Change-Id: I7137a181aed633a3793f15b26de831d35796c0d5 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2016-03-14Bug 467499 - [GTK3] Issue in layout of editors ("leaking" rulers)Eric Williams5-18/+14
Re-factor IS_MAC_BUG_298936 field to AVOID_NEW_GC in order to make code more understandable. Change-Id: I718218975ac6b026ccb65337def386b97bdc1227 Signed-off-by: Eric Williams <ericwill@redhat.com>
2016-03-14Bug 467499 - [GTK3] Issue in layout of editors ("leaking" rulers)I20160314-1400Eric Williams5-10/+17
This bug was primarily caused by Canvases being re-painted without checking for visibility of said Canvas. In SWT, there are methods in Control called redraw() and update(), which re-paint a Control. These methods include visibility checks to prevent double painting. Paint event cases stay the same, as paint events are not triggered by invisible regions. Instead of creating a new GC and calling doubleBufferPaint(), we can use redraw() and update() to re-paint editor rulers. This is already done on OSX, so the code already exists. Only the if statement needs to be edited to allow the code path to exist on GTK. This will also increase performance, as creating a new GC involves native machinery which is relatively expensive compared to using existing Controls. Tested on GTK3.18, 3.16, 3.14, and 2.24. No SWT tests ran as this is a platform patch. Windows and OSX behavior is unaffected. Change-Id: I5e7d21cb68ccc67999abdc83071c8f64376748b4 Signed-off-by: Eric Williams <ericwill@redhat.com>

Back to the top