diff options
| author | Andrey Loskutov | 2017-03-11 23:15:33 +0000 |
|---|---|---|
| committer | Andrey Loskutov | 2017-03-11 23:15:33 +0000 |
| commit | c88654a1094f40f402575bfd0e258aade7dac74b (patch) | |
| tree | 0f68b5c92fed7b39946bfd43445cf0d33a4edcb6 /org.eclipse.ui.workbench.texteditor | |
| parent | 8253bfb80f6510e5d1c7e2e757af04dd11343cac (diff) | |
| download | eclipse.platform.text-c88654a1094f40f402575bfd0e258aade7dac74b.tar.gz eclipse.platform.text-c88654a1094f40f402575bfd0e258aade7dac74b.tar.xz eclipse.platform.text-c88654a1094f40f402575bfd0e258aade7dac74b.zip | |
Bug 513517 - printStackTrace() should not be used in production codeI20170315-0500I20170314-2000I20170313-2000I20170312-2000
Change-Id: I7b4a4d0a1af3979852269b1ee53fb9a8ba444e93
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Diffstat (limited to 'org.eclipse.ui.workbench.texteditor')
2 files changed, 5 insertions, 3 deletions
diff --git a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java index a169e279ab2..b196c83ce69 100644 --- a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java +++ b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java @@ -107,8 +107,7 @@ public final class HippieProposalProcessor implements IContentAssistProcessor { String replacement= fString.substring(offset - fOffset); document.replace(offset, 0, replacement); } catch (BadLocationException x) { - // TODO Auto-generated catch block - x.printStackTrace(); + // ignore } } diff --git a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java index f783dcfb705..04987fc3b24 100644 --- a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java +++ b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java @@ -48,6 +48,8 @@ import org.eclipse.swt.widgets.TreeColumn; import org.eclipse.swt.widgets.TreeItem; import org.eclipse.core.runtime.Assert; +import org.eclipse.core.runtime.IStatus; +import org.eclipse.core.runtime.Status; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IAction; @@ -1307,7 +1309,8 @@ public abstract class AbstractTemplatesPage extends Page implements ITemplatesPa try { getTemplateStore().save(); } catch (IOException e) { - e.printStackTrace(); + TextEditorPlugin.getDefault().getLog().log(new Status(IStatus.ERROR, TextEditorPlugin.PLUGIN_ID, + TemplatesMessages.TemplatesPage_save_error_message, e)); MessageDialog.openError(getShell(), TemplatesMessages.TemplatesPage_save_error_message, e.getMessage()); } |