diff options
| author | Matthias Becker | 2018-02-09 09:58:32 +0000 |
|---|---|---|
| committer | Matthias Becker | 2018-02-12 09:06:13 +0000 |
| commit | ce56a0e12ccc495fa9319cadecf18e2bf7d6a9b6 (patch) | |
| tree | 8d06158f5e154a8e995a826631e9a5a4b7b17364 /org.eclipse.ui.editors | |
| parent | 101d3f2be142e55728dd942c2504af299ba33b1f (diff) | |
| download | eclipse.platform.text-ce56a0e12ccc495fa9319cadecf18e2bf7d6a9b6.tar.gz eclipse.platform.text-ce56a0e12ccc495fa9319cadecf18e2bf7d6a9b6.tar.xz eclipse.platform.text-ce56a0e12ccc495fa9319cadecf18e2bf7d6a9b6.zip | |
Bug 517393: Dark theme hyper-link text is dark blue
Dark theme hyper-link text was dark blue on black background in JDT's
Javadoc. The cause is that JDT's CSS contains hard-coded colors for
the links.
To solve this provide a mechanism in HTMLPrinter to replace symbolic
color names with actual color values from the preferences.
A consumer of HTMLPrinter now can you the symbolic names
hyperlinkColor and
activeHyperlinkColor in their stylesheets.
These symbolic names are replaced with
JFacePreferences.HYPERLINK_COLOR and
JFacePreferences.ACTIVE_HYPERLINK_COLOR by HTMLPrinter automatically.
Also fixed: If one changed the theme or color preferences the cached
colors in HTMLPrinter were not updated.
Change-Id: I386c0a7feff6da132b76bd3ff80c91b4fb919b67
Signed-off-by: Matthias Becker <ma.becker@sap.com>
Diffstat (limited to 'org.eclipse.ui.editors')
| -rw-r--r-- | org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/RevisionHoverInformationControlCreator.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/RevisionHoverInformationControlCreator.java b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/RevisionHoverInformationControlCreator.java index 10ece57026c..5f417e24e1b 100644 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/RevisionHoverInformationControlCreator.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/RevisionHoverInformationControlCreator.java @@ -53,8 +53,8 @@ class RevisionHoverInformationControlCreator extends AbstractReusableInformation "dd { margin-top: 0; margin-bottom: 0 }\n" + //$NON-NLS-1$ "\n" + //$NON-NLS-1$ "/* Styles and colors */\n" + //$NON-NLS-1$ - "a:link { color: #0000FF }\n" + //$NON-NLS-1$ - "a:hover { color: #000080 }\n" + //$NON-NLS-1$ + "a:link { color: hyperlinkColor }\n" + //$NON-NLS-1$ + "a:hover { color: activeHyperlinkColor }\n" + //$NON-NLS-1$ "a:visited { text-decoration: underline }\n" + //$NON-NLS-1$ "h4 { font-style: italic }\n" + //$NON-NLS-1$ "strong { font-weight: bold }\n" + //$NON-NLS-1$ |