Use isEmpty() instead of size()==0 where possibleI20190613-0210I20190612-1800

Change-Id: Ib6c59f4c9cea396c98196d23ff9ea917e2ef4114
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>

8 files changed, 11 insertions, 11 deletions

diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java
index 697a3a38765..4d7c78ba543 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningManager.java
@@ -119,7 +119,7 @@ public class CodeMiningManager implements Runnable {
 	@Override
 	public void run() {
 		if (fViewer == null || fInlinedAnnotationSupport == null || fCodeMiningProviders == null
-				|| fCodeMiningProviders.size() == 0 || fViewer.getAnnotationModel() == null) {
+				|| fCodeMiningProviders.isEmpty() || fViewer.getAnnotationModel() == null) {
 			return;
 		}
 		// Cancel the last progress monitor to cancel last resolve and render of code
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java
index eb783f4280b..f96276a985d 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java
@@ -173,7 +173,7 @@ public final class RevisionPainter {
 			float scale;
 			if (fRenderingMode == IRevisionRulerColumnExtension.AGE) {
 				int index= computeAgeIndex(revision);
-				if (index == -1 || fRevisions.size() == 0) {
+				if (index == -1 || fRevisions.isEmpty()) {
 					rgb= getBackground().getRGB();
 				} else {
 					// gradient from intense red for most recent to faint yellow for oldest
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/DocumentCommand.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/DocumentCommand.java
index 37d869c3010..cf6898d4d8a 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/DocumentCommand.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/DocumentCommand.java
@@ -391,7 +391,7 @@ public class DocumentCommand {
 	 */
 	void execute(IDocument document) throws BadLocationException {
 
-		if (length == 0 && text == null && fCommands.size() == 0)
+		if (length == 0 && text == null && fCommands.isEmpty())
 			return;
 
 		DefaultPositionUpdater updater= new DefaultPositionUpdater(getCategory());
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/PaintManager.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/PaintManager.java
index 08ac23004e9..e9c38bbd20f 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/PaintManager.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/PaintManager.java
@@ -220,7 +220,7 @@ public final class PaintManager implements KeyListener, MouseListener, ISelectio
 			painter.deactivate(true);
 			painter.setPositionManager(null);
 		}
-		if (fPainters.size() == 0)
+		if (fPainters.isEmpty())
 			dispose();
 	}
 
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextPresentation.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextPresentation.java
index a23b5932e6f..ff79eff039e 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextPresentation.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextPresentation.java
@@ -270,7 +270,7 @@ public class TextPresentation {
 		int length= range.length;
 		int end= start + length;
 
-		if (fRanges.size() == 0) {
+		if (fRanges.isEmpty()) {
 			StyleRange defaultRange= getDefaultStyleRange();
 			if (defaultRange == null)
 				defaultRange= range;
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
index c98fa3ec50d..2c266dcea06 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java
@@ -2491,7 +2491,7 @@ public class TextViewer extends Viewer implements
 
 		if (fPostSelectionChangedListeners != null)  {
 			fPostSelectionChangedListeners.remove(listener);
-			if (fPostSelectionChangedListeners.size() == 0)
+			if (fPostSelectionChangedListeners.isEmpty())
 				fPostSelectionChangedListeners= null;
 		}
 	}
@@ -2661,7 +2661,7 @@ public class TextViewer extends Viewer implements
 
 		if (fTextListeners != null) {
 			fTextListeners.remove(listener);
-			if (fTextListeners.size() == 0)
+			if (fTextListeners.isEmpty())
 				fTextListeners= null;
 		}
 	}
@@ -2709,7 +2709,7 @@ public class TextViewer extends Viewer implements
 
 		if (fTextInputListeners != null) {
 			fTextInputListeners.remove(listener);
-			if (fTextInputListeners.size() == 0)
+			if (fTextInputListeners.isEmpty())
 				fTextInputListeners= null;
 		}
 	}
@@ -5446,7 +5446,7 @@ public class TextViewer extends Viewer implements
 
 		if (fTextPresentationListeners != null) {
 			fTextPresentationListeners.remove(listener);
-			if (fTextPresentationListeners.size() == 0)
+			if (fTextPresentationListeners.isEmpty())
 				fTextPresentationListeners= null;
 		}
 	}
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/reconciler/DirtyRegionQueue.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/reconciler/DirtyRegionQueue.java
index fc4c7f11bc7..c342fc77627 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/reconciler/DirtyRegionQueue.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/reconciler/DirtyRegionQueue.java
@@ -98,7 +98,7 @@ class DirtyRegionQueue {
 	 * @return the next dirty region on the queue
 	 */
 	public DirtyRegion removeNextDirtyRegion() {
-		if (fDirtyRegions.size() == 0)
+		if (fDirtyRegions.isEmpty())
 			return null;
 		DirtyRegion dr= fDirtyRegions.get(0);
 		fDirtyRegions.remove(0);
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/InlinedAnnotationSupport.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/InlinedAnnotationSupport.java
index 69aa435caa5..cc897c5549a 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/InlinedAnnotationSupport.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/InlinedAnnotationSupport.java
@@ -441,7 +441,7 @@ public class InlinedAnnotationSupport {
 			for (AbstractInlinedAnnotation ann : annotations) {
 				ann.setSupport(this);
 			}
-			if (annotationsToAdd.size() == 0 && annotationsToRemove.size() == 0) {
+			if (annotationsToAdd.isEmpty() && annotationsToRemove.isEmpty()) {
 				// None change, do nothing. Here the user could change position of codemining
 				// range
 				// (ex: user key press