summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMickael Istria2018-05-03 14:22:27 -0400
committerMickael Istria2018-05-04 04:29:49 -0400
commit95e1301bd4f658b8cfbd728ef4f504e1c62f6c60 (patch)
tree4752c79bfb6d7787790b0bd5f61245ff4638d4be
parent7140afe557f9a04fc8e4e3b00e51a287e0b593ad (diff)
downloadeclipse.platform.text-95e1301bd4f658b8cfbd728ef4f504e1c62f6c60.tar.gz
eclipse.platform.text-95e1301bd4f658b8cfbd728ef4f504e1c62f6c60.tar.xz
eclipse.platform.text-95e1301bd4f658b8cfbd728ef4f504e1c62f6c60.zip
Bug 534325 - Generic editor shows 2 "highlight" buttons in toolbarI20180505-1500I20180504-2000
It seems like the actionSet do persist a lot of state about buttons, so the commands that are added in the actionSet toolbar with the previous "hack" lead to having buttons persisted in the actionSet state and added as part of it, then added again by the command framework, and again and again, once per startup of the IDE. To improve this situation, work should happen in bug 527007 and in Platform to replace the actionSet by regular commands and menu contributions, that are much more flexible and do not persist buttons. Change-Id: Ic57a478795e6b5d1df8c1551f2d786b1808b3c8f Signed-off-by: Mickael Istria <mistria@redhat.com>
-rw-r--r--org.eclipse.ui.genericeditor/plugin.xml10
1 files changed, 1 insertions, 9 deletions
diff --git a/org.eclipse.ui.genericeditor/plugin.xml b/org.eclipse.ui.genericeditor/plugin.xml
index f2c4b4af6..78ddce654 100644
--- a/org.eclipse.ui.genericeditor/plugin.xml
+++ b/org.eclipse.ui.genericeditor/plugin.xml
@@ -86,15 +86,7 @@
</menuContribution>
<menuContribution
allPopups="false"
- locationURI="toolbar:org.eclipse.ui.edit.text.actionSet.presentation?after=additions">
- <separator
- name="Presentation"
- visible="false">
- </separator>
- </menuContribution>
- <menuContribution
- allPopups="false"
- locationURI="toolbar:org.eclipse.ui.edit.text.actionSet.presentation?before=Presentation">
+ locationURI="toolbar:org.eclipse.ui.edit.text.actionSet.presentation">
<command
commandId="org.eclipse.ui.genericeditor.togglehighlight"
label="%command.toggle.highlight.label"