Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Keller2017-02-08 16:23:03 -0500
committerMarkus Keller2017-02-20 14:11:35 -0500
commit3ca21626191205535e438c5b922c48daacd50b4e (patch)
treef5d063e1773ff485feadc0aa17f4868693afa48f
parent74ba31227ea48ab3b181a099d83f775a8011d65a (diff)
downloadeclipse.platform.text-R4_6_maintenance.tar.gz
eclipse.platform.text-R4_6_maintenance.tar.xz
eclipse.platform.text-R4_6_maintenance.zip
Bug 511596: [painting][rulers] Rulers are forcing synchronous paints during scrollS4_6_3_RC4S4_6_3_RC3R4_6_3M20170301-0400M20170228-0545M20170222-0400R4_6_maintenance
-rw-r--r--org.eclipse.jface.text/src/org/eclipse/jface/text/source/VerticalRuler.java21
1 files changed, 12 insertions, 9 deletions
diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/VerticalRuler.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/VerticalRuler.java
index 04e361675..311f411fc 100644
--- a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/VerticalRuler.java
+++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/VerticalRuler.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2000, 2016 IBM Corporation and others.
+ * Copyright (c) 2000, 2017 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -81,14 +81,17 @@ public final class VerticalRuler implements IVerticalRuler, IVerticalRulerExtens
}
}
- /**
- * <code>true</code> if we're on a Mac/GTK, where "new GC(canvas)" is expensive.
- * @see <a href="https://bugs.eclipse.org/298936">bug 298936</a>
- * @see <a href="https://bugs.eclipse.org/467499">bug 467499</a>
- * @since 3.6
- */
- static final boolean AVOID_NEW_GC= Util.isMac() || Util.isGtk();
-
+ /**
+ * <code>true</code> if we're on a Mac/GTK, where "new GC(canvas)" is expensive.
+ * <b>Warning:</b> On Windows, we can't switch to direct-paint mode, because
+ * calls to update() have been removed, and now repaints would only happen with huge
+ * delays when scrolling, see <a href="https://bugs.eclipse.org/511596#c26">bug 511596 comment 26</a>.
+ *
+ * @see <a href="https://bugs.eclipse.org/298936">bug 298936</a>
+ * @see <a href="https://bugs.eclipse.org/467499">bug 467499</a>
+ * @since 3.6
+ */
+ static final boolean AVOID_NEW_GC= Util.isMac() || Util.isGtk();
/** The vertical ruler's text viewer */

Back to the top