Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Valenta2002-09-03 09:05:45 -0400
committerMichael Valenta2002-09-03 09:05:45 -0400
commite7c21f77b43ef3fa0d88b940a1647f58ed4508cb (patch)
treec5b3aeefb647ca1884b0c636ded23e84886d3b0a
parentdf7c03475d5b8680dfda113a6cf11ed91ba8f108 (diff)
downloadeclipse.platform.team-branch_21281.tar.gz
eclipse.platform.team-branch_21281.tar.xz
eclipse.platform.team-branch_21281.zip
*** empty log message ***branch_21281
-rw-r--r--bundles/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/actions/CVSAction.java20
1 files changed, 8 insertions, 12 deletions
diff --git a/bundles/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/actions/CVSAction.java b/bundles/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/actions/CVSAction.java
index 12ee6a676..2111c15b5 100644
--- a/bundles/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/actions/CVSAction.java
+++ b/bundles/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/actions/CVSAction.java
@@ -60,8 +60,9 @@ import org.eclipse.ui.IWorkbenchWindow;
import org.eclipse.ui.PlatformUI;
/**
- * Superclass for all CVS actions. It provides helper enablement
- * methods and common pre-run and post-run hadling.
+ * CVSAction is the common superclass for all CVS actions. It provides
+ * facilities for enablement handling, standard error handling, selection
+ * retrieval and prompting.
*/
abstract public class CVSAction extends TeamAction {
@@ -69,11 +70,6 @@ abstract public class CVSAction extends TeamAction {
/**
* Common run method for all CVS actions.
- *
- * [Note: it would be nice to have common CVS error handling
- * placed here and have all CVS actions subclass. For example
- * error handling UI could provide a retry facility for actions
- * if they have failed.]
*/
final public void run(IAction action) {
try {
@@ -110,6 +106,11 @@ abstract public class CVSAction extends TeamAction {
}
/**
+ * Actions must override to do their work.
+ */
+ abstract protected void execute(IAction action) throws InvocationTargetException, InterruptedException;
+
+ /**
* This method gets invoked after <code>CVSAction#execute(IAction)</code>
* if no exception occured. Sunclasses may override but should invoke this
* inherited method to ensure proper handling oy any accumulated IStatus.
@@ -230,11 +231,6 @@ abstract public class CVSAction extends TeamAction {
}
ErrorDialog.openError(getShell(), title, message, statusToDisplay);
}
-
- /**
- * Actions must override to do their work.
- */
- abstract protected void execute(IAction action) throws InvocationTargetException, InterruptedException;
/**
* Convenience method for running an operation with the appropriate progress.

Back to the top