Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-01-29Force qualifier update.I20180129-0540Alexander Kurtakov1-0/+1
Due to Bug 521182 - [compiler] method reference on null object should throw NPE at runtime (JLS compliance) Change-Id: I2acd20d411748d8e3c9d5b806aadff9cfa19f35d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-17Bug 527738 [Webkit2] Add test case for calling setUrl with POST data.Roland Grunberg1-0/+28
Simply call bugs.eclipse.org and pass some x-www-form-urlencoded data in the POST message body. Change-Id: I9148ee19468c910044b5f2b93b4a7e96f3730edb Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-01-10Bug 529474 - [GTK] Fix array initialization problemRené Purrio2-2/+54
- Added test for treeitems also. - Added test for third column as well Change-Id: Ia16837a105bad053948faa079ab328aba88a8100 Signed-off-by: René Purrio <rpurrio@itemis.de> Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-01-07Bug 529494 - Convert to StringBuilderAlexander Kurtakov1-3/+3
Change-Id: Ic959ed6d7ae7aa50da85837105570b2b69ae66d3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-05Bug 529442: [Webkit2] Add more restrictions on clearAllSessionCookies.Roland Grunberg1-1/+7
The clear all sessions functionality for Webkit2 is only available since version 2.16, so skip the test if this is not satisfied. Change-Id: I0ee752be9f5cc65191b31b1f4f101dea6c2e5570 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2017-12-22Bug 528968: [Wayland] JVM crashes when running JUnit tests on WaylandEric Williams2-4/+7
Guard call to takeScreenshot() so that running the SWT JUnit tests doesn't crash the JVM on Wayland. Change-Id: I0ea725a491dfc1f7781ccd647b706e5a5517fc59 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-12-21Bug 528746 - Added test for StyledText#getOffsetAtPoint(Point)Karsten Thoms2-2/+34
Change-Id: I4e9a0024ec8b5a167815f2a60d313e5596c5217d Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2017-12-18Bug 528415 - CTabFolder tabs vanish after mouse-overSimeon Andreev1-0/+47
If a CTabFolder specifies SWT.RIGHT_TO_LEFT as one of its styles, mouse-over on a tab will make the tab not draw. This painting artifact remains until another window becomes active. See the bug snippet. This is due to wrong clipping set to the draw event in Control.gtk_draw(). The event bounds are correctly set in the case of SWT.MIRRORED (derived from SWT.RIGHT_TO_LEFT), but for the clipping area SWT.MIRRORED is not taken into account. This is a regression coming from bug 421127. This change ensures the event clipping equals the event bounds, on draw event creation. This ensures the tabs of the CTabFolder are redrawn. Change-Id: I3bb9049bac98c5f5d360135771ef43ef1cc1a9b1 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2017-12-15Bug 475659 Data race asyncExecRanLeo Ufimtsev1-3/+5
Use AtomicBoolean instead an array to avoid concurrent read/write warning/issues. Bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=475659 Change-Id: I80f5e026e1cfa6503e45e65e074de855454989cc Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-12-13Bug 528251 - Test to check tab highlight with nested CTabFoldersSimeon Andreev1-0/+83
When a view contains a selected CTabFolder, selecting another view in the same part stack results in non-highlighted view tab. This is the case, since CTabFolder.onActivate/onDeactivate will tell ancestor CTabFolders to highlight resp. not highlight. Selecting another view results in deactivating the nested CTabFolder and so removing highlighting from the part stack tabs. This is a test for the missing highlight. Change-Id: Iad92b122883068114ddeebe96bc422da206d2c85 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2017-12-12Bug 528251 - view CTabFolders result in not highlighted part stack tabSimeon Andreev1-0/+96
When a view contains a selected CTabFolder, selecting another view in the same part stack results in non-highlighted view tab. This is the case, since CTabFolder.onActivate/onDeactivate will tell ancestor CTabFolders to highlight resp. not highlight. Selecting another view results in deactivating the nested CTabFolder and so removing highlighting from the part stack tabs. This regression was introduced with the fix for Bug 474444. With this change, highlighting is toggled only for the CTabFolder which is being activated/deactivated. The change was verified both on Windows and on RHEL+GTK3.14. The problem from Bug 474444 is not observed. Change-Id: I6fd4bf7f049e84d95bd5e83332a6484164623576 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2017-12-08Remove useless code.Alexander Kurtakov1-1/+1
Useless suppress warnings and semicolon. Change-Id: I23b782aae94b774c9a9b38f89f541c659c4c5566 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-12-01Bug 510905 [Webkit2] BrowserFunction with return value back toLeo Ufimtsev1-4/+0
Javascript (PRIOR TO MERGING, SWT BINARY REPO NEEDS TO BE PATCHED) Webkit2 moved it's webprocess into a separate process. For javascript to call a function, it needs to do so via the separate process. To interact with the separate process, we need to implement a webextension, which is a separate '.so' file loaded at run time. The extension needs to reside in it's own folder otherwise webkit will try to load the other .so files as extensions. (See Library.java changes). Communication between the extension and the main process is done via a gdbus channel. Javascript/Java types are packaged into GVariants and transmitted via gdbus. Compilation of the webextension requires webkit2gtk package to be present on build servers. Tests: - All jUnits pass - SWT Snippet (307) that use BrowserFunction work. - Attached local snippet can be used to test sending various paramaters over gdbus and receiving them back prints to main webview. - Child eclipse works fine with the patch. - Afaik, no known error/warnings are produced. (If there are, let me know). This might break 32bit build of SWT though, not tested on 32 bit. Patch set log: -------------- Patchset 6: - Passing webview as string in javascript function. Patchset 8: - Implemented dynamic gdbus bindigs on SWT/Java side. Works. (fairly large patch) Patchset 9: - Implemented gdbus bindings on client side, such that it can reach server. (working) Patchset 10: - Added GVariant conversion functions on SWT side. Works. - Moved code out of OS.java to reside only in WebKitGTK Patchset 11: - Figured out how to provide return value as an object array. Added snippet to show how to provide a string return value. (working) Patchset 12: - Passed webview pointer, index and token to Java. - Fixed typo in type definition. > (Working) Patchset 13: - Now passing javascript arguments along through gdbus to java. > (Working) Patchset 14: (Week 46) - Implemented support for 'null'. (use byte as magic number). - Found that there is a bug in how I deal with return value in gdbus, gdbus returns an array (always). Need to return first item in array. Patchset 15: (Week 46) - Implemented proper return value of java to javascript. - Found that js calls with no paramaters call() fail, need to fix. Patchset 16: (Week 46) - Implemented support for empty arrays (including calls without args). - Code tidy. - Found that I need to implement input argument verification from JS call and from java code ran by user, otherwise gdbus can crash. Patchset 17: (Week 46) - Implement checking of user-input arguments, to ensure it won't break gdbus connection. Patchset 18: (Week 46) - Implemented checking of return value from userfunction, so bad return value doesn't break gdbus. - Code tidy/polish. - Need to implement lazy loading of gdbus, only init gdbus for the first function that we instantiate. - Also still getting warning when loading webkit library. Patchset 19: [Week 47] - Implemented lazy loading of gdbus, to only load when needed. - wrapped getPID() into lock, otherwise had strange debug/execution behaviour. Patchset 20: [Week 47] - Two BrowserInstances with Two BrowserFunctions seem to hang (snippet), (need to investigate) Patchset 21: [W47] - Removed redundant print statements. Cleaned up code. Patchset 22: [W47] - Moved Webkit extension initialization logic into a callback, so that it's guaranteed to be loaded at the most optimal time. (All jUnits pass). Patchset 23: [W47] - Removed redundant println. Patchset 24: [W47] - Implemented mechanism by which webextension is compiled and loaded from a folder. (This needs a patch to binary project's build.properties) Patchset 25: [W47] - Code tidy. Patch complete (ish). Patchset 26: [W47] - forgot to add files to patchset 25. Patchset 27: [W47] - Verified that Browser widget will continue to work if webextension fails to load. - Added relevant warnings. Patchset 28: - Minor update on SWT_LIB_VERSIONS. Change-Id: Iccfc48bc78774ac4120aafd976186381f247c562 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-11-30Bug 527935 - Add Automatic-Module-Name to MANIFEST.MF in SWT repoAlexander Kurtakov1-0/+1
Change-Id: I7ac7f58b3c252b6baabaacae3ac4d3b197b76ba3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-11-28Bug 522020 - [API] Customize different line spacing of StyledText withangelozerr2-2/+88
LineSpacingProvider Change-Id: I5c622f791b6561c1af080cc455343b15c0fba784 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2017-11-20Bug 522181: [Webkit2] Implement clearSessions() on WebKit2.Roland Grunberg1-0/+107
The WebKit2 implementation of clearSessions() will remove session and non-session (those with an expiry) cookies. The API specifies only the former shall be removed but there is no way to be more selective for now. Tested on WEBKIT1 and WEBKIT2 using the JUnit test provided. The general test approach involves manipulating cookies through javascript. Some additional tests have also been added. test_evaluate_Cookie acts as a sanity check for the correct functioning of 'document.cookie' and the browser.evaluate() functionality. test_get_set_Cookies will eventually help with further implementation of the Cookie API on WEBKIT2. Change-Id: Icc17fe90bf4de38c8d5f0fbb7b5937552ce33d54 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2017-10-10Bug 525807 - Use surefire 2.20.1 for swt testsAlexander Kurtakov1-2/+3
Extract surefire version to property to change the version only in one place in the future. Change-Id: Ifbf8891084e0de990c268503639ce382b3cc2a3d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-10-02Bug 525340 [Gtk][Webkit2] Javascript evaluate fails with "SyntaxError:Leo Ufimtsev1-0/+18
Return statements are only valid inside functions" jUnit test to catch such issues in the future. Change-Id: Ib94b293232a42a3c14748a325ea388a3e37ff88b Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-09-27Bug 525264 - Use foreach in snippets and examplesAlexander Kurtakov2-8/+4
Change-Id: I083db281df708346964203015bd9663bb8e943e1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-21Bug 517264 – Refactor Test_*_Browser (setText issues on win)Leo Ufimtsev1-1/+2
On Windows, setTitle() sometimes seems to trigger multiple title changes, once to "about:blank" and then to the actual desired page. This patch skips over "about:blank" changes. Change-Id: I8b30988e32e23162cf81ea45ea267e1aa39445c7 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-18[Bug 500475] Guard 'doubleClickSelection' with 'doubleClickEnabled'.Arne Deutsch1-0/+34
The field 'doubleClickSelection' might be accessed only in case 'doubleClickEnabled' is true. Otherwise it will be null and NPE is the result. In case 'doubleClickEnabled = false" 'selectionAnchor' will already have the correct value. Added snippet to reproduce bug. Change-Id: Id5743435fd231dc03df8376122495a51b9bcb662 Signed-off-by: Arne Deutsch <arne@idedeluxe.com>
2017-08-17Bug 521024 - [api] Provide helpers to use lambda expressions for BrowserAlexander Kurtakov1-276/+155
listeners Adapt tests and examples. Change-Id: I49288d44f25ec2c7f370bc1481f5dd09a35c31a4 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-16Bug 520948: [Tests] [GTK] Increase color test coverage in SWTEric Williams1-0/+254
Add background/foreground color tests to widgets that have different internal mechanisms for setting a background/foreground color. This ensures that certain corner case styles get tested properly. Change-Id: I43bdcd3f4cc620cd94e0ac6f3326a7a8cb43acf8 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-08-16[Bug 520446] Added test cases to cover most code for block selection.Arne Deutsch1-0/+200
Fix test_getSelectionRangesInBlockSelection to work on linux, too. Fix test_getSelectionCountInBlockSelection to work on linux, too. Change-Id: I83dc68ccc7d10f59a138311d0be9249ac624dd39 Signed-off-by: Arne Deutsch <arne@idedeluxe.com>
2017-08-16Bug 520983 - [api] Provide helpers to use lambda expressions forAlexander Kurtakov1-0/+242
ShellListener Add tests. Change-Id: Ia5cfa9c43e5dacb5a0aebba20c8e557321767105 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-15Bug 520948: [Tests] [GTK] Increase color test coverage in SWTEric Williams2-0/+174
Add background/foreground color tests to widgets that have different internal mechanisms for setting a background/foreground color. This ensures that certain corner case styles get tested properly. Change-Id: I52139f3a4e1352790c4f8495dd8cbed637e2af8f Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-08-15Bug 517264 Refactor old Browser* tests -- Skip test_setUrl_remote on badLeo Ufimtsev1-2/+39
connection. test_setUrl_remote() requires a live Internet connection. This test sometimes times out when a build server happens to have a bad Internet connection. This causes noise in the test logs. It's difficult to ensure live connectivity is always present, so instead this test will be skipped if there is no internet present. Note, setUrl(..) is still tested against local files even if an internet connection is not available. Change-Id: I098c1ecf3707c23260440fa0cf9081805198a627 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-14Bug 517264 – Refactor old Browser* tests into Test_*_BrowserI20170814-2000Leo Ufimtsev1-3/+10
Increasing timeout for test_setUrl_remote() as it sometimes timesout on windows. (I presume due to bad internet connection). Change-Id: Ibbaac8538f71a91292fe4d935bd3e4ba0bda6b41 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-13Bug 520884 - [api] Provide helpers to use lambda expressions forAlexander Kurtakov1-0/+97
MouseTrackListener Add tests. Change-Id: I9846addac996fedf6f975e651232f6c9e24af9f4 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-11Bug 520831 - [api] Provide helpers to use lambda expressions forAlexander Kurtakov1-1/+51
TreeListener Add tests. Change-Id: I9f17b21053e70834dd52d859e6352f8a1d5779f2 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-11Bug 520822 - [api] Provide helpers to use lambda expressions forAlexander Kurtakov1-1/+50
MenuListener Add tests for the helper methods. Change-Id: Ifc7f5238a7d60e982d7560bddd3b853e993ecaae Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-11Bug 520806 - [api] Provide helpers to use lambda expressions forAlexander Kurtakov1-1/+49
ExpandListener Add tests. Change-Id: Id8fd3c2d81a7465ece5b02e4cad1b2f6d07239d4 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-10[Bug 520442] Add test cases to cover StyledText.handleMouseDown.Arne Deutsch1-0/+101
Change-Id: Id5d5c5a4d05f05dff9b9142572cd07d40a7c7593 Signed-off-by: Arne Deutsch <arne@idedeluxe.com>
2017-08-10Bug 517264 – Refactor old Browser* tests (investigate *local fail)Leo Ufimtsev1-4/+22
Investigating why test_setUrl_local() is failing on some hudson build platforms. Cocoa/Linux: Might need bigger timeout. Maven can be very slow at times. Win32: Protentially issue on getting url for path. Added alternative method. Need to remove printing of verbose output once fixed. Change-Id: I2994e329bcb71545cfb8c53034dd648f121f7853 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-10Bug 512342 - [api] Provide helper methods to use lambda expressions forAlexander Kurtakov1-0/+48
ControlListener Add tests. Change-Id: I37f3bd8aeeed048ea9c1ff022040bf473ff0c30f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-09Bug 304893 - [Custom Widgets] READ_ONLY CCombo does not de-select textLeo Ufimtsev1-0/+38
on FocusOut (snippet) Snippet to reproduce issue. Change-Id: I50ed901248d350b1f28f5917177ec438113c345e Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09[Bug 520422] Split test cases to contain one test case eachArne Deutsch1-0/+83
Change-Id: I963f5478ee3f5c4f80763cfa9bc161aa14b9dc67 Signed-off-by: Arne Deutsch <arne@idedeluxe.com>
2017-08-09Bug 517264 – Refactor old Browser* tests into Test_*_Browser (part 9)Leo Ufimtsev1-1/+0
Remove export of removed package. Change-Id: Icfb857dd753b9e540f26c0865331a9a5260ded37 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09Bug 517264 : browser_tests (part 8) Leo Ufimtsev5-261/+0
Removing old Browser8. execute() and evaluate() are tested extensively by new evaluate* and execute* tests in Test_*Browser.java. This test is redundant. Change-Id: I62d4ecf730be30e09185c29659b2b72e07c8b564 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09Bug 517264 : browser_tests (part 7) Leo Ufimtsev2-156/+0
Removing Browser7.test() Tests to validate visibility events were added in part part 5: -> test_VisibilityWindowListener_multiple_shells -> test_VisibilityWindowListener_eventSize() Change-Id: I13405c6a791f5c6be0c815bb943445d8205c7997 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09Bug 517264 browser_tests (part 6)Leo Ufimtsev5-190/+72
Replacing Browser6 test with: -> test_TitleListener_event -> test_setText -> test_setUrl_local -> test_setUrl_remote Also update setText()/setUrl to actually verify that url was loaded as oppose to just starting the operation. Change-Id: Ib8965b6b26422ee16e8f2ae414b4fb29ab7b2c67 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09Bug 517264 : browser_tests (part 5)Leo Ufimtsev3-191/+117
Replacing Browser5.test1() with: -> test_VisibilityWindowListener_multiple_shells -> test_VisibilityWindowListener_eventSize() Also introducing the notion of testLog. Print a test log, but only if the test fails. Patchset 4: - Updated to fix Win and Cocoa specific issues. Change-Id: I5b783a0a9e2be2ab0df39d0957c6aa44c47542af Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09Bug 517264 - browser_tests part4Leo Ufimtsev5-230/+13
Removing Browser4. For the most part it's a duplicate of Browser3. The only difference is the added closeWindowListener. -> Most of it is covered by test cases added in part3 -> added test_CloseWindowListener_close to complete coverage. Change-Id: Iff86338177047fa8fc74990559ddb59fa9ff2969 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=517264 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09Bug 517264: browser_tests (Part 3)Leo Ufimtsev4-215/+116
Replace Browser3.test1() with: -> test_OpenWindowListener_openHasValidEventDetails() -> test_OpenWindowListener_open() -> test_OpenWindowListener_open_AndValidateEventOrder() Patchset 2: - Updated patch for parent to set content of child window instead of trying to load 127.0.0.1, as this would not work reliably on webkit1. Patchset 3: - Added similar fix test_OpenWindowListener_openHasValidEventDetails. Patchest 5: - Updated test such that progressCompletion is fired on Windows also. Change-Id: I40f5313488de56afb90660116593f4545183c1f7 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=517264 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-08-09Increment micro version for changes in o.e.swt.tests.Alexander Kurtakov2-3/+3
Change-Id: I8ffcc39e3e27761bb30effc6ecf3fcf6930e16dd Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-08-09Bug 298679 - [StyledText] Fixed left margin if alignment is set.Thorsten Hake1-1/+13
Change-Id: I7144cc95c1f0940e791526c3bb3c4326fe9e007c Signed-off-by: Thorsten Hake <eclipse@thorsten-hake.com>
2017-08-08Bug 519576: [GTK3] Use GTK CSS for background/foreground colors onEric Williams1-0/+166
GTK3.14 and below Test cases to prevent issues with background/foreground colors for SWT.CHECK and SWT.RADIO Buttons. Change-Id: I270b060639c80d0c2c9c22602ec04ce79ad4a4f4 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-25Fix swt.tests build.properties.Alexander Kurtakov1-2/+3
Change-Id: Iaa5e94dae937ee8af3a5c66b70824b1133879ccf Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-07-21Bug 507611 - Unit test highlighting sizing issue.Mickael Istria1-0/+35
Adding jUnit test for failure. Currently marked as Ignored until solution is implemented. Change-Id: I662bdef4af53e352ffda934339e8027b5b92a3d3 Signed-off-by: Mickael Istria <mistria@redhat.com> Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-20Bug 517264: browser_tests (part 2)Leo Ufimtsev3-244/+35
Replacing Browser2 with newer tests. test1->test_LocationListener_ProgressListener_noExtraEvents (new) test2->test_LocationListener_ProgressListener_cancledLoad (from Part 1) Change-Id: Iacfba4e12fcb23c072dc193b873e32d07a0a5869 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=517264 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>

Back to the top