Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2 hoursv4926r16HEADv4926r16aI20190425-1800mastergenie.releng1-1/+1
9 hoursBug 531634 - [GTK] Linux: Handle logoff / shutdown events from session managerAlexandr Miloslavskiy2-52/+33
Hotfix for first version of the patch. Using System.exit() from Shell's 'SWT.Close' event caused deadlock, because main thread held 'Platform.lock' in its event loop and waited for shutdown hook, which waited for the lock - see also Bug 546743. Since multiple Displays are not possible currently (there's only dead code pretending to support it), it should be OK to have non-static object. Having it non-static removes the need for shutdown hook. Signed-off-by: Alexandr Miloslavskiy <>
18 hoursBug 536621 - [Win32] Custom cell style on Table doesn't workNikita Nemkin1-50/+45
Only force custom background color if the widget is disabled. The regression was introduced in 15eb1ba with the fix for Bug 516365. Change-Id: Ib39f0b19303be7f6fbc934e8c83d2d9020156e80 Signed-off-by: Nikita Nemkin <>
26 hoursv4926r16v4926r16I20190425-0030I20190424-1800genie.releng1-1/+1
26 hoursv4926r16genie.releng2-3/+3
34 hoursBug 475833 - SWT API filterLars Vogel1-3/+3
This has been created with the Eclipse quickfix. API Baseline is set to Eclipse 2019-03 and a clean build was triggered two times. Change-Id: I3d095fa7af1a5f28afff27ac1d34ec0ce4a244a9 Signed-off-by: Lars Vogel <>
34 hoursBug 546274: [GTK] vm crash when scrolling StyledTextEric Williams5-38/+125
The method scrollInPixels() doesn't seem to be needed. I've reverted the fix from commit 64ae338b9c279c9bbcc158165aa451193a503c0a to preserve stability on GTK3, but on GTK4 this method is never called. Tested with the snippet attached, as well as the Canvas tab on ControlExample (GTK3 and GTK4). Change-Id: If907bf6c4c805c24eb021b687d5affbbc2e8bc3f Signed-off-by: Eric Williams <>
35 hoursBug 531634 - [GTK] Linux: Handle logoff / shutdown events from session managerAlexandr Miloslavskiy7-1/+764
Fix 1 ----- Previously, SWT applications terminated unexpectedly on session end (logoff / shutdown) and didn't have a chance to perform on-exit actions, such as saving current settings. This patch fixes it, bringing Linux in line with Windows and macOS. SWT applications will now: 1) Receive 'SWT.Close' event for their 'Display'. Similar to Windows and macOS, this now allows to set 'Event.doit' to 'false', hinting the OS that application is not ready to close. Linux often ignores this hint, though. I think handling this properly would require inhibitors which are not yet covered by this patch. 2) Force 'Display.dispose()' when 'EndSession' is received This allows applications to use all forms of on-exit cleanup, such as * Listening to 'SWT.Dispose' * Running code after 'while (!display.isDisposed())' * Installing Java shutdown hooks (because a typical application will exit its 'main()' after display is disposed) Some system properties are available for customization, see code in 'org.eclipse.swt.internal.SessionManagerDBus' Fix 2 ----- Noticed and fixed a memory leak in 'WebkitGDBusinvokeReturnValueExtensionIdentifier'. Fix 3 ----- Moved test snippets to correct folder Change-Id: If968fc4b86cc0b6de192ef3ef4319ca96967cd22 Signed-off-by: Alexandr Miloslavskiy <>
36 hoursBug 546144 - [JNI] Revert some recent jnigen changesNikita Nemkin4-103/+44
Revert "Bug 515610 - [GTK] SWT generates incorrect fall-through for memmove()" This reverts commit 4c3b9d2b9864a1910c5116168456ab215a2dc2aa. Change-Id: Iea193f29a877face605deaa51bfce96027f7d7ac Signed-off-by: Nikita Nemkin <>
36 hoursBug 546144 - [JNI] Revert some recent jnigen changesNikita Nemkin4-383/+353
Revert "Bug 534923 - Cocoa: objc_msgSend is called incorrectly from os.c" This reverts commit 94bbab9593afe86192ce9ff1c7d23f9003c3ef5e. Change-Id: If227caf179ffc8cb018c343d3b99d3535aea8d04 Signed-off-by: Nikita Nemkin <>
36 hoursBug 540357 - [10.14] Make SWT adapt to switching to dark mode (and back)Lakshmi Priya Shanmugam2-1/+58
Widgets should have correct foreground, background colors in the Dark mode. Set default foreground color for Link and Multi-style text. Update multi-style text background color. Change-Id: I49eaee8064edddba3c2e751dd3450b74d02ecacc
40 hoursBug 475833: Delete TableTree and related itemsLars Vogel4-1995/+20
Change-Id: I0811d7d0ae7e449adf85d031d3eaa2ef143ed5c6 Signed-off-by: Lars Vogel <>
41 hoursBug 540357 - [10.14] Make SWT adapt to switching to dark mode (and back)Lakshmi Priya Shanmugam5-8/+12
Set correct foreground color for TabFolder and Tree and Table headers. Redraw header view after setting header fg & bg colors. Table header bg/fg color should use the default color when no color is set, similar to Tree. Change-Id: Ief188ba5fd1fda8efe563fa492a74b4fc01df77d
2 daysv4926r15v4926r15I20190423-1800genie.releng1-1/+1
2 daysv4926r15genie.releng2-3/+3
2 daysBug 546349: [Wayland] Prevent GtkIMContext crashes/warningsEric Williams5-1/+24
Check the imHandle before calling gtk_im_context_reset(). Change-Id: I1cfc46ffeb1ff66d9ceca2415213364826451032 Signed-off-by: Eric Williams <>
2 daysBug 466511: Replace dropdown menu custom drawing with pngMatthias Becker1-2/+13
View dropdown uses grey as foreground color so the min max icons need to use the same color Change-Id: If6d5b618658787ea0f83423c8c817e00fd359f0d Signed-off-by: Matthias Becker <>
3 daysBug 462665 - Remove references to Carbon in SWT Java code and commentsLars Vogel6-9/+8
Change-Id: I5f6a558564239e64db2aae3c504df604ebb884bb Signed-off-by: Lars Vogel <>
3 daysv4926r14v4926r14bI20190422-1800genie.releng1-1/+1
4 daysBug 536021 - [Win32] Table: right-aligned column header with own background ↵Thomas Singer1-1/+1
color lacks margin Change-Id: Ieecfc0d5fa13bfbd99e87cc7616e5cbf97ce285c Signed-off-by: Thomas Singer <>
6 daysv4926r14v4926r14aI20190421-1800I20190420-1800I20190419-1800genie.releng1-1/+1
6 daysBug 493148 - [Win32] Non-editable StyledText can be changed by typing ↵Thomas Singer1-0/+8
Chinese using IME Change-Id: I0a67a1b576abae0c02e4cbcdc469bb786a8a9ecd Signed-off-by: Thomas Singer <>
7 daysBug 546585 - [Cocoa] Don't use objc_msgSend to call variadic functionsNikita Nemkin7-93/+7
JNIGen generates wrong C code for calling variadic ObjC methods, remove all such methods from SWT codebase. Change-Id: Icee75b71c4035a331a4b52ddcaf65e0d59c8793c Signed-off-by: Nikita Nemkin <>
7 daysv4926r14v4926r14I20190418-1800genie.releng1-1/+1
7 daysv4926r14genie.releng2-3/+3
7 daysBug 540903 - [GTK4] Adapt to GtkClipboard changesXi Yan6-2/+45
1) ifdef gdk_display_get_*_clipboard on GTK4 2) Replace gtk_clipboard_clear with gdk_clipboard_set_content(null) Change-Id: I139b8606f01961c31adc56c08ad35c4abd1fb0bc Signed-off-by: Xi Yan <>
8 daysv4926r13v4926r13aI20190417-1800genie.releng1-1/+1
8 daysBug 546493: [GTK4] Button click coordinates are incorrect for some casesEric Williams5-3/+42
This is a two-part fix: 1) Adjust the sendMouseDown() function in Control, as event coordinates on GTK4 are already parent relative. 2) Table/Tree have headers built into the GtkTreeview's surface, meaning the y-coordinates will include the height of the header. This throws off any geometry-item querying code in Table/Tree. The fix is to adjust the coordinates to account for the size of the header. GTK3 doesn't have this problem because the header has its own GdkWindow which is separate from the rest of the Table/Tree. Tested using Snippet3 on GTK4. Change-Id: Ia68a6edb376a823dc3beb57e4db084075e42138b Signed-off-by: Eric Williams <>
9 daysv4926r13v4926r13I20190416-1800genie.releng1-1/+1
9 daysv4926r13genie.releng2-3/+3
9 daysBug 546489 - [GTK4] Replace GtkClipboard with GdkClipboardXi Yan6-5/+57
Replace GtkClipboard with GdkClipboard Change-Id: Iad0c8bff10ab325cf53bde1711bddf0e3842ee9d Signed-off-by: Xi Yan <>
9 daysBug 545943 - [GTK4] Scrolling with the mouse wheel not workingXi Yan1-1/+1
Fix GdkEventControllerScroll flags so that scrolling with mouse works on GTK4. Tested with Snippet 7, 8, 52, 53, 59, 61, 90. Change-Id: I5a4b344e1b7ec0eef75733bdbe04649d15645b77 Signed-off-by: Xi Yan <>
9 daysBug 546488: [GTK4] Cursor never reverts back to normalEric Williams7-6/+31
Use gtk_widget_set_cursor() in certain instances in order to make sure the cursor is set/unset properly. Change-Id: Iad680c4ab71aae79faf6ac7e61513b793dd5380a Signed-off-by: Eric Williams <>
9 daysBug 546481: [GTK4] Fix Snippet4Eric Williams1-2/+5
Allocate to shellHandle so that drawing works properly -- otherwise the snapshot will stop at the child GtkWindow and nothing will be passed on to any of the children. This means the Shell would not draw. Change-Id: I62e7b845fdab99acb864aea86de7916e88829f3e Signed-off-by: Eric Williams <>
9 daysBug 546252 - [GTK] Cleanup for tooltip color fixesAlexandr Miloslavskiy5-76/+52
Fix: ---- All layers are rendered when background color is estimated. This solves the problem for themes that utilize semi-transparent labels in tooltips, such as 'HighContrast'. NOTE: 'gtk_style_context_get_parent' requires 3.4. However, for Eclipse 4.12 requires at least GTK 3.10, so this can be ignored. Code cleaning: -------------- Deleted tooltip-related CSS parsing code that is now dead. Tests: ------ Added snippets I developed during investigation. Change-Id: Ic4504be60df58f32e32b90a487e28af68853977d Signed-off-by: Alexandr Miloslavskiy <>
10 daysBug 545884 - [Win32] Remove TCHAR string wrapper (Part 1)Nikita Nemkin33-321/+244
Replace TCHARs that are used as fixed-size buffers with plain char[] arrays of the same size. Change-Id: Ic54bafb4e865dff62de67a0efefc6020aa5349f3 Signed-off-by: Nikita Nemkin <>
10 daysv4926r12v4926r12aI20190415-1800genie.releng1-1/+1
10 daysBug 545645 - [GTK] Table/Tree header must not keep focusXi Yan1-0/+5
Address issue with updating SWT.VIRTUAL table making header being focused on click. Tested with 2 attached snippets and Snippet38. Change-Id: If02802c01bab05db3b7c241e90dc4a4ed4176608 Signed-off-by: Xi Yan <>
10 daysRevert "Bug 466511: Replace dropdown menu custom drawing with png"Eric Williams1-13/+2
This reverts commit a5d8b38bcb1b0702f9e164aacfd92f5edc1df87b. Change-Id: I519b1f7f74771bdd10a85ab12dca30e37b977982
11 daysBug 546420 - [Win32] Don't guard against GDI+ loading failureNikita Nemkin3-33/+19
GDI+ presence is guaranteed on WinXP and later. Change-Id: Iee3c46ce8a2ac61170a51b06d7986340051ca1c8 Signed-off-by: Nikita Nemkin <>
13 daysv4926r12v4926r12I20190415-0300I20190414-1800I20190414-0210I20190413-1800I20190412-1800genie.releng1-1/+1
13 daysv4926r12genie.releng2-3/+3
13 daysBug 546110 - FileDialog Cancel/OK not localized on LinuxXi Yan2-2/+2
Set labels for GtkFileChooserNative to null to get default localized buttons. Issue fixed for GTK3.20+. Tested with Snippet72. Change-Id: Iaa7a777a12a84b52af634dfc4c64249372d6d81b Signed-off-by: Xi Yan <>
13 daysBug 466511: Replace dropdown menu custom drawing with pngMatthias Becker1-2/+13
View dropdown uses grey as foreground color so the min max icons need to use the same color Change-Id: I4a0c16f8a61faf4ac7d98deb35123d02a4e5ffeb Signed-off-by: Matthias Becker <>
14 daysBug 545854 - [Win32] Drop custom JNI code for GDI+ interopNikita Nemkin8-452/+302
Custom code for point and color conversion is unnecessary, because Color/Point/PointF are binary compatible with primitive arrays. GDI+ Color is a thin wrapper around DWORD, use plain int for interop. Change-Id: If586f3772c4409e4f7583e497552ca6b54d71138 Signed-off-by: Nikita Nemkin <>
14 daysv4926r11v4926r11aI20190412-0520genie.releng1-1/+1
14 daysRemove natures.Alexander Kurtakov4-4/+2
Locking the possible shell script editor to single one doesn't make much sense. Additionally there are better editors like ShellWax either way. Change-Id: I5e08fa8105cd56b8d2c5b278eca6091df5ccc258 Signed-off-by: Alexander Kurtakov <>
2019-04-09Bug 545923 - [regression][GTK] Tooltip foreground is wrongAlexandr Miloslavskiy5-246/+79
Fix 1: ------ The problem with previous approach taken in Bug 545587 was: 'Clearlooks-Phenix' does not define 'color' property for 'tooltip *' CSS selector. Instead, it's expected to be inherited from 'tooltip' CSS selector. However, 'gtk_style_context_set_path' is flawed: it will use parent for searching CSS selector, but it will *not* use parent for inheritance. I'm not sure whether this is GTK bug, GTK design bug, GTK documentation bug, or something else. One thing for sure, 'GtkWidgetPath' approach proved fragile. Also, it requires to set various components carefully, and GTK guys love to change these. Also, 'GtkWidgetPath' seems to be abandoned (even though not deprecated yet), for example GTK commit 101df329 mentions '... applications that still use widget paths ...' So I decided to take another approach: actually create the tooltip and let it handle all the magic itself, then request its GtkStyleContext. This seems to work much more reliably. Since this no longer requires anything from GTK higher then 3.0, I also removed all fallback code paths. Fix 2: ------ Added a quick workaround for 'HighContrast' theme. Change-Id: Icbb0b315bdfed2a1668e622240026a942148ac66 Signed-off-by: Alexandr Miloslavskiy <>

Back to the top