Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-07-24Bug 455854: Text field with SWT.SEARCH style ignores setBackgroundStefan Winkler8-2/+105
Implemented custom SWTSearchFieldCell to handle non-default background color. Change-Id: I80db1fa0c42ca3ad194e8416ef1793aa6328f992 Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
2017-07-24Bug 519996 Widget is disposed exception when closing shell with ccombosAlexander Kurtakov1-1/+1
Fix warning in nighty builds. Change-Id: Ib12b1c8d4ef0c7eab8c7adfcc4da4f2ed87702d1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2017-07-23v4807v4807gI20170723-2000Arun Thondapu1-1/+1
2017-07-22v4807v4807fI20170722-2000Arun Thondapu1-1/+1
2017-07-21v4807v4807eI20170722-0045I20170721-2000Arun Thondapu1-1/+1
2017-07-21Bug 486068: [GTK3.20+] Allocation warnings printed in error consoleEric Williams6-1/+42
This patch fixes up GTK warnings which occur on GTK3.20 and above. They happen when running any SWT application, though mostly when running the Eclipse IDE itself. An example of the type of warning fixed by this patch: Gtk-WARNING **: Negative content width -1 (allocation 1, extents 1x1) while allocating gadget (node trough, owner GtkProgressBar) On GTK3.20+, size calculations take into account GtkCSSNode elements which we cannot access. The fix: if the to-be-allocated size minus these elements is < 0, allocate the preferred size instead. Tested on GTK3.20, 3.22 and 3.18. No visible breakages in the IDE or ControlExample. No failing JUnit test cases occur. Change-Id: I2d3234ba16f3a90c7b81b859a4910cc26337f362 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-21Bug 519996 Widget is disposed exception when closing shell with ccombosLeo Ufimtsev1-0/+40
Snippet to reproduce issue. Change-Id: I609b21126ee8d3b46b188519ba5d45df758ff5cb Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-21Bug 507611 - Unit test highlighting sizing issue.Mickael Istria1-0/+35
Adding jUnit test for failure. Currently marked as Ignored until solution is implemented. Change-Id: I662bdef4af53e352ffda934339e8027b5b92a3d3 Signed-off-by: Mickael Istria <mistria@redhat.com> Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-20v4807v4807dI20170720-2000Arun Thondapu1-1/+1
2017-07-20Bug 517264: browser_tests (part 2)Leo Ufimtsev3-244/+35
Replacing Browser2 with newer tests. test1->test_LocationListener_ProgressListener_noExtraEvents (new) test2->test_LocationListener_ProgressListener_cancledLoad (from Part 1) Change-Id: Iacfba4e12fcb23c072dc193b873e32d07a0a5869 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=517264 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-20Bug 519576: [GTK3] Use GTK CSS for background/foreground colors onEric Williams3-4/+89
GTK3.14 and below This fix reverts some changes in Table and Tree that were not necessary to begin with. They were causing failing test cases in Platform UI and are not integral to the actual bug. Change-Id: I94e61737e2a39bb21dc5846097a83264d72f6d1e Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-20Bug 519916 pom.xml doesn't have to specify webkit as default browserLeo Ufimtsev1-1/+1
anymore In tests/../pom.xml, we hard-code the default browser to be webkit. This causes maven tests related to Browser to fail on Windows as it's trying to use webkit instead of I.e, which by default is not installed. I.e: <argLine> .. -Dorg.eclipse.swt.browser.DefaultType=webkit ... </argLine> Since XUL Runner is removed from codebase, hard-coding webkit is no longer needed. As of recently: - On Linux, webkit is default - On Cocoa, webkit is default - On Win, I.E is default Thus the hard-coding can be safely removed without breakage. Change-Id: I815d3ac45f4c957f0d6f79066d27f2a1d98b2273 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-19v4807v4807cI20170719-2000Arun Thondapu1-1/+1
2017-07-19Bug 519576: [GTK3] Use GTK CSS for background/foreground colors onEric Williams1-2/+4
GTK3.14 and below GtkTreeView still uses the ":selected" selector on GTK3.20+, unlike most other GTK widgets. Therefore the selection CSS needs to change when setting the background/foreground. Change-Id: I926e168482550ca07622164bd0b1899cee43d0ff
2017-07-19v4807v4807bI20170719-0600Arun Thondapu1-1/+1
2017-07-19Bug 517264 browser_tests (Browser1)I20170719-0040Leo Ufimtsev3-233/+97
Replace old Browser1.test() with newer equivalent. Browser1.test1() ->test_LocationListener_changingAndOnlyThenChanged (existing) ->test_LocationListener_then_ProgressListener (new) Browser1.test2() -> test_LocationListener_ProgressListener_cancledLoad (new) Tested on: [X] Webkit1 [X] Webkit2 [x] Cocoa [x] Win32 Change-Id: Iec0df863321cd5245fb51df3fb8e8451131592aa Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-18v4807I20170718-2000Arun Thondapu1-1/+1
2017-07-18Bug 519844 – Improve test_setCursorLocation stabilityLeo Ufimtsev1-4/+17
See bug comment #1 for details. Change-Id: Ibbb8511bf45d577659d64bc4f7ac379ee8b53b93 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-18Bug 519576: [GTK3] Use GTK CSS for background/foreground colors onEric Williams18-189/+103
GTK3.14 and below This patch brings GTK CSS machinery to GTK 3.14. We already use GTK CSS for system colors on GTK 3.14, no reason why background/foreground colors can't use it either. Change-Id: Id8cc46abba9e2e5c333d3d0decf7f11c20d02117 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-18v4807v4807I20170718-0355Arun Thondapu1-1/+1
2017-07-18v4807Arun Thondapu3-4/+4
2017-07-17Bug 494565: [GTK] Snippet243 doesn't work because Text#insert(String)I20170717-2000Eric Williams5-6/+101
modifies topIndex Methods that insert or select text should not modify the topIndex of the viewer. To avoid this issue we calculate the visible area, positions of the topIndex, and the insertion/selection points. If the insertion/selection points are outside the visible area, then scroll to them. Otherwise do nothing, which preserves the topIndex. Tested on GTK3.22, 3.20, 3.18, 3.16, 3.14, 3.10, and 2.24. No additional AllNonBrowser JUnit test failures occur. Change-Id: Ib020473a5a31d535fb0b1b84f8b13e087fa16c62 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-17Bug 500832 - [Win32] StringIndexOutOfBoundsException belowNiraj Modi1-1/+1
Table.wmNotifyChild (thrown in String.getChars) Change-Id: I0481635eeaf599fb2be22a0f203724d6bed24ea7 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2017-07-16v4806v4806pI20170717-0350I20170716-2000Arun Thondapu1-1/+1
2017-07-15v4806v4806oI20170716-0130I20170715-2000Arun Thondapu1-1/+1
2017-07-14v4806v4806nI20170714-2000Arun Thondapu1-1/+1
2017-07-14Bug 519505: [GTK3] Whitespace characters black instead of greyEric Williams1-1/+1
This bug was caused by cairo_set_source_rgba() being fed the Color's alpha value instead of the GCData's alpha value. This fix restores the proper whitespace transparency. Change-Id: Idc11321ab30c453be053cd68d8b9050d12b09228 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-13v4806v4806mI20170713-2000Arun Thondapu1-1/+1
2017-07-12v4806v4806lI20170713-0615I20170712-2000Arun Thondapu1-1/+1
2017-07-12Bug 477950 - [GTK3] Port SWT colors from using GdkColor to GdkRGBA soEric Williams1-0/+127
alpha is not lost Snippet for debugging system color issues, only useful on Fedora (Adwaita theme). Change-Id: I5ed0885e3e2bb760841cdc7ebf4ac9a4ee5c4b10 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-12Bug 519570 - [gtk] fix .project of org.eclipse.swt.tests.featureLeo Ufimtsev1-1/+1
Renaming project name from tools to tests Change-Id: Ia0c2373eb6d11ed804e1d08fffe326d4120d69c2 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-11v4806v4806kI20170711-2000Arun Thondapu1-1/+1
2017-07-11Bug 519416: [GTK] Composite.setBackgroundMode() not working properly onEric Williams1-1/+1
GTK Quick fix for Group to allow backgrounds to be set after setText() is called. This change only affects GTK3.16 and above. No additional JUnit tests failures for GTK 3.16 - 3.22. Change-Id: I7328bd14a3f8e70e8483c5e6384cd9e223af8955 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-10Bug 519328 - [All] Add "Bug Snippets" folder to org.eclipse.swt.testsI20170710-2000Leo Ufimtsev3-0/+119
project Adding an initial snippet for Bug 212416. Change-Id: Ia77ce9997d3c4075cd58606974029905ce70327e Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-10Bug 519177 – [All] update Browser.getText() javadoc to reflect platformLeo Ufimtsev1-1/+6
specific behavior of returned html (ex Windows) Change-Id: I6256b3ac8b7ce2a56c4125bd59aadce805fe1ed2 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-10v4806v4806jArun Thondapu1-1/+1
2017-07-10Bug 518276 Code documentation - OS.java gtk typesLeo Ufimtsev1-1/+1
Fixing minor error in documentation. Change-Id: Id6ba0bab427f842193e6d90d29cbd491f6792487 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-10Bug 519237 [Cocoa] mvn -Pbuild-individual-bundles fails on OSX due toLeo Ufimtsev3-1/+6
missing -XstartOnFirstThread vm arg Adding missing argument for maven test execution. See bug submission for details. Change-Id: Ie6faf2b22afc537373984388684646d6b7054b42 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-10Bug 518657: [GTK] Add bug snippets to GTK only tests project Eric Williams3-5/+20
Add generated serialVersionUID's to prevent warnings during builds. Change-Id: I9ee63bca87bcf0131613cd1cb098bddcd2dfb886 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-09v4806v4806iI20170709-2000Arun Thondapu1-1/+1
2017-07-08v4806v4806hI20170708-2000Arun Thondapu1-1/+1
2017-07-07v4806v4806gI20170707-2000Arun Thondapu1-1/+1
2017-07-07Bug 518379 – Allow platform specific JUnit tests(gtk tests not on cocoa)Leo Ufimtsev1-1/+2
Currently swt gtk only tests are marked to compile/build on cocoa, because Cocoa is a 'unix' family type (as is Linux). The correct solution is to add "<name>Linux</name>" to activation profile. This way the Unix profile is only launched on Linux and not on Cocoa. Found this in: http://maven.40175.n5.nabble.com/Profile-activation-for-mac-and-linux-td3263043.html https://stackoverflow.com/questions/38465711/choose-maven-profile-from-os-family/44975462#44975462 As a note, family names are defined here: https://github.com/sonatype/plexus-utils/blob/f2beca21c75084986b49b3ab7b5f0f988021dcea/src/main/java/org/codehaus/plexus/util/Os.java#L72 Verified on: - Fedora/Ubuntu/CentOS (gtk tests included) - Cocoa (gtk tests not included) Change-Id: I51dd2cd9de9e6efc8c348d1eec083325c2774b2a Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-07Bug 518657: [GTK] Add bug snippets to GTK only tests projectEric Williams17-1/+1343
Merge first batch of snippets from personal repository into the SWT platform specific one. Change-Id: I2e00cf08e14615e3279c85a8ffb1d066ae1283cd Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-06v4806v4806fI20170707-0530I20170706-2000Arun Thondapu1-1/+1
2017-07-06Bug 519321: [GTK3] Preferences window sometimes has white backgroundEric Williams8-0/+41
In Control.setBackgroundGdkRGBA(): if the incoming GdkRGBA is null, then the background color needs to be reset to COLOR_WIDGET_BACKGROUND. On GTK3.16+ there is an automatic check with GTK CSS to set incoming GdkRGBA's as COLOR_WIDGET_BACKGROUND if they are null. Setting a null GdkRGBA using GtkStyleContext machinery resets the current color to its previous value, which now (after bug 477950) could sometimes be transparent. This is what was causing the bug. The fix is to set incoming GdkRGBA's that are null to COLOR_WIDGET_BACKGROUND. Of course not every widget uses COLOR_WIDGET_BACKGROUND as the default, so it's been overriden in those places. This ensures GTK3.14 and below still works correctly when setBackground(null) is called. Change-Id: Ib635be9ed61edf8c8e602fe3e27dd8c418210b12 Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-06Bug 519124 – Add SWT variable to print versions of underlying librariesLeo Ufimtsev2-1/+19
Adding code to print gtk/webkit versions if SWT_LIB_VERSIONS is specified. This is helpful for bug report investigations. Note, SWT_LIB_ prefix is for easier grep-ing of console output in the situation if there is a lot of console output. Console output is like: SWT_LIB_Gtk:3.22.15 SWT_LIB_WebkitGtk:2.16.0 (Version >=2.5 is Webkit2) Change-Id: I753e006d8f0464ca51035400327c43550a3f3c31 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2017-07-05v4806v4806eI20170706-0630I20170705-2000Arun Thondapu1-1/+1
2017-07-05Bug 519138 - [GTK3] White or invisible text all over the place withEric Williams2-17/+9
non-Adwaita themes Fix getBackground() methods for Table and Tree to return COLOR_LIST_BACKGROUND instead of COLOR_WIDGET_BACKGROUND when the background is reset. This affects behavior on GTK 3.0 - 3.14. This fixes the following Platform UI failing test cases: ColorAndFontLabelProviderTest.testColorsAndFonts ColorAndFontViewerLabelProviderTest.testColorsAndFonts Tested on GTK3.16, 3.14, and 3.10. No additional AllNonBrowser JUnit test cases fail. Change-Id: I96be5602fb9a246711b78c4237f36f40f65f63ff Signed-off-by: Eric Williams <ericwill@redhat.com>
2017-07-05Bug 514719 [Browser][Webkit2] port Browser.getText() to webkit2Leo Ufimtsev1-1/+1
(timeout) A few of the browser tests sometimes timeout on a slow OSX laptop if ran via mvn. With a higher timeout (5->15 sec), they don't fail. Change-Id: I131f282950825bff0559096922b3a89f0c502687 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>

Back to the top