Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-04-18Bug 540903 - [GTK4] Adapt to GtkClipboard changesXi Yan6-2/+45
1) ifdef gdk_display_get_*_clipboard on GTK4 2) Replace gtk_clipboard_clear with gdk_clipboard_set_content(null) Change-Id: I139b8606f01961c31adc56c08ad35c4abd1fb0bc Signed-off-by: Xi Yan <>
2019-04-17Bug 546493: [GTK4] Button click coordinates are incorrect for some casesEric Williams5-3/+42
This is a two-part fix: 1) Adjust the sendMouseDown() function in Control, as event coordinates on GTK4 are already parent relative. 2) Table/Tree have headers built into the GtkTreeview's surface, meaning the y-coordinates will include the height of the header. This throws off any geometry-item querying code in Table/Tree. The fix is to adjust the coordinates to account for the size of the header. GTK3 doesn't have this problem because the header has its own GdkWindow which is separate from the rest of the Table/Tree. Tested using Snippet3 on GTK4. Change-Id: Ia68a6edb376a823dc3beb57e4db084075e42138b Signed-off-by: Eric Williams <>
2019-04-16Bug 546489 - [GTK4] Replace GtkClipboard with GdkClipboardXi Yan6-5/+57
Replace GtkClipboard with GdkClipboard Change-Id: Iad0c8bff10ab325cf53bde1711bddf0e3842ee9d Signed-off-by: Xi Yan <>
2019-04-16Bug 545943 - [GTK4] Scrolling with the mouse wheel not workingXi Yan1-1/+1
Fix GdkEventControllerScroll flags so that scrolling with mouse works on GTK4. Tested with Snippet 7, 8, 52, 53, 59, 61, 90. Change-Id: I5a4b344e1b7ec0eef75733bdbe04649d15645b77 Signed-off-by: Xi Yan <>
2019-04-16Bug 546488: [GTK4] Cursor never reverts back to normalEric Williams7-6/+31
Use gtk_widget_set_cursor() in certain instances in order to make sure the cursor is set/unset properly. Change-Id: Iad680c4ab71aae79faf6ac7e61513b793dd5380a Signed-off-by: Eric Williams <>
2019-04-16Bug 546481: [GTK4] Fix Snippet4Eric Williams1-2/+5
Allocate to shellHandle so that drawing works properly -- otherwise the snapshot will stop at the child GtkWindow and nothing will be passed on to any of the children. This means the Shell would not draw. Change-Id: I62e7b845fdab99acb864aea86de7916e88829f3e Signed-off-by: Eric Williams <>
2019-04-16Bug 546252 - [GTK] Cleanup for tooltip color fixesAlexandr Miloslavskiy7-76/+528
Fix: ---- All layers are rendered when background color is estimated. This solves the problem for themes that utilize semi-transparent labels in tooltips, such as 'HighContrast'. NOTE: 'gtk_style_context_get_parent' requires 3.4. However, for Eclipse 4.12 requires at least GTK 3.10, so this can be ignored. Code cleaning: -------------- Deleted tooltip-related CSS parsing code that is now dead. Tests: ------ Added snippets I developed during investigation. Change-Id: Ic4504be60df58f32e32b90a487e28af68853977d Signed-off-by: Alexandr Miloslavskiy <>
2019-04-16Bug 545884 - [Win32] Remove TCHAR string wrapper (Part 1)Nikita Nemkin34-324/+246
Replace TCHARs that are used as fixed-size buffers with plain char[] arrays of the same size. Change-Id: Ic54bafb4e865dff62de67a0efefc6020aa5349f3 Signed-off-by: Nikita Nemkin <>
2019-04-15Bug 545645 - [GTK] Table/Tree header must not keep focusXi Yan3-0/+222
Address issue with updating SWT.VIRTUAL table making header being focused on click. Tested with 2 attached snippets and Snippet38. Change-Id: If02802c01bab05db3b7c241e90dc4a4ed4176608 Signed-off-by: Xi Yan <>
2019-04-15Revert "Bug 466511: Replace dropdown menu custom drawing with png"Eric Williams1-13/+2
This reverts commit a5d8b38bcb1b0702f9e164aacfd92f5edc1df87b. Change-Id: I519b1f7f74771bdd10a85ab12dca30e37b977982
2019-04-15Bug 546420 - [Win32] Don't guard against GDI+ loading failureNikita Nemkin3-33/+19
GDI+ presence is guaranteed on WinXP and later. Change-Id: Iee3c46ce8a2ac61170a51b06d7986340051ca1c8 Signed-off-by: Nikita Nemkin <>
2019-04-12Bug 546110 - FileDialog Cancel/OK not localized on LinuxXi Yan2-2/+2
Set labels for GtkFileChooserNative to null to get default localized buttons. Issue fixed for GTK3.20+. Tested with Snippet72. Change-Id: Iaa7a777a12a84b52af634dfc4c64249372d6d81b Signed-off-by: Xi Yan <>
2019-04-12Bug 466511: Replace dropdown menu custom drawing with pngMatthias Becker1-2/+13
View dropdown uses grey as foreground color so the min max icons need to use the same color Change-Id: I4a0c16f8a61faf4ac7d98deb35123d02a4e5ffeb Signed-off-by: Matthias Becker <>
2019-04-12Bug 545854 - [Win32] Drop custom JNI code for GDI+ interopNikita Nemkin8-452/+302
Custom code for point and color conversion is unnecessary, because Color/Point/PointF are binary compatible with primitive arrays. GDI+ Color is a thin wrapper around DWORD, use plain int for interop. Change-Id: If586f3772c4409e4f7583e497552ca6b54d71138 Signed-off-by: Nikita Nemkin <>
2019-04-12Remove natures.Alexander Kurtakov7-7/+4
Locking the possible shell script editor to single one doesn't make much sense. Additionally there are better editors like ShellWax either way. Change-Id: I5e08fa8105cd56b8d2c5b278eca6091df5ccc258 Signed-off-by: Alexander Kurtakov <>
2019-04-09Bug 545923 - [regression][GTK] Tooltip foreground is wrongAlexandr Miloslavskiy5-246/+79
Fix 1: ------ The problem with previous approach taken in Bug 545587 was: 'Clearlooks-Phenix' does not define 'color' property for 'tooltip *' CSS selector. Instead, it's expected to be inherited from 'tooltip' CSS selector. However, 'gtk_style_context_set_path' is flawed: it will use parent for searching CSS selector, but it will *not* use parent for inheritance. I'm not sure whether this is GTK bug, GTK design bug, GTK documentation bug, or something else. One thing for sure, 'GtkWidgetPath' approach proved fragile. Also, it requires to set various components carefully, and GTK guys love to change these. Also, 'GtkWidgetPath' seems to be abandoned (even though not deprecated yet), for example GTK commit 101df329 mentions '... applications that still use widget paths ...' So I decided to take another approach: actually create the tooltip and let it handle all the magic itself, then request its GtkStyleContext. This seems to work much more reliably. Since this no longer requires anything from GTK higher then 3.0, I also removed all fallback code paths. Fix 2: ------ Added a quick workaround for 'HighContrast' theme. Change-Id: Icbb0b315bdfed2a1668e622240026a942148ac66 Signed-off-by: Alexandr Miloslavskiy <>
2019-04-09Bug 546211 - [GTK3] Disposing TableItem should not scroll tableXi Yan2-3/+4
Apply same fix as bug 545994 for disposing TableItem. Change-Id: Iaeeadaf8c2752b1a4fef1dcbeb87190c577f98d4 Signed-off-by: Xi Yan <>
2019-04-08Bug 297510 - Disable failing testRolf Theunissen4-0/+46
Change-Id: I4bde2171f42dda790d4c566545b5b13dd93d0c5b Signed-off-by: Rolf Theunissen <>
2019-04-08Bug 546192 - Test failure in test_setForegroundAfterBackground on MacLakshmi Priya Shanmugam1-1/+2
The default Text foreground color on Mac uses SWT.COLOR_LIST_FOREGROUND not SWT.COLOR_WIDGET_FOREGROUND. Updated test for Mac. Change-Id: I14beb8ffa47caa1a9943ab5acdf6b7076311994d
2019-04-07Bug 297510 - Wait for the shell to become active in focus test casesRolf Theunissen4-22/+17
Fix failing tests in Cocoa, on GTK it replaces forceActivate of the shell Change-Id: Ifd27c4885f65a8aa2576977283a9b63a10d7abc2 Signed-off-by: Rolf Theunissen <>
2019-04-05Bug 545073 - [GTK] MouseNavigation pastes text on middle clickLaurent CARON2-16/+38
Change-Id: I7fa01f6520c43acd5dd39e5ba1ead6d5e2de9b0e Signed-off-by: Laurent CARON <>
2019-04-05Bug 297510 - Rework focus tests to make them pass on all platformsRolf Theunissen5-7/+54
- Use Text instead of Button for focus child - Drain event queue in tearDown on Cocoa to close shells properly - Force focus on shell only on GTK - Disable focus test for some custom widgets Change-Id: I876f625fa5d00e8c1c0485efb675743540f02bee Signed-off-by: Rolf Theunissen <>
2019-04-04Bug 182598 - adjusted patch to deal with nested tree elementsSimeon Andreev2-29/+38
The previous patch for bug 182598 did not take tree items with parent tree items into account. This led to throwing exceptions in cases which were not broken. With this change, the tree elements that are being removed are correctly iterated. Change-Id: I8632202d13995f0cc2203a52027b0deb7006085a Signed-off-by: Simeon Andreev <> Signed-off-by: Andrey Loskutov <>
2019-04-03Bug 546096 - [GTK3] TextEditor toolbar icon wrong transparencyXi Yan1-4/+22
Add additional means of getting transparencyMask from alphaData. We should not get mask from transparentPixel if we already have alphaData. Change-Id: I546a4a120babbfe28e7e7d9dfee2c2b75569d3dc Signed-off-by: Xi Yan <>
2019-04-03Bug 546089 - [GTK3] Jagged edges in some iconsXi Yan1-2/+0
Revert Better solution found in Change-Id: I1ea0d07d9450dc52b09f87784d8b673779831d53 Signed-off-by: Xi Yan <>
2019-04-03Bug 546035 - [GTK3][regression] Some icons aren't rendered properlyXi Yan1-22/+61
anymore Caused by ImageLoader#save not working properly when we want to save in RGBA channel but ImageData is in RGB channel. Fix is to iterate over each pixel and fix the byte ordering to get a good pixel data buffer to pass to gdk_pixbuf_new. Tested with child Eclipse on X11 and Wayland with hover icons. Tested with ImageAnalyzer: loading any format image and saving it as PNG should work. Load JPEG file (in RGB), add Alpha mask to it, then saving it as PNG should work. Change-Id: I60dd32e313276ebb0dc35a5646beb4b57691e665 Signed-off-by: Xi Yan <>
2019-04-03Bug 545942: [GTK4] Ensure snippets work on GTK4Eric Williams1-2/+9
Remove last reference to gdk_window_get_display() on GTK4 to make Snippet39 run without crashing. Change-Id: I27886412cb67e713c760e29ed903f79b6cdba3ab Signed-off-by: Eric Williams <>
2019-04-03Bug 546073 - [GTK3] Warnings building bindings with GdkPixbuf functionsXi Yan2-14/+14
Remove const qualifier Change-Id: Ifa758742a6bf036b5f71164d3a92a23ccdb3abe8 Signed-off-by: Xi Yan <>
2019-04-03Bug 182598 - assertion failed in gtktreestore.cSimeon Andreev5-2/+147
Throw an exception instead of crashing, whenever a tree or table item is destroyed while its properties are being applied. Change-Id: Ia333a69f7ed94b5eed547a9f90120135f92b6eaa Signed-off-by: Simeon Andreev <> Signed-off-by: Andrey Loskutov <>
2019-04-03Bug 543704: SWT Table does not release all relevant items when input hasLakshmi Shanmugam1-0/+55
changed Updated Table.remove tests to ensure that the removed items are disposed and other items are not. Change-Id: I226e7d49e2578fe5b6777c6fa5baf5be1d8dcf5b
2019-04-03Bug 536468: NPE when adding 2nd entry in module pathLakshmi Shanmugam1-5/+5
Table.remove doesn't set null to all the disposed items. Change-Id: I90ac6133b28c963102fcb0ec88e231b4d8ae86a3

Back to the top