Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-02-12Bug 544365 - [Mac] Native dialogs should use dark appearance in EclipseLakshmi Priya Shanmugam2-5/+11
Set the dark/light appearance to the NSApplication directly so that we don't have to set the appearance to each NSPanel for the SWT dialogs such as FileDialog, Color/Font Dialogs, etc. Change-Id: I7cb65292b226971a68c41d9f649b978b4b8ed6fc
2019-02-11Bug 544198: atk_text_get_text() seems brokenEric Williams1-1/+0
Remove bad return statement from swt_fixed_accessible_text_get_text(). Change-Id: Iaa9997a14b26c95013169b5f53e1e0307655eb35 Signed-off-by: Eric Williams <>
2019-02-11Bug 544296: [Gtk] Regression: KeyEvent keyCode no longer setEric Williams1-8/+9
Check if ptr is also non-zero as it will hold the result of gtk_get_current_event() in the event that the initial event is 0. Change-Id: Idf477d48868919d4aa21ae1eec12525ca316856e Signed-off-by: Eric Williams <>
2019-02-11Bug 538487 - [HiDPI] GC.copyArea() and Image.getImageData() behaveSravan Kumar Lakkimsetti1-10/+47
differently (and buggy) MacOS 10.13.6. Change-Id: I3e4ef6b3672dc44ec401a9e139ba3081170a23c1 Signed-off-by: Sravan Kumar Lakkimsetti <>
2019-02-09Remove empty lines from o.e.swt pom.xml.Alexander Kurtakov1-80/+3
Change-Id: I20f79df4b97f3b0b9cf5f26a89cbd4fd38233979 Signed-off-by: Alexander Kurtakov <>
2019-02-08Bug 544282 - [GTK3] apply the optimization for Tree.setItemCount(0) tooAndrey Loskutov3-2/+61
Also added some more tests. Change-Id: Ic14ff6e0f7f694c8a1756e34a7b17986301213d4 Signed-off-by: Andrey Loskutov <>
2019-02-08Bug 515849: Enable Device.DEBUG via SWT_DEBUG=1 env variableEric Williams2-0/+14
Enable Device.DEBUG via SWT_DEBUG=1. Change-Id: Ie3e4064484cd8546072b348380e05830cb31b6c5 Signed-off-by: Eric Williams <>
2019-02-08Bug 544282 - [GTK3] org.eclipse.swt.widgets.Table.remove(int, int) isAndrey Loskutov1-1/+5
extremely slow In case we set table items count to zero, it is way faster to use GTK.gtk_list_store_clear() instead of iterating over every element via GTK.gtk_list_store_remove(). Change-Id: I0ae296b40b05fcdfcecc1d2d8a3fb4885d9c9b64 Signed-off-by: Andrey Loskutov <>
2019-02-08Bug 472417 - Typo in examples_texteditor.propertiesAlexander Kurtakov3-4/+4
Fix typo. Change-Id: I45160685a2197f112adb99d426dad67f58538f23 Signed-off-by: Alexander Kurtakov <>
2019-02-07Bug 543908: GTK4] Get ControlExample to launch and run on GTK4Eric Williams17-38/+155
Add proper GtkCssProvider API for GTK4 and adjust SwtFixed->measure to produce properly sized containers. Also make some small adjustments so that the DateTime tab works properly. Change-Id: I3dea2ec74788f11131187056a63e7e1505e9c2a5 Signed-off-by: Eric Williams <>
2019-02-06Bug 542940 - Method setEditor of class TreeEditor raises javaXi Yan1-5/+0
nullException Stop hiding Text widget in gtk_draw. Change-Id: I1f2cd9260b65bcab03a27c4431822059f2e238c5 Signed-off-by: Xi Yan <>
2019-02-05Bug 543908: [GTK4] Get ControlExample to launch and run on GTK4Eric Williams7-8/+38
Fix TabFolder display issue, as well as pixbuf crashes due to cairo_image_surface_create() being fed incorrect parameters. Snippet76 no works as expected on GTK4 just as it does on GTK3. Change-Id: Ie1d3504eca532fdb9e33763c98434e33ca53be01 Signed-off-by: Eric Williams <>
2019-02-05Bug 544140: Endless calls to Tree.rendererGetPreferredWidthProc afterEric Williams3-8/+51
clicking on editable PropertySheetPage tree cell Only re-draw the headers of a Table/Tree widget when a scroll event has occurred. This narrows the use of gtk_widget_queue_draw() to the specific case that needs it. It also avoids triggering native callbacks as the enter Table/Tree does not need to be re-drawn. Tested using the Bug535978_TableEditorHeader snippet as well as the snippet attached to this bug report. A cursory check in the IDE yields no regressions. Change-Id: Ia1d4bdf9a55f83658b13cc8c64219efbd1175097 Signed-off-by: Eric Williams <>
2019-02-05Bug 534923 - Cocoa: objc_msgSend is called incorrectly from os.cThomas Wolf4-353/+383
C calling conventions may be different for vararg and non-vararg functions. Change the generated code to not cast vararg functions to function pointers with non-vararg profiles. Instead annotate the objc_msgSend* functions in MacGenerator as "fixedargs=2" (meaning: it's a vararg function with two fixed parameters), and change the NativesGenerator to use this annotation to generate a cast to a function pointer with a vararg profile with that many fixed parameters. "fixedargs=0" or absence of the "fixedargs" annotation means all parameters are fixed; there are no varargs. The behavior in this case in unchanged. The casting cannot be avoided altogether; the objc_msgSend*_stret functions _must_ be casted. Also use BOOL as return type for the cast of objc_msgSendSuper_bool, not just for objc_msgSend_bool. Verified that casting to a profile with varargs indeed makes the compiler generate the assembly code that on x86_64 does clear register %al, as it should per the ABI spec.[1] The old code generated did not do this. (Verified with with cc -S using Apple's clang and inspecting the assembler output; on OS X 10.14.2.) Ran the new MacGenerator to regenerate the Cocoa, then ran the new JNIGenerator to regenerate the Cocoa os.c. Re-built the binary library. Set up an Eclipse using this rebuilt library and ran all SWT tests. All tests passed locally. [1] Change-Id: Ib03226ad9ecdf4bfcf789cd2b42f592b9a2b9021 Signed-off-by: Thomas Wolf <>
2019-02-04Bug 543989: [GTK4] De-couple GtkEntry calls from GtkSpinButtonEric Williams7-36/+83
Separate GtkSpinButton from the actual GtkEntry handle inside of it before calling gtk_entry_* functions. Tested on GTK4 using Snippet184, Snippet190, and Snippet310. Change-Id: I7d175ce836d65f7a67755ff6b3fdff5f84cc0faf Signed-off-by: Eric Williams <>
2019-02-04Bug 543984 - [GTK4] Adapt to GdkEventType constants changesXi Yan21-20/+185
- Add new GdkEventType constant values - Add pre-processing function to fix different GdkEventType values on GTK4 - Adapt all GdkEventType to use correct constant on GTK3 and GTK4 - Guard connecting to event signal in Shell to avoid duplicate mouse press/release events. Tested on GTK3 with ControlExample Listeners. Tested with attached snippet on GTK4. Change-Id: I43f139a0b8d8b41820c64189767377ebb6fc9db5 Signed-off-by: Xi Yan <>
2019-02-04Bug 139791 - [Win32] GC.fillPolygon paints at wrong coordinates whenNiraj Modi1-1/+10
GDI+ is used Change-Id: I9a0e965dd43d6325e759ddeefa2ea4274a43caba Signed-off-by: Niraj Modi <>
2019-02-04Bug 48020 - added range checks in StyledTextRenderer.textChanging()Andrey Loskutov1-2/+8
This should hopefully give some hints where the wrong data is coming from. Change-Id: I64f2a125738e16d5a952fba1b8f552f3f50b7ce4 Signed-off-by: Andrey Loskutov <>
2019-02-04Bug 544085 - [JNI] Insert correct newline character into generated codeNikita Nemkin1-2/+2
Change-Id: I167eb7bcdeda257af27a01da1c053778fe7a3786 Signed-off-by: Nikita Nemkin <>
2019-02-01Revert "Bug 501491 - Draw close button with antialiasing."Andrey Loskutov1-3/+0
This reverts commit b96722424ff908aba3b0ce5a2b173f5080b3c281. Change-Id: I3c3d5f4d4794f866261f62b4f458b7eadb064b54
2019-01-31Revert "Bug 543984 - [GTK4] Adapt to GdkEventType constants changes"Xi Yan18-518/+300
This reverts commit 2f5a98b4cbd50b436a5ffad0a1d5949f3b9a1b18. Change-Id: I60ebccca14cfdc5619bb763424f1289a44e3ed89
2019-01-31Bug 543984 - [GTK4] Adapt to GdkEventType constants changesXi Yan18-300/+518
Add new GdkEventType constant values, adapt GDK.EXPOSE, GDK.BUTTON_PRESS, GDK.BUTTON_RELEASE on GTK4. Guard connecting to event signal in Shell to avoid duplicate mouse press/release events. Tested on GTK3 with ControlExample MouseListener. Tested with attached snippet on GTK4. Change-Id: Ida2f3a4d77efcb98d99a1aa4bcbb418c8cbfc718
2019-01-31Bug 541376 - [GTK4] Replace signals which have been removedXi Yan8-26/+167
- Replace button-press-event/button-release-event/configure-event signal with generic event handler. Change-Id: Ic3726b03041d332d75c2c170dfc25966d53afe61 Signed-off-by: Xi Yan <>
2019-01-31Bug 543932 - Tree/Table should use correct colors in Eclipse Dark ThemeLakshmi Priya Shanmugam2-4/+4
on Mac Fix tree and table foreground for Eclipse dark theme. Change-Id: I60e8f829a73585f96420f3df4b1c478f6c2b0307
2019-01-30Bug 501491 - Draw close button with antialiasing.Mike Marchand1-0/+3
Change-Id: I11a22e345a12d9dbdadfceaf9f7fe543119d0964 Signed-off-by: Mike Marchand <>
2019-01-30Bug 543912: [GTK4] Adapt to GdkCursor API changesEric Williams10-47/+107
Restore GTK3 GdkCursor API for cases where CSS named cursors aren't available (like GTK3.10). Change-Id: Ib26888543eeb7df7d51e9eac3d0a8bf023e6d9f3 Signed-off-by: Eric Williams <>
2019-01-30Remove useless empty lines in gtk Kurtakov1-14/+1
Change-Id: I55609c54dd12a1ae508eee207e0039a71c53cb2f Signed-off-by: Alexander Kurtakov <>
2019-01-30Bug 539707 - [GTK3] Replace deprecated gdk_threads_leave()Alexander Kurtakov9-25/+25
This functions doesn't exist on GTK4 so guard invocations. Change-Id: I95f6be304cc601ba7cbce8709ea0c3cd2af9ebc3 Signed-off-by: Alexander Kurtakov <>
2019-01-30Bug 456108: Display.getSystemMenu().isEnabled() throwsLakshmi Shanmugam1-0/+1
NullPointerException Added check for display.appMenu Change-Id: I619e8365dfb2018000851714354fc3239e04b412 Signed-off-by: Lakshmi Shanmugam <>
2019-01-29Bug 459789 - [Mac] Window title bar should be dark when Eclipse is inLakshmi Priya Shanmugam6-0/+112
dark theme Use NSWindow.appearance to set the the title bar to dark or light. Added a new setTheme method that will send the appAppearanceChanged custom message and set the appearance of the window to either Dark or Light. It'll be called from Platform UI code whenever there is a theme change.

Back to the top