Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-15v4918v4918aI20180815-1250Eclipse Platform RelEng Bot1-1/+1
2018-08-15Move to Surefire 2.22.0 in swt.tests.Alexander Kurtakov1-1/+1
Change-Id: Ie4133c4d80bce537f18761204740bfe7ff4cbf4c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-14v4918v4918I20180814-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-14v4918Eclipse Platform RelEng Bot3-4/+4
2018-08-14Bug 386769: Use of GTK_HAS_FOCUS with deprecated GTK_WIDGET_SET andEric Williams2-3/+0
UNSET FLAGS in Composite Widget Remove GTK_HAS_FOCUS flags as they are deprecated and already set by gtk_widget_grab_focus(). Change-Id: I5439bca85543ebe48ea07b0b6a8c7e87eb122504 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-14Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events whenXi Yan3-4/+90
opening context menu Fix test issues caused by previous patch. Previous patch prevents activate event to be send when they are necessary, causing several shell issues. This patch has the logic: when context menu is shown, ignore focus_out/deactivate event for shells. When context menu is hidden, ignore activate event for shells. Tested with WorkbenchTextEditorTestSuite (workbench.texteditor.tests), UIAllTests (e4.ui.tests), and UiTestSuite (ui.tests) locally. In child Eclipse, Ctrl+F and pasting text via Ctrl+V pastes text into search entry. Holding down Ctrl and pressing E multiple times cycles list. Change-Id: I2a2a023c798e1231a7c6c72e9cb94177af5f4aa2 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-14Bug 537713: [GTK3] Combo sizing problemsEric Williams2-22/+50
Do not perform resize calculations for Combos, as their large minimum and/or natural sizes causes API breakages with setBounds(). Tested with the snippets from this bug and bug 535323, AllNonBrowserTests, and the IDE: no allocation warnings occur. Change-Id: Ieefa0752fcb2dd3a743ebcc432eef939a46b73f4 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-14Bug 536141: [Webkit2][Gtk] BrowserFunction lost after page reload onEric Williams14-59/+1174
Linux/GTK The main cause of this bug is that web pages load too quickly -- by the time the BrowserFunctions are re-registered asynchronously from Java, the extension has loaded the page. BEFORE THIS PATCH: BrowserFunctions were registered asynchronously from Java into the web extension (C). This was done either at the outset (WebBrowser.createFunction()), or after every page load (Webkit.webkit_load_changed() callback). AFTER THIS PATCH: The fix is relatively straightforward, yet GDBus adds a lot of overhead. Instead of constantly registering BrowserFunctions from Java, we load them into the web extension on creation. This hands off the responsibility of re-registering BrowserFunctions to the web extension, which reduces overhead and ensures the functions are registered/executed before the page loads. The BrowserFunctions are stored at the C level in the extension, using a linked list. Whenever the "object-cleared" callback is triggered in the extension, the linked list is iterated over and any BrowserFunctions for that page are re-registered. Chronological ordering of information flow from SWT -> web extension via GDBus. 1) SWT Webkit class is loaded. SWT GDBus server is created. 2) SWT Webkit creates the extension, passing it the information of the SWT Webkit GDBus server. 3) The extension's initialization callback is called in C. 4) In this callback the extension contacts the SWT Webkit GDBus server and provides it with information such as its PID and name. 5) SWT Webkit acknowledges this information, and sends back any BrowserFunctions that were created before the extension loaded. 6) The extension adds these BrowserFunctions to its linked list. 7) Any subsequent BrowserFunctions are added to the extension's linked list by calling the extension's GDBus server synchronously. In the event of a GDBus timeout (happens sometimes when running tests), the GDBus call is made asynchronously. This functionality can be tested with the attached snippet. AllBrowserTests pass without issue, and there are no visible Browser issues in the IDE. The plugin attached to the initial bug report is now functional. Change-Id: Iddc5f2e69f0a7fd4500bd8228f0bc46c4b3a6322 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-14v4917v4917aI20180814-0910Eclipse Platform RelEng Bot1-1/+1
2018-08-14Bug 515502 - [HiDPI][Win10] SWT to receive/handle DPI changeI20180814-0900Niraj Modi5-3/+313
notification from OS Change-Id: Ic0b851b76cbd5b270f4d4337de6ac6f2fb81812c Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-08-13v4917v4917I20180813-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-13v4917Eclipse Platform RelEng Bot3-4/+4
2018-08-13Revert "Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events when ↵Andrey Loskutov3-91/+6
opening context menu" This reverts commit 9f91c882bb8f96c689143525a71937171402a3d7.
2018-08-13Bug 537908: [GTK3] Warning about invalid signal forEric Williams6-0/+21
GtkTextViewAccessible "attributes-changed" Only send "attributes-changed" signal on GTK2 instances of GtkTextViewAccessible. Change-Id: I47d79fa68ee8c0046f9ad436371c19f0bc112859 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-13Bug 534554 - [Wayland] Javadoc doesn't dissapear via Esc until youXi Yan2-8/+34
clicked into it Added constants for GdkSeatCapabilities. Passed GDK_SEAT_CAPABILITY_KEYBOARD to gdk_seat_grab instead of 1 to grab keyboard focus instead of pointer focus. Implemented isMappedToPopup to check if a shell's parent is a popup. Note: Calling gdk_seat_grab on visible window causes caret to get stuck in Eclipse after closing Javadoc using only gdk_seat_ungrab. The fix is to hide GtkWindow before grabbing. GtkWindow should only be hidden for a popup window whose parent is a top most window to prevent gdk warnings and shells not showing. Tested with child Eclipse on Wayland. Pressing F2 makes Javadoc popup, pressing UP/DOWN arrow scrolls, pressing ESC closes Javadoc. Completion popup works with tab. Snippet with bug 515773 works as before. Change-Id: I2a6cca4062379c2b52ca93ec1c8bccfab9e1aebb Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-10v4916v4916dI20180812-2000I20180811-1500I20180810-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-10Bug 537863 - Errors trying to build 4.9 SDK locally: Missing requirementAndrey Loskutov1-0/+14
org.eclipse.swt.tools.feature.source.feature.group 0.0.0 Change-Id: I5e19bda2e490b89abdae84924c43b214d9a2f410 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-08-08v4916v4916cY20180808-2200I20180810-0320I20180809-2000I20180808-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-07Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events whenXi Yan3-6/+91
opening context menu Activate/Deactivate events are sent when the context menu is shown. Use flag to ignore activate/deactivate events when context menu is open. Change-Id: Iaa7a55fca388220421ba1d7f6718874689f7d88b Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-06v4916v4916bI20180807-2000I20180807-1425I20180807-0350I20180806-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-06Bug 537614 - [Win32][CustomHiDPI] Gap between Checkbox/Radio and TextNiraj Modi1-1/+5
not getting scaled Change-Id: I67eda8932305288e3f72c94a205f118508e71f4e Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-08-05v4916v4916aI20180806-0300I20180805-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-04Bug 476608 - Sluggishness reported in gdk_flushAlexander Kurtakov1-1/+0
Remove call from setDarkThemePreferred. Change-Id: Ia70b1b705b0bef7bbae1c5c3d7a0a7034e64ba38 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-04v4916v4916I20180804-1500Eclipse Platform RelEng Bot1-1/+1
2018-08-04v4916Eclipse Platform RelEng Bot3-4/+4
2018-08-04Bug 532941 - [Wayland] Error output about "a temporary window withoutXi Yan7-4/+125
parent" 1) Attached snippet was broken on GTK3 with both x11 and Wayland. The column width is 0 and the table appears as a thin line. See bug 509503. This was fixed by always showing the table before getting preferred size on GTK3. 2) The warnings on Wayland occurs due to having a popup window without a parent. Shells with SWT.ON_TOP style was always created as a GTK_WINDOW_POPUP, this causes issues when the shell has no parent on Wayland due to lack of global coordinates. The fix is to never create a popup window without a parent. 3) Fixed the issue with the open editor dialog (CTRL+E) having a title bar above, by preventing decorations for shells without SHELL_TRIM style set. Tested with attached snippet and open editor (Ctrl + E) in child Eclipse with GTK3.22 on X11 and Wayland. Change-Id: I6d33c2e9bb00a55f84a79303f7326d0c8cd0a3ec Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-04Fix compiation without XTest.Alexander Kurtakov1-7/+2
No longer used for anything. Change-Id: I869f3ad59f28e0f374fde770f08880e324072f12 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-04Bug 537025 - SWT + GTK3 + Sending key events programmaticallyXi Yan2-6/+256
Fixed regression from Bug 302171 where sending modifier as a separate key event does not work. Sending GDK_KEY_PRESS event using gdk_test_simulate_key will not hold key down infinitely until a GDK_KEY_RELEASE event is sent. The modifier is cached in case modifiers are sent in separate event to Display.post(). Tested using attached snippet and Snippet146. Change-Id: I2c9b617345b3f92c3a32299e64ce7f1ce5ef7992 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-04Bug 530577 - [Wayland] Popup menus sometimes emit GDK warningsXi Yan2-29/+35
1) On Wayland, clicking Show In button in Open Resource dialog causes menu.setVisible to be called twice, once due to MouseDown and once due to ButtonClicked. This causes two duplicate menus (with different handles) to popup at the same time. The second one does not have a top-most parent which emits a GDK warning, and the menu cannot be closed. The same issue also happens on both X11 and Wayland with toggle buttons. See bug 528998. The fix is to avoid adding two identical popup menus in the queue. 2) Implemented Menu#setLocation() on Wayland by passing the window of the relative parent shell of menu to gtk_menu_popup_at_rect to position the menu. Used hasLocation flag for Wayland (see Bug 530204). Tested on Wayland and X11 with GTK3.22. Clicking "Show In" button in Open Resource Dialog, and the "Run As..." triangle now opens popup menu under the button rather than by the mouse. Right click on perspective button and clicking anywhere now able to close the context menu, whereas before requires two clicks. Change-Id: I89110e5d095ca896fa0b0d775e617889ea75912d Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-04Bug 336238 - Shell.setBounds sometimes fails to set the right locationXi Yan2-1/+66
Calling gtk_widget_show for the first time before gtk_widget_resize assumes the initial default size for any subsequent calls to gtk_widget_move. This causes issue with shell.setBounds where the location can only be moved to a limited bound on the screen corresponding to the default size by the window manager, even when the new resized shell is smaller and is able to move to further x, y position without being cutoff by the screen. The fix is to set the default size to the smallest possible (1, 1) before gtk_widget_show. Tested with attached JUnit test. Change-Id: I3f20a6aaed5972bfda3775816aab96202bae7e5d Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-01Bug 530138 - [Wayland] Completion details are far away from theXi Yan1-1/+14
completion list Wayland does not have support for absolute coordinates. When a GTK_WINDOW_POPUP is attached to another GTK_WINDOW_POPUP parent, it gets positioned relatively to its parent, causing it to be far away from the screen when its position in absolute coordinates. The fix is to use gtk_window_set_transient_for to attach the GTK_WINDOW_POPUP to a GTK_WINDOW_TOPLEVEL parent already mapped on screen. Tested with completion list in child Eclipse on Wayland, GTK3.22. Change-Id: Ic9d0b4f785a12c6a659546fc362fcc8c9b0ddc4c Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-01v4915v4915Y20180801-2200S4_9_0_M2I20180803-2000I20180801-2000I20180801-0820Eclipse Platform RelEng Bot1-1/+1
2018-08-01v4915Eclipse Platform RelEng Bot3-4/+4
2018-08-01Bug 520134: Mac generator removes space incorrectly in OS.javaI20180801-0800Lakshmi Shanmugam2-2/+2
The updated Mac generator removes the struct from struct FSRef. Source code changes with the updated Mac Generator. Change-Id: I75597419ac93dcca8c0db0851e2e7c02361bb690
2018-07-30v4914v4914bI20180801-0550I20180731-2000I20180731-1305I20180731-1250I20180731-1025I20180731-0800I20180731-0340I20180730-2240I20180730-2000I20180730-0800Eclipse Platform RelEng Bot1-1/+1
2018-07-30Bug 514191 - [Cocoa] [10.11] Bridge support files should be updated to ↵Gunnar Wagenknecht1-0/+3
latest macOS supported version 'struct FSRef*' should be 'FSRef*' Change-Id: I8d8d23c1d805a6feac325300abb0249dc39013e5 Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
2018-07-29v4914v4914aI20180729-2000I20180729-0800Eclipse Platform RelEng Bot1-1/+1
2018-07-28Bug 532632 - added guard for disposed shell in BusyIndicatorAndrey Loskutov1-43/+53
This is a paranoia check, see comment 20 for an attempt to explain it. Change-Id: I573410c898470bc725ea820252b4da36ac4bc092 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-07-28v4914v4914I20180728-1500Eclipse Platform RelEng Bot1-1/+1
2018-07-28v4914Eclipse Platform RelEng Bot3-4/+4
2018-07-28Bug 514191 - [Cocoa] [10.11] Bridge support files should be updated to ↵Gunnar Wagenknecht1-0/+4
latest macOS supported version Catch-all replace for common generic types Change-Id: I76df6b0cd570debb9bfb165c0f46b93f1464da80 Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
2018-07-28Bug 514191 - [Cocoa] [10.11] Bridge support files should be updated to ↵Gunnar Wagenknecht1-0/+3
latest macOS supported version Remove __kindof keyword. This is also a new objective c feature that should be ignored for now. It's like a super/extends in Java generics but we need more details in order to support it. Change-Id: Ife60c4ffc83f39acdb7a8eceb305b2a0d6307d34 Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
2018-07-28Bug 514191 - Bridge support files should be updated to latest macOSLakshmi Shanmugam28-83/+101
supported version (10.11) Updated Cocoa classes and extras file after changes to bridgesupport files. Change-Id: I3e60736d1452ac9e062650193a6a3f258e353f55 Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
2018-07-28Bug 514191 - Bridge support files should be updated to latest macOSLakshmi Shanmugam1-0/+3
supported version (10.11) strip greater-than sign Change-Id: I094a2ff75645bfad5d8d1633a8360ee496c60531
2018-07-28Bug 514191 - Bridge support files should be updated to latest macOSLakshmi Shanmugam5-15671/+18927
supported version (10.11) Change-Id: I6acae0343ae5abbd59ef18838d21c1d23fc99ab3 Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
2018-07-27v4913v4913gI20180728-0805I20180727-2000Eclipse Platform RelEng Bot1-1/+1
2018-07-27Bug 532632 - enable "fast" widgetTable checks by defaultAndrey Loskutov2-10/+6
Change-Id: Ib06c96cc501fa717dcf757bb7d36224bedd14354 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-07-27Bug 532632 - fixed NPE on error reporting for new leak checksAndrey Loskutov1-4/+4
Change-Id: I827c3e2de8f924fe741ea18f99fc09c54ffa19ce Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-07-27Bug 537364 - restrict widgetTable leak tests to Linux onlyAndrey Loskutov1-2/+2
Change-Id: Ib989a8aec54874922e8cd1ba53ed128b509334e0 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-07-26v4913v4913fI20180726-2000Eclipse Platform RelEng Bot1-1/+1

Back to the top