Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2019-05-03Bug 546525: [GTK4] Handle layout problemsEric Williams3-7/+17
Connect the proper "size-allocate" signal for GTK4, which solves the layout issues. At the time of this patch, there were some overdrawing issues -- the buttons in Snippet5 are drawn outside their Shell. This will be handled separately. Tested on GTK 3.94 on Fedora 29 and Fedora 30. Change-Id: I055efc036b3c0580247bdb0d07af271d0b3abba1 Signed-off-by: Eric Williams <>
2019-04-30Bug 540357 - [10.14] Make SWT adapt to switching to dark mode (and back)Lakshmi Priya Shanmugam1-1/+1
Revert to using windowBackgroundColor() for COLOR_WIDGET_BACKGROUND, as controlBackgroundColor() returns white. Change-Id: I1be55eee8769084bcbed8eb71e56d931cbeaa495
2019-04-29Bug 531634 - [GTK] Linux: Handle logoff / shutdown events from session managerAlexandr Miloslavskiy1-17/+24
Do not show errors if session manager is not supported. Change-Id: I55e93786596791e8e8593e393c32867d56e5aae9 Signed-off-by: Alexandr Miloslavskiy <>
2019-04-26Bug 540357 - [10.14] Make SWT adapt to switching to dark mode (and back)Lakshmi Priya Shanmugam1-2/+6
Create system property org.eclipse.swt.display.useSystemTheme which should be set for SWT application to use the system's theme. Change-Id: I9a319b276d3dedabd6195dbf383c5a3b4c8180e7
2019-04-26Bug 540357 - [10.14] Make SWT adapt to switching to dark mode (and back)Lakshmi Priya Shanmugam5-2/+33
The patch sets the appearance of SWT application to dark or light based on the system setting. The patch reads the setting only at startup, changing the system setting dynamically doesn't cause any change in SWT. Change-Id: I0d49f2995f55dae2a6349504a2a63e1c3723319f
2019-04-25Bug 531634 - [GTK] Linux: Handle logoff / shutdown events from session managerAlexandr Miloslavskiy3-53/+45
Hotfix for first version of the patch. Using System.exit() from Shell's 'SWT.Close' event caused deadlock, because main thread held 'Platform.lock' in its event loop and waited for shutdown hook, which waited for the lock - see also Bug 546743. Since multiple Displays are not possible currently (there's only dead code pretending to support it), it should be OK to have non-static object. Having it non-static removes the need for shutdown hook. Signed-off-by: Alexandr Miloslavskiy <>
2019-04-25Bug 536621 - [Win32] Custom cell style on Table doesn't workNikita Nemkin1-50/+45
Only force custom background color if the widget is disabled. The regression was introduced in 15eb1ba with the fix for Bug 516365. Change-Id: Ib39f0b19303be7f6fbc934e8c83d2d9020156e80 Signed-off-by: Nikita Nemkin <>
2019-04-24Bug 475833 - SWT API filterLars Vogel1-3/+3
This has been created with the Eclipse quickfix. API Baseline is set to Eclipse 2019-03 and a clean build was triggered two times. Change-Id: I3d095fa7af1a5f28afff27ac1d34ec0ce4a244a9 Signed-off-by: Lars Vogel <>
2019-04-24Bug 546274: [GTK] vm crash when scrolling StyledTextEric Williams6-38/+227
The method scrollInPixels() doesn't seem to be needed. I've reverted the fix from commit 64ae338b9c279c9bbcc158165aa451193a503c0a to preserve stability on GTK3, but on GTK4 this method is never called. Tested with the snippet attached, as well as the Canvas tab on ControlExample (GTK3 and GTK4). Change-Id: If907bf6c4c805c24eb021b687d5affbbc2e8bc3f Signed-off-by: Eric Williams <>
2019-04-24Bug 531634 - [GTK] Linux: Handle logoff / shutdown events from session managerAlexandr Miloslavskiy10-1/+819
Fix 1 ----- Previously, SWT applications terminated unexpectedly on session end (logoff / shutdown) and didn't have a chance to perform on-exit actions, such as saving current settings. This patch fixes it, bringing Linux in line with Windows and macOS. SWT applications will now: 1) Receive 'SWT.Close' event for their 'Display'. Similar to Windows and macOS, this now allows to set 'Event.doit' to 'false', hinting the OS that application is not ready to close. Linux often ignores this hint, though. I think handling this properly would require inhibitors which are not yet covered by this patch. 2) Force 'Display.dispose()' when 'EndSession' is received This allows applications to use all forms of on-exit cleanup, such as * Listening to 'SWT.Dispose' * Running code after 'while (!display.isDisposed())' * Installing Java shutdown hooks (because a typical application will exit its 'main()' after display is disposed) Some system properties are available for customization, see code in 'org.eclipse.swt.internal.SessionManagerDBus' Fix 2 ----- Noticed and fixed a memory leak in 'WebkitGDBusinvokeReturnValueExtensionIdentifier'. Fix 3 ----- Moved test snippets to correct folder Change-Id: If968fc4b86cc0b6de192ef3ef4319ca96967cd22 Signed-off-by: Alexandr Miloslavskiy <>
2019-04-24Bug 546144 - [JNI] Revert some recent jnigen changesNikita Nemkin4-103/+44
Revert "Bug 515610 - [GTK] SWT generates incorrect fall-through for memmove()" This reverts commit 4c3b9d2b9864a1910c5116168456ab215a2dc2aa. Change-Id: Iea193f29a877face605deaa51bfce96027f7d7ac Signed-off-by: Nikita Nemkin <>
2019-04-24Bug 546144 - [JNI] Revert some recent jnigen changesNikita Nemkin4-383/+353
Revert "Bug 534923 - Cocoa: objc_msgSend is called incorrectly from os.c" This reverts commit 94bbab9593afe86192ce9ff1c7d23f9003c3ef5e. Change-Id: If227caf179ffc8cb018c343d3b99d3535aea8d04 Signed-off-by: Nikita Nemkin <>
2019-04-24Bug 540357 - [10.14] Make SWT adapt to switching to dark mode (and back)Lakshmi Priya Shanmugam2-1/+58
Widgets should have correct foreground, background colors in the Dark mode. Set default foreground color for Link and Multi-style text. Update multi-style text background color. Change-Id: I49eaee8064edddba3c2e751dd3450b74d02ecacc
2019-04-24Bug 475833: Delete TableTree and related itemsLars Vogel10-2442/+26
Change-Id: I0811d7d0ae7e449adf85d031d3eaa2ef143ed5c6 Signed-off-by: Lars Vogel <>
2019-04-24Bug 540357 - [10.14] Make SWT adapt to switching to dark mode (and back)Lakshmi Priya Shanmugam5-8/+12
Set correct foreground color for TabFolder and Tree and Table headers. Redraw header view after setting header fg & bg colors. Table header bg/fg color should use the default color when no color is set, similar to Tree. Change-Id: Ief188ba5fd1fda8efe563fa492a74b4fc01df77d
2019-04-23Bug 546349: [Wayland] Prevent GtkIMContext crashes/warningsEric Williams5-1/+24
Check the imHandle before calling gtk_im_context_reset(). Change-Id: I1cfc46ffeb1ff66d9ceca2415213364826451032 Signed-off-by: Eric Williams <>
2019-04-23Bug 466511: Replace dropdown menu custom drawing with pngMatthias Becker1-2/+13
View dropdown uses grey as foreground color so the min max icons need to use the same color Change-Id: If6d5b618658787ea0f83423c8c817e00fd359f0d Signed-off-by: Matthias Becker <>
2019-04-23Version 4.12 update for org.eclipse.swt.examplesLars Vogel2-3/+3
Required for Bug 475833. Change-Id: Ib8a07acdb6096f04b6814996a560e558cb4bea38 Signed-off-by: Lars Vogel <>
2019-04-23Bug 462665 - Remove references to Carbon in SWT Java code and commentsLars Vogel7-10/+8
Change-Id: I5f6a558564239e64db2aae3c504df604ebb884bb Signed-off-by: Lars Vogel <>
2019-04-22Bug 536021 - [Win32] Table: right-aligned column header with own background ↵Thomas Singer1-1/+1
color lacks margin Change-Id: Ieecfc0d5fa13bfbd99e87cc7616e5cbf97ce285c Signed-off-by: Thomas Singer <>
2019-04-19Bug 493148 - [Win32] Non-editable StyledText can be changed by typing ↵Thomas Singer1-0/+8
Chinese using IME Change-Id: I0a67a1b576abae0c02e4cbcdc469bb786a8a9ecd Signed-off-by: Thomas Singer <>
2019-04-19Bug 546585 - [Cocoa] Don't use objc_msgSend to call variadic functionsNikita Nemkin7-93/+7
JNIGen generates wrong C code for calling variadic ObjC methods, remove all such methods from SWT codebase. Change-Id: Icee75b71c4035a331a4b52ddcaf65e0d59c8793c Signed-off-by: Nikita Nemkin <>
2019-04-18Bug 540903 - [GTK4] Adapt to GtkClipboard changesXi Yan6-2/+45
1) ifdef gdk_display_get_*_clipboard on GTK4 2) Replace gtk_clipboard_clear with gdk_clipboard_set_content(null) Change-Id: I139b8606f01961c31adc56c08ad35c4abd1fb0bc Signed-off-by: Xi Yan <>
2019-04-17Bug 546493: [GTK4] Button click coordinates are incorrect for some casesEric Williams5-3/+42
This is a two-part fix: 1) Adjust the sendMouseDown() function in Control, as event coordinates on GTK4 are already parent relative. 2) Table/Tree have headers built into the GtkTreeview's surface, meaning the y-coordinates will include the height of the header. This throws off any geometry-item querying code in Table/Tree. The fix is to adjust the coordinates to account for the size of the header. GTK3 doesn't have this problem because the header has its own GdkWindow which is separate from the rest of the Table/Tree. Tested using Snippet3 on GTK4. Change-Id: Ia68a6edb376a823dc3beb57e4db084075e42138b Signed-off-by: Eric Williams <>
2019-04-16Bug 546489 - [GTK4] Replace GtkClipboard with GdkClipboardXi Yan6-5/+57
Replace GtkClipboard with GdkClipboard Change-Id: Iad0c8bff10ab325cf53bde1711bddf0e3842ee9d Signed-off-by: Xi Yan <>
2019-04-16Bug 545943 - [GTK4] Scrolling with the mouse wheel not workingXi Yan1-1/+1
Fix GdkEventControllerScroll flags so that scrolling with mouse works on GTK4. Tested with Snippet 7, 8, 52, 53, 59, 61, 90. Change-Id: I5a4b344e1b7ec0eef75733bdbe04649d15645b77 Signed-off-by: Xi Yan <>
2019-04-16Bug 546488: [GTK4] Cursor never reverts back to normalEric Williams7-6/+31
Use gtk_widget_set_cursor() in certain instances in order to make sure the cursor is set/unset properly. Change-Id: Iad680c4ab71aae79faf6ac7e61513b793dd5380a Signed-off-by: Eric Williams <>
2019-04-16Bug 546481: [GTK4] Fix Snippet4Eric Williams1-2/+5
Allocate to shellHandle so that drawing works properly -- otherwise the snapshot will stop at the child GtkWindow and nothing will be passed on to any of the children. This means the Shell would not draw. Change-Id: I62e7b845fdab99acb864aea86de7916e88829f3e Signed-off-by: Eric Williams <>
2019-04-16Bug 546252 - [GTK] Cleanup for tooltip color fixesAlexandr Miloslavskiy7-76/+528
Fix: ---- All layers are rendered when background color is estimated. This solves the problem for themes that utilize semi-transparent labels in tooltips, such as 'HighContrast'. NOTE: 'gtk_style_context_get_parent' requires 3.4. However, for Eclipse 4.12 requires at least GTK 3.10, so this can be ignored. Code cleaning: -------------- Deleted tooltip-related CSS parsing code that is now dead. Tests: ------ Added snippets I developed during investigation. Change-Id: Ic4504be60df58f32e32b90a487e28af68853977d Signed-off-by: Alexandr Miloslavskiy <>
2019-04-16Bug 545884 - [Win32] Remove TCHAR string wrapper (Part 1)Nikita Nemkin34-324/+246
Replace TCHARs that are used as fixed-size buffers with plain char[] arrays of the same size. Change-Id: Ic54bafb4e865dff62de67a0efefc6020aa5349f3 Signed-off-by: Nikita Nemkin <>
2019-04-15Bug 545645 - [GTK] Table/Tree header must not keep focusXi Yan3-0/+222
Address issue with updating SWT.VIRTUAL table making header being focused on click. Tested with 2 attached snippets and Snippet38. Change-Id: If02802c01bab05db3b7c241e90dc4a4ed4176608 Signed-off-by: Xi Yan <>
2019-04-15Revert "Bug 466511: Replace dropdown menu custom drawing with png"Eric Williams1-13/+2
This reverts commit a5d8b38bcb1b0702f9e164aacfd92f5edc1df87b. Change-Id: I519b1f7f74771bdd10a85ab12dca30e37b977982
2019-04-15Bug 546420 - [Win32] Don't guard against GDI+ loading failureNikita Nemkin3-33/+19
GDI+ presence is guaranteed on WinXP and later. Change-Id: Iee3c46ce8a2ac61170a51b06d7986340051ca1c8 Signed-off-by: Nikita Nemkin <>

Back to the top