Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-23v4919v4919aY20180823-0800S4_9_0_M3I20180823-0450I20180823-0430I20180823-0100Eclipse Platform RelEng Bot1-1/+1
2018-08-22Revert "Bug 518414 - [gtk] Package explorer double click opens currently ↵Y20180822-2200I20180822-2000Alexander Kurtakov4-74/+25
selected (highlighted) resource" This reverts commit 570eea028ff9794f1df7de6a4445780010e8eaa8. Change-Id: I33051d4de5cd6fc2e785137bb05d25054d30f7fb
2018-08-21Bug 518414 - [gtk] Package explorer double click opens currentlyXi Yan4-25/+74
selected (highlighted) resource Added row-activation handler for Tree/Table/List to know when double-click triggers a 'row-activated' event. Prevent Default Selection from triggered when double clicking the expander triangle. Tested in child Eclipse, double-clicking/enter on a file gains focus as before. Double-click the expand triangle or anywhere else does not open the current highlighted item. Change-Id: I4727906525d3ce379e66514f74209522261706c7 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-21v4919v4919I20180822-0800I20180821-2000I20180821-0800Eclipse Platform RelEng Bot1-1/+1
2018-08-21v4919Eclipse Platform RelEng Bot3-4/+4
2018-08-21Bug 530393 - EPL 2.0 update for SWT bundlesLars Vogel1141-3423/+6846
Update all sources files except .exsd files, Java pref files and pom files Staged via: git grep --name-only 'Eclipse Public License 2.0' > input.txt Manually added \ before the spaces in the directories with spaces cat input.txt | xargs git add Regex used: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: If93c95c1ce4c7ee8345dea43e7b9ae71f5fa4739 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-21Bug 530393 - EPL 2.0 update for SWT test plug-insLars Vogel338-1017/+2034
Update all sources files except .exsd files, Java pref files and pom files Staged via: git grep --name-only 'Eclipse Public License 2.0' > input.txt Manually added \ before the spaces in the directories with spaces cat input.txt | xargs git add Regex used: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: I000f78a584a97bdd8d6749b3569cd953a4e7e0c1 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-21Bug 530393 - EPL 2.0 update for SWT for swt.tools.feature and localbuildLars Vogel3-12/+24
Change-Id: Idc26ab5e340a7c0ed34d7bd90593cf7fa2beedfe Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-21Bug 530393 - EPL 2.0 update for SWT for swt.example plug-insLars Vogel578-1724/+3448
This updates files to EPL 2.0. As this repo contains also LGPL code, I added only files containing 'Eclipse Public License 2.0' via: git grep --name-only 'Eclipse Public License 2.0' | xargs git add Regex used for replacement: find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: Ifad89e954b50112a71c30842130e558d171631f6 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-20v4918v4918fI20180820-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-20Bug 442831 - TextLayout.getLineBounds returns incorrect values for rightXi Yan2-9/+138
to left text pango_layout_iter_get_line_extents gets the extents in layout coordinates from top-left corner. Removed recalculation of x when using RTL since already in correct direction. Change-Id: Ib7e1bbb552805eab89ebf072481dfcdec7599caf Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-20Bug 537960 - Tree and Table queue a re-draw if bounds changedSimeon Andreev2-0/+39
If an SWT tree or table has a registered listener for item measure, paint or erase events, its possible that the last rows of the tree or table are not correctly repainted on resize. If such a listener takes "too long", GTK will not always invalidate the pixel cache of the underlying tree widget. As a result, views such as the Package Explorer and Outline will not always draw text and icons for their last (3 to 4) rows, when the height of their part stack is increased by dragging a Sash. With this change, SWT trees and tables check if a resize occurred since the last draw. If so, the current draw is discarded and a new draw is requested via GTK API gtk_widget_queue_draw. This ensures that the GTK pixel cache is invalidated after a sash resize, as well as minimizes extra widget draws. Change-Id: I84b73826ff8b566d102c5e42177576feb28a2bd6 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-08-20Bug 530393 - EPL 2.0 update for SWT for swt.tools plug-insLars Vogel62-192/+384
This updates files to EPL 2.0. Regex used for replacement: find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: Ia82f1301d4f811557057db226c1f04098f45f9de Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-20v4918v4918eI20180820-0800Eclipse Platform RelEng Bot1-1/+1
2018-08-20Bug 530393 - EPL 2.0 for exsd in SWTLars Vogel1-3/+6
Only one exsd present in SWT. Regex used: find . -type f -name "*.exsd" -exec sed -i -E 's/http:\/\/www.eclipse.org\/legal\/epl-v10.html\&quot;\&gt;http:\/\/www.eclipse.org\/legal\/epl-v10.html\&lt;\/a\&gt;/https:\/\/www.eclipse.org\/legal\/epl-2.0\&quot;\&gt;https:\/\/www.eclipse.org\/legal\/epl-v20.html\&lt;\/a\&gt;\/\n\nSPDX-License-Identifier: EPL-2.0/' {} + find . -type f -name "*.exsd" | xargs sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' find . -type f -name "*.exsd" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: Ib27dc3787b5afdffac273cc764907696ad6f9f3e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-17v4918v4918dI20180819-2000I20180819-0800I20180818-1500I20180818-0800I20180817-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-17Bug 536564: Test failures on Mac OS X 10.13 from I20180628-0230Lakshmi Shanmugam2-8/+0
Removed code to capture screenshots Change-Id: I0dae4bb46682bb7f3a85b22de820bd6e70c73e50
2018-08-16v4918v4918cI20180816-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-16Added native C snippets for SWT bugs.Xi Yan3-0/+268
Change-Id: I16e310881955447d8d7e9244558c388a2cb6f907 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-16Bug 210915 - Shell#getLocation() wrong after setVisible(false)Xi Yan1-0/+5
When shell is moved and then hidden, its location does not get updated to the latest location. The fix is to move the shell to the latest location before getting its position. Change-Id: I10b2725c2404eca65727b37aab88f0e0ee7657d2 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-16Bug 534229 - [GTK 3.22] assertion size >= 0 failed on GtkCheckButton onXi Yan1-8/+14
standard error When size of GtkCheckButton and GtkRadioButton is set larger than the visible container size, assertion size >= 0 error gets generated. Only resize SwtFixed handle for GtkCheckButton and GtkRadioButton. Tested with Run/Debug page in Window -> Preferences, and new Eclipse Application configuration page. Change-Id: I28fb465202dcd40bcc2e4a4778b60c70f0906ebd Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-16[WIP] Bug 537960 - Tree in SashForm doesnt paint last rows on resizeSimeon Andreev1-0/+109
When resizing tree views, e.g. the Package Explorer, the text and images of bottom rows are sometimes not painted. In particular, JFace OwnerDrawLabelProvider registers an paint and an item measure listener. Due to the registered measure listener, the paint listener is not triggered when the sash is moved. This behavior is seen due to the fix for bug 531667, which (among other changes) restricts widgets from painting over other widgets. This change adds an SWT bug snippet for the problem. Change-Id: I2f523565675907aaadad8e09a0f054698272885d Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-08-16Bug 536564: Test failures on Mac OS X 10.13 from I20180628-0230Lakshmi Shanmugam2-4/+25
Temp code in attempt to fix failing tests - added sleep before asserts and capture screenshots. Change-Id: I78920da73ff1ed91219174964f9fc80ca6ebf6b4
2018-08-16Bug 459043: [Cocoa] NPE while invoking Display.getBoundsLakshmi Shanmugam7-9/+35
Added null checks for all calls of NSScreen.screens() except in Shell & Tracker. Change-Id: Ifaf21c2c35b2445451cb3c6a0b7a53b7afe8a8c8
2018-08-15v4918v4918bY20180815-2200I20180815-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-15Bug 528819: [GTK3] StyledText draws carets if unfocusedEric Williams2-1/+56
Only draw the caret if it has focus: this logic existed for GTK3.20- but was removed in a fix for Wayland. Restoring this behaviour fixes the bug for GTK3.22 as well. Tested with the snippet attached and in the IDE. No reduction in Caret performance is observed. Change-Id: I91d78217e90ce7ac7d1ab3e0898b0dda6fad44d2 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-15Bug 386054: Unnecessary code in dialogs?Eric Williams2-10/+0
Remove unnecessary gtk_window_set_icon_list() code from Color and Font dialogs. Windows that have gtk_window_set_transient_for() set on them inherit their icons from their parent windows. No issues observed in ControlExample. Change-Id: I43f509861345288b9620751ff38622006ef59d4b Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-15v4918v4918aI20180815-1250Eclipse Platform RelEng Bot1-1/+1
2018-08-15Move to Surefire 2.22.0 in swt.tests.Alexander Kurtakov1-1/+1
Change-Id: Ie4133c4d80bce537f18761204740bfe7ff4cbf4c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-08-14v4918v4918I20180814-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-14v4918Eclipse Platform RelEng Bot3-4/+4
2018-08-14Bug 386769: Use of GTK_HAS_FOCUS with deprecated GTK_WIDGET_SET andEric Williams2-3/+0
UNSET FLAGS in Composite Widget Remove GTK_HAS_FOCUS flags as they are deprecated and already set by gtk_widget_grab_focus(). Change-Id: I5439bca85543ebe48ea07b0b6a8c7e87eb122504 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-14Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events whenXi Yan3-4/+90
opening context menu Fix test issues caused by previous patch. Previous patch prevents activate event to be send when they are necessary, causing several shell issues. This patch has the logic: when context menu is shown, ignore focus_out/deactivate event for shells. When context menu is hidden, ignore activate event for shells. Tested with WorkbenchTextEditorTestSuite (workbench.texteditor.tests), UIAllTests (e4.ui.tests), and UiTestSuite (ui.tests) locally. In child Eclipse, Ctrl+F and pasting text via Ctrl+V pastes text into search entry. Holding down Ctrl and pressing E multiple times cycles list. Change-Id: I2a2a023c798e1231a7c6c72e9cb94177af5f4aa2 Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-14Bug 537713: [GTK3] Combo sizing problemsEric Williams2-22/+50
Do not perform resize calculations for Combos, as their large minimum and/or natural sizes causes API breakages with setBounds(). Tested with the snippets from this bug and bug 535323, AllNonBrowserTests, and the IDE: no allocation warnings occur. Change-Id: Ieefa0752fcb2dd3a743ebcc432eef939a46b73f4 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-14Bug 536141: [Webkit2][Gtk] BrowserFunction lost after page reload onEric Williams14-59/+1174
Linux/GTK The main cause of this bug is that web pages load too quickly -- by the time the BrowserFunctions are re-registered asynchronously from Java, the extension has loaded the page. BEFORE THIS PATCH: BrowserFunctions were registered asynchronously from Java into the web extension (C). This was done either at the outset (WebBrowser.createFunction()), or after every page load (Webkit.webkit_load_changed() callback). AFTER THIS PATCH: The fix is relatively straightforward, yet GDBus adds a lot of overhead. Instead of constantly registering BrowserFunctions from Java, we load them into the web extension on creation. This hands off the responsibility of re-registering BrowserFunctions to the web extension, which reduces overhead and ensures the functions are registered/executed before the page loads. The BrowserFunctions are stored at the C level in the extension, using a linked list. Whenever the "object-cleared" callback is triggered in the extension, the linked list is iterated over and any BrowserFunctions for that page are re-registered. Chronological ordering of information flow from SWT -> web extension via GDBus. 1) SWT Webkit class is loaded. SWT GDBus server is created. 2) SWT Webkit creates the extension, passing it the information of the SWT Webkit GDBus server. 3) The extension's initialization callback is called in C. 4) In this callback the extension contacts the SWT Webkit GDBus server and provides it with information such as its PID and name. 5) SWT Webkit acknowledges this information, and sends back any BrowserFunctions that were created before the extension loaded. 6) The extension adds these BrowserFunctions to its linked list. 7) Any subsequent BrowserFunctions are added to the extension's linked list by calling the extension's GDBus server synchronously. In the event of a GDBus timeout (happens sometimes when running tests), the GDBus call is made asynchronously. This functionality can be tested with the attached snippet. AllBrowserTests pass without issue, and there are no visible Browser issues in the IDE. The plugin attached to the initial bug report is now functional. Change-Id: Iddc5f2e69f0a7fd4500bd8228f0bc46c4b3a6322 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-14v4917v4917aI20180814-0910Eclipse Platform RelEng Bot1-1/+1
2018-08-14Bug 515502 - [HiDPI][Win10] SWT to receive/handle DPI changeI20180814-0900Niraj Modi5-3/+313
notification from OS Change-Id: Ic0b851b76cbd5b270f4d4337de6ac6f2fb81812c Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-08-13v4917v4917I20180813-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-13v4917Eclipse Platform RelEng Bot3-4/+4
2018-08-13Revert "Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events when ↵Andrey Loskutov3-91/+6
opening context menu" This reverts commit 9f91c882bb8f96c689143525a71937171402a3d7.
2018-08-13Bug 537908: [GTK3] Warning about invalid signal forEric Williams6-0/+21
GtkTextViewAccessible "attributes-changed" Only send "attributes-changed" signal on GTK2 instances of GtkTextViewAccessible. Change-Id: I47d79fa68ee8c0046f9ad436371c19f0bc112859 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-08-13Bug 534554 - [Wayland] Javadoc doesn't dissapear via Esc until youXi Yan2-8/+34
clicked into it Added constants for GdkSeatCapabilities. Passed GDK_SEAT_CAPABILITY_KEYBOARD to gdk_seat_grab instead of 1 to grab keyboard focus instead of pointer focus. Implemented isMappedToPopup to check if a shell's parent is a popup. Note: Calling gdk_seat_grab on visible window causes caret to get stuck in Eclipse after closing Javadoc using only gdk_seat_ungrab. The fix is to hide GtkWindow before grabbing. GtkWindow should only be hidden for a popup window whose parent is a top most window to prevent gdk warnings and shells not showing. Tested with child Eclipse on Wayland. Pressing F2 makes Javadoc popup, pressing UP/DOWN arrow scrolls, pressing ESC closes Javadoc. Completion popup works with tab. Snippet with bug 515773 works as before. Change-Id: I2a6cca4062379c2b52ca93ec1c8bccfab9e1aebb Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-10v4916v4916dI20180812-2000I20180811-1500I20180810-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-10Bug 537863 - Errors trying to build 4.9 SDK locally: Missing requirementAndrey Loskutov1-0/+14
org.eclipse.swt.tools.feature.source.feature.group 0.0.0 Change-Id: I5e19bda2e490b89abdae84924c43b214d9a2f410 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-08-08v4916v4916cY20180808-2200I20180810-0320I20180809-2000I20180808-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-07Bug 436841 - [GTK3] FocusOut/In and Activate/Deactivate events whenXi Yan3-6/+91
opening context menu Activate/Deactivate events are sent when the context menu is shown. Use flag to ignore activate/deactivate events when context menu is open. Change-Id: Iaa7a55fca388220421ba1d7f6718874689f7d88b Signed-off-by: Xi Yan <xixiyan@redhat.com>
2018-08-06v4916v4916bI20180807-2000I20180807-1425I20180807-0350I20180806-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-06Bug 537614 - [Win32][CustomHiDPI] Gap between Checkbox/Radio and TextNiraj Modi1-1/+5
not getting scaled Change-Id: I67eda8932305288e3f72c94a205f118508e71f4e Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-08-05v4916v4916aI20180806-0300I20180805-2000Eclipse Platform RelEng Bot1-1/+1
2018-08-04Bug 476608 - Sluggishness reported in gdk_flushAlexander Kurtakov1-1/+0
Remove call from setDarkThemePreferred. Change-Id: Ia70b1b705b0bef7bbae1c5c3d7a0a7034e64ba38 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>

Back to the top