Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-02-03v4858v4858I20180206-0315I20180205-2000I20180204-2000I20180203-1500I20180202-2000genie.releng1-1/+1
2018-02-03v4858genie.releng3-4/+4
2018-02-02Bug 481485: [GTK3.10+] Paint listener for button/label does not workEric Williams3-38/+81
On GTK3.10+, Buttons and Labels do not receive the proper draw signals. This is due to them drawing on their SwtFixed parents (fixedHandle), as GtkButton and GtkLabel do not have their own GdkWindows. This patch reverts parts of bug 483791 and fixes this bug by overriding windowProc() in Button and Label. There we check if the incoming handle is the paintHandle, and draw accordingly. Bug snippet is attached in this patch. Change-Id: I7c415985248ca5fda9e38aaf9b0c08ae834d762d Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-02-02Bug 530567 – Move BugSnippets into separate package and exclude fromLeo Ufimtsev56-5/+155
builds. (rename) Renaming bug snippets to 'ManualTests' to better express functionality. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530567 Change-Id: If0132056efaf7a952dbe9f9248180cb56c8f6c9d Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-02Bug 529151 [Gtk] Move gtk/gdk function from OS.java to GTk.java andLeo Ufimtsev87-8327/+8396
GDK.java 1) a) Moved gdk functions from OS.java to a new GDK.java. This removes the need to have manual entries in os_custom.h for dynamic functions. (I took care to add copyright header to GDK.java :-). b) Added custom macro to os.h to link GDK_LOAD_FUNCTION to LIB_GDK c) Removed manual links from os_custom.h, as they're now auto-generated. 2) a) In OS.java, I moved custom functions close to each other and labeled with with '@category custom', to make it easier to tell them apart. For some functions, it's hard to tell if they're custom or native, e.g 'g_utf16_strlen' is actually a custom function in os_custom.c. Also added documentation on the two types of custom functions and how to add a custom function. New SWT developers often struggle to figure this out. b) I left 2 custom macros and a custom gdk fuction in OS.java. (e.g gdk_keymap_translate_keyboard_state). This is because it belongs more to 'OS.java custom' with link to os_custom.h type functions. Testing: - JUnits Gtk2.24 & Gtk3.22 - Child eclipse on wayland backend, on Gtk2.24/Gtk3.22 * (X11) * (Wayland). - Child eclipse on X11 desktop backend, on gtk3.22/gtk2.24 and x11 eclipse. Afaik good to merge. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=529151 Change-Id: I4becc174df8d2dc3375828b4c8e2e3cdcf5c3c3a Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-02v4857v4857I20180202-0315I20180201-2325I20180201-2000genie.releng1-1/+1
2018-02-02v4857genie.releng3-4/+4
2018-02-01Suppress deprecation warnings.Alexander Kurtakov1-1/+3
For tests of deprecated methods. Change-Id: I58cd788ea798671d7d935480eb492886005e1384 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-01Suppress deprecations warnings.Alexander Kurtakov1-1/+2
For tests of deprecated method. Change-Id: I0d06befc87db71586784fd970d92efd4ce980d7f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-01Bug 530611 - Simplify code of StyledTextRenderer with LineSizeInfo classangelozerr1-41/+110
Change-Id: I99c620183cb26d884ef000af9d4cc5098321b318 Signed-off-by: angelozerr <angelo.zerr@gmail.com>
2018-02-01Bug 530609 – Add missing license headers to bug snippetsLeo Ufimtsev42-35/+613
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530609 Change-Id: Idacfef6e77f9b9a4a3ecb75c8ad6b1746a86f50e Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-01Bug 530602 - Remove atom based OpenDocumentAlexander Kurtakov8-260/+2
There is new dbus based implementation (used by launcher) and the atom/property based one is not supportable under wayland. Change-Id: I18e594b2690ddb8b91f8532d2216b536e6d05ed6 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-01Bug 528679 - Eclipse Photon M3a crashes on CentOS 6Alexander Kurtakov5-4/+24
Print the minimal required Cairo version if older one is detected. Do not exit but let the user know of the issue. Change-Id: I3c8ec968f7a49bc84fda335e9b4812540d943829 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-01Bug 529151 [Gtk] Move gtk function from OS.java to GTK.javaLeo Ufimtsev84-25121/+25057
Benefits: - Adding dynamic functions doesn't require one to manually link the function in os_custom.h anymore. This makes prototyping much faster and SWT development more user friendly. - NativeStats tool generates a separate category for gtk functions (from OS.java once). Technical details: - SWT Tools generates <CLASS_NAME>_LOAD_FUNCTION with GTK.java, we get GTK_LOAD_FUNCTION - we hard-code GTK_LOAD_FUNCTION to link to gtk lib (see os.h). - All native code is still put into os.(c|h) - I manually Updated a few special OS_LOAD_FUNCTION calls and removed old bindings in os_custom.h Verified with child eclipse. Fedora 27, Gtk3.22. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=529151 Change-Id: I6446ee5cca090022a8d984a1f92969c26e5e2f24 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-02-01v4856v4856eI20180201-0200I20180131-2000genie.releng1-1/+1
2018-01-31Bug 530059: [Wayland] Show In menu appears in the wrong placeEric Williams1-0/+2
Add breaks to switch statement. Change-Id: Ie22d3a152726e47becb64b8d7f09070a16ed6a51 Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-01-31Bug 530567 – Move BugSnippets into separate package and exclude fromLeo Ufimtsev8-33/+130
builds. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530567 Change-Id: I8cde9c76bf39ef8c1aa3e303012994e9c1473241 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-31v4856v4856bgenie.releng1-1/+1
2018-01-31Bug 530536: Reconfigure SWT build jobs for JenkinsLakshmi Shanmugam1-2/+2
Use replaceAll instead of replace. Change-Id: Iab7e220414cf47c736039d10ed83ff1f1f84f3d9
2018-01-31Bug 530459 – Improve error message "Embedded browser not available"Leo Ufimtsev1-2/+24
Enhance the error message. Change-Id: I278fd09e0d6004de781dc8c0c22ffba25a6b357d Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-31v4856v4856dgenie.releng1-1/+1
2018-01-31v4856v4856cgenie.releng1-1/+1
2018-01-31v4856genie.releng1-1/+1
2018-01-30Bug 529870 – [webkit2]BrowserProblemI20180130-2000Leo Ufimtsev2-6/+67
Fixing a corner case that can generate a deadlock. - A) User calls evaluate(SCRIPT) - B) The SCRIPT calls a BrowserFunction, (java/swt) - C) The BrowserFunction calls evaluate() Now webkit_web_view_run_javascript() in C never starts because webkit is still executing A. But A never finishes because it's waiting for C to complete to get a return value for A's callback. Solution: Don't allow blocking evaluation in BrowserFunction() callbacks. This shouldn't affect folks mostly, because from what I gather people use 'evaluate' as a form of execute(). This has gone unnoticed on Win32/Cocoa because issue isn't explicitly raised and 'evaluate()' return value wasn't used. Verified with AllBrowser JUnits. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5298702 Change-Id: Iddc8c753051455f6706ea81db85e0c6610be11a9 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-30Bug 530315: OS X automatically replaced -- with dash in "OS arguments"Lakshmi Shanmugam1-0/+4
field of launch configuration Disable automatic quote & dash substitution for the application by default. Change-Id: I5d555c6a3bc9305bf089d303d97cadd0811b211f Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
2018-01-30Bug 525305: [API]Provide SWT.OpenUrl eventLakshmi Shanmugam2-2/+6
application:openUrls: is a custom selector, move it out of the auto-generated function. Otherwise, it'll be removed by the MacGenerator. Change-Id: Icbb26c1e0abc9340798dc1c39f2cbf217deceea2
2018-01-29v4856v4856aI20180129-2000I20180129-0605genie.releng1-1/+1
2018-01-29Force qualifier update.I20180129-0540Alexander Kurtakov1-0/+1
Due to Bug 521182 - [compiler] method reference on null object should throw NPE at runtime (JLS compliance) Change-Id: I2acd20d411748d8e3c9d5b806aadff9cfa19f35d Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-01-27v4856v4856I20180128-2000I20180127-1500I20180127-0150I20180126-2040genie.releng1-1/+1
2018-01-27v4856genie.releng3-4/+4
2018-01-26Bug 519753 - Added disposal checksKarsten Thoms1-2/+2
Change-Id: Ic34f2a6b6c3ebe63ba2c843d975a023f9b56003e Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-01-26Bug 530166 - [Sonar] Performance - Method invokes inefficient NumberLars Vogel2-11/+11
constructor; use static valueOf instead Sonar reports issues in org.eclipse.swt.examples, which should be fixed Change-Id: Ic55348a56f75991dcb2d9147add97e8c47610e85 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-01-26Bug 530172 - Prefer using Boolean.valueOf and Integer.ValueOf in GDBusLars Vogel1-3/+3
Change-Id: I76612df9a5585b1509d2920a6bc872701c0c5757 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-01-26Bug 530397 – [Gtk] Make gdbus initialization dynamicLeo Ufimtsev4-58/+56
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=530397 Change-Id: Ia99129ce35b8e190402abea3a2eb75d668e8c825 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-26Bug 530170 - Prefer using Boolean.valueOf and Integer.ValueOf inLars Vogel1-3/+3
Control.java Change-Id: I2a033ec1af2fbc2a359c65b60f99958d8f4a77ba Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-01-26Bug 530059: [Wayland] Show In menu appears in the wrong placeEric Williams6-0/+143
Events used to spawn menus can contain inaccurate window information on Wayland. If we are running on Wayland, set the event window to be that of the mouse pointer location. Tested on GTK3.22 using the Wayland backend. X11 is unaffected by this fix. No AllNonBrowser JUnit tests fail. Change-Id: I6410694a88faacc672144d9f57e6c61032ea33cf Signed-off-by: Eric Williams <ericwill@redhat.com>
2018-01-25v4855v4855cS4_8_0_M5I20180124-2000genie.releng1-1/+1
2018-01-24Bug 525305: [API]Provide SWT.OpenUrl eventLakshmi Shanmugam1-0/+1
Added missing openUrl selector to appProc Change-Id: I1ff1777b1523df468269f00c3587e43de1f8f604
2018-01-23v4855v4855bI20180124-0800I20180123-2000I20180123-1010I20180123-0800I20180122-2000genie.releng1-1/+1
2018-01-22Bug 525305 – [API]Provide SWT.OpenUrl event (Linux implementation)Leo Ufimtsev4-11/+68
(For review/merge) Linux implementation for OpenUrl event, with use of GDBus. (As per original patch *1). URL vs file detection done via "new URI(file).getScheme()". I tested, this distinguishes URI's from files quite well. I.e: /myfile/ ./file file .. -> (OpenFile) http://www.eclipse.org mailto:my@mail.com .. -> (OpenUrl) I've tested with latest launcher: 1) Via launcher: eclipse http://www.eclipse.org /tmp/myFile 2) Via gdbus calls: gdbus call --session --dest org.eclipse.swt --object-path /org/eclipse/swt --method org.eclipse.swt.FileOpen "['http://www.google.com', '/tmp/myFile']" Patchset 2: - Updated URL detection logic so that files/urls are properly distinguished. Links: [1] Original patch: https://git.eclipse.org/r/#/c/30107/14/bundles/org.eclipse.swt/Eclipse+SWT/gtk/org/eclipse/swt/widgets/Display.java Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=525305 Change-Id: I6531989e3eb766fdf0715a0a9cb86c9ed2b973f3 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-20v4855v4855aI20180122-0800I20180121-2000I20180121-0800I20180120-1500I20180120-0800I20180119-2000genie.releng1-1/+1
2018-01-19Bug 529979 - [sonar] Resolve "Write to static field from instance meth."René Purrio2-5/+4
Change-Id: I5d188d56aa3c916d15c6084769d8b23d2ad68486 Signed-off-by: René Purrio <rpurrio@itemis.de>
2018-01-19v4855v4855I20180119-0110genie.releng1-1/+1
2018-01-19v4855genie.releng3-4/+4
2018-01-18Bug 525305: [API]Provide SWT.OpenUrl eventI20180118-2000Lakshmi Shanmugam1-0/+6
Added api filter for SWT.OpenUrl. Change-Id: I61240b9d4fca747e358e7efecfd034a7e38ac505
2018-01-18Bug 528414 (swtWaylandLauncher) Part 1.2 : Polishing of SWT GDBusLeo Ufimtsev6-35/+147
Not a prereq to launcher patch, but nice to merge. - Mostly polish. No real functional change to existing functionality. - Clarified code that was confusing when there was an issue. - Added documentation with samples. - Added/tested support for Boolean and Integer to GDBus implementation, I initially was planning on using them for ping method, but later discovered that I could use DBus's standard Peer.Ping method. However, Boolean/Integer handling might come in handy in the future, since I developed/tested it, we might as well add it. - Minor bug-fixes here and there. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=528414 Change-Id: I201ce2bfd71afb563d3463f2f8ce980422423a8d Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
2018-01-18v4854v4854I20180117-2000genie.releng1-1/+1
2018-01-18v4854genie.releng3-4/+4
2018-01-17Bug 527738 [Webkit2] Add test case for calling setUrl with POST data.Roland Grunberg1-0/+28
Simply call bugs.eclipse.org and pass some x-www-form-urlencoded data in the POST message body. Change-Id: I9148ee19468c910044b5f2b93b4a7e96f3730edb Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
2018-01-17Bug 528284: [GTK3] Toolbar: TCF dropdown control is cutoffEric Williams2-4/+8
Fix casting in OS.java. Change-Id: I470bd08d636945360f32c81c8a6b9a433db0837e Signed-off-by: Eric Williams <ericwill@redhat.com>

Back to the top