Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2018-09-17 11:16:51 +0000
committerAlexander Kurtakov2018-09-17 11:16:51 +0000
commit2c981a5d0ca27f5265fb0d25636bb1ffc8df676b (patch)
tree0b103983a0163b5aca5edb494c14e3a4fd2f766b /bundles
parentf04161cd3ce2cb7be6ae95d3a4cbecc21f0f3b5f (diff)
downloadeclipse.platform.swt-2c981a5d0ca27f5265fb0d25636bb1ffc8df676b.tar.gz
eclipse.platform.swt-2c981a5d0ca27f5265fb0d25636bb1ffc8df676b.tar.xz
eclipse.platform.swt-2c981a5d0ca27f5265fb0d25636bb1ffc8df676b.zip
Bug 530841: [GTK2] Remove GTK 2.x support
Remove GTK3 assertts - not needed anymore. Change-Id: If4fff6fbac817d9963beef3203d0f7f7541a45b5 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Diffstat (limited to 'bundles')
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Button.java6
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Combo.java5
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Composite.java1
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java2
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java5
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Label.java1
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java1
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Spinner.java2
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java2
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabItem.java2
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Text.java2
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolBar.java3
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolItem.java4
13 files changed, 0 insertions, 36 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Button.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Button.java
index 23e5c1672e..c0fe04246b 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Button.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Button.java
@@ -133,7 +133,6 @@ static GtkBorder getBorder (byte[] border, long /*int*/ handle, int defaultBorde
@Override
GdkRGBA getContextBackgroundGdkRGBA () {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (background != null && (state & BACKGROUND) != 0) {
return background;
}
@@ -810,8 +809,6 @@ void _setAlignment (int alignment) {
@Override
void setBackgroundGdkRGBA (long /*int*/ context, long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
-
background = rgba;
//Pre GTK 3.10 doesn't handle CSS background color very well for GTK Check/Radio button.
// 3.10.3 as it was the latest to affect theming in button.
@@ -921,7 +918,6 @@ boolean setRadioSelection (boolean value) {
@Override
void setForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
super.setForegroundGdkRGBA(rgba);
setForegroundGdkRGBA (fixedHandle, rgba);
if (labelHandle != 0) setForegroundGdkRGBA (labelHandle, rgba);
@@ -941,7 +937,6 @@ void setForegroundGdkRGBA (GdkRGBA rgba) {
@Override
void setForegroundGdkRGBA (long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION < OS.VERSION(3, 14, 0)) {
super.setForegroundGdkRGBA(handle, rgba);
return;
@@ -963,7 +958,6 @@ void setForegroundGdkRGBA (long /*int*/ handle, GdkRGBA rgba) {
}
private void gtk_swt_set_border_color (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
String css_string = "* {\n";
if (rgba != null) {
String css_color = display.gtk_rgba_to_css_string (rgba);
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Combo.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Combo.java
index 80d28d2ebb..b05412b379 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Combo.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Combo.java
@@ -973,7 +973,6 @@ public int getCaretPosition () {
@Override
GdkRGBA getContextBackgroundGdkRGBA () {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (background != null && (state & BACKGROUND) != 0) {
return background;
}
@@ -2019,7 +2018,6 @@ void setButtonBackgroundGdkRGBA (GdkRGBA rgba) {
}
void setButtonForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
GdkRGBA toSet;
if (rgba != null) {
toSet = rgba;
@@ -2041,7 +2039,6 @@ void setButtonForegroundGdkRGBA (GdkRGBA rgba) {
@Override
void setBackgroundGdkRGBA (long /*int*/ context, long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (rgba == null) {
background = defaultBackground();
} else {
@@ -2093,7 +2090,6 @@ void setBackgroundGdkRGBA (long /*int*/ context, long /*int*/ handle, GdkRGBA rg
@Override
void setBackgroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
super.setBackgroundGdkRGBA(rgba);
if (entryHandle != 0) setBackgroundGdkRGBA (entryHandle, rgba);
setBackgroundGdkRGBA (fixedHandle, rgba);
@@ -2155,7 +2151,6 @@ void setFontDescription (long /*int*/ font) {
@Override
void setForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (entryHandle != 0) {
setForegroundGdkRGBA (entryHandle, rgba);
}
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Composite.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Composite.java
index e87f2b0afd..38560abd55 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Composite.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Composite.java
@@ -569,7 +569,6 @@ void fixChildren (Shell newShell, Shell oldShell, Decorations newDecorations, De
@Override
void fixParentGdkWindow() {
- assert GTK.GTK3;
// Changes to this method should be verified via
// org.eclipse.swt.tests.gtk/*/Bug510803_TabFolder_TreeEditor_Regression.java (part two)
for (Control child : _getChildren()) {
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java
index 7334383b7e..b7d9a81cad 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java
@@ -3077,7 +3077,6 @@ GdkRGBA toGdkRGBA (GdkRGBA rgba, double brightness) {
}
GdkRGBA getBackgroundColor (long /*int*/ context, int state) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
/*
* Draw the context background to an offset screen surface and get the color
* in the middle of the surface.
@@ -3345,7 +3344,6 @@ void initializeSystemColors () {
}
GdkRGBA styleContextGetColor(long /*int*/ context, int flag) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
/*
* Feature in GTK: we need to handle calls to gtk_style_context_get_color()
* differently due to changes in GTK3.18+. This solves failing test cases
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java
index c825a2f674..05342414a4 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Group.java
@@ -152,7 +152,6 @@ Rectangle getClientAreaInPixels () {
@Override
GdkRGBA getContextColorGdkRGBA () {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION (3, 14, 0)) {
if (foreground != null) {
return foreground;
@@ -166,7 +165,6 @@ GdkRGBA getContextColorGdkRGBA () {
@Override
GdkRGBA getContextBackgroundGdkRGBA () {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION(3, 14, 0)) {
return super.getContextBackgroundGdkRGBA();
} else {
@@ -328,7 +326,6 @@ void releaseWidget () {
@Override
void setBackgroundGdkRGBA(long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION(3, 18, 0)) {
super.setBackgroundGdkRGBA(handle, rgba);
} else {
@@ -344,7 +341,6 @@ void setFontDescription (long /*int*/ font) {
@Override
void setForegroundGdkRGBA (long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION < OS.VERSION(3, 14, 0)) {
super.setForegroundGdkRGBA(handle, rgba);
return;
@@ -363,7 +359,6 @@ void setForegroundGdkRGBA (long /*int*/ handle, GdkRGBA rgba) {
@Override
void setForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
super.setForegroundGdkRGBA(rgba);
setForegroundGdkRGBA (labelHandle, rgba);
}
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Label.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Label.java
index 17df2d36bc..75bb8bfb19 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Label.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Label.java
@@ -590,7 +590,6 @@ void setFontDescription (long /*int*/ font) {
@Override
void setForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
super.setForegroundGdkRGBA (rgba);
setForegroundGdkRGBA (fixedHandle, rgba);
if (labelHandle != 0) setForegroundGdkRGBA (labelHandle, rgba);
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java
index cadd60f141..a4d03abaa4 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java
@@ -1503,7 +1503,6 @@ public void setItems (String... items) {
@Override
void setForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION (3, 14, 0)) {
GdkRGBA toSet = rgba == null ? display.COLOR_LIST_FOREGROUND_RGBA : rgba;
setForegroundGdkRGBA (handle, toSet);
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Spinner.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Spinner.java
index cd7583ffcf..0ed0eaecca 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Spinner.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Spinner.java
@@ -910,7 +910,6 @@ void removeVerifyListener (VerifyListener listener) {
@Override
GdkRGBA getContextBackgroundGdkRGBA () {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (background != null && (state & BACKGROUND) != 0) {
return background;
}
@@ -919,7 +918,6 @@ GdkRGBA getContextBackgroundGdkRGBA () {
@Override
void setBackgroundGdkRGBA (long /*int*/ context, long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
background = rgba;
setBackgroundGradientGdkRGBA (context, handle, rgba);
}
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java
index 13e389936a..d590729d48 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabFolder.java
@@ -747,7 +747,6 @@ void reskinChildren (int flags) {
@Override
void setBackgroundGdkRGBA (long /*int*/ context, long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION(3, 14, 0)) {
// Form background string
String name = GTK.GTK_VERSION >= OS.VERSION(3, 20, 0) ? "notebook header" : "GtkNotebook.header";
@@ -793,7 +792,6 @@ void setFontDescription (long /*int*/ font) {
@Override
void setForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
super.setForegroundGdkRGBA(rgba);
TabItem [] items = getItems ();
for (int i = 0; i < items.length; i++) {
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabItem.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabItem.java
index ff45232aaf..cf8ad95a33 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabItem.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabItem.java
@@ -328,13 +328,11 @@ void setFontDescription (long /*int*/ font) {
}
void setForegroundRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
setForegroundGdkRGBA (labelHandle, rgba);
setForegroundGdkRGBA (imageHandle, rgba);
}
void setForegroundGdkRGBA (long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
GdkRGBA toSet = new GdkRGBA();
if (rgba != null) {
toSet = rgba;
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Text.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Text.java
index b074bfd97e..63f9627b84 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Text.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Text.java
@@ -2199,7 +2199,6 @@ public void selectAll () {
@Override
GdkRGBA getContextBackgroundGdkRGBA () {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (background != null && (state & BACKGROUND) != 0) {
return background;
}
@@ -2208,7 +2207,6 @@ GdkRGBA getContextBackgroundGdkRGBA () {
@Override
void setBackgroundGdkRGBA (long /*int*/ context, long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
/* Setting the background color overrides the selected background color.
* To prevent this, we need to re-set the default. This can be done with CSS
* on GTK3.16+, or by using GtkStateFlags as an argument to
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolBar.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolBar.java
index f663b0bd7b..47c241079a 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolBar.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolBar.java
@@ -597,7 +597,6 @@ int setBounds (int x, int y, int width, int height, boolean move, boolean resize
@Override
void setBackgroundGdkRGBA (long /*int*/ context, long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION(3, 14, 0)) {
// Form background string
String name = GTK.GTK_VERSION >= OS.VERSION(3, 20, 0) ? "toolbar" : "GtkToolbar";
@@ -624,7 +623,6 @@ void setParentBackground () {
@Override
void setForegroundGdkRGBA (long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION(3, 14, 0)) {
GdkRGBA toSet = new GdkRGBA();
if (rgba != null) {
@@ -676,7 +674,6 @@ void restoreBackground () {
@Override
void setForegroundGdkRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
super.setForegroundGdkRGBA (rgba);
ToolItem [] items = getItems ();
for (int i = 0; i < items.length; i++) {
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolItem.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolItem.java
index 78a48f6b00..838162d6ae 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolItem.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolItem.java
@@ -1005,17 +1005,14 @@ void setFontDescription (long /*int*/ font) {
}
void setForegroundRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (labelHandle != 0) setForegroundRGBA (labelHandle, rgba);
}
void setBackgroundRGBA (GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (handle != 0) setBackgroundRGBA (handle, rgba);
}
void setBackgroundRGBA (long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION >= OS.VERSION(3, 14, 0)) {
// Form background string
long /*int*/ context = GTK.gtk_widget_get_style_context(handle);
@@ -1030,7 +1027,6 @@ void setBackgroundRGBA (long /*int*/ handle, GdkRGBA rgba) {
}
void setForegroundRGBA (long /*int*/ handle, GdkRGBA rgba) {
- assert GTK.GTK3 : "GTK3 code was run by GTK2";
if (GTK.GTK_VERSION < OS.VERSION(3, 14, 0)) {
GdkRGBA selectedForeground = display.COLOR_LIST_SELECTION_TEXT_RGBA;
GTK.gtk_widget_override_color (handle, GTK.GTK_STATE_FLAG_NORMAL, rgba);

Back to the top