diff options
| author | Eric Williams | 2019-09-30 18:21:25 +0000 |
|---|---|---|
| committer | Eric Williams | 2019-10-02 15:36:24 +0000 |
| commit | e15a71f2395f1d2a6a155ec16ed66226e79a1657 (patch) | |
| tree | 219f45f4f906672117978e0b40b6f716f116add5 /bundles/org.eclipse.swt | |
| parent | bb4fbd51a4a0cd92d004003a8522f41f23d088e8 (diff) | |
| download | eclipse.platform.swt-e15a71f2395f1d2a6a155ec16ed66226e79a1657.tar.gz eclipse.platform.swt-e15a71f2395f1d2a6a155ec16ed66226e79a1657.tar.xz eclipse.platform.swt-e15a71f2395f1d2a6a155ec16ed66226e79a1657.zip | |
Bug 551624 - [GTK3] Recursive loop of SWT.Show events
Revert commit 83a43f4d1fc67b864696f081d908956580c27303 as it
causes a StackOverflow, as well as SWT.Show event loop.
AFAICT the original bug being fixed by the commit in question
is no longer reproducible on modern desktop environments.
Tested on Fedora 30, GTK3.24, GNOME3 and X11. No AllNonBrowser
JUnit tests fail.
Change-Id: I283e087e1872220ee348e5b1aa9288f7bec98f45
Signed-off-by: Eric Williams <ericwill@redhat.com>
Diffstat (limited to 'bundles/org.eclipse.swt')
| -rw-r--r-- | bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Shell.java | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Shell.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Shell.java index 99f514f3f6..f048086143 100644 --- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Shell.java +++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Shell.java @@ -1938,9 +1938,6 @@ long notifyStateProc (long gdk_handle, long handle) { public void open () { checkWidget (); bringToTop (false); - if (Shell.class.isInstance(getParent()) && !getParent().isVisible()) { - Shell.class.cast(getParent()).open(); - } setVisible (true); if (isDisposed ()) return; /* |