Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Keller2016-09-06 17:19:09 +0000
committerMarkus Keller2016-09-06 17:19:09 +0000
commita707757677b3f2f85d89c66edbc9334ea4a15f7e (patch)
tree0f73091f21e476c1898f7692fe293e207c1bf721
parente6349257e05a89e01f81a9400e925d17523a77fc (diff)
downloadeclipse.platform.swt-a707757677b3f2f85d89c66edbc9334ea4a15f7e.tar.gz
eclipse.platform.swt-a707757677b3f2f85d89c66edbc9334ea4a15f7e.tar.xz
eclipse.platform.swt-a707757677b3f2f85d89c66edbc9334ea4a15f7e.zip
Revert "Bug 312451: Accessible.addRelations should check if target == null"
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT Accessibility/cocoa/org/eclipse/swt/accessibility/Accessible.java6
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT Accessibility/gtk/org/eclipse/swt/accessibility/Accessible.java5
-rw-r--r--bundles/org.eclipse.swt/Eclipse SWT Accessibility/win32/org/eclipse/swt/accessibility/Accessible.java6
3 files changed, 4 insertions, 13 deletions
diff --git a/bundles/org.eclipse.swt/Eclipse SWT Accessibility/cocoa/org/eclipse/swt/accessibility/Accessible.java b/bundles/org.eclipse.swt/Eclipse SWT Accessibility/cocoa/org/eclipse/swt/accessibility/Accessible.java
index 3327c593be..1e064353d0 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT Accessibility/cocoa/org/eclipse/swt/accessibility/Accessible.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT Accessibility/cocoa/org/eclipse/swt/accessibility/Accessible.java
@@ -455,13 +455,11 @@ public class Accessible {
*
* @param type an <code>ACC</code> constant beginning with RELATION_* indicating the type of relation
* @param target the accessible that is the target for this relation
- * @exception IllegalArgumentException ERROR_NULL_ARGUMENT - if the Accessible target is null
*
* @since 3.6
*/
public void addRelation(int type, Accessible target) {
checkWidget();
- if (target == null) SWT.error (SWT.ERROR_NULL_ARGUMENT);
if (relations[type] == null) {
relations[type] = new Relation(this, type);
}
@@ -3082,13 +3080,11 @@ public class Accessible {
*
* @param type an <code>ACC</code> constant beginning with RELATION_* indicating the type of relation
* @param target the accessible that is the target for this relation
- * @exception IllegalArgumentException ERROR_NULL_ARGUMENT - if the Accessible target is null
- *
+ *
* @since 3.6
*/
public void removeRelation(int type, Accessible target) {
checkWidget();
- if (target == null) SWT.error (SWT.ERROR_NULL_ARGUMENT);
if (relations[type] != null) {
relations[type].removeTarget(target);
}
diff --git a/bundles/org.eclipse.swt/Eclipse SWT Accessibility/gtk/org/eclipse/swt/accessibility/Accessible.java b/bundles/org.eclipse.swt/Eclipse SWT Accessibility/gtk/org/eclipse/swt/accessibility/Accessible.java
index af6b3c5511..018fd36a5d 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT Accessibility/gtk/org/eclipse/swt/accessibility/Accessible.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT Accessibility/gtk/org/eclipse/swt/accessibility/Accessible.java
@@ -412,12 +412,10 @@ public class Accessible {
* @param type an <code>ACC</code> constant beginning with RELATION_* indicating the type of relation
* @param target the accessible that is the target for this relation
*
- * @exception IllegalArgumentException ERROR_NULL_ARGUMENT - if the Accessible target is null
* @since 3.6
*/
public void addRelation(int type, Accessible target) {
checkWidget();
- if (target == null) SWT.error (SWT.ERROR_NULL_ARGUMENT);
if (relations == null) relations = new ArrayList<>();
Relation relation = new Relation(type, target);
if (relations.indexOf(relation) != -1) return;
@@ -869,13 +867,12 @@ public class Accessible {
*
* @param type an <code>ACC</code> constant beginning with RELATION_* indicating the type of relation
* @param target the accessible that is the target for this relation
- * @exception IllegalArgumentException ERROR_NULL_ARGUMENT - if the Accessible target is null
+ *
* @since 3.6
*/
public void removeRelation(int type, Accessible target) {
checkWidget();
if (relations == null) return;
- if (target == null) SWT.error (SWT.ERROR_NULL_ARGUMENT);
Relation relation = new Relation(type, target);
int index = relations.indexOf(relation);
if (index == -1) return;
diff --git a/bundles/org.eclipse.swt/Eclipse SWT Accessibility/win32/org/eclipse/swt/accessibility/Accessible.java b/bundles/org.eclipse.swt/Eclipse SWT Accessibility/win32/org/eclipse/swt/accessibility/Accessible.java
index 37147be43c..5ec04e2a9e 100644
--- a/bundles/org.eclipse.swt/Eclipse SWT Accessibility/win32/org/eclipse/swt/accessibility/Accessible.java
+++ b/bundles/org.eclipse.swt/Eclipse SWT Accessibility/win32/org/eclipse/swt/accessibility/Accessible.java
@@ -1039,12 +1039,11 @@ public class Accessible {
*
* @param type an <code>ACC</code> constant beginning with RELATION_* indicating the type of relation
* @param target the accessible that is the target for this relation
- * @exception IllegalArgumentException ERROR_NULL_ARGUMENT - if the Accessible target is null
+ *
* @since 3.6
*/
public void addRelation(int type, Accessible target) {
checkWidget();
- if (target == null) SWT.error (SWT.ERROR_NULL_ARGUMENT);
if (relations[type] == null) {
relations[type] = new Relation(this, type);
}
@@ -1448,12 +1447,11 @@ public class Accessible {
*
* @param type an <code>ACC</code> constant beginning with RELATION_* indicating the type of relation
* @param target the accessible that is the target for this relation
- * @exception IllegalArgumentException ERROR_NULL_ARGUMENT - if the Accessible target is null
+ *
* @since 3.6
*/
public void removeRelation(int type, Accessible target) {
checkWidget();
- if (target == null) SWT.error (SWT.ERROR_NULL_ARGUMENT);
Relation relation = relations[type];
if (relation != null) {
relation.removeTarget(target);

Back to the top