From ec774ae5b0e9989299dc7daad7b657949cd66f28 Mon Sep 17 00:00:00 2001 From: Carsten Hammer Date: Fri, 24 May 2019 17:03:16 +0200 Subject: Use StringBuilder instead of StringBuffer where possible. Change-Id: I990721405fb7e486fc93ef2b22e56e81ed4a78c8 Signed-off-by: Carsten Hammer --- .../debug/tests/launching/ArgumentParsingTests.java | 2 +- .../eclipse/debug/tests/viewer/model/TestModel.java | 2 +- .../tests/viewer/model/TestModelUpdatesListener.java | 8 ++++---- .../debug/tests/viewer/model/TreePathWrapper.java | 2 +- .../org/eclipse/debug/internal/ui/DebugUIPlugin.java | 2 +- .../debug/internal/ui/DefaultLabelProvider.java | 20 ++++++++++---------- .../debug/internal/ui/LazyModelPresentation.java | 2 +- .../internal/ui/VariablesViewModelPresentation.java | 2 +- .../ui/actions/ToggleBreakpointsTargetManager.java | 2 +- .../breakpointGroups/GroupBreakpointsByAction.java | 2 +- .../elements/adapters/MemorySegmentLabelAdapter.java | 2 +- .../debug/internal/ui/hover/DebugTextHover.java | 2 +- .../CompileErrorProjectPromptStatusHandler.java | 2 +- .../LaunchConfigurationManager.java | 2 +- .../LaunchConfigurationTabGroupViewer.java | 2 +- .../LaunchConfigurationsDialog.java | 2 +- .../provisional/AbstractAsyncTableRendering.java | 6 +++--- .../provisional/AbstractAsyncTextRendering.java | 2 +- .../ui/model/elements/ExpressionLabelProvider.java | 6 +++--- .../ui/preferences/StringVariablePreferencePage.java | 7 ++++--- .../ui/preferences/ViewManagementPreferencePage.java | 2 +- .../sourcelookup/SourceElementWorkbenchAdapter.java | 4 ++-- .../debug/internal/ui/viewers/AsynchronousModel.java | 4 ++-- .../eclipse/debug/internal/ui/viewers/ModelNode.java | 2 +- .../ui/viewers/model/ChildrenCountUpdate.java | 2 +- .../internal/ui/viewers/model/ChildrenUpdate.java | 2 +- .../ui/viewers/model/ElementCompareRequest.java | 2 +- .../ui/viewers/model/ElementMementoRequest.java | 2 +- .../internal/ui/viewers/model/HasChildrenUpdate.java | 2 +- .../debug/internal/ui/viewers/model/LabelUpdate.java | 2 +- .../ui/views/breakpoints/BreakpointsView.java | 2 +- .../ui/views/breakpoints/WorkingSetCategory.java | 2 +- .../internal/ui/views/console/ProcessConsole.java | 4 ++-- .../debug/internal/ui/views/launch/LaunchView.java | 2 +- .../debug/internal/ui/views/memory/MemoryView.java | 2 +- .../ui/views/memory/SwitchMemoryBlockAction.java | 2 +- .../ui/views/memory/ViewPaneRenderingMgr.java | 2 +- .../CopyTableRenderingToClipboardAction.java | 2 +- .../renderings/FormatTableRenderingDialog.java | 4 ++-- .../views/memory/renderings/HexIntegerRendering.java | 2 +- .../ui/views/memory/renderings/HexRendering.java | 2 +- .../memory/renderings/PrintTableRenderingAction.java | 4 ++-- .../ui/views/memory/renderings/RenderingsUtil.java | 4 ++-- .../memory/renderings/SignedIntegerRendering.java | 4 ++-- .../renderings/TableRenderingCellModifier.java | 2 +- .../views/memory/renderings/TableRenderingLine.java | 2 +- .../renderings/TableRenderingPropertiesPage.java | 2 +- .../memory/renderings/UnsignedIntegerRendering.java | 4 ++-- .../variables/AvailableLogicalStructuresAction.java | 2 +- .../ui/views/variables/IndexedVariablePartition.java | 2 +- .../details/AvailableDetailPanesAction.java | 2 +- .../views/variables/details/DetailPaneManager.java | 2 +- .../debug/ui/StringVariableSelectionDialog.java | 2 +- .../ui/actions/AbstractLaunchHistoryAction.java | 2 +- .../debug/ui/actions/ContextualLaunchAction.java | 2 +- .../debug/ui/actions/ExportBreakpointsOperation.java | 2 +- .../org/eclipse/debug/ui/actions/LaunchAsAction.java | 2 +- .../debug/ui/actions/LaunchShortcutsAction.java | 2 +- .../debug/ui/memory/AbstractMemoryRendering.java | 2 +- .../debug/ui/memory/AbstractTableRendering.java | 4 ++-- .../debug/ui/memory/AbstractTextRendering.java | 2 +- .../ui/internal/console/ConsoleDropDownAction.java | 2 +- .../ui/internal/console/IOConsolePartitioner.java | 2 +- .../ui/internal/console/OpenConsoleAction.java | 2 +- .../launchConfigurations/ExternalToolsBuildTab.java | 2 +- .../ExternalToolsBuilderTab.java | 4 ++-- .../launchConfigurations/ExternalToolsMainTab.java | 2 +- .../internal/model/ExternalToolsImages.java | 2 +- .../internal/ui/BuilderPropertyPage.java | 2 +- .../internal/variables/BuildProjectResolver.java | 2 +- .../program/launchConfigurations/ProgramMainTab.java | 2 +- 71 files changed, 100 insertions(+), 99 deletions(-) diff --git a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/ArgumentParsingTests.java b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/ArgumentParsingTests.java index db2718306..e9cbbeccb 100644 --- a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/ArgumentParsingTests.java +++ b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/launching/ArgumentParsingTests.java @@ -178,7 +178,7 @@ public class ArgumentParsingTests extends AbstractDebugTest { } public void test100arg() throws Exception { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); for (int i = 0; i < 100; i++) { buf.append("a "); //$NON-NLS-1$ } diff --git a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModel.java b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModel.java index a6a7f5fcc..572a92ea2 100644 --- a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModel.java +++ b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModel.java @@ -680,7 +680,7 @@ public class TestModel implements IElementContentProvider, IElementLabelProvider } public String getElementString(TestElement element, String indent) { - StringBuffer builder = new StringBuffer(); + StringBuilder builder = new StringBuilder(); builder.append(indent); builder.append(element.toString()); builder.append('\n'); diff --git a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModelUpdatesListener.java b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModelUpdatesListener.java index 3a4a60d8a..8945010b7 100644 --- a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModelUpdatesListener.java +++ b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TestModelUpdatesListener.java @@ -772,7 +772,7 @@ public class TestModelUpdatesListener implements IViewerUpdateListener, ILabelUp } private String toString(int flags) { - StringBuffer buf = new StringBuffer("Viewer Update Listener"); //$NON-NLS-1$ + StringBuilder buf = new StringBuilder("Viewer Update Listener"); //$NON-NLS-1$ if (fJobError != null) { buf.append("\n\t"); //$NON-NLS-1$ @@ -901,7 +901,7 @@ public class TestModelUpdatesListener implements IViewerUpdateListener, ILabelUp if (set.isEmpty()) { return "(EMPTY)"; //$NON-NLS-1$ } - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); for (Iterator itr = set.iterator(); itr.hasNext();) { buf.append("\n\t\t"); //$NON-NLS-1$ buf.append(toString(itr.next())); @@ -913,7 +913,7 @@ public class TestModelUpdatesListener implements IViewerUpdateListener, ILabelUp if (map.isEmpty()) { return "(EMPTY)"; //$NON-NLS-1$ } - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); for (Iterator itr = map.keySet().iterator(); itr.hasNext();) { buf.append("\n\t\t"); //$NON-NLS-1$ TreePath path = itr.next(); @@ -929,7 +929,7 @@ public class TestModelUpdatesListener implements IViewerUpdateListener, ILabelUp if (path.getSegmentCount() == 0) { return "/"; //$NON-NLS-1$ } - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); for (int i = 0; i < path.getSegmentCount(); i++) { buf.append("/"); //$NON-NLS-1$ buf.append(path.getSegment(i)); diff --git a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TreePathWrapper.java b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TreePathWrapper.java index e428b9652..b68c73280 100644 --- a/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TreePathWrapper.java +++ b/org.eclipse.debug.tests/src/org/eclipse/debug/tests/viewer/model/TreePathWrapper.java @@ -47,7 +47,7 @@ public class TreePathWrapper { return "TreePath:EMPTY"; //$NON-NLS-1$ } - StringBuffer buf = new StringBuffer("TreePath:["); //$NON-NLS-1$ + StringBuilder buf = new StringBuilder("TreePath:["); //$NON-NLS-1$ for (int i = 0; i < fPath.getSegmentCount(); i++) { if (i != 0) { diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java index 175436224..6049c5fa0 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java @@ -1193,7 +1193,7 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener, monitor.beginTask(DebugUIMessages.DebugUITools_3, 100); try { if(waitInJob) { - StringBuffer buffer = new StringBuffer(configuration.getName()); + StringBuilder buffer = new StringBuilder(configuration.getName()); buffer.append(DebugUIMessages.DebugUIPlugin_0); ILaunchConfigurationWorkingCopy workingCopy = configuration.copy(buffer.toString()); workingCopy.setAttribute(ATTR_LAUNCHING_CONFIG_HANDLE, configuration.getMemento()); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DefaultLabelProvider.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DefaultLabelProvider.java index f630871e9..8c5021e06 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DefaultLabelProvider.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DefaultLabelProvider.java @@ -203,7 +203,7 @@ public class DefaultLabelProvider implements ILabelProvider { */ @Override public String getText(Object element) { - StringBuffer label= new StringBuffer(); + StringBuilder label= new StringBuilder(); try { // Group elements into debug elements and non-debug elements // to reduce the number of instanceof checks performed @@ -285,7 +285,7 @@ public class DefaultLabelProvider implements ILabelProvider { */ private String getBreakpointText(IBreakpoint breakpoint) { IResource resource = breakpoint.getMarker().getResource(); - StringBuffer label = new StringBuffer(); + StringBuilder label = new StringBuilder(); if (resource != null) { label.append(resource.getName()); } @@ -318,7 +318,7 @@ public class DefaultLabelProvider implements ILabelProvider { } // new launch configuration ILaunchConfiguration config = launch.getLaunchConfiguration(); - StringBuffer buff= new StringBuffer(config.getName()); + StringBuilder buff= new StringBuilder(config.getName()); buff.append(" ["); //$NON-NLS-1$ try { buff.append(config.getType().getName()); @@ -333,7 +333,7 @@ public class DefaultLabelProvider implements ILabelProvider { if (expression instanceof IWatchExpression) { return getWatchExpressionText((IWatchExpression) expression); } - StringBuffer buffer= new StringBuffer(expression.getExpressionText()); + StringBuilder buffer= new StringBuilder(expression.getExpressionText()); String valueString= null; IValue value= expression.getValue(); if (value != null) { @@ -355,10 +355,10 @@ public class DefaultLabelProvider implements ILabelProvider { * @return */ protected String getWatchExpressionText(IWatchExpression expression) { - StringBuffer result= new StringBuffer(); + StringBuilder result= new StringBuilder(); String snippet = expression.getExpressionText().trim(); - StringBuffer snippetBuffer = new StringBuffer(); + StringBuilder snippetBuffer = new StringBuilder(); if (snippet.length() > 30){ snippetBuffer.append(snippet.substring(0, 15)); snippetBuffer.append(DebugUIMessages.DefaultLabelProvider_0); @@ -392,7 +392,7 @@ public class DefaultLabelProvider implements ILabelProvider { } protected String getVariableText(IVariable variable) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); try { IValue value = variable.getValue(); buffer.append(variable.getName()); @@ -405,7 +405,7 @@ public class DefaultLabelProvider implements ILabelProvider { } protected String getRegisterGroupText(IRegisterGroup registerGroup) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); try { buffer.append(registerGroup.getName()); } catch (DebugException de) { @@ -521,7 +521,7 @@ public class DefaultLabelProvider implements ILabelProvider { if (string == null) { return null; } - StringBuffer escaped = new StringBuffer(); + StringBuilder escaped = new StringBuilder(); for (int i = 0; i < string.length(); i++) { char c = string.charAt(i); switch (c) { @@ -562,7 +562,7 @@ public class DefaultLabelProvider implements ILabelProvider { if (string == null) { return null; } - StringBuffer encoded = new StringBuffer(); + StringBuilder encoded = new StringBuilder(); if (string.length() == 1) { return string; } diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/LazyModelPresentation.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/LazyModelPresentation.java index e32129daf..8bf88af20 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/LazyModelPresentation.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/LazyModelPresentation.java @@ -194,7 +194,7 @@ public class LazyModelPresentation implements IDebugModelPresentation, IDebugEdi if (showVariableTypeNames()) { try { if (element instanceof IExpression) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); IValue value = ((IExpression)element).getValue(); if (value != null) { String type = value.getReferenceTypeName(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/VariablesViewModelPresentation.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/VariablesViewModelPresentation.java index 0f02465b6..1d39f0a02 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/VariablesViewModelPresentation.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/VariablesViewModelPresentation.java @@ -25,7 +25,7 @@ public class VariablesViewModelPresentation extends DelegatingModelPresentation */ @Override public String getText(Object element) { - StringBuffer string= new StringBuffer(); + StringBuilder string= new StringBuilder(); StringTokenizer tokenizer= new StringTokenizer(super.getText(element), "\b\f\n\r\t\\", true); //$NON-NLS-1$ String token; while (tokenizer.hasMoreTokens()) { diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/ToggleBreakpointsTargetManager.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/ToggleBreakpointsTargetManager.java index 341152025..eba6a00e3 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/ToggleBreakpointsTargetManager.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/ToggleBreakpointsTargetManager.java @@ -592,7 +592,7 @@ public class ToggleBreakpointsTargetManager implements IToggleBreakpointsTargetM * key in the mapping and the values are the associated String value in the mapping. */ private void storePreferredTargets() { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); for (Entry, String> entry : fPreferredTargets.entrySet()) { for (String currentID : entry.getKey()) { buffer.append(currentID); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpointGroups/GroupBreakpointsByAction.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpointGroups/GroupBreakpointsByAction.java index 887fad1c5..524eb1591 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpointGroups/GroupBreakpointsByAction.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpointGroups/GroupBreakpointsByAction.java @@ -134,7 +134,7 @@ public class GroupBreakpointsByAction extends AbstractBreakpointsViewAction impl } private void addAccel(int accel, IAction action, String label) { - StringBuffer actionLabel= new StringBuffer(); + StringBuilder actionLabel= new StringBuilder(); if (accel != 10) { if (accel < 10) { // add the numerical accelerators 1 through 9 diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/elements/adapters/MemorySegmentLabelAdapter.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/elements/adapters/MemorySegmentLabelAdapter.java index bfc0616ac..3430b43ec 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/elements/adapters/MemorySegmentLabelAdapter.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/elements/adapters/MemorySegmentLabelAdapter.java @@ -94,7 +94,7 @@ public class MemorySegmentLabelAdapter extends AsynchronousLabelAdapter { int addressSize = descriptor.getAddressSize(); int prefillLength = addressSize * 2 - columnLabel.length(); - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (prefillLength > 0) { for (int i=0; i modeset) { - StringBuffer buff = new StringBuffer(); + StringBuilder buff = new StringBuilder(); for (Iterator iter = modeset.iterator(); iter.hasNext();) { buff.append(iter.next()); if (iter.hasNext()) { diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationTabGroupViewer.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationTabGroupViewer.java index bd9b0f7d9..f947492a9 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationTabGroupViewer.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationTabGroupViewer.java @@ -1313,7 +1313,7 @@ public class LaunchConfigurationTabGroupViewer { } message = tab.getErrorMessage(); if (message != null) { - StringBuffer temp= new StringBuffer(); + StringBuilder temp= new StringBuilder(); temp.append('['); temp.append(DebugUIPlugin.removeAccelerators(tab.getName())); temp.append("]: "); //$NON-NLS-1$ diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java index 8aed33b13..a4a49817d 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java @@ -1538,7 +1538,7 @@ public class LaunchConfigurationsDialog extends TitleAreaDialog implements ILaun * IDialogConstants. */ private int showDiscardChangesDialog() { - StringBuffer buffer = new StringBuffer(MessageFormat.format(LaunchConfigurationsMessages.LaunchConfigurationDialog_The_configuration___35, new Object[] { fTabViewer.getWorkingCopy().getName() })); + StringBuilder buffer = new StringBuilder(MessageFormat.format(LaunchConfigurationsMessages.LaunchConfigurationDialog_The_configuration___35, new Object[] { fTabViewer.getWorkingCopy().getName() })); buffer.append(fTabViewer.getErrorMesssage()); buffer.append(LaunchConfigurationsMessages.LaunchConfigurationDialog_Do_you_wish_to_discard_changes_37); MessageDialog dialog = new MessageDialog(getShell(), diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTableRendering.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTableRendering.java index 1e4d7090d..1fbcbb768 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTableRendering.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTableRendering.java @@ -568,7 +568,7 @@ public abstract class AbstractAsyncTableRendering extends AbstractBaseTableRende * @param parent the parent composite */ private void createTableViewer(final Composite parent) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); IMemoryRenderingType type = DebugUITools.getMemoryRenderingManager().getRenderingType(getRenderingId()); buffer.append(type.getLabel()); buffer.append(": "); //$NON-NLS-1$ @@ -887,7 +887,7 @@ public abstract class AbstractAsyncTableRendering extends AbstractBaseTableRende if (!validated) { // pop up dialog to ask user for default values - StringBuffer msgBuffer = new StringBuffer(DebugUIMessages.AbstractTableRendering_20); + StringBuilder msgBuffer = new StringBuilder(DebugUIMessages.AbstractTableRendering_20); msgBuffer.append(" "); //$NON-NLS-1$ msgBuffer.append(this.getLabel()); msgBuffer.append("\n\n"); //$NON-NLS-1$ @@ -2858,7 +2858,7 @@ public abstract class AbstractAsyncTableRendering extends AbstractBaseTableRende * @since 3.2 */ protected String getToolTipText(BigInteger address, MemoryByte[] bytes) { - StringBuffer buf = new StringBuffer("0x"); //$NON-NLS-1$ + StringBuilder buf = new StringBuilder("0x"); //$NON-NLS-1$ buf.append(address.toString(16).toUpperCase()); return buf.toString(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTextRendering.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTextRendering.java index 88f26e0d6..0e4a2d2ed 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTextRendering.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/memory/provisional/AbstractAsyncTextRendering.java @@ -99,7 +99,7 @@ abstract public class AbstractAsyncTextRendering extends AbstractAsyncTableRende } if (hasInvalid) { - StringBuffer strBuf = new StringBuffer(); + StringBuilder strBuf = new StringBuilder(); for (int i = 0; i < data.length; i++) { if (invalid[i]) { strBuf.append(paddedStr); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/model/elements/ExpressionLabelProvider.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/model/elements/ExpressionLabelProvider.java index b3f1d8eef..f0457c5db 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/model/elements/ExpressionLabelProvider.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/model/elements/ExpressionLabelProvider.java @@ -108,10 +108,10 @@ protected String getLabel(TreePath elementPath, IPresentationContext context, St * @since 3.6 */ private String getWatchExpressionName(IWatchExpression expression, IPresentationContext context) { - StringBuffer result= new StringBuffer(); + StringBuilder result= new StringBuilder(); String snippet = expression.getExpressionText().trim(); - StringBuffer snippetBuffer = new StringBuffer(); + StringBuilder snippetBuffer = new StringBuilder(); if (snippet.length() > 254) { snippetBuffer.append(snippet.substring(0, 127)); snippetBuffer.append(DebugUIMessages.DefaultLabelProvider_0); @@ -143,7 +143,7 @@ protected String getLabel(TreePath elementPath, IPresentationContext context, St protected String getExpressionValueText(IExpression expression, IValue value, IPresentationContext context) throws CoreException { if (expression instanceof IWatchExpression) { IWatchExpression watchExpression = (IWatchExpression)expression; - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); if (watchExpression.isPending() && value == null) { result.append(DebugUIMessages.DefaultLabelProvider_12); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/StringVariablePreferencePage.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/StringVariablePreferencePage.java index 9b136deaf..9814eea8d 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/StringVariablePreferencePage.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/StringVariablePreferencePage.java @@ -373,7 +373,7 @@ public class StringVariablePreferencePage extends PreferencePage implements IWor private void handleRemoveButtonPressed() { IStructuredSelection selection = variableTable.getStructuredSelection(); List variablesToRemove = selection.toList(); - StringBuffer contributedVariablesToRemove= new StringBuffer(); + StringBuilder contributedVariablesToRemove= new StringBuilder(); Iterator iter = variablesToRemove.iterator(); while (iter.hasNext()) { VariableWrapper variable = iter.next(); @@ -445,7 +445,7 @@ public class StringVariablePreferencePage extends PreferencePage implements IWor } public void saveColumnWidths() { - StringBuffer widthPreference = new StringBuffer(); + StringBuilder widthPreference = new StringBuilder(); for (int i = 0; i < variableTable.getTable().getColumnCount(); i++) { widthPreference.append(variableTable.getTable().getColumn(i).getWidth()); widthPreference.append(','); @@ -675,12 +675,13 @@ public class StringVariablePreferencePage extends PreferencePage implements IWor VariableWrapper variable= (VariableWrapper) element; switch (columnIndex) { case 0 : - StringBuffer name = new StringBuffer(); + StringBuilder name = new StringBuilder(); name.append(variable.getName()); if (variable.isReadOnly()){ name.append(DebugPreferencesMessages.StringVariablePreferencePage_26); } return name.toString(); + case 1: String value= variable.getValue(); if (value == null) { diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ViewManagementPreferencePage.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ViewManagementPreferencePage.java index 876a4d352..51d69d6d5 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ViewManagementPreferencePage.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ViewManagementPreferencePage.java @@ -193,7 +193,7 @@ public class ViewManagementPreferencePage extends PreferencePage implements IWor getPreferenceStore().setValue(IDebugUIConstants.PREF_MANAGE_VIEW_PERSPECTIVES, IDebugUIConstants.PREF_MANAGE_VIEW_PERSPECTIVES_DEFAULT); } else { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); for (Iterator itr = perspectives.iterator(); itr.hasNext();) { buffer.append(itr.next()).append(','); } diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/SourceElementWorkbenchAdapter.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/SourceElementWorkbenchAdapter.java index bc2364053..4c569cfcd 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/SourceElementWorkbenchAdapter.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/SourceElementWorkbenchAdapter.java @@ -50,7 +50,7 @@ public class SourceElementWorkbenchAdapter implements IWorkbenchAdapter { } if (o instanceof ZipEntryStorage) { ZipEntryStorage storage = (ZipEntryStorage)o; - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(storage.getZipEntry().getName()); buffer.append(" - "); //$NON-NLS-1$ buffer.append(storage.getArchive().getName()); @@ -64,7 +64,7 @@ public class SourceElementWorkbenchAdapter implements IWorkbenchAdapter { } public static String getQualifiedName(IPath path) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); String[] segments = path.segments(); if (segments.length > 0) { buffer.append(path.lastSegment()); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/AsynchronousModel.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/AsynchronousModel.java index f3eabc5e2..49978b4f5 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/AsynchronousModel.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/AsynchronousModel.java @@ -104,7 +104,7 @@ public abstract class AsynchronousModel { public AsynchronousModel(AsynchronousViewer viewer) { fViewer = viewer; if (DebugUIPlugin.DEBUG_MODEL) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("MODEL CREATED for: "); //$NON-NLS-1$ buffer.append(fViewer); buffer.append(" ("); //$NON-NLS-1$ @@ -135,7 +135,7 @@ public abstract class AsynchronousModel { */ public synchronized void dispose() { if (DebugUIPlugin.DEBUG_MODEL) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("MODEL DISPOSED for: "); //$NON-NLS-1$ buffer.append(fViewer); buffer.append(" ("); //$NON-NLS-1$ diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/ModelNode.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/ModelNode.java index ccd12e8fe..4bca52a57 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/ModelNode.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/ModelNode.java @@ -199,7 +199,7 @@ public class ModelNode { @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (isDisposed()) { buf.append("[DISPOSED] "); //$NON-NLS-1$ } diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenCountUpdate.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenCountUpdate.java index 31f307838..940d18bf2 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenCountUpdate.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenCountUpdate.java @@ -150,7 +150,7 @@ class ChildrenCountUpdate extends ViewerUpdateMonitor implements IChildrenCountU @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("IChildrenCountUpdate: "); //$NON-NLS-1$ buf.append(getElement()); return buf.toString(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenUpdate.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenUpdate.java index 6429a69e9..8819290ea 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenUpdate.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ChildrenUpdate.java @@ -169,7 +169,7 @@ public class ChildrenUpdate extends ViewerUpdateMonitor implements IChildrenUpda @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("IChildrenUpdate: "); //$NON-NLS-1$ buf.append(getElement()); buf.append(" {"); //$NON-NLS-1$ diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementCompareRequest.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementCompareRequest.java index 728a4df2e..25d737dad 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementCompareRequest.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementCompareRequest.java @@ -123,7 +123,7 @@ public class ElementCompareRequest extends MementoUpdate implements IElementComp @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("IElementCompareRequest: "); //$NON-NLS-1$ buf.append(getElement()); return buf.toString(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementMementoRequest.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementMementoRequest.java index 6bbcfb24f..7b3c8e73b 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementMementoRequest.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/ElementMementoRequest.java @@ -76,7 +76,7 @@ class ElementMementoRequest extends MementoUpdate implements IElementMementoRequ @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("IElementMementoRequest: "); //$NON-NLS-1$ buf.append(getElement()); return buf.toString(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/HasChildrenUpdate.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/HasChildrenUpdate.java index a7602b017..808f66e5a 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/HasChildrenUpdate.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/HasChildrenUpdate.java @@ -70,7 +70,7 @@ class HasChildrenUpdate extends ViewerUpdateMonitor implements IHasChildrenUpdat @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("IHasChildrenUpdate: "); //$NON-NLS-1$ buf.append(getElement()); return buf.toString(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/LabelUpdate.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/LabelUpdate.java index 176c1b988..4ece51019 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/LabelUpdate.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/LabelUpdate.java @@ -149,7 +149,7 @@ class LabelUpdate extends Request implements ILabelUpdate, ICheckUpdate { @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("ILabelUpdate: "); //$NON-NLS-1$ buf.append(getElement()); return buf.toString(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointsView.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointsView.java index faa5492f6..76a100ff5 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointsView.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointsView.java @@ -385,7 +385,7 @@ public class BreakpointsView extends VariablesView implements IBreakpointManager @Override public void saveViewerState(IMemento memento) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); if (fOrganizers != null) { for (int i = 0; i < fOrganizers.length; i++) { IBreakpointOrganizer organizer = fOrganizers[i]; diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/WorkingSetCategory.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/WorkingSetCategory.java index 0b1d871ce..6fe66273f 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/WorkingSetCategory.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/WorkingSetCategory.java @@ -52,7 +52,7 @@ public class WorkingSetCategory extends PlatformObject implements IWorkbenchAdap @Override public String getLabel(Object o) { - StringBuffer name = new StringBuffer(fWorkingSet.getName()); + StringBuilder name = new StringBuilder(fWorkingSet.getName()); if (isDefault()) { name.append(DebugUIViewsMessages.WorkingSetCategory_0); } diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/console/ProcessConsole.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/console/ProcessConsole.java index 04833103c..0514024ee 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/console/ProcessConsole.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/console/ProcessConsole.java @@ -278,7 +278,7 @@ public class ProcessConsole extends IOConsole implements IConsole, IDebugEventSe type = config.getType().getName(); } catch (CoreException e) { } - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(config.getName()); if (type != null) { buffer.append(" ["); //$NON-NLS-1$ @@ -793,7 +793,7 @@ public class ProcessConsole extends IOConsole implements IConsole, IDebugEventSe } private String escape(String path) { - StringBuffer buffer = new StringBuffer(path); + StringBuilder buffer = new StringBuilder(path); int index = buffer.indexOf("\\"); //$NON-NLS-1$ while (index >= 0) { buffer.insert(index, '\\'); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/launch/LaunchView.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/launch/LaunchView.java index 9ba292322..e287c7474 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/launch/LaunchView.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/launch/LaunchView.java @@ -957,7 +957,7 @@ public class LaunchView extends AbstractDebugView } } - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); for (Iterator itr = fDebugToolbarPerspectives.iterator(); itr.hasNext();) { buffer.append(itr.next()).append(','); } diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/MemoryView.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/MemoryView.java index 25c128610..71b707408 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/MemoryView.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/MemoryView.java @@ -638,7 +638,7 @@ public class MemoryView extends ViewPart implements IMemoryRenderingSite2 { private void storeViewPaneVisibility() { fVisibleViewPanes.clear(); - StringBuffer visibleViewPanes = new StringBuffer(); + StringBuilder visibleViewPanes = new StringBuilder(); Enumeration enumeration = fViewPaneControls.keys(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/SwitchMemoryBlockAction.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/SwitchMemoryBlockAction.java index a2604aef1..6292c9be2 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/SwitchMemoryBlockAction.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/SwitchMemoryBlockAction.java @@ -174,7 +174,7 @@ public class SwitchMemoryBlockAction extends Action implements IViewActionDelega } private void getLabels(final IMemoryBlock memBlk) { - StringBuffer text = new StringBuffer(IInternalDebugCoreConstants.EMPTY_STRING); + StringBuilder text = new StringBuilder(IInternalDebugCoreConstants.EMPTY_STRING); String label = new String(IInternalDebugCoreConstants.EMPTY_STRING); if (memBlk instanceof IMemoryBlockExtension) { String expression = ((IMemoryBlockExtension) memBlk).getExpression(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/ViewPaneRenderingMgr.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/ViewPaneRenderingMgr.java index f3ef6d02f..ff8ec2667 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/ViewPaneRenderingMgr.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/ViewPaneRenderingMgr.java @@ -267,7 +267,7 @@ public class ViewPaneRenderingMgr implements IDebugEventSetListener { // constructs id based on memory view's secondary id + the rendering // view pane id // format: secondaryId:viewPaneId - StringBuffer id = new StringBuffer(); + StringBuilder id = new StringBuilder(); IMemoryRenderingSite renderingSite = fViewPane.getMemoryRenderingSite(); IWorkbenchPartSite ps = renderingSite.getSite(); if (ps instanceof IViewSite) { diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/CopyTableRenderingToClipboardAction.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/CopyTableRenderingToClipboardAction.java index 5e04d5560..2a284980c 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/CopyTableRenderingToClipboardAction.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/CopyTableRenderingToClipboardAction.java @@ -65,7 +65,7 @@ public class CopyTableRenderingToClipboardAction extends Action return null; } - StringBuffer tableContents = new StringBuffer(); + StringBuilder tableContents = new StringBuilder(); Table table = (Table)fViewer.getControl(); int numColumns = table.getColumnCount(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/FormatTableRenderingDialog.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/FormatTableRenderingDialog.java index b4ccce0ff..7ddfd7f26 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/FormatTableRenderingDialog.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/FormatTableRenderingDialog.java @@ -304,7 +304,7 @@ public class FormatTableRenderingDialog extends TrayDialog if (!isValid(rowSize, colSize)) { Label label = new Label(parent, SWT.NONE); - StringBuffer errorMsg = new StringBuffer(); + StringBuilder errorMsg = new StringBuilder(); errorMsg.append(DebugUIMessages.FormatTableRenderingAction_9); errorMsg.append("\n"); //$NON-NLS-1$ errorMsg.append(DebugUIMessages.FormatTableRenderingAction_11); @@ -333,7 +333,7 @@ public class FormatTableRenderingDialog extends TrayDialog columns[i] = new TableColumn(table, SWT.NONE); } - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); for (int j=0; j, String> entry : fPreferredDetailPanes.entrySet()) { for (String currentID : entry.getKey()) { buffer.append(currentID); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/StringVariableSelectionDialog.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/StringVariableSelectionDialog.java index 2edbbcae3..b6c7ddb2d 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/StringVariableSelectionDialog.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/StringVariableSelectionDialog.java @@ -119,7 +119,7 @@ public class StringVariableSelectionDialog extends ElementListSelectionDialog { Object[] selected = getResult(); if (selected != null && selected.length == 1) { IStringVariable variable = (IStringVariable)selected[0]; - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("${"); //$NON-NLS-1$ buffer.append(variable.getName()); if (fArgumentValue != null && fArgumentValue.length() > 0) { diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/AbstractLaunchHistoryAction.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/AbstractLaunchHistoryAction.java index 060a5dd6a..d0fc7c389 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/AbstractLaunchHistoryAction.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/AbstractLaunchHistoryAction.java @@ -146,7 +146,7 @@ public abstract class AbstractLaunchHistoryAction implements IActionDelegate2, I * @param accelerator the number that should appear as an accelerator */ protected void addToMenu(Menu menu, IAction action, int accelerator) { - StringBuffer label= new StringBuffer(); + StringBuilder label= new StringBuilder(); if (accelerator >= 0 && accelerator < 10) { //add the numerical accelerator label.append('&'); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ContextualLaunchAction.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ContextualLaunchAction.java index 04eae0f16..e0c837f28 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ContextualLaunchAction.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ContextualLaunchAction.java @@ -298,7 +298,7 @@ public abstract class ContextualLaunchAction implements IObjectActionDelegate, I if (helpContextId != null) { PlatformUI.getWorkbench().getHelpSystem().setHelp(action, helpContextId); } - StringBuffer label= new StringBuffer(); + StringBuilder label= new StringBuilder(); if (accelerator >= 0 && accelerator < 10) { //add the numerical accelerator label.append('&'); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ExportBreakpointsOperation.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ExportBreakpointsOperation.java index 90b4c8973..b3b4b7b27 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ExportBreakpointsOperation.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/ExportBreakpointsOperation.java @@ -168,7 +168,7 @@ public class ExportBreakpointsOperation implements IRunnableWithProgress { */ private String getWorkingSetsAttribute(IBreakpoint breakpoint) { IWorkingSetManager mgr = PlatformUI.getWorkbench().getWorkingSetManager(); - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); IWorkingSet[] sets = mgr.getWorkingSets(); for (int i = 0; i < sets.length; i++) { if(IDebugUIConstants.BREAKPOINT_WORKINGSET_ID.equals(sets[i].getId()) && diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchAsAction.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchAsAction.java index c301cd6a1..b0d800b58 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchAsAction.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchAsAction.java @@ -102,7 +102,7 @@ public class LaunchAsAction extends Action implements IMenuCreator, IWorkbenchWi } private void createAction(Menu parent, IAction action, int count) { - StringBuffer label= new StringBuffer(); + StringBuilder label= new StringBuilder(); //add the numerical accelerator if (count < 10) { label.append('&'); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchShortcutsAction.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchShortcutsAction.java index 36be7fbc1..aa905eacb 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchShortcutsAction.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/actions/LaunchShortcutsAction.java @@ -235,7 +235,7 @@ public class LaunchShortcutsAction extends Action implements IMenuCreator, IWork if (helpContextId != null) { PlatformUI.getWorkbench().getHelpSystem().setHelp(action, helpContextId); } - StringBuffer label= new StringBuffer(); + StringBuilder label= new StringBuilder(); if (accelerator >= 0 && accelerator < 10) { //add the numerical accelerator label.append('&'); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractMemoryRendering.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractMemoryRendering.java index 959162a87..f4e5588c6 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractMemoryRendering.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractMemoryRendering.java @@ -224,7 +224,7 @@ public abstract class AbstractMemoryRendering extends PlatformObject implements return IInternalDebugCoreConstants.EMPTY_STRING; } - StringBuffer label = new StringBuffer(IInternalDebugCoreConstants.EMPTY_STRING); + StringBuilder label = new StringBuilder(IInternalDebugCoreConstants.EMPTY_STRING); if (fMemoryBlock instanceof IMemoryBlockExtension) { diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTableRendering.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTableRendering.java index 39d8053de..75928a8ba 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTableRendering.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTableRendering.java @@ -954,7 +954,7 @@ public abstract class AbstractTableRendering extends AbstractBaseTableRendering if (!validated) { // pop up dialog to ask user for default values - StringBuffer msgBuffer = new StringBuffer(DebugUIMessages.AbstractTableRendering_20); + StringBuilder msgBuffer = new StringBuilder(DebugUIMessages.AbstractTableRendering_20); msgBuffer.append(" "); //$NON-NLS-1$ msgBuffer.append(this.getLabel()); msgBuffer.append("\n\n"); //$NON-NLS-1$ @@ -3796,7 +3796,7 @@ public abstract class AbstractTableRendering extends AbstractBaseTableRendering */ protected String getToolTipText(BigInteger address, MemoryByte[] bytes) { - StringBuffer buf = new StringBuffer("0x"); //$NON-NLS-1$ + StringBuilder buf = new StringBuilder("0x"); //$NON-NLS-1$ buf.append(address.toString(16).toUpperCase()); return buf.toString(); diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTextRendering.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTextRendering.java index c068d6acc..f62d75687 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTextRendering.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/memory/AbstractTextRendering.java @@ -107,7 +107,7 @@ abstract public class AbstractTextRendering extends AbstractTableRendering { if (hasInvalid) { - StringBuffer strBuf = new StringBuffer(); + StringBuilder strBuf = new StringBuilder(); for (int i=0; i it = inputPartitions.iterator(); while (it.hasNext()) { IOConsolePartition partition = it.next(); diff --git a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java index 35b1375ba..6559f6601 100644 --- a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java +++ b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java @@ -118,7 +118,7 @@ public class OpenConsoleAction extends Action implements IMenuCreator { private void addActionToMenu(Menu parent, Action action, int accelerator) { if (accelerator < 10) { - StringBuffer label= new StringBuffer(); + StringBuilder label= new StringBuilder(); //add the numerical accelerator label.append('&'); label.append(accelerator); diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuildTab.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuildTab.java index 4d6920d28..e483f439f 100644 --- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuildTab.java +++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuildTab.java @@ -353,7 +353,7 @@ public class ExternalToolsBuildTab extends AbstractLaunchConfigurationTab { * @return an equivalent refresh attribute */ public static String getBuildScopeAttribute(List projects) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append("${projects:"); //$NON-NLS-1$ Iterator iterator = projects.iterator(); while (iterator.hasNext()) { diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuilderTab.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuilderTab.java index 22662fc20..c9afb5626 100644 --- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuilderTab.java +++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsBuilderTab.java @@ -311,7 +311,7 @@ public class ExternalToolsBuilderTab extends AbstractLaunchConfigurationTab { @Override public void setDefaults(ILaunchConfigurationWorkingCopy configuration) { - StringBuffer buffer= new StringBuffer(IExternalToolConstants.BUILD_TYPE_FULL); + StringBuilder buffer= new StringBuilder(IExternalToolConstants.BUILD_TYPE_FULL); buffer.append(','); buffer.append(IExternalToolConstants.BUILD_TYPE_INCREMENTAL); buffer.append(','); @@ -410,7 +410,7 @@ public class ExternalToolsBuilderTab extends AbstractLaunchConfigurationTab { @Override public void performApply(ILaunchConfigurationWorkingCopy configuration) { if (fCreateBuildScheduleComponent) { - StringBuffer buffer= new StringBuffer(); + StringBuilder buffer= new StringBuilder(); if (afterClean.getSelection()) { buffer.append(IExternalToolConstants.BUILD_TYPE_FULL).append(','); } diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsMainTab.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsMainTab.java index dd1250874..520c4db2b 100644 --- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsMainTab.java +++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations/ExternalToolsMainTab.java @@ -624,7 +624,7 @@ public abstract class ExternalToolsMainTab extends AbstractLaunchConfigurationTa public void addControlAccessibleListener(Control control, String controlName) { //strip mnemonic (&) String[] strs = controlName.split("&"); //$NON-NLS-1$ - StringBuffer stripped = new StringBuffer(); + StringBuilder stripped = new StringBuilder(); for (int i = 0; i < strs.length; i++) { stripped.append(strs[i]); } diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsImages.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsImages.java index f11caec8c..6fb547796 100644 --- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsImages.java +++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/model/ExternalToolsImages.java @@ -176,7 +176,7 @@ public class ExternalToolsImages { throw new MalformedURLException(); } - StringBuffer buffer= new StringBuffer(prefix); + StringBuilder buffer= new StringBuilder(prefix); buffer.append('/'); buffer.append(name); return new URL(ICON_BASE_URL, buffer.toString()); diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java index d1241ad51..cd9c3224e 100644 --- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java +++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/ui/BuilderPropertyPage.java @@ -589,7 +589,7 @@ public final class BuilderPropertyPage extends PropertyPage implements ICheckSta String name= DebugPlugin.getDefault().getLaunchManager().generateLaunchConfigurationName(ExternalToolsUIMessages.BuilderPropertyPage_New_Builder_7); workingCopy = type.newInstance(BuilderUtils.getBuilderFolder(getInputProject(), true), name); - StringBuffer buffer= new StringBuffer(IExternalToolConstants.BUILD_TYPE_FULL); + StringBuilder buffer= new StringBuilder(IExternalToolConstants.BUILD_TYPE_FULL); buffer.append(','); buffer.append(IExternalToolConstants.BUILD_TYPE_INCREMENTAL); buffer.append(','); diff --git a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/BuildProjectResolver.java b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/BuildProjectResolver.java index 016c403a3..4be9ee7a3 100644 --- a/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/BuildProjectResolver.java +++ b/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/BuildProjectResolver.java @@ -62,7 +62,7 @@ public class BuildProjectResolver implements IDynamicVariableResolver { * @return vraiable reference expression */ protected String getReferenceExpression(IDynamicVariable variable, String argument) { - StringBuffer reference = new StringBuffer(); + StringBuilder reference = new StringBuilder(); reference.append("${"); //$NON-NLS-1$ reference.append(variable.getName()); if (argument != null) { diff --git a/org.eclipse.ui.externaltools/Program Tools Support/org/eclipse/ui/externaltools/internal/program/launchConfigurations/ProgramMainTab.java b/org.eclipse.ui.externaltools/Program Tools Support/org/eclipse/ui/externaltools/internal/program/launchConfigurations/ProgramMainTab.java index 7227beef3..ca2377f26 100644 --- a/org.eclipse.ui.externaltools/Program Tools Support/org/eclipse/ui/externaltools/internal/program/launchConfigurations/ProgramMainTab.java +++ b/org.eclipse.ui.externaltools/Program Tools Support/org/eclipse/ui/externaltools/internal/program/launchConfigurations/ProgramMainTab.java @@ -41,7 +41,7 @@ public class ProgramMainTab extends ExternalToolsMainTab { } Object file= result.getFirstElement(); if (file instanceof IFile) { - StringBuffer expression = new StringBuffer(); + StringBuilder expression = new StringBuilder(); expression.append("${workspace_loc:"); //$NON-NLS-1$ expression.append(((IFile)file).getFullPath().toString()); expression.append("}"); //$NON-NLS-1$ -- cgit v1.2.3