From df17a90ffe71e042d60710d86356c9a4c95956e8 Mon Sep 17 00:00:00 2001 From: Alexander Kurtakov Date: Wed, 26 Apr 2017 09:28:44 +0300 Subject: Bug 515798 - Unreadable description of launcher There is no need for Text when it would not be edited at all. Also remove the useless @see javadoc comments. Change-Id: Id57c227752eeb518d65c9478679670a8c0216026 Signed-off-by: Alexander Kurtakov --- .../ui/preferences/LaunchersPreferencePage.java | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchersPreferencePage.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchersPreferencePage.java index 58f741a21..779e7c664 100644 --- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchersPreferencePage.java +++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchersPreferencePage.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2006, 2016 IBM Corporation and others. + * Copyright (c) 2006, 2017 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -44,8 +44,8 @@ import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Group; +import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Table; -import org.eclipse.swt.widgets.Text; import org.eclipse.swt.widgets.Tree; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; @@ -145,7 +145,7 @@ public class LaunchersPreferencePage extends PreferencePage implements IWorkbenc private Map> fDuplicates = null; private Map fDupeSelections = null; private boolean fDirty = false; - private Text fDescription = null; + private Label fDescription = null; /** * Constructor @@ -154,18 +154,12 @@ public class LaunchersPreferencePage extends PreferencePage implements IWorkbenc setTitle(DebugPreferencesMessages.LaunchDelegatesPreferencePage_0); } - /** - * @see org.eclipse.jface.preference.PreferencePage#createControl(org.eclipse.swt.widgets.Composite) - */ @Override public void createControl(Composite parent) { super.createControl(parent); PlatformUI.getWorkbench().getHelpSystem().setHelp(getControl(), IDebugHelpContextIds.LAUNCH_DELEGATES_PREFERENCE_PAGE); } - /** - * @see org.eclipse.jface.preference.PreferencePage#createContents(org.eclipse.swt.widgets.Composite) - */ @Override protected Control createContents(Composite parent) { Composite comp = SWTFactory.createComposite(parent, 2, 1, GridData.FILL_BOTH); @@ -262,15 +256,10 @@ public class LaunchersPreferencePage extends PreferencePage implements IWorkbenc } }); Group group = SWTFactory.createGroup(comp, DebugPreferencesMessages.LaunchDelegatesPreferencePage_4, 1, 2, GridData.FILL_BOTH); - fDescription = SWTFactory.createText(group, SWT.WRAP | SWT.READ_ONLY, 1, GridData.FILL_BOTH); - fDescription.setEnabled(enabled); - fDescription.setBackground(group.getBackground()); + fDescription = SWTFactory.createWrapLabel(group, "", 1); //$NON-NLS-1$ return comp; } - /** - * @see org.eclipse.jface.preference.PreferencePage#performOk() - */ @Override public boolean performOk() { if(fDirty && fDupeSelections != null && fDupeSelections.size() > 0) { @@ -289,9 +278,6 @@ public class LaunchersPreferencePage extends PreferencePage implements IWorkbenc return super.performOk(); } - /** - * @see org.eclipse.ui.IWorkbenchPreferencePage#init(org.eclipse.ui.IWorkbench) - */ @Override public void init(IWorkbench workbench) { //init a listing of duplicate delegates arranged by type -- cgit v1.2.3