Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-10-18Bug 540259 - NPE in ProcessConsole$InputReadJob.runI20181019-0450I20181019-0330I20181018-1800Andrey Loskutov1-3/+7
Change-Id: Ib4c5510e95e2d707e9b649c010cc6d16ffe01609 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-18Bug 540242 - SWTException in InternalTreeModelViewer.getDisplayAndrey Loskutov2-13/+11
ElementMementoRequest should not try to call done() on already disposed viewer Change-Id: I09276f7f001a4c1725519183ee1a05d8485c6fb2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-18Bug 491273 - remove copy/pasted getClosestMonitor() implementationAndrey Loskutov2-40/+3
Change-Id: I66ec9cdcde9ea31977ae5b5f77282edcdd22a684 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-09-14Bug 355011 - Deadlock on creating console in the build threadI20180914-0620Andrey Loskutov1-16/+61
Do not create console directly in the launchChanged() callback, because the current thread may hold already some lock, and if the ProcessConsole() init requires another one lock, we will have a classic deadlock. In case of bug 355011 current thread owns workspace lock and ProcessConsole() init requires UI lock. Change-Id: Ia01df4cb3f714b16fce84620538e66aa3de10b76 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-09-14Bug 537903 - Wrong Debug View due to evaluation on debug context changeSimeon Andreev1-2/+12
Whenever an evaluation runs during thread suspend handling, its possible to create a delta which selects the suspended thread but not its first stack frame. This results due to very specific interleaving of thread running state and code in ThreadEventHandler.fireDeltaUpdatingSelectedFrame(). An evaluation can e.g. be triggered by a job in client code, either with IJavaThread.runEvaluation() or with IJavaObject.sendMessage() methods. No synchronization is possible between those methods and the suspend handling, since such synchronization can block debug event processing and so potentially lead to deadlocks. This change attempts to salvage the situation, after the bad case is encountered. If no top stack frame could be retrieved by ThreadEventHandler.fireDeltaUpdatingSelectedFrame(), but the thread is in suspended state, we query the top stack frame again. In case one evaluation ran in parallel with the suspend handling, at this point we know for sure that the evaluation is done and so the top stack frame is accessible. This change does not help in case client code bombards the thread with evaluations. It also does not help in case an evaluation ran throughout the entire thread suspend handling. Change-Id: I34252c0dac3d031bbbefc3a1328175cab0793ae5 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-09-12Bug 538548 - Debug View in another perspective causes editor to pop-upY20180912-2200I20180913-1800I20180913-0415I20180912-2240Simeon Andreev1-1/+3
If a window has the Debug View open in an inactive perspective, breakpoint hits will cause an editor to open in that window. This hinders the use of multiple windows, each with a different type of perspective. Only windows which have the Debug View in their active perspective should show source on breakpoint hit. The editor is activated due to the Debug View reacting to selection events, which occur due to breakpoint hits. This change ensures that the Debug View will react to selection events only if its active. I.e. only if the active perspective of the window contains the Debug View. Change-Id: Ida92f5322e1a83b95af4bc43f25a9fac9d4519b6 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-09-11Bug 538303 - Debug View wrong selection if activated by breakpointI20180912-0225I20180912-0210I20180911-1400Simeon Andreev3-3/+3
If a breakpoint is hit when the Debug View is not active, the Debug View is activated. In some cases, this leads to a bad selection and expanded state. When the Debug View is activated, either by a breakpoint or by a user, a state is saved in ViewerStateTracker. This state is cancelled by TreeModelContentProvider on breakpoint hit, however without removing COLLAPSED delta states. As such, applying the state later on will lead to a collapsed thread, if the state had a collapsed flag for that thread. This "overwrites" a thread selected by suspend handling. This change should ensure that COLLAPSED thread state in ViewerStateTracker is cleared when an expand is handled, regardless if the tree had to be expanded or was expanded already by another operation. Change-Id: I7c43b8317081747c6d8e85020e7040e928c4f39b Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-09-04Bug 538531 - POM version change for 4.10 releaseY20180905-2200I20180907-0855I20180907-0715I20180907-0650I20180907-0400I20180906-1400I20180906-0005I20180905-1305I20180905-0410Sravan Kumar Lakkimsetti1-1/+1
Change-Id: I05159d79d261e80ffc94a2bf3abccc6ec3b46243 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-08-27Bug 537877: Drawing problems in debug breadcrumb toolbarY20180829-2200S4_9_0_RC2S4_9_0_RC1R4_9I20180906-0745I20180905-2000I20180905-0800I20180904-2000I20180904-0800I20180903-2000I20180903-1305I20180903-1125I20180903-0945I20180903-0800I20180902-2000I20180902-0800I20180901-1500I20180901-0800I20180831-2000I20180831-0815I20180830-1030I20180829-2000I20180829-0800I20180828-2000I20180828-0800I20180827-2000I20180827-0800R4_9_maintenanceMatthias Becker2-2/+4
Change-Id: Ic0e03e48c221ef85d91c4c1bae895e3a488c3042 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2018-08-21Bug 535802 - EPL-2.0 for platform.debug plug-insY20180823-0800Y20180822-2200S4_9_0_M3I20180823-0450I20180823-0430I20180823-0100I20180822-2000I20180822-0800I20180821-2000Lars Vogel870-2620/+5220
Commands used for this conversion: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: I3c49f3d254233c87acef9c83b3eb9ba831b9d6ff Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-20Bug 530393 - EPL 2.0 for exsd in platform.debugI20180821-0800I20180820-2000Lars Vogel17-51/+102
Based on the following regex. find . -type f -name "*.exsd" -exec sed -i -E 's/http:\/\/www.eclipse.org\/legal\/epl-v10.html\&quot;\&gt;http:\/\/www.eclipse.org\/legal\/epl-v10.html\&lt;\/a\&gt;/https:\/\/www.eclipse.org\/legal\/epl-2.0\&quot;\&gt;https:\/\/www.eclipse.org\/legal\/epl-v20.html\&lt;\/a\&gt;\/\n\nSPDX-License-Identifier: EPL-2.0/' {} + find . -type f -name "*.exsd" | xargs sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' find . -type f -name "*.exsd" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: I560e99597565ce4ddf645ff1632b84603cb30086 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-08-20Bug 538072 - Show Command Line button is shown when there are no launchI20180820-0800Sarika Sinha1-0/+1
configurations Change-Id: Icd83fcd3fd3b61bbedec07c3873f4ee39376f11f
2018-08-14Bug 537525 - Follow up of Bug 312397 - Run Configuration Command Line toI20180819-2000I20180819-0800I20180818-1500I20180818-0800I20180817-2000I20180816-2000Sarika Sinha4-4/+57
Clipboard Change-Id: Idfb989cb7ff3d47c4162becea5227a7c04e975cc
2018-08-14Bug 537525 - Follow up of Bug 312397 - Run Configuration Command Line toY20180815-2200I20180815-2000I20180815-1250I20180814-2000I20180814-0910I20180814-0900Sarika Sinha2-1/+8
Clipboard Change-Id: If197112aa3f36344e0efc5d77be169ae743d9e27
2018-08-09Bug 537818 - missing "a" in date pattern string variableI20180813-2000I20180812-2000I20180811-1500I20180810-2000I20180810-0320I20180809-2000Michael Keppler1-1/+1
Also remove the plenking by replacing double blanks with single blanks. Change-Id: I0ae81e406d770b6776e1b4ebd57c42d3e120e610 Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2018-08-01Bug 312397 - Run Configuration Command Line to ClipboardY20180808-2200Y20180801-2200S4_9_0_M2I20180808-2000I20180807-2000I20180807-1425I20180807-0350I20180806-2000I20180806-0300I20180805-2000I20180804-1500I20180803-2000I20180801-2000I20180801-0820I20180801-0800Sarika Sinha1-0/+1
Change-Id: I23b39a6165a1a50723fd41aaeb5e91e945d7485c
2018-07-31Bug 312397 - Run Configuration Command Line to ClipboardI20180801-0550I20180731-2000I20180731-1305I20180731-1250I20180731-1025I20180731-0800Sarika Sinha2-9/+11
Change-Id: I6d6b01ad2bda796a43c77399a6a62b2f59edd9fc
2018-07-29Bug 312397 - Run Configuration Command Line to ClipboardI20180731-0340I20180730-2240I20180730-2000I20180730-0800I20180729-2000Sarika Sinha4-20/+50
Change-Id: I19d054bed10f834c52bc00f0397255f870b4d6c8
2018-07-27Bug 312397 - Run Configuration Command Line to ClipboardI20180729-0800I20180728-1500I20180728-0805Sarika Sinha4-2/+186
Change-Id: I766655f94324002a8e67310e7882c1a63a706c5b
2018-07-24Bug 537330 - Breakpoints View NPE on perspective switch during debugI20180727-2000Simeon Andreev1-0/+4
The error log indicates that at the time of BreakpointsView.contextActivated, the Breakpoints View had no tree model viewer. This caused a NPE to be logged in the Error Log. This change adds a guard to the method, similar to the guard found in VariablesView.contextActivated. This avoids the logged NPE and does not alter behavior otherwise; the rest of BreakpointsView.contextActivated does nothing if there is no tree model. Change-Id: I070a2714c40636fb8796a963b7a3d4c147c04bf9
2018-07-24Bug 537322 - Improved logging in exception case of flushMarkerCacheY20180725-2200I20180726-2000I20180725-2000I20180724-2000Simeon Andreev1-1/+5
Whenever an exception occurs during marker attribute setting in BreakpointWorkingSetCache.flushMarkerCache, the logged error does not include information for the attributes which are to be set on the marker. When logged e.g. from tests, its difficult to understand where the logged error is coming from. This change adds some extra information to the logged error. Change-Id: I0b9a1aadb9310b26778f200df4004cdbb8756eef Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-07-20Bug 465666: Fix bread crumb background in dark themeY20180723-0635Y20180723-0615I20180723-2000I20180722-2000I20180721-1500I20180720-2000Matthias Becker7-127/+66
Change-Id: Ifb6349ffd0af011933760e6ee8eef3f984209b8e Signed-off-by: Matthias Becker <ma.becker@sap.com>
2018-07-19Bug 521038 - [refactoring] Replace anonymous Runnable classes by lambdaAlexander Kurtakov62-2013/+1545
expression Changed some formatters to Eclipse so there is some formatting happening as the debug one is not clear where to get from and it's unrealistic to expect random contributors to do it. Change-Id: I731410854f9a4ac0c9fc18bcf3ad3dcf7d941c9a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-07-15Bug 535151 - Show only launch types with children in export dialogY20180718-2200I20180718-2000I20180718-0130I20180717-2000I20180717-0320I20180716-2000I20180716-0715I20180715-2000Michael Keppler1-5/+26
Since a typical Eclipse user will have a lot of empty launch config types (i.e. with no defined launch configs or prototypes), which we can hide from the export launch config dialog. Had to move some private members from the nested class to the top level class to use them in both. Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Also-by: Karsten Thoms <karsten.thoms@itemis.de> Change-Id: I04a0e52b5c9d4427e5221591b33ea0aaf67488e7 Bug:535151
2018-07-14Bug 535466 - Menus in export launch dialog should have ellipsisMichael Keppler1-2/+2
Change-Id: Id1fffba4c3976e7f3efbc0dba8468a6fd0382f51 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Bug:535466
2018-07-13Bug 536648 - Thread evaluation runs in parallel with thread label updateI20180714-1500I20180713-2000Simeon Andreev1-1/+1
When running an evaluation on a thread suspension, its possible that a label update of the Debug View runs in parallel. The label update can then retrieve the intermediate state of the evaluation. If no further label update is issued, the thread will be shown as running until the Debug View is refreshed. With this change, suspending a thread after an evaluation will also update the thread state in the Debug View. This avoids the wrong running icon of the thread. Change-Id: Id6ec6a9d48c041d0b2617adb8b7da91ba5140b15 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-07-05Bug 536677 - AbstractDebugView should release MessagePage instancesI20180710-2000I20180709-2000I20180708-2000I20180707-1500I20180706-2000I20180705-2000Andrey Loskutov1-16/+15
Not disposed MessagePage holds site -> serviceLocator -> services -> window reference of closed window. Change-Id: I0e5045d752e35b83f6463bb61114dda09f8bf994 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-20Bug 534298 - [quick fix] The New PreferenceY20180705-0105Y20180628-0525I20180704-2000I20180704-0805I20180704-0605I20180704-0545I20180703-2000I20180702-2000I20180702-0435I20180701-2000I20180630-1500I20180629-2000I20180629-0420I20180629-0400I20180628-2000I20180628-0230I20180627-2020I20180627-2000I20180625-1545I20180621-2000Kalyan Prasad Tatavarthi1-1/+15
"PREF_COMPLIANCE_COMPATIBLE_JRE_NOT_AVAILABLE" creates a new problem marker But does not provide Quick Fix for the problem marker Change-Id: Ie9e1697dc4f83c6e8251d8b68c254cf964e95262 Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
2018-06-14Bug 535686 - use one queue for scheduling async tasksI20180618-0800I20180615-0655I20180615-0300I20180614-2045I20180614-2000Andrey Loskutov1-9/+22
Queue async tasks coming from ChildrenUpdate's jobs via scheduleViewerUpdate() in the same queue with async tasks coming from modelChanged(), so that they all run in more predictable order. This allows us to run async UI updates triggered by ElementContentProvider jobs before we run next batch of model change events. Additionally this should further reduce the number of Display.asyncExec() tasks coming from debugger. Change-Id: I4a16e9cc79ab453b35d064c85440b726a4772442 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-14Bug 535686 - wait for pending ElementContentProvider jobsAndrey Loskutov1-1/+8
Before triggering another update round via doModelChanged(), wait for all previously scheduled ElementContentProvider jobs, so that they can read the model data before it changes again. Change-Id: I2534d140c295341f3a69793254b6f94d5e7ef04e Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-12Bug 535468 - Link with prototype does not set an initial selectionI20180613-0440I20180613-0300Michael Keppler1-0/+1
Set an initial selection in the dialog to indicate what is currently the linked prototype. Change-Id: I9414b8f020b7b80de95464db35cdc4d2481a94c3 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Bug:535468
2018-06-12Bug 535809 - ElementContentProvider jobs have no familyAndrey Loskutov1-15/+18
Added family to all jobs and cleaned up the code a bit. Change-Id: I777599bce7f347a07d0d2c7051fdd695204a9e46 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-12Bug 534681 - Remove redundant modifiers in org.eclipse.debug.uiKarsten Thoms134-1082/+1056
Change-Id: I1d0b999ad8ead1bad88e9f23aa32fd34418c63aa Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-06-08LaunchView cleanupAndrey Loskutov1-113/+6
Change-Id: Ic8081419430d04e55d593810e3ba4e21655eb8dc Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-08Bug 535707 - AssertionFailedException via LaunchView.showBreadcrumbPageAndrey Loskutov1-2/+7
DebugContextEvent expects a non-null context object. Change-Id: I6268e8cda92c619c2b900812be762ca86360c972 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-08Bug 535462 - NPE when closing second window during debugSimeon Andreev2-2/+19
The bug occurs while debugging, having two windows and a custom debug context provider. When closing the second window, DebugWindowContextService.notify is called with the selection of the custom debug context provider. If this selection is e.g. a stack frame, SourceLookupService asks SourceLookupFacility to open a source file. This throws a NPE, since the workbench page window is closing. With this change SourceLookupFacility checks if the active workbench window is closing. If so, the source is not opened, avoiding the NPE. Note: updated platform.ui version range to see re-export updated ui.workbench API. Change-Id: Ifb177c1211248b0cda17c6d14201a210d5fec8dc Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-07TreeModelContentProvider cleanupI20180607-2000Andrey Loskutov1-58/+37
Change-Id: I6e3b6faece08d4e4e52cd4a4c60d9c5b6ed09521 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-07ModelDelta cleanupAndrey Loskutov1-34/+8
Change-Id: I962d7c4043e4f50104119c6059cf368da2eb51ea Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-06-05Bug 535318 - Update license to EPL-2.0 for platform.debug in about.htmlI20180606-1020Lars Vogel1-16/+24
Change-Id: Ide949707f61f88a56527c56610c1dfeb551a1db9 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-06-01Revert second update of org.eclipse.debug.ui for 4.9Lars Vogel2-2/+2
Change-Id: Ib1149da96d2e4e68127c09829ceb47e40b027328 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-06-01Bug 535454 - do not allow null context in DebugContextEvent constructorSimeon Andreev1-0/+2
In case of a null context passed to the constructor of DebugContextEvent, a NPE could be thrown later on when the event is being processed. This is the case since DebugContextEvent.getContext() makes no mention of possibly returning a null. E.g. some code in ToggleStepFiltersAction and LaunchView does not check if the returned context is null. At the point of throwing the NPE, its unclear where the null context actually came from. For issues which are difficult to reproduce, this information is vital. With this change, an exception is thrown if the passed context is null. Change-Id: If7a86500bc827bc6aa73ca971c9be79a714be81f Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-06-01Version 4.9 update in plaform.debug as prep for the EPL 2.0 updateI20180601-0915I20180601-0900Lars Vogel2-2/+2
Change-Id: I0780d35d66fd25b70bbf7618979672bcbd2a559e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-06-01Bug 535148 - Export launch wizard confirmation dialog typoMichael Keppler3-4/+4
Add missing "to". Change-Id: I5f5ebd168a56d8fbe9bf21dc54c07fe957712236 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de> Bug: 535148
2018-05-30Bug 535191 - POM version change for 4.9 releaseI20180531-2125I20180531-2000I20180531-1245I20180531-0910Alexander Kurtakov1-1/+1
Change-Id: Ic421012d21e951ef7763a6be83c2f2a42eed5c15 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-14Bug 517809 - Modes in Launches tab of Launch Group use mode namesS4_8_0_RC2S4_8_0_RC1I20180528-0800I20180527-2250I20180527-2000I20180527-0800I20180526-1500I20180526-0800I20180525-2000I20180524-0900I20180523-2000I20180523-0800I20180522-2000I20180522-0800I20180521-2000I20180521-0800I20180520-2000I20180520-0800I20180519-1500I20180519-0800I20180518-2000I20180516-2000I20180516-0800I20180515-2000I20180515-1755I20180515-1620I20180515-1440I20180515-1300I20180515-0950I20180515-0800I20180514-2000I20180514-0800Sarika Sinha2-70/+104
instead of labels Change-Id: I2e62b93ee3810b06f75278db08f423f08bf60b2d
2018-05-12Bug 534597 - Unanticipated comparator errors in I20180511-2000I20180513-2000I20180513-0800I20180512-1500I20180512-0830Sravan Kumar Lakkimsetti1-0/+1
Change-Id: Ie82f0677a530ab8077b14141b8658f6f838f14bf Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-05-09Bug 534380 - Reset button is not working in New Configuration ->S4_8_0_M7I20180511-2000I20180509-2000Sarika Sinha1-1/+1
Prototype tab Change-Id: Ia43c51525afe9f6a1f0984abd8e01f3cf5545a57
2018-05-09Bug 533788 - Use StandardCharsetsI20180509-0800Alexander Kurtakov2-4/+6
Another bunch of such changes. Change-Id: I4012772607b8f7c165156b8d03fbd5bcbee4b581 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-05-07Bug 534379 - GVT48: English Strings are found in New Prototype ->I20180508-2000I20180508-0800I20180507-2205I20180507-2000I20180507-0810I20180507-0800Sarika Sinha3-4/+10
Prototype tab Change-Id: I1b47534b83d9927090b0b55646bccee0618c85ba
2018-05-03Bug 532602 - Remove all Breakpoints dialog should use verbsI20180506-2000I20180506-0800I20180505-1500I20180504-2000I20180503-2000Lars Vogel1-1/+1
Change-Id: I66a7035fa798e0f33cf808ed3c02a37dca121774 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

Back to the top