Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
47 hoursConvert to lambda or member referenceI20190918-0300I20190917-1800Carsten Hammer3-20/+3
Convert anonymous inner classes to lambda expressions or member references. Change-Id: I232b73cdb76810568d3e1ffdeba3a6bf42a6a337 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
47 hoursSynchronizing on this in anonymous classI20190916-1800Carsten Hammer1-1/+1
or local class is probably a result of refactoring and possibly a mistake Change-Id: I7e7d09e3ad9a4a833de2de5baedc378d37edcc06 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2 daysRemove unnecessary type specificationsCarsten Hammer3-3/+3
Since Java 7 the diamond operator can be used instead of explicit type parameters. Version bumps for 4.14 Change-Id: I15a2ec4f20428b1fdecc6a7e11dae5e1966b21e6 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-08-14Use StringBuilder in org.eclipse.debug.uiY20190815-0900I20190816-0155I20190814-1800Lars Vogel7-15/+15
Change-Id: Ifd968748a493a9717bce4841360eec6bd7fc7893 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-08-12Bug 549903 - Replace usage of deprecated SubProgressMonitor withI20190813-1800I20190812-1800Paul Pazderski1-33/+19
SubMonitor Also replaced the anti-pattern: if(doMore) { doSomething(new SubProgressMonitor(monitor)); } else { monitor.worked(); } As consequence skipped optional work will not move the progress bar anymore but leave the space for the remaining tasks. Change-Id: Id58944194449f58f887e8969d7ba9d7c16939f9c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-08-09Remove trailing whitespaces in org.eclipse.debug.uiY20190812-0900Lars Vogel3-3/+3
Already active the via save actions on the project but code still contains some whitespace Change-Id: I2f1df596aa9cc6de753a99324ab5382fd972549c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-08-09Run Organize imports org.eclipse.debug.uiLars Vogel3-4/+2
This would have made the fix for https://git.eclipse.org/r/#/c/147409/ easier Change-Id: Ic95f0d1b03cc89e93192547e2dd7adcbc7e29d10 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-08-09Bug 549858 - Use PlatformUI.getWorkbench instead ofLars Vogel12-16/+22
AbstractUIPlugin.getWorkbench AbstractUIPlugin.getWorkbench is a simple wrapper around PlatformUI.getWorkbench . As we want to reduce the usage of activators, we are planning to deprecate AbstractUIPlugin.getWorkbench via Bug 549848. Activators can slow down the start of Eclipse applications and should be avoided if possible. Change-Id: Id61f894709d98534021f412405b1cde42318632f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-15Bug 548799 - Replace usage of AbstractUIPlugin#imageDescriptorFromPluginY20190722-0900Y20190718-0905Y20190718-0450Y20190715-2335I20190721-1800I20190720-1800I20190719-1800I20190718-1800I20190717-1800I20190716-1800I20190715-1800Alexander Fedorov1-4/+7
Use ResourceLocator#imageDescriptorFromBundle Change-Id: Iecd9472c60526e40774f776315e34d37a794e7e6 Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2019-07-05Bug 529651 - Launch group launches do not build before launchAlexander Fedorov1-0/+30
Launch group delegates the build flag resolution to IStatusHandler that reads the IDebugUIConstants.PREF_BUILD_BEFORE_LAUNCH preference Change-Id: If8c6b1bbf0987279228e89edfd76e36157f097c2 Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2019-07-03Bug 548885 - Launch dialog's 'Show Command Line' disabled after applyPaul Pazderski1-3/+5
Change-Id: I7f8e2db74cdadec7b0c484435cc1230a75f0f6fc Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-07-03Bug 32205 - [console] Add launch option to merge process outputI20190703-0640Paul Pazderski2-0/+2
Also make use of output merge option in external tool launch. Change-Id: Ibc3cec8df076a4cea3f83e37fa2640115dd3f49b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-07-02Remove unused NLS message variableI20190702-1800Paul Pazderski1-1/+0
EnvironmentTab_2 is not used and has no corresponding message. Change-Id: I1f7f256d9c3f9ad55e2ca4240d272d74209c69f1 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-06-28Bug 548520 - Change use of "New" to "Add" for Env Var TabY20190701-0635I20190630-1800I20190629-1800I20190628-1800Andrew Obuchowicz2-15/+10
Removed redundant externalized string Change-Id: I6f91d1b6bc9e969b7843defddd4cb9b5bce36977 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-06-23Bug 548557 - Warnings in I20190621-1800 for debug.uiI20190624-1800Sarika Sinha1-0/+3
Change-Id: Ifcada89b06f9c8a8ed16f8754a9dc347c476b052 Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2019-06-21Bug 548520 - Add right-click context-menu for Java environment var tabI20190623-1800Andrew Obuchowicz2-0/+15
Patch ready for review. Change-Id: Ie1d939bc0bf50ca58098785bb072de980c56fbb2 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-06-21Bug 548344 - Add inline editing support for environment variables tableI20190621-1800Andrew Obuchowicz2-0/+73
Applied requested changes. Patch ready for review. Change-Id: Idfce2e6549a6c13af2b96b8e8c9c37f762e58c51 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-06-21Lamba optimizationLars Vogel6-8/+7
Use method references if possible Remove unnecessary brackets Change-Id: I82c219171f7b3e459d4e2f70ae916d44d25fdc11 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-20Small String optimizationI20190620-1800Lars Vogel9-14/+14
Useless toString call in String concatenation Using String.valueOf instead of ""+ Use faster indexof('') version Change-Id: Iec383bd1b6af03a40af735f9ec878689caf4fb23 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-18Use addAll, deleteAll instead of looping through a collectionI20190620-0130I20190619-1820I20190619-1800I20190618-1805Lars Vogel23-76/+45
Change-Id: I9c95900ed1b6e8823bb30c4ded37f214a92deffc Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-18Bug 446151 - Dead lock while startingI20190618-0225Sarika Sinha1-4/+9
Change-Id: I7030b4b58b88cd278add760ac18bf7beccaeee90 Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2019-06-17Removes redundant semicolonsLars Vogel2-3/+3
Change-Id: Ia156b94bd7a69b362d7ad272347e61e2fd7760bc Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17StringBuilder instead of StringBufferLars Vogel1-1/+1
Change-Id: Ife52e063a0baa0504b6549f25df4d170999f0498 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-14Bug 547304 - [cleanup] Fix wrong space/tab indentationI20190616-1800I20190615-1800I20190614-1800Paul Pazderski313-22262/+22262
This change fixes space or mixed tab/space indentations in all Java files. This also includes two or three space indentations and even fix most stray single spaces in indentations. The change includes only whitespace formatting and no code changes. Change-Id: I95f385f1587b72776aee5d955b66e82539dedc3c
2019-06-13Use StringBuilder instead of StringBuffer where possible.Carsten Hammer48-71/+72
Change-Id: I990721405fb7e486fc93ef2b22e56e81ed4a78c8 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-13Replace chain of ifs with switchI20190614-0330I20190613-1800Carsten Hammer5-57/+74
Sometimes if statements are chained and form a series of == comparisons against constants. Such situation is more readable if written using switch statement. Change-Id: I699710eb77cb7b84e34d32ec1460daab696c8591 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-11String.indexOf can be replaced with String.containsI20190613-0210I20190612-1800I20190612-0115Carsten Hammer2-2/+2
Change-Id: Ia3ff4eebc3799a8c1b8f6bbcddd200d08e1d966b Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-11Use isEmpty() instead of size()==0 where possibleCarsten Hammer8-9/+9
Change-Id: Iba492570def0a381d0c4a06a5ad3b7c8c8a3419e Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-05-18Bug 547304 - [cleanup] Fix wrong line delimitersS4_12_0_RC2S4_12_0_RC1aS4_12_0_RC1S4_12_0_M3R4_12I20190605-1800I20190605-0600I20190604-1800I20190604-0600I20190603-1800I20190603-0600I20190602-1800I20190602-0600I20190601-1800I20190531-1800I20190531-0245I20190529-2005I20190529-1800I20190529-0600I20190528-1800I20190528-0915I20190528-0850I20190528-0600I20190527-1805I20190527-0600I20190526-1800I20190526-0600I20190525-1800I20190525-0600I20190524-1800I20190524-0135I20190522-1800I20190522-0600I20190521-1800I20190521-0600I20190520-1805I20190520-0600I20190519-1800R4_12_maintenancePaul Pazderski14-695/+695
This updates all Java files with wrong or mixed line delimiters to use Unix style delimiters. The change includes only whitespace formatting and no code changes. Change-Id: I2b11370da258d1c5952a75647772e983e81db8d2
2019-05-14Bug 545769 - [console] UTF-8 content read or send to process can beI20190517-1800I20190516-1800Paul Pazderski1-14/+23
corrupted With some bad luck the ProcessConsole may disrupt multibyte UTF-8 characters read from input source (usually user input or file) due to incorrect stream reading / buffer handling. The same problem exist for reading the processes output streams. Change-Id: I8d52d1973f3739e2c510a8a4c48b44f345c33dfe Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-05-12Bug 344349 - [breakpoints] Delete undo doesn't work when multi-selectI20190513-1800I20190512-1800Paul Pazderski1-2/+4
group and breakpoints Do/Undo-Operation fails if breakpoints are deleted twice. Change-Id: Ifa617309f2b822a13cc4f766b2cc2b050d71da3b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-05-08Bug 545544 - Contribute Launch/Debug configuration to Quick AccessI20190509-1800I20190508-1800Mickael Istria5-0/+220
Change-Id: I046fb61551c60a54c6a726f32f2f3b01ba129e91 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-28Bug 546710 - [console] Race condition on process console creationI20190501-1800I20190501-0525I20190430-1800I20190429-1800I20190429-0240I20190428-1800Paul Pazderski1-2/+10
Change-Id: I473f4fa1296cbbc823f6d2b6ad6827957816d64c Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-04-25Bug 546710 - [console] Synchronize "remove all" action enable updateI20190427-1800I20190426-1800I20190425-1800Paul Pazderski1-1/+1
This should fix the following race condition for fast terminating processes: When the action is constructed it will update its enablement. The terminated notification, which also updates enablement, can come from a different thread. It may happen that the initial enablement update is interrupted after calculating the enablement state but before setting it. If then the process terminates the action is enabled due to terminated notification but the later resumed initial update will set it to disabled again. Change-Id: I32eafe4676b3fbd57a997ef75c96965bb5159f2f Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-04-24Bug 546710 - [console] Race condition in ProcessConsole init with fastPaul Pazderski1-4/+4
terminating processes Monitoring of process termination and console initialization are performed in separate threads. The ProcessConsole can miss the termination between the termination check in init and the following listener registration. Change-Id: If66027d87a7ef0cc19869d568d209c9387d5a606 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-04-24Bug 546641 - [console] ProcessConsole InputReadJob is not cancelableI20190425-0030I20190424-1800Paul Pazderski1-5/+27
Change-Id: I453380da668bc5d04e2f90469a16d2ce37d1e90d Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-04-10Bug 546314 - Fix mangled copyright headersS4_12_0_M1I20190412-1800I20190412-0520I20190411-0625Paul Pazderski1-11/+12
Change-Id: I463de4caa71ab86ad9a95592892c1072d1ba0f9b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-04-08Revert "Bug 545544 - Contribute Launch/Debug configuration to Quick Access"I20190410-1800I20190410-0600I20190409-1800I20190409-0600I20190408-1800Dani Megert5-235/+0
This reverts commit 27ffa28c237adb1de4de7339c16583845b0f79a0. See bug 546187 for details. Change-Id: I024f37eba46b7d9c6e3d5f6befcc281746a5f9cb
2019-04-02Bug 545544 - Contribute Launch/Debug configuration to Quick AccessI20190408-0600I20190407-1800I20190406-1800Mickael Istria5-0/+235
Change-Id: Ic0cc44a599bc749953db99d885ff31e38132bcbc Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-20Remove useless non-javadoc see comments. (take 4)I20190329-0120I20190328-1800I20190327-1800I20190326-2305I20190326-1800I20190325-1800I20190325-0105I20190324-1800I20190323-1800I20190322-1800I20190321-1800I20190321-0435I20190321-0245Alexander Kurtakov142-1742/+57
Handled by Override annotation. Change-Id: Ic81aef130640547b3d07fd874f9da197bdbc1644 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-20Remove useless non-javadoc see comments. (take 3)I20190320-1800Alexander Kurtakov126-1577/+41
Handled by Override annotation. Change-Id: Ife58fe4576a16053087be89b91c1042efb0ab0a3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-20Remove useless non-javadoc see comments. (take 2)Alexander Kurtakov122-2230/+334
Handled by Override annotation. Change-Id: Ia58f7defc807ae5ff37f1ef8a6617d4d8cac2a0a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-01Bug 544926 - NPE inY20190320-2200Y20190319-2305Y20190316-1220Y20190313-2200Y20190313-0215Y20190308-0715Y20190307-1015Y20190306-2200S4_11_0_RC2R4_11I20190307-0500I20190306-2135I20190306-1800I20190306-0600I20190305-1800I20190305-0600I20190304-1800I20190304-0600R4_11_maintenanceSarika Sinha1-0/+3
DefaultDetailPane$DetailJob$1.runInUIThread(DefaultDetailPane.java:317) Change-Id: Ic67c7a9431b08fd2bb8cf7c238c3fb5a273d4117
2019-02-18Bug 543933 - Build javadocs with Java 11Y20190227-2200Y20190225-0415Y20190222-0110Y20190220-2200S4_11_0_RC1S4_11_0_M3I20190303-1800I20190303-0600I20190302-1800I20190302-0600I20190301-1800I20190301-0040I20190228-0300I20190227-1800I20190227-0600I20190226-1800I20190226-1020I20190226-0715I20190226-0600I20190225-1800I20190225-0600I20190225-0200I20190224-1800I20190224-0930I20190224-0600I20190223-1800I20190223-0600I20190222-1800I20190222-0645I20190222-0440I20190220-1800I20190220-0600I20190219-1800I20190219-0600I20190218-1800Alexander Kurtakov1-1/+2
After fixing majority of Xdoclint:html issues there are warnings even with Xdoclint:none. Change-Id: I8d4ec9e2b5bfa137526e8bee0d00a3c9fef0eddb Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-18Bug 544528 - avoid deadlock after failed evaluationJulian Honnen1-6/+1
Moved fPendingValues.notifyAll() into finally block to ensure waiting threads are woken up after uncaught exceptions. Change-Id: Ia8a6c0126a6bf368c389118640edf51a7af7c6b0 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
2019-02-12Bug 544400 - Replace usage of StructuredViewer#getSorter()Y20190213-2200Y20190213-0305I20190213-1800Karsten Thoms2-9/+9
Replace by StructuredViewer#getComparator Change-Id: I926b8c2329519b1add153906b772f60535dd79a3 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-02-10Bug 544313 - NPE on workbench close if debug view in foregroundI20190212-1800I20190211-1800I20190210-2135I20190210-1800Andrey Loskutov1-0/+4
Change-Id: I057c371f8280482636a5ffa9f618d2afbaf4b46f Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-01-25Bug 459906 - Add the ability to copy and paste environment variablesY20190208-0505Y20190206-2200Y20190205-0115Y20190201-0030Y20190130-2200Y20190130-0010I20190209-1800I20190208-1800I20190207-1800I20190206-1800I20190205-1800I20190204-1800I20190203-1800I20190202-1800I20190201-1800I20190201-0600I20190131-1800I20190131-0130I20190130-1800I20190129-1800I20190128-1800I20190127-1800I20190126-1800I20190125-1800Jens Reimann2-2/+13
This change adds the functionality of copy & pasting environment variables out of the env-var table view to the clipboard. Change-Id: I312f6966ebbf6b261dd858b4a55b660f86ed3727 Signed-off-by: Jens Reimann <jreimann@redhat.com>
2019-01-25Bug 543832 - NPE in ProcessConsole.getStream()Andrey Loskutov1-6/+6
Reordered stream disposal and disconnecting of listeners, so that listener should not run on disposed streams. Change-Id: I895f580c7eaca746994bd78f31ea82c62bfddffd Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-01-22Bug 543672 - SWT Widget Disposed in variables viewY20190123-2200I20190124-1800I20190124-1235I20190124-0930I20190123-1800I20190122-1800Sarika Sinha1-2/+2
Change-Id: I90091e6fe43cebd03ef772ebff2e77007ab57f32

Back to the top