Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-03-20Remove useless non-javadoc see comments. (take 4)I20190329-0120I20190328-1800I20190327-1800I20190326-2305I20190326-1800I20190325-1800I20190325-0105I20190324-1800I20190323-1800I20190322-1800I20190321-1800I20190321-0435I20190321-0245Alexander Kurtakov142-1742/+57
Handled by Override annotation. Change-Id: Ic81aef130640547b3d07fd874f9da197bdbc1644 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-20Remove useless non-javadoc see comments. (take 3)I20190320-1800Alexander Kurtakov126-1577/+41
Handled by Override annotation. Change-Id: Ife58fe4576a16053087be89b91c1042efb0ab0a3 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-20Remove useless non-javadoc see comments. (take 2)Alexander Kurtakov154-2704/+381
Handled by Override annotation. Change-Id: Ia58f7defc807ae5ff37f1ef8a6617d4d8cac2a0a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-20Remove useless non-javadoc see comments.Alexander Kurtakov168-1766/+145
Handled by Override annotation. Change-Id: Icd0334c0b57bb3021693117877a9af5fcda571d7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-19Bug 545330: Problems in javadoc for platformAlexander Kurtakov5-14/+12
Fix platform.debug issues. Change-Id: I90e3cd73e3d4fa187cd2ba567a76e4749bfad8e1 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-03-16Bug 544969 - [console] ConsoleDocumentAdapter.setText does not set textI20190318-1800Paul Pazderski7-8/+315
Change-Id: Ib12b38b964891bb13bd933bb1f9d74fb39421471 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-03-08Bug 545094 - POM and product version change for 4.12 releaseI20190314-1800I20190312-1800I20190312-0340I20190311-1800I20190311-0410I20190309-1830I20190308-1830I20190308-1525I20190308-1055I20190308-0740Niraj Modi12-12/+12
Change-Id: Ic2a42e91bdc21b9d41a4d1036b67a71bdd433eb6 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-03-01Bug 544926 - NPE inY20190320-2200Y20190319-2305Y20190316-1220Y20190313-2200Y20190313-0215Y20190308-0715Y20190307-1015Y20190306-2200S4_11_0_RC2R4_11I20190307-0500I20190306-2135I20190306-1800I20190306-0600I20190305-1800I20190305-0600I20190304-1800I20190304-0600R4_11_maintenanceSarika Sinha1-0/+3
DefaultDetailPane$DetailJob$1.runInUIThread(DefaultDetailPane.java:317) Change-Id: Ic67c7a9431b08fd2bb8cf7c238c3fb5a273d4117
2019-02-18Bug 543933 - Build javadocs with Java 11Y20190227-2200Y20190225-0415Y20190222-0110Y20190220-2200S4_11_0_RC1S4_11_0_M3I20190303-1800I20190303-0600I20190302-1800I20190302-0600I20190301-1800I20190301-0040I20190228-0300I20190227-1800I20190227-0600I20190226-1800I20190226-1020I20190226-0715I20190226-0600I20190225-1800I20190225-0600I20190225-0200I20190224-1800I20190224-0930I20190224-0600I20190223-1800I20190223-0600I20190222-1800I20190222-0645I20190222-0440I20190220-1800I20190220-0600I20190219-1800I20190219-0600I20190218-1800Alexander Kurtakov4-15/+20
After fixing majority of Xdoclint:html issues there are warnings even with Xdoclint:none. Change-Id: I8d4ec9e2b5bfa137526e8bee0d00a3c9fef0eddb Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-18Bug 543933 - Build javadocs with Java 11Alexander Kurtakov1-2/+2
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: Ie338a5e924a45d8d144bd32e22259db29e364591 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-18Bug 544528 - avoid deadlock after failed evaluationJulian Honnen1-6/+1
Moved fPendingValues.notifyAll() into finally block to ensure waiting threads are woken up after uncaught exceptions. Change-Id: Ia8a6c0126a6bf368c389118640edf51a7af7c6b0 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
2019-02-16Bug 543933 - Build javadocs with Java 11I20190218-0600I20190217-1800I20190217-0600I20190216-1800Alexander Kurtakov5-20/+22
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: Ia9710302e4ac410d5724ae0430ee32389132f76b Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-15Bug 543933 - Build javadocs with Java 11I20190216-0600I20190215-1800Alexander Kurtakov14-137/+198
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: I22598ce741b2ced850e6642575460534d7ba6309 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-15Bug 543933 - Build javadocs with Java 11Alexander Kurtakov4-31/+43
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: Ica791208fc04920e9937cd4a929b55872d342856 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-14Bug 543933 - Build javadocs with Java 11I20190215-0630I20190215-0055I20190214-1800Alexander Kurtakov44-573/+689
Fix javadoc warnings catched by Java 11 tool with XDoclint:html. Change-Id: I99061cad4e8a9e3eb18bfc97143fa893715a58f8 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-14Fix incorrect javadoc @params.Alexander Kurtakov2-5/+3
One was not existing, the other one had wrong name. Change-Id: I4c0de14bf5a386c825c4a5512e168d76604b39c0 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-14Remove unused api filters.Alexander Kurtakov5-41/+2
Change-Id: I2e6e9d9373faba9bd394ef4ed55fd0407064beed Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-14Remove duplicate maven version.Alexander Kurtakov1-1/+0
Change-Id: I829555b5500a8533b5f5927e1742d336010e08aa Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-02-12Bug 544400 - Replace usage of StructuredViewer#getSorter()Y20190213-2200Y20190213-0305I20190213-1800Karsten Thoms2-9/+9
Replace by StructuredViewer#getComparator Change-Id: I926b8c2329519b1add153906b772f60535dd79a3 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-02-10Bug 544313 - NPE on workbench close if debug view in foregroundI20190212-1800I20190211-1800I20190210-2135I20190210-1800Andrey Loskutov1-0/+4
Change-Id: I057c371f8280482636a5ffa9f618d2afbaf4b46f Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-01-25Bug 459906 - Add the ability to copy and paste environment variablesY20190208-0505Y20190206-2200Y20190205-0115Y20190201-0030Y20190130-2200Y20190130-0010I20190209-1800I20190208-1800I20190207-1800I20190206-1800I20190205-1800I20190204-1800I20190203-1800I20190202-1800I20190201-1800I20190201-0600I20190131-1800I20190131-0130I20190130-1800I20190129-1800I20190128-1800I20190127-1800I20190126-1800I20190125-1800Jens Reimann5-8/+201
This change adds the functionality of copy & pasting environment variables out of the env-var table view to the clipboard. Change-Id: I312f6966ebbf6b261dd858b4a55b660f86ed3727 Signed-off-by: Jens Reimann <jreimann@redhat.com>
2019-01-25Bug 543832 - NPE in ProcessConsole.getStream()Andrey Loskutov1-6/+6
Reordered stream disposal and disconnecting of listeners, so that listener should not run on disposed streams. Change-Id: I895f580c7eaca746994bd78f31ea82c62bfddffd Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-01-22Bug 543672 - SWT Widget Disposed in variables viewY20190123-2200I20190124-1800I20190124-1235I20190124-0930I20190123-1800I20190122-1800Sarika Sinha1-2/+2
Change-Id: I90091e6fe43cebd03ef772ebff2e77007ab57f32
2019-01-22Bug 334991 - Variables view: Add history with recent expressions to theSarika Sinha3-4/+11
details pane Change-Id: I4535a2c2917cb07db5cb98a6e6bd2a4db83257b9
2019-01-11Bug 538213 - The files in org.eclipse.debug.examples.memory should beY20190116-2200I20190121-1800I20190121-1415I20190120-1800I20190119-1800I20190118-1800I20190117-2335I20190116-1800I20190115-1800I20190114-1800I20190113-1800I20190112-1800I20190111-1800I20190111-0850Sarika Sinha2-3/+3
converted to Unix line delimiter Change-Id: Ie7708e7e3deb43483e677809994b0d75501cd77a
2019-01-11Bug 538213 - The files in org.eclipse.debug.examples.memory should beSarika Sinha14-1430/+1430
converted to Unix line delimiter Change-Id: I15c097e44d4081635a03ab3b61bda68733c64981
2019-01-05Bug 536943 - add method to check if OutputStreamMonitor is doneY20190109-2200Y20190108-0410Y20190108-0135Y20190107-0850Y20190107-0505S4_11_0_M1I20190109-1800I20190109-0655I20190108-1800I20190108-0600I20190107-2050I20190107-1800I20190107-0600I20190106-1800I20190106-0600I20190106-0150I20190105-1800Simeon Andreev1-1/+21
This change adds further functionality to org.eclipse.debug.internal.core.OutputStreamMonitor, which allows checking whether stream reading is done. Change-Id: Icd973a76fee9d1beeedcda988cf7a9c119f9a2b4 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-12-20Bug 542943: Improve performance of DebuggerY20190102-2200Y20181226-2200I20190105-0810I20190104-1800I20190103-1800I20190102-1800I20190101-1800I20181231-1800I20181230-1800I20181229-1800I20181228-1800I20181227-1800I20181226-1800I20181225-1800I20181224-1800I20181223-1800I20181222-1800I20181221-1800I20181220-1800Denis Ungemach1-1/+0
The call to getViewSite().getActionsBars().updateActionBars() is not necessary because setGlobalActions() also executes this call. Change-Id: I90889af76f1997662d10fc8b90f303e05c534c5c Signed-off-by: Denis Ungemach <denis.ungemach@sap.com>
2018-12-20Revert "Bug 536943 - give the reader thread a chance to start reading"Simeon Andreev1-87/+2
This reverts commit f01aa33b2a7155e98055c57f78608525b7e33d15.
2018-12-13Bug 536943 - give the reader thread a chance to start readingY20181219-2200I20181219-1800I20181218-1800I20181218-0120I20181217-1800I20181216-1800I20181215-1800I20181215-0340I20181214-1800I20181214-0720I20181214-0105I20181213-1800Andrey Loskutov1-2/+87
Added a wait in OutputStreamMonitor.getContents(), until stream reading is done or until a timeout of default 10 seconds occurs. If the timeout is reached before stream reading is done, a warning is logged. The timeout can be configured by specifying VM property: -Dorg.eclipse.debug.core.msMaxWaitTimeForStreamMonitorReading=5000 The VM property time unit is milliseconds. The wait ensures that callers of OutputStreamMonitor.getContents() actually see correct stream contents in cases such as accessing contents before the reading has even started, which could cause bug 536943. Change-Id: I7e4af3d06ef528030df5b263b3d664b853f12456 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-12-12Bug 527365 - use IWorkspace.AVOID_UPDATE in all breakpoint operationsAndrey Loskutov3-6/+6
Change-Id: I664a6c564d484b99176b4f513c20e210966a485a Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-12-12Bug 540243 - Bad selection when opening Debug View on breakpointY20181212-2200I20181212-1800Simeon Andreev3-9/+47
When the Debug View is not open and a breakpoint is hit, a preference dictates whether the Debug View is opened. If this preference is used, it is possible to observe a bad selection in the Debug View. E.g. a thread is selected and not a stack frame, or a stack frame and a thread are selected. The problem is seen for Java debug targets, when owned monitors are displayed in the Debug View. When the Debug View debug target element is created, DebugTargetProxy.doInstalled() is called. This will retrieve the first suspended thread and expand it, if such a thread is available. The expand delta contains also the top stack frame at which the thread is suspended. This stack frame is added to the delta with index 0. Unfortunately, owned monitors are displayed before stack frames in the list of thread children. So as soon as the children of the thread are updated for the tree view, a thread owned monitor will replace the selected stack frame. This results in an invalid selection handling, which in turn breaks the selection. This change allows classes which extend DebugTargetProxy to override computation of indices for the launch, debug target and suspended stack frame. A follow-up change in JDT debug will ensure the correct index is computed for the suspended stack frame, one which takes the thread owned monitors into account. Change-Id: Ic8ca2f06a7ea9e47c0322e5d3a62775a0c816652 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-12-07Bug 541822 - POM and product version change for 4.11 releaseI20181212-0230I20181211-1800I20181211-0230I20181210-1800I20181210-0755I20181210-0535Niraj Modi12-13/+13
Change-Id: Ic13c9d1d503e49d1e1ac30968c733b8c650b2495 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2018-12-01Bug 541705 - mute explicitlyClosedAutoCloseable errorsY20181205-2200Y20181204-0315S4_10_0_RC2R4_10I20181206-0815I20181206-0320I20181206-0225I20181206-0030I20181205-1800I20181205-0600I20181204-1800I20181204-0600I20181203-1800I20181203-0600I20181202-1800I20181202-0600I20181201-1800R4_10_maintenanceAndrey Loskutov1-1/+1
Set explicitlyClosedAutoCloseable compiler option to warning level and added suppress warnings annotation to mute new warning. Change-Id: If0ece9a44d976a27f7a70e8729b45f565a4bce21 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-11-14Bug 535339 - All repositories need a NOTICE and LICENSE fileY20181128-2200Y20181121-2200Y20181114-2200S4_10_0_RC1S4_10_0_M3I20181201-0600I20181130-1800I20181129-0330I20181128-1800I20181128-1105I20181128-0810I20181128-0600I20181128-0130I20181127-1800I20181127-0600I20181126-1800I20181126-0940I20181126-0600I20181126-0140I20181125-1800I20181125-0600I20181124-1800I20181124-0600I20181123-1800I20181121-1800I20181121-0910I20181121-0600I20181120-1800I20181120-0600I20181119-2315I20181119-1800I20181119-0600I20181118-1800I20181118-0600I20181117-1800I20181117-0600I20181116-1800I20181115-1800I20181115-0200I20181114-1800I20181114-1345I20181114-1325I20181114-1050Sravan Kumar Lakkimsetti3-26/+371
Change-Id: Ib12fa4f17eb770dc93bfafdad358309bf573833c Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2018-11-08Bug 540850 - Permanent freeze relating to breakpoint updateI20181114-0925I20181114-0355I20181114-0200I20181112-1800I20181112-0435I20181112-0320I20181109-0350I20181108-1800Andrey Loskutov1-5/+10
Do not lock BreakpointManager in the call to enableTriggerPoints() - it will try to acquire workspace lock while modifying markers, and this can deadlock with other threads trying to access BreakpointManager while holding the workspace lock. Instead, lock on fTriggerPointDisabledList instance. Change-Id: I03c9fba2d8ec84dad0f7f1a598cbe8a908c9d94a Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-11-08Bug 540850 - code cleanupAndrey Loskutov1-24/+22
As a preparation for the bigger change, cleaning up some code issues. - made all effectively final fields final - removed printStackTrace() - simplified code inside enableTriggerPoints() Should not affect any existing functionality. Change-Id: Ie1b1df3370833cd8995a1488a3d2e730f32ff0f2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-28[minor] Fix typo in extension point descriptionY20181107-2200Y20181031-2200Y20181030-1100Y20181030-0940I20181107-1800I20181107-0200I20181106-1800I20181106-0125I20181105-1800I20181104-1800I20181103-1800I20181102-2120I20181102-1800I20181101-1800I20181031-1800I20181031-0550I20181031-0540I20181030-1800I20181029-1800I20181028-1800Michael Keppler3-3/+3
Change-Id: I43177cf15e248c9136f60a149c0940a3cc038437 Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2018-10-26Bug 540253 - Debug inactive after switching perspectivesI20181027-1800I20181026-1800Simeon Andreev2-8/+46
The fix for bug 538548 introduces a regression as follows. Switch from Java to Debug perspective, then back to Java perspective. Debug a snippet until a breakpoint is hit. Choose yes when asked whether to switch to the Debug perspective. Observe that debug controls are inactive. This is the case since LaunchView context provider no longer reacts to debug events, after switching to the Java perspective. It misses the breakpoint hit (which also triggers the Debug perspective switch-to confirmation dialog). This change removes the fix for bug 538548 and adds a local fix to SourceLookupService. The added fix prevents an editor popping up in the current perspective under the following conditions: 1. If the Debug View was not open in the current perspective. 2. Preferences to switch to a debug perspective on a breakpoint hit or on launch are set to "never". 3. Preference to activate the Debug View on a breakpoint hit is set to "disabled". Change-Id: Iab575ee2f9a292c23c47c95d23afadc49b8b2dff Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-19Bug 307309 - IOConsoleInputStream.available() should return -1 if sizeY20181026-0120Y20181025-0550Y20181025-0530I20181025-1800I20181024-1800I20181023-1800I20181023-1200I20181023-0800I20181022-2040I20181022-1800I20181021-1800I20181020-1800I20181019-1800Andrey Loskutov1-0/+5
is zero This avioids endless while loop in ProcessConsole.InputReadJob.run(IProgressMonitor) Change-Id: Ied3dc78a2f1b9671e64193a18ead17c9f9f57f08 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-18Bug 540259 - NPE in ProcessConsole$InputReadJob.runI20181019-0450I20181019-0330I20181018-1800Andrey Loskutov1-3/+7
Change-Id: Ib4c5510e95e2d707e9b649c010cc6d16ffe01609 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-18Bug 540242 - SWTException in InternalTreeModelViewer.getDisplayAndrey Loskutov2-13/+11
ElementMementoRequest should not try to call done() on already disposed viewer Change-Id: I09276f7f001a4c1725519183ee1a05d8485c6fb2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-18Bug 491273 - remove copy/pasted getClosestMonitor() implementationAndrey Loskutov2-40/+3
Change-Id: I66ec9cdcde9ea31977ae5b5f77282edcdd22a684 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-10-11Bug 307309 - [console] Some uses of IOConsoleInputStream.available()I20181017-1800Sarika Sinha6-13/+19
throw IOException for no good reason Change-Id: Iaa7ad7e96bb602532ed7af4c02e35911d26a7e3f
2018-09-26Bump versions for 4.10.S4_10_0_M1I20181016-1800I20181015-1800I20181015-0255I20181014-2350I20181014-1800I20181013-1800I20181012-1800I20181010-1800I20181010-0600I20181009-1800I20181009-0600I20181008-1800I20181008-0600I20181007-1800I20181007-0600I20181006-1800I20181006-0600I20181005-1800I20181004-1800I20181003-2215I20181003-1800I20181002-1800I20181002-0205I20181001-1800I20181001-0920I20181001-0235I20180930-1800I20180929-1800I20180928-1800I20180927-1800I20180927-0135I20180927-0040I20180926-1800I20180926-0830Alexander Kurtakov2-2/+2
Change-Id: I699b10c3e18d51d7998c4a940286e3afa59a60bf Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-09-18Bug 453407 - [platform] SIOOBE in IOConsolePartition.insertY20180919-2200I20180925-1800I20180924-1800I20180923-1800I20180922-1800I20180922-0245I20180922-0005I20180921-1800I20180920-1800I20180920-0630I20180920-0430I20180919-1800I20180918-2005I20180918-1800Sarika Sinha1-0/+5
Change-Id: I12e9490497da6a81febbe7c820870ed564ce22de
2018-09-14Bug 355011 - Deadlock on creating console in the build threadI20180914-0620Andrey Loskutov1-16/+61
Do not create console directly in the launchChanged() callback, because the current thread may hold already some lock, and if the ProcessConsole() init requires another one lock, we will have a classic deadlock. In case of bug 355011 current thread owns workspace lock and ProcessConsole() init requires UI lock. Change-Id: Ia01df4cb3f714b16fce84620538e66aa3de10b76 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2018-09-14Bug 537903 - Wrong Debug View due to evaluation on debug context changeSimeon Andreev1-2/+12
Whenever an evaluation runs during thread suspend handling, its possible to create a delta which selects the suspended thread but not its first stack frame. This results due to very specific interleaving of thread running state and code in ThreadEventHandler.fireDeltaUpdatingSelectedFrame(). An evaluation can e.g. be triggered by a job in client code, either with IJavaThread.runEvaluation() or with IJavaObject.sendMessage() methods. No synchronization is possible between those methods and the suspend handling, since such synchronization can block debug event processing and so potentially lead to deadlocks. This change attempts to salvage the situation, after the bad case is encountered. If no top stack frame could be retrieved by ThreadEventHandler.fireDeltaUpdatingSelectedFrame(), but the thread is in suspended state, we query the top stack frame again. In case one evaluation ran in parallel with the suspend handling, at this point we know for sure that the evaluation is done and so the top stack frame is accessible. This change does not help in case client code bombards the thread with evaluations. It also does not help in case an evaluation ran throughout the entire thread suspend handling. Change-Id: I34252c0dac3d031bbbefc3a1328175cab0793ae5 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-09-12Bug 538548 - Debug View in another perspective causes editor to pop-upY20180912-2200I20180913-1800I20180913-0415I20180912-2240Simeon Andreev1-1/+3
If a window has the Debug View open in an inactive perspective, breakpoint hits will cause an editor to open in that window. This hinders the use of multiple windows, each with a different type of perspective. Only windows which have the Debug View in their active perspective should show source on breakpoint hit. The editor is activated due to the Debug View reacting to selection events, which occur due to breakpoint hits. This change ensures that the Debug View will react to selection events only if its active. I.e. only if the active perspective of the window contains the Debug View. Change-Id: Ida92f5322e1a83b95af4bc43f25a9fac9d4519b6 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2018-09-11Bug 538303 - Debug View wrong selection if activated by breakpointI20180912-0225I20180912-0210I20180911-1400Simeon Andreev3-3/+3
If a breakpoint is hit when the Debug View is not active, the Debug View is activated. In some cases, this leads to a bad selection and expanded state. When the Debug View is activated, either by a breakpoint or by a user, a state is saved in ViewerStateTracker. This state is cancelled by TreeModelContentProvider on breakpoint hit, however without removing COLLAPSED delta states. As such, applying the state later on will lead to a collapsed thread, if the state had a collapsed flag for that thread. This "overwrites" a thread selected by suspend handling. This change should ensure that COLLAPSED thread state in ViewerStateTracker is cleared when an expand is handled, regardless if the tree had to be expanded or was expanded already by another operation. Change-Id: I7c43b8317081747c6d8e85020e7040e928c4f39b Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>

Back to the top