diff options
author | Andrey Loskutov | 2017-12-27 17:04:26 +0000 |
---|---|---|
committer | Andrey Loskutov | 2017-12-27 17:04:26 +0000 |
commit | e323d5f8870d7c4788f5812ef6a349abe1ddba52 (patch) | |
tree | 253eadfe82d8d35a08e59c4f8f6fb129a44ccc74 /org.eclipse.ui.console | |
parent | cfe9dc2550cde15a5749582c1f069ad27ee8822a (diff) | |
download | eclipse.platform.debug-e323d5f8870d7c4788f5812ef6a349abe1ddba52.tar.gz eclipse.platform.debug-e323d5f8870d7c4788f5812ef6a349abe1ddba52.tar.xz eclipse.platform.debug-e323d5f8870d7c4788f5812ef6a349abe1ddba52.zip |
Bug 529162 - Don't use empty job names
Change-Id: I62364f847eac31cd6dd1ebd310560e192b1b8288
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Diffstat (limited to 'org.eclipse.ui.console')
3 files changed, 5 insertions, 20 deletions
diff --git a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleDropDownAction.java b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleDropDownAction.java index b510e9996..3d34f1a73 100644 --- a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleDropDownAction.java +++ b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleDropDownAction.java @@ -37,9 +37,6 @@ class ConsoleDropDownAction extends Action implements IMenuCreator, IConsoleList private IConsoleView fView; private Menu fMenu; - /* (non-Javadoc) - * @see org.eclipse.ui.texteditor.IUpdate#update() - */ @Override public void update() { IConsole[] consoles = ConsolePlugin.getDefault().getConsoleManager().getConsoles(); @@ -57,9 +54,6 @@ class ConsoleDropDownAction extends Action implements IMenuCreator, IConsoleList update(); } - /* (non-Javadoc) - * @see org.eclipse.jface.action.IMenuCreator#dispose() - */ @Override public void dispose() { if (fMenu != null) { @@ -70,17 +64,11 @@ class ConsoleDropDownAction extends Action implements IMenuCreator, IConsoleList ConsolePlugin.getDefault().getConsoleManager().removeConsoleListener(this); } - /* (non-Javadoc) - * @see org.eclipse.jface.action.IMenuCreator#getMenu(org.eclipse.swt.widgets.Menu) - */ @Override public Menu getMenu(Menu parent) { return null; } - /* (non-Javadoc) - * @see org.eclipse.jface.action.IMenuCreator#getMenu(org.eclipse.swt.widgets.Control) - */ @Override public Menu getMenu(Control parent) { if (fMenu != null) { @@ -113,9 +101,6 @@ class ConsoleDropDownAction extends Action implements IMenuCreator, IConsoleList item.fill(parent, -1); } - /* (non-Javadoc) - * @see org.eclipse.jface.action.IAction#run() - */ @Override public void run() { ConsoleView consoleView = (ConsoleView) fView; @@ -146,12 +131,9 @@ class ConsoleDropDownAction extends Action implements IMenuCreator, IConsoleList } } - /* (non-Javadoc) - * @see org.eclipse.ui.console.IConsoleListener#consolesAdded(org.eclipse.ui.console.IConsole[]) - */ @Override public void consolesAdded(IConsole[] consoles) { - UIJob job = new UIJob("") { //$NON-NLS-1$ + UIJob job = new UIJob(ConsoleMessages.UpdatingConsoleState) { @Override public IStatus runInUIThread(IProgressMonitor monitor) { update(); @@ -172,7 +154,7 @@ class ConsoleDropDownAction extends Action implements IMenuCreator, IConsoleList */ @Override public void consolesRemoved(IConsole[] consoles) { - UIJob job = new UIJob("") { //$NON-NLS-1$ + UIJob job = new UIJob(ConsoleMessages.UpdatingConsoleState) { @Override public IStatus runInUIThread(IProgressMonitor monitor) { if (fMenu != null) { diff --git a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.java b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.java index 7f3a13e92..6146adb43 100644 --- a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.java +++ b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.java @@ -70,4 +70,6 @@ public class ConsoleMessages extends NLS { public static String PatternMatchListenerExtension_4; public static String PatternMatchListenerExtension_5; + + public static String UpdatingConsoleState; } diff --git a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.properties b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.properties index 6c33fcde2..90644607d 100644 --- a/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.properties +++ b/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleMessages.properties @@ -55,3 +55,4 @@ TextConsolePage_PasteDescrip=Paste PatternMatchListenerExtension_3=Console Pattern Match Listener PatternMatchListenerExtension_4=contributed by PatternMatchListenerExtension_5=is missing required enablement expression and will be removed +UpdatingConsoleState=Updating console state
\ No newline at end of file |