Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2017-10-05 07:48:43 +0000
committerAlexander Kurtakov2017-10-12 07:11:31 +0000
commit6a3333193b51d4f83a3dc442d6db5f28bf9837c7 (patch)
treee1cb176ffe67afad553f95c6c72c37ecd39e5c4d
parentaa4768fe77615b457e4eb3aca5f0dd22b1ed7da2 (diff)
downloadeclipse.platform.debug-6a3333193b51d4f83a3dc442d6db5f28bf9837c7.tar.gz
eclipse.platform.debug-6a3333193b51d4f83a3dc442d6db5f28bf9837c7.tar.xz
eclipse.platform.debug-6a3333193b51d4f83a3dc442d6db5f28bf9837c7.zip
Bug 525596 - Use StringBuilder instead of StringBuffer in
org.eclipse.core.externaltools Change-Id: Ie82e88ed87e670c39b769e28410dd9ea8571bd9c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
-rw-r--r--org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/launchConfigurations/ProgramLaunchDelegate.java4
-rw-r--r--org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/model/BuilderCoreUtils.java2
-rw-r--r--org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/registry/ExternalToolMigration.java2
3 files changed, 4 insertions, 4 deletions
diff --git a/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/launchConfigurations/ProgramLaunchDelegate.java b/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/launchConfigurations/ProgramLaunchDelegate.java
index 0086da7e6..8385553aa 100644
--- a/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/launchConfigurations/ProgramLaunchDelegate.java
+++ b/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/launchConfigurations/ProgramLaunchDelegate.java
@@ -169,11 +169,11 @@ public class ProgramLaunchDelegate extends LaunchConfigurationDelegate {
if (commandLine.length < 1) {
return IExternalToolConstants.EMPTY_STRING;
}
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
for (int i = 0; i < commandLine.length; i++) {
buf.append(' ');
char[] characters = commandLine[i].toCharArray();
- StringBuffer command = new StringBuffer();
+ StringBuilder command = new StringBuilder();
boolean containsSpace = false;
for (int j = 0; j < characters.length; j++) {
char character = characters[j];
diff --git a/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/model/BuilderCoreUtils.java b/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/model/BuilderCoreUtils.java
index fdb756f60..75ad019c0 100644
--- a/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/model/BuilderCoreUtils.java
+++ b/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/model/BuilderCoreUtils.java
@@ -214,7 +214,7 @@ public class BuilderCoreUtils {
args = new HashMap<String, String>();
// Launch configuration builders are stored with a project-relative
// path
- StringBuffer buffer = new StringBuffer(PROJECT_TAG);
+ StringBuilder buffer = new StringBuilder(PROJECT_TAG);
// Append the project-relative path (workspace path minus first
// segment)
buffer.append('/').append(temp.getFile().getFullPath().removeFirstSegments(1));
diff --git a/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/registry/ExternalToolMigration.java b/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/registry/ExternalToolMigration.java
index a1b2fe933..c7887fb02 100644
--- a/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/registry/ExternalToolMigration.java
+++ b/org.eclipse.core.externaltools/src/org/eclipse/core/externaltools/internal/registry/ExternalToolMigration.java
@@ -248,7 +248,7 @@ public final class ExternalToolMigration {
if (arguments != null) {
int start = 0;
ArrayList<String> targets = new ArrayList<String>();
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
VariableDefinition varDef = extractVariableDefinition(arguments, start);
while (varDef.end != -1) {
if ("ant_target".equals(varDef.name) && varDef.argument != null) { //$NON-NLS-1$

Back to the top