Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorptessier2015-01-21 05:01:01 -0500
committerptessier2015-01-21 05:01:01 -0500
commit25a25bc8046b4b81a23667d4f4b34b0e6a8d5de3 (patch)
treeea2a289ec7af65149f2d89556b3383cbf651fbce
parent7369ae5c58c501e7e6509ee571b157e6bb396dda (diff)
downloadorg.eclipse.papyrus-25a25bc8046b4b81a23667d4f4b34b0e6a8d5de3.tar.gz
org.eclipse.papyrus-25a25bc8046b4b81a23667d4f4b34b0e6a8d5de3.tar.xz
org.eclipse.papyrus-25a25bc8046b4b81a23667d4f4b34b0e6a8d5de3.zip
445892: [Sequence Diagram] NPE when Double Clicking on Links tool
https://bugs.eclipse.org/bugs/show_bug.cgi?id=445892 Change-Id: I5d8e6c898ae4e66c495ccbdffc4310fdfc629049
-rw-r--r--plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/layout/LayoutUtils.java4
-rw-r--r--plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/service/AspectUnspecifiedTypeConnectionTool.java2
2 files changed, 3 insertions, 3 deletions
diff --git a/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/layout/LayoutUtils.java b/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/layout/LayoutUtils.java
index 3085d107af4..09c3556f3f5 100644
--- a/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/layout/LayoutUtils.java
+++ b/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/layout/LayoutUtils.java
@@ -238,9 +238,9 @@ public class LayoutUtils {
* an Affixed Child Node
*
* @param sourceEditPart
- * the source EditPart
+ * the source EditPart, it must be a node
* @param targetEditPart
- * the targetEditPart
+ * the targetEditPart, it must be a node
* @return <ul>
* <li>Point[0] is the source Anchor</li>
* <li>Point[1] is the target Anchor</li>
diff --git a/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/service/AspectUnspecifiedTypeConnectionTool.java b/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/service/AspectUnspecifiedTypeConnectionTool.java
index d38e70a2e75..df5562e7fab 100644
--- a/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/service/AspectUnspecifiedTypeConnectionTool.java
+++ b/plugins/uml/diagram/org.eclipse.papyrus.uml.diagram.common/src/org/eclipse/papyrus/uml/diagram/common/service/AspectUnspecifiedTypeConnectionTool.java
@@ -182,7 +182,7 @@ public class AspectUnspecifiedTypeConnectionTool extends UnspecifiedTypeConnecti
}
}
- // do nothing if you have at least one edge element
+ // do nothing if you have at least one edge element, in fact the following lines have been written to take in account only nodes.
if( !(sourceEditPart instanceof NodeEditPart) || !(targetEditPart instanceof NodeEditPart)){
break;
}

Back to the top