From 04f0803b14e6d19a601fd97c7e3115484fd6f9c6 Mon Sep 17 00:00:00 2001 From: ddunne Date: Tue, 8 Mar 2011 20:00:47 -0700 Subject: feature: Coverage - Search Coverage Method hyperlink doesn't have Test_Unit in selection --- .../osee/coverage/action/EditCoverageMethodAction.java | 3 ++- .../osee/coverage/model/CoverageOptionManager.java | 17 +++++++++++++++-- .../util/widget/XHyperlabelCoverageMethodSelection.java | 4 +++- 3 files changed, 20 insertions(+), 4 deletions(-) (limited to 'plugins/org.eclipse.osee.coverage') diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java index 951335cb8b8..e95ba06ac56 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java @@ -18,6 +18,7 @@ import org.eclipse.osee.coverage.editor.xcover.CoverageXViewer; import org.eclipse.osee.coverage.internal.Activator; import org.eclipse.osee.coverage.model.CoverageItem; import org.eclipse.osee.coverage.model.CoverageOption; +import org.eclipse.osee.coverage.model.CoverageOptionManager.EnabledOption; import org.eclipse.osee.coverage.model.ICoverage; import org.eclipse.osee.coverage.util.ISaveable; import org.eclipse.osee.coverage.util.dialog.CoverageMethodListDialog; @@ -78,7 +79,7 @@ public class EditCoverageMethodAction extends Action { } CoverageMethodListDialog dialog = - new CoverageMethodListDialog(coverageXViewer.getCoverageOptionManager().getEnabled()); + new CoverageMethodListDialog(coverageXViewer.getCoverageOptionManager().getEnabled(EnabledOption.Write)); if (dialog.open() == 0) { Set coveragesToSave = new HashSet(); for (ICoverage coverageItem : selectedCoverageEditorItem.getSelectedCoverageEditorItems()) { diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoverageOptionManager.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoverageOptionManager.java index 22de4301d40..f4662ea93e6 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoverageOptionManager.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoverageOptionManager.java @@ -37,6 +37,10 @@ public class CoverageOptionManager { public static CoverageOption Exception_Handling = new CoverageOption("Exception_Handling"); public static CoverageOption Test_Unit = new CoverageOption("Test_Unit"); public static CoverageOption Not_Covered = new CoverageOption("Not_Covered"); + public static enum EnabledOption { + Write, + Read + } public CoverageOptionManager(List options) { this.options = options; @@ -50,10 +54,19 @@ public class CoverageOptionManager { fromXml(xml); } - public Collection getEnabled() { + /** + * Return valid options. If Read, all values returned. This handles the search use case where wouldn't want to set + * values, but would want to search them. If Write, only enabled values are returned. + * + * @param enabledOption + * @return + */ + public Collection getEnabled(EnabledOption enabledOption) { List enabled = new ArrayList(); for (CoverageOption option : options) { - if (option.isEnabled()) { + if (enabledOption == EnabledOption.Read) { + enabled.add(option); + } else if (enabledOption == EnabledOption.Write && option.isEnabled()) { enabled.add(option); } } diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/util/widget/XHyperlabelCoverageMethodSelection.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/util/widget/XHyperlabelCoverageMethodSelection.java index 1d0af83aa14..4a4d77b62db 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/util/widget/XHyperlabelCoverageMethodSelection.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/util/widget/XHyperlabelCoverageMethodSelection.java @@ -14,6 +14,7 @@ import java.util.Collection; import java.util.HashSet; import org.eclipse.osee.coverage.model.CoverageOption; import org.eclipse.osee.coverage.model.CoverageOptionManager; +import org.eclipse.osee.coverage.model.CoverageOptionManager.EnabledOption; import org.eclipse.osee.coverage.util.dialog.CoverageMethodListDialog; import org.eclipse.osee.framework.jdk.core.util.Collections; import org.eclipse.osee.framework.logging.OseeLevel; @@ -65,7 +66,8 @@ public class XHyperlabelCoverageMethodSelection extends XHyperlinkLabelCmdValueS @Override public boolean handleSelection() { try { - dialog = new CoverageMethodListDialog(coverageOptionManager.getEnabled(), selectedCoverageMethods); + dialog = + new CoverageMethodListDialog(coverageOptionManager.getEnabled(EnabledOption.Read), selectedCoverageMethods); int result = dialog.open(); if (result == 0) { selectedCoverageMethods.clear(); -- cgit v1.2.3