diff options
author | ddunne | 2010-05-19 23:10:20 +0000 |
---|---|---|
committer | ddunne | 2010-05-19 23:10:20 +0000 |
commit | 4136f66fd7c350fc5eb12662849f9c9235000449 (patch) | |
tree | f9fe721081e68984485eb702c8d2b8452a75fe33 | |
parent | 8eb5edc26168ca3d69cb7c8e32db5aff002ffc2d (diff) | |
download | org.eclipse.osee-4136f66fd7c350fc5eb12662849f9c9235000449.tar.gz org.eclipse.osee-4136f66fd7c350fc5eb12662849f9c9235000449.tar.xz org.eclipse.osee-4136f66fd7c350fc5eb12662849f9c9235000449.zip |
collection.isEmpty()
124 files changed, 198 insertions, 198 deletions
diff --git a/plugins/org.eclipse.osee.ats.config.demo/src/org/eclipse/osee/ats/config/demo/config/PopulateDemoActions.java b/plugins/org.eclipse.osee.ats.config.demo/src/org/eclipse/osee/ats/config/demo/config/PopulateDemoActions.java index bd628608c56..c8372095169 100644 --- a/plugins/org.eclipse.osee.ats.config.demo/src/org/eclipse/osee/ats/config/demo/config/PopulateDemoActions.java +++ b/plugins/org.eclipse.osee.ats.config.demo/src/org/eclipse/osee/ats/config/demo/config/PopulateDemoActions.java @@ -487,7 +487,7 @@ public class PopulateDemoActions extends XNavigateItemAction { Operations.executeWorkAndCheckStatus(operation, new NullProgressMonitor(), -1);
// Validate that something was imported
- if (systemReq.getChildren().size() == 0) {
+ if (systemReq.getChildren().isEmpty()) {
throw new IllegalStateException("Artifacts were not imported");
}
}
diff --git a/plugins/org.eclipse.osee.ats.test/src/org/eclipse/osee/ats/test/cases/AtsActionableItemToTeamDefinitionTest.java b/plugins/org.eclipse.osee.ats.test/src/org/eclipse/osee/ats/test/cases/AtsActionableItemToTeamDefinitionTest.java index 8d84bbc74e6..eeaa86e5eac 100644 --- a/plugins/org.eclipse.osee.ats.test/src/org/eclipse/osee/ats/test/cases/AtsActionableItemToTeamDefinitionTest.java +++ b/plugins/org.eclipse.osee.ats.test/src/org/eclipse/osee/ats/test/cases/AtsActionableItemToTeamDefinitionTest.java @@ -31,7 +31,7 @@ public class AtsActionableItemToTeamDefinitionTest { AtsUtil.getAtsBranch())) {
ActionableItemArtifact aia = (ActionableItemArtifact) artifact;
if (aia.isActionable()) {
- if (TeamDefinitionArtifact.getImpactedTeamDefs(Arrays.asList(aia)).size() == 0) {
+ if (TeamDefinitionArtifact.getImpactedTeamDefs(Arrays.asList(aia)).isEmpty()) {
sb.append("Actionable Item \"" + aia + "\" has no Team Def associated and is Actionable.");
error = true;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/ConvertActionableItemsAction.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/ConvertActionableItemsAction.java index bfe0b466a8a..e2baa5ec9b9 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/ConvertActionableItemsAction.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/ConvertActionableItemsAction.java @@ -41,7 +41,7 @@ public class ConvertActionableItemsAction extends Action { try { Collection<TeamWorkFlowArtifact> teamArts = Collections.castMatching(TeamWorkFlowArtifact.class, selectedAtsArtifacts.getSelectedSMAArtifacts()); - if (teamArts.size() == 0) { + if (teamArts.isEmpty()) { throw new OseeStateException("No TeamWorkflows selected"); } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/DuplicateWorkflowViaWorldEditorAction.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/DuplicateWorkflowViaWorldEditorAction.java index 9e9b1d63090..9bf9ba67c35 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/DuplicateWorkflowViaWorldEditorAction.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/DuplicateWorkflowViaWorldEditorAction.java @@ -41,7 +41,7 @@ public class DuplicateWorkflowViaWorldEditorAction extends Action { @Override
public void run() {
- if (worldEditor.getWorldComposite().getXViewer().getSelectedTeamWorkflowArtifacts().size() == 0) {
+ if (worldEditor.getWorldComposite().getXViewer().getSelectedTeamWorkflowArtifacts().isEmpty()) {
AWorkbench.popup("ERROR", "Must select one or more team workflows to duplicate");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsTaskEditorSelected.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsTaskEditorSelected.java index deca317a27b..3fbcc429874 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsTaskEditorSelected.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsTaskEditorSelected.java @@ -47,7 +47,7 @@ public class OpenNewAtsTaskEditorSelected extends Action { @Override
public void run() {
try {
- if (openNewAtsTaskEditorSelectedHandler.getSelectedArtifacts().size() == 0) {
+ if (openNewAtsTaskEditorSelectedHandler.getSelectedArtifacts().isEmpty()) {
AWorkbench.popup("ERROR", "Select items to open");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsWorldEditorSelectedAction.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsWorldEditorSelectedAction.java index f18b84cd1ff..6d1f055dd24 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsWorldEditorSelectedAction.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/OpenNewAtsWorldEditorSelectedAction.java @@ -48,7 +48,7 @@ public class OpenNewAtsWorldEditorSelectedAction extends Action { @Override
public void run() {
try {
- if (openNewAtsWorldEditorSelectedHandler.getSelectedArtifacts().size() == 0) {
+ if (openNewAtsWorldEditorSelectedHandler.getSelectedArtifacts().isEmpty()) {
AWorkbench.popup("ERROR", "Select items to open");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewActionPage1.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewActionPage1.java index eba42cc0d49..68c6203268f 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewActionPage1.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewActionPage1.java @@ -177,7 +177,7 @@ public class NewActionPage1 extends WizardPage { @Override
public boolean isPageComplete() {
- if (treeViewer.getChecked().size() == 0) {
+ if (treeViewer.getChecked().isEmpty()) {
return false;
}
try {
@@ -189,7 +189,7 @@ public class NewActionPage1 extends WizardPage { }
Collection<TeamDefinitionArtifact> teamDefs =
TeamDefinitionArtifact.getImpactedTeamDefs(getSelectedActionableItemArtifacts());
- if (teamDefs.size() == 0) {
+ if (teamDefs.isEmpty()) {
AWorkbench.popup("ERROR", "No Teams Associated with selected Actionable Items");
return false;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewNotePage.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewNotePage.java index 22e354eb231..4cec3aea43a 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewNotePage.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/actions/wizard/NewNotePage.java @@ -121,10 +121,10 @@ public class NewNotePage extends WizardPage { if (noteText.get().equals("")) { return false; } - if (typeList.getSelected().size() == 0) { + if (typeList.getSelected().isEmpty()) { return false; } - if (artifactList.getSelected().size() == 0) { + if (artifactList.getSelected().isEmpty()) { return false; } return true; diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSLog.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSLog.java index 454d06e54a0..5aa2451eccd 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSLog.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSLog.java @@ -82,7 +82,7 @@ public class ATSLog { }
public String getHtml(boolean showLog) throws OseeCoreException {
- if (getLogItems().size() == 0) {
+ if (getLogItems().isEmpty()) {
return "";
}
StringBuffer sb = new StringBuffer();
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSNote.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSNote.java index 304b36d5b97..fafc5945f47 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSNote.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ATSNote.java @@ -69,7 +69,7 @@ public class ATSNote { }
NoteItem logItem = new NoteItem(type, state, date.getTime() + "", user, msg);
List<NoteItem> logItems = getNoteItems();
- if (logItems.size() == 0) {
+ if (logItems.isEmpty()) {
logItems = Arrays.asList(logItem);
} else {
logItems.add(logItem);
@@ -167,7 +167,7 @@ public class ATSNote { showNotes.add(li);
}
}
- if (showNotes.size() == 0) {
+ if (showNotes.isEmpty()) {
return "";
}
StringBuilder builder = new StringBuilder();
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ActionArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ActionArtifact.java index b7fda46dcb1..307ea5bc239 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ActionArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ActionArtifact.java @@ -612,7 +612,7 @@ public class ActionArtifact extends ATSArtifact implements IWorldViewArtifact { currentAias.remove(aia);
}
}
- if (currentAias.size() == 0) {
+ if (currentAias.isEmpty()) {
return new Result("Can not remove all actionable items for a team.\n\nActionable Items will go to 0 for [" +
//
team.getTeamName() + "][" + team.getHumanReadableId() + "]\n\nCancel team workflow instead.");
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/GoalArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/GoalArtifact.java index 4f2abeb8556..6b0eb830343 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/GoalArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/GoalArtifact.java @@ -61,7 +61,7 @@ public class GoalArtifact extends StateMachineArtifact { @Override
public StateMachineArtifact getParentSMA() throws OseeCoreException {
List<Artifact> parents = getRelatedArtifacts(AtsRelationTypes.Goal_Goal);
- if (parents.size() == 0) {
+ if (parents.isEmpty()) {
return null;
}
if (parents.size() == 1) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ReviewSMArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ReviewSMArtifact.java index 3e4f8482b7b..78dd5c37830 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ReviewSMArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/ReviewSMArtifact.java @@ -205,7 +205,7 @@ public abstract class ReviewSMArtifact extends TaskableStateMachineArtifact { if (teams.size() > 1) {
OseeLog.log(AtsPlugin.class, Level.SEVERE,
getArtifactTypeName() + " " + getHumanReadableId() + " has multiple parent workflows");
- } else if (!isStandAloneReview() && teams.size() == 0) {
+ } else if (!isStandAloneReview() && teams.isEmpty()) {
OseeLog.log(AtsPlugin.class, Level.SEVERE,
getArtifactTypeName() + " " + getHumanReadableId() + " has no parent workflow");
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/StateMachineArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/StateMachineArtifact.java index 4687ee0079a..cb02c7920e5 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/StateMachineArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/StateMachineArtifact.java @@ -262,7 +262,7 @@ public abstract class StateMachineArtifact extends ATSArtifact implements IGroup }
}
preSaveStateAssignees = getStateMgr().getAssignees();
- if (newAssignees.size() == 0) {
+ if (newAssignees.isEmpty()) {
return;
}
try {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskArtifact.java index 2e4d9f0e1da..71bce193227 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskArtifact.java @@ -286,7 +286,7 @@ public class TaskArtifact extends StateMachineArtifact implements IWorldViewArti if (parentSma != null) return parentSma;
Collection<StateMachineArtifact> smas =
getRelatedArtifacts(AtsRelationTypes.SmaToTask_Sma, StateMachineArtifact.class);
- if (smas.size() == 0) throw new OseeStateException("Task has no parent - " + getHumanReadableId());
+ if (smas.isEmpty()) throw new OseeStateException("Task has no parent - " + getHumanReadableId());
parentSma = smas.iterator().next();
return parentSma;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskableStateMachineArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskableStateMachineArtifact.java index bf6e4bedf16..228d7443b0a 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskableStateMachineArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TaskableStateMachineArtifact.java @@ -103,7 +103,7 @@ public abstract class TaskableStateMachineArtifact extends StateMachineArtifact }
public String getWorldViewNumberOfTasksRemaining() throws OseeCoreException {
- if (getTaskArtifacts().size() == 0) return "";
+ if (getTaskArtifacts().isEmpty()) return "";
return String.valueOf(getNumTasksInWork());
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamDefinitionArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamDefinitionArtifact.java index 8c691a9c83c..9e06de235a0 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamDefinitionArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamDefinitionArtifact.java @@ -392,7 +392,7 @@ public class TeamDefinitionArtifact extends Artifact implements ICommitConfigArt }
}
}
- if (leads.size() == 0) {
+ if (leads.isEmpty()) {
leads.addAll(getLeads());
}
return leads;
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamWorkFlowArtifact.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamWorkFlowArtifact.java index 870e1b9c43c..55edd4ab176 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamWorkFlowArtifact.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/artifact/TeamWorkFlowArtifact.java @@ -292,7 +292,7 @@ public class TeamWorkFlowArtifact extends TaskableStateMachineArtifact implement }
Collection<ActionArtifact> arts =
getRelatedArtifacts(AtsRelationTypes.ActionToWorkflow_Action, ActionArtifact.class);
- if (arts.size() == 0) {
+ if (arts.isEmpty()) {
throw new OseeStateException("Team " + getHumanReadableId() + " has no parent Action");
} else if (arts.size() > 1) {
throw new OseeStateException("Team " + getHumanReadableId() + " has multiple parent Actions");
@@ -310,7 +310,7 @@ public class TeamWorkFlowArtifact extends TaskableStateMachineArtifact implement public String getWorldViewTargetedVersionStr() throws OseeCoreException {
Collection<VersionArtifact> verArts =
getRelatedArtifacts(AtsRelationTypes.TeamWorkflowTargetedForVersion_Version, VersionArtifact.class);
- if (verArts.size() == 0) {
+ if (verArts.isEmpty()) {
return "";
}
if (verArts.size() > 1) {
@@ -407,7 +407,7 @@ public class TeamWorkFlowArtifact extends TaskableStateMachineArtifact implement if (diag.open() != 0) {
return Result.FalseResult;
}
- if (diag.getChecked().size() == 0) {
+ if (diag.getChecked().isEmpty()) {
return new Result("At least one actionable item must must be selected.");
}
if (diag.getChecked().size() > 1) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/config/AtsCacheManager.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/config/AtsCacheManager.java index a3bda83f6c9..5d3cabed567 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/config/AtsCacheManager.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/config/AtsCacheManager.java @@ -76,7 +76,7 @@ public class AtsCacheManager implements IArtifactsPurgedEventListener, IFramewor if (!teamTasksCache.containsKey(sma)) {
Collection<TaskArtifact> taskArtifacts =
sma.getRelatedArtifacts(AtsRelationTypes.SmaToTask_Task, TaskArtifact.class);
- if (taskArtifacts.size() == 0) {
+ if (taskArtifacts.isEmpty()) {
return taskArtifacts;
}
teamTasksCache.put(sma, taskArtifacts);
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAActionableItemHeader.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAActionableItemHeader.java index d8f43028684..85f014f0c1e 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAActionableItemHeader.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAActionableItemHeader.java @@ -91,7 +91,7 @@ public class SMAActionableItemHeader extends Composite implements IFrameworkTran } final TeamWorkFlowArtifact teamWf = (TeamWorkFlowArtifact) sma; if (!sma.isCancelled() && !sma.isCompleted()) { - if (teamWf.getParentActionArtifact().getActionableItems().size() == 0) { + if (teamWf.getParentActionArtifact().getActionableItems().isEmpty()) { label.setText(" " + "Error: No Actionable Items identified."); label.setForeground(Display.getCurrent().getSystemColor(SWT.COLOR_RED)); } else { @@ -110,7 +110,7 @@ public class SMAActionableItemHeader extends Composite implements IFrameworkTran label.update(); layout(); } else { - if (teamWf.getParentActionArtifact().getActionableItems().size() == 0) { + if (teamWf.getParentActionArtifact().getActionableItems().isEmpty()) { label.setText(" " + "Error: No Actionable Items identified."); label.setForeground(Display.getCurrent().getSystemColor(SWT.COLOR_RED)); } else { diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAAssigneesHeader.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAAssigneesHeader.java index 203cb792421..305af2233bf 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAAssigneesHeader.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAAssigneesHeader.java @@ -88,7 +88,7 @@ public class SMAAssigneesHeader extends Composite { private void updateLabel(StateMachineArtifact sma) throws OseeCoreException {
String value = "";
try {
- if (sma.getStateMgr().getAssignees().size() == 0) {
+ if (sma.getStateMgr().getAssignees().isEmpty()) {
value = "Error: State has no assignees";
} else {
valueLabel.setToolTipText(sma.getStateMgr().getAssigneesStr());
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMARelationsHyperlinkComposite.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMARelationsHyperlinkComposite.java index 9ccd7bf4f7f..62dbf6035f6 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMARelationsHyperlinkComposite.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMARelationsHyperlinkComposite.java @@ -135,7 +135,7 @@ public class SMARelationsHyperlinkComposite extends Composite { } private void processReviewArtifact(final ReviewSMArtifact reviewArt) throws OseeCoreException { - if (reviewArt.getActionableItemsDam().getActionableItemGuids().size() == 0) { + if (reviewArt.getActionableItemsDam().getActionableItemGuids().isEmpty()) { return; } actionableItemsLabel = toolkit.createLabel(this, ""); diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAWorkFlowSection.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAWorkFlowSection.java index 2b4e7bc4f57..b73395813ae 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAWorkFlowSection.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/SMAWorkFlowSection.java @@ -469,7 +469,7 @@ public class SMAWorkFlowSection extends SectionPart { return;
}
Collection<User> users = uld.getUsersSelected();
- if (users.size() == 0) {
+ if (users.isEmpty()) {
AWorkbench.popup("ERROR", "Must have at least one assignee");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/widget/ReviewInfoXWidget.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/widget/ReviewInfoXWidget.java index fbe36923dac..b66cd9f6381 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/widget/ReviewInfoXWidget.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/editor/widget/ReviewInfoXWidget.java @@ -101,7 +101,7 @@ public class ReviewInfoXWidget extends XLabelValueBase implements IFrameworkTran try {
addAdminRightClickOption();
Collection<ReviewSMArtifact> revArts = ReviewManager.getReviews(teamArt, forStateName);
- if (revArts.size() == 0) {
+ if (revArts.isEmpty()) {
setValueText("No Reviews Created");
}
@@ -200,7 +200,7 @@ public class ReviewInfoXWidget extends XLabelValueBase implements IFrameworkTran }
public static String toHTML(final TeamWorkFlowArtifact teamArt, String forStateName) throws OseeCoreException {
- if (ReviewManager.getReviews(teamArt, forStateName).size() == 0) {
+ if (ReviewManager.getReviews(teamArt, forStateName).isEmpty()) {
return "";
}
StringBuffer html = new StringBuffer();
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/export/AtsExportPage.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/export/AtsExportPage.java index 861b1f83e2e..e5625224665 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/export/AtsExportPage.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/export/AtsExportPage.java @@ -76,7 +76,7 @@ public class AtsExportPage extends WizardDataTransferPage { composite.setFont(parent.getFont());
Label label = new Label(composite, SWT.NONE);
- if (artifacts.size() == 0) {
+ if (artifacts.isEmpty()) {
label.setText("Error: No ATS Artifacts input. Close wizard and re-perform selection.");
label.setBackground(Display.getCurrent().getSystemColor(SWT.COLOR_RED));
} else {
@@ -118,7 +118,7 @@ public class AtsExportPage extends WizardDataTransferPage { }
public Result isEntryValid() {
- if (artifacts.size() == 0) {
+ if (artifacts.isEmpty()) {
return new Result("No Artifacts selected. Cancel wizard and try again.");
}
if (!selectedExportOptions.contains(ExportOption.AS_HTML_TO_FILE) && !selectedExportOptions.contains(ExportOption.AS_HTML_TO_RESULT_EDITOR) && !selectedExportOptions.contains(ExportOption.AS_PDF)) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/health/ValidateAtsDatabase.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/health/ValidateAtsDatabase.java index f40880d3da1..2f9685ec561 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/health/ValidateAtsDatabase.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/health/ValidateAtsDatabase.java @@ -299,7 +299,7 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { if (art instanceof TeamWorkFlowArtifact) {
TeamWorkFlowArtifact teamArt = (TeamWorkFlowArtifact) art;
try {
- if (teamArt.getActionableItemsDam().getActionableItems().size() == 0) {
+ if (teamArt.getActionableItemsDam().getActionableItems().isEmpty()) {
testNameToResultsMap.put("testTeamWorkflows",
"Error: TeamWorkflow " + XResultData.getHyperlink(teamArt) + " has 0 ActionableItems");
}
@@ -348,7 +348,7 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { xResultData.log(monitor, "testLoadAllCommonArtifactIds - Started " + XDate.getDateNow(XDate.MMDDYYHHMM));
List<Integer> artIds = ArtifactQuery.selectArtifactListFromBranch(AtsUtil.getAtsBranch(), false);
- if (artIds.size() == 0) {
+ if (artIds.isEmpty()) {
xResultData.logError("Error: Artifact load returned 0 artifacts to check");
}
xResultData.log(monitor, "testLoadAllCommonArtifactIds - Completed " + XDate.getDateNow(XDate.MMDDYYHHMM));
@@ -466,7 +466,7 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { private void testAtsActionsHaveTeamWorkflow(Collection<Artifact> artifacts) throws OseeCoreException {
for (Artifact artifact : artifacts) {
if (artifact instanceof ActionArtifact) {
- if (((ActionArtifact) artifact).getTeamWorkFlowArtifacts().size() == 0) {
+ if (((ActionArtifact) artifact).getTeamWorkFlowArtifacts().isEmpty()) {
testNameToResultsMap.put("testAtsActionsHaveTeamWorkflow",
"Error: Action " + XResultData.getHyperlink(artifact) + " has no Team Workflows\n");
}
@@ -550,7 +550,7 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { if (artifact instanceof ActionableItemArtifact) {
ActionableItemArtifact aia = (ActionableItemArtifact) artifact;
if (aia.isActionable()) {
- if (TeamDefinitionArtifact.getImpactedTeamDefs(Arrays.asList(aia)).size() == 0) {
+ if (TeamDefinitionArtifact.getImpactedTeamDefs(Arrays.asList(aia)).isEmpty()) {
testNameToResultsMap.put(
"testActionableItemToTeamDefinition",
"Error: ActionableItem " + XResultData.getHyperlink(artifact.getName(), artifact) + " has to related TeamDefinition and is set to Actionable");
@@ -578,12 +578,12 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { if (artifact instanceof ReviewSMArtifact) {
ReviewSMArtifact reviewArtifact = (ReviewSMArtifact) artifact;
try {
- if (reviewArtifact.getAttributes(ATSAttributes.REVIEW_DEFECT_ATTRIBUTE.getStoreName()).size() > 0 && reviewArtifact.getDefectManager().getDefectItems().size() == 0) {
+ if (reviewArtifact.getAttributes(ATSAttributes.REVIEW_DEFECT_ATTRIBUTE.getStoreName()).size() > 0 && reviewArtifact.getDefectManager().getDefectItems().isEmpty()) {
testNameToResultsMap.put(
"testReviewsHaveValidDefectAndRoleXml",
"Error: Review " + XResultData.getHyperlink(reviewArtifact) + " has defect attribute, but no defects (xml parsing error).");
}
- if (reviewArtifact.getAttributes(ATSAttributes.ROLE_ATTRIBUTE.getStoreName()).size() > 0 && reviewArtifact.getUserRoleManager().getUserRoles().size() == 0) {
+ if (reviewArtifact.getAttributes(ATSAttributes.ROLE_ATTRIBUTE.getStoreName()).size() > 0 && reviewArtifact.getUserRoleManager().getUserRoles().isEmpty()) {
testNameToResultsMap.put(
"testReviewsHaveValidDefectAndRoleXml",
"Error: Review " + XResultData.getHyperlink(reviewArtifact) + " has role attribute, but no roles (xml parsing error).");
@@ -601,7 +601,7 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { for (Artifact artifact : artifacts) {
if (artifact instanceof ReviewSMArtifact) {
ReviewSMArtifact reviewArtifact = (ReviewSMArtifact) artifact;
- if (reviewArtifact.getRelatedArtifacts(AtsRelationTypes.TeamWorkflowToReview_Team).size() == 0 && reviewArtifact.getActionableItemsDam().getActionableItemGuids().size() == 0) {
+ if (reviewArtifact.getRelatedArtifacts(AtsRelationTypes.TeamWorkflowToReview_Team).isEmpty() && reviewArtifact.getActionableItemsDam().getActionableItemGuids().isEmpty()) {
testNameToResultsMap.put(
"testReviewsHaveParentWorkflowOrActionableItems",
"Error: Review " + XResultData.getHyperlink(reviewArtifact) + " has 0 related parents and 0 actionable items.");
@@ -708,7 +708,7 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { "testStateMachineAssignees",
"Error: " + art.getHumanReadableId() + " is assigned to OseeSystem; invalid assignment - MANUAL FIX REQUIRED");
}
- if (!sma.isCompleted() && !sma.isCancelled() && sma.getStateMgr().getAssignees().size() == 0) {
+ if (!sma.isCompleted() && !sma.isCancelled() && sma.getStateMgr().getAssignees().isEmpty()) {
testNameToResultsMap.put(
"testStateMachineAssignees",
"Error: " + sma.getArtifactTypeName() + " " + XResultData.getHyperlink(sma) + " In Work without assignees");
@@ -729,7 +729,7 @@ public class ValidateAtsDatabase extends WorldXNavigateItemAction { }
} else if (sma.getStateMgr().getAssignees().size() != relationAssigned.size()) {
// Make sure this isn't just an UnAssigned user issue (don't relate to unassigned user anymore)
- if (!(sma.getStateMgr().getAssignees().contains(UserManager.getUser(SystemUser.UnAssigned)) && relationAssigned.size() == 0)) {
+ if (!(sma.getStateMgr().getAssignees().contains(UserManager.getUser(SystemUser.UnAssigned)) && relationAssigned.isEmpty())) {
testNameToResultsMap.put(
"testStateMachineAssignees",
"Error: " + sma.getArtifactTypeName() + " " + XResultData.getHyperlink(sma) + " attribute assignees doesn't match related assignees");
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/ArtifactHyperView.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/ArtifactHyperView.java index 5f229725e1d..f7d9246060c 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/ArtifactHyperView.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/ArtifactHyperView.java @@ -268,7 +268,7 @@ public class ArtifactHyperView extends HyperView implements IFrameworkTransactio try {
Collection<Artifact> arts =
ArtifactQuery.getArtifactListFromIds(Arrays.asList(hridGuid), BranchManager.getCommonBranch());
- if (arts.size() == 0) {
+ if (arts.isEmpty()) {
AWorkbench.popup("ERROR", "No Artifacts Found");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/HyperView.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/HyperView.java index dd0038b9fd3..94d85fa7578 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/HyperView.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/hyper/HyperView.java @@ -425,7 +425,7 @@ public class HyperView extends ViewPart implements IPartListener { if (HyperView.debugOn) {
System.out.println("drawNodes");
}
- if (hvis.size() == 0) {
+ if (hvis.isEmpty()) {
return;
}
final boolean isRight = relType == RelationEnum.RIGHT;
@@ -927,7 +927,7 @@ public class HyperView extends ViewPart implements IPartListener { @Override
public void run() {
printBackList("pre backSelected");
- if (backList.size() == 0) {
+ if (backList.isEmpty()) {
return;
}
if (backListIndex > 0) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/ArtifactImpactToActionSearchItem.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/ArtifactImpactToActionSearchItem.java index be5f96b06a3..7d78d212dc1 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/ArtifactImpactToActionSearchItem.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/ArtifactImpactToActionSearchItem.java @@ -96,7 +96,7 @@ public class ArtifactImpactToActionSearchItem extends XNavigateItemAction { final Collection<Artifact> srchArts =
ArtifactQuery.getArtifactListFromName("%" + artifactName + "%", branch, true);
final Set<Artifact> processArts = new HashSet<Artifact>();
- if (srchArts.size() == 0) {
+ if (srchArts.isEmpty()) {
return;
}
if (srchArts.size() > 1) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/EmailTeamsItem.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/EmailTeamsItem.java index 1efda92b319..ca34af36f01 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/EmailTeamsItem.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/EmailTeamsItem.java @@ -57,7 +57,7 @@ public class EmailTeamsItem extends XNavigateItemAction { @Override public void run(TableLoadOption... tableLoadOptions) throws OseeCoreException { Collection<TeamDefinitionArtifact> teamDefs = getTeamDefinitions(); - if (teamDefs.size() == 0) return; + if (teamDefs.isEmpty()) return; Set<String> emails = new HashSet<String>(); for (TeamDefinitionArtifact teamDef : teamDefs) { if (memberTypes.contains(MemberType.Members) || memberTypes.contains(MemberType.Both)) { @@ -69,7 +69,7 @@ public class EmailTeamsItem extends XNavigateItemAction { if (!user.getEmail().equals("")) emails.add(user.getEmail()); } } - if (emails.size() == 0) { + if (emails.isEmpty()) { AWorkbench.popup("Error", "No emails configured."); return; } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/TeamWorkflowSearchWorkflowSearchItem.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/TeamWorkflowSearchWorkflowSearchItem.java index d0f77f6a880..6da2b02691e 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/TeamWorkflowSearchWorkflowSearchItem.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/TeamWorkflowSearchWorkflowSearchItem.java @@ -172,7 +172,7 @@ public class TeamWorkflowSearchWorkflowSearchItem extends WorldEditorParameterSe if (versionCombo != null) {
try {
Collection<TeamDefinitionArtifact> teamDefArts = getSelectedTeamDefinitions();
- if (teamDefArts.size() == 0) {
+ if (teamDefArts.isEmpty()) {
versionCombo.setDataStrings(new String[] {});
return;
}
@@ -184,7 +184,7 @@ public class TeamWorkflowSearchWorkflowSearchItem extends WorldEditorParameterSe }
Collection<String> names =
Artifacts.artNames(teamDefHoldingVersions.getVersionsArtifacts(VersionReleaseType.Both));
- if (names.size() == 0) {
+ if (names.isEmpty()) {
versionCombo.setDataStrings(new String[] {});
return;
}
@@ -305,7 +305,7 @@ public class TeamWorkflowSearchWorkflowSearchItem extends WorldEditorParameterSe if (user != null && includeCompleted) {
return new Result("Assignee and Include Completed are not compatible selections.");
}
- if (user != null && includeCompleted && verArt == null && teamDefs.size() == 0) {
+ if (user != null && includeCompleted && verArt == null && teamDefs.isEmpty()) {
return new Result("You must select at least Team or Version with Include Completed.");
}
return Result.TrueResult;
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/UserSearchWorkflowSearchItem.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/UserSearchWorkflowSearchItem.java index 0575493516b..4bd6adb8308 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/UserSearchWorkflowSearchItem.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/navigate/UserSearchWorkflowSearchItem.java @@ -208,7 +208,7 @@ public class UserSearchWorkflowSearchItem extends WorldEditorParameterSearchItem if (versionCombo != null) {
try {
Collection<TeamDefinitionArtifact> teamDefArts = getSelectedTeamDefinitions();
- if (teamDefArts.size() == 0) {
+ if (teamDefArts.isEmpty()) {
versionCombo.setDataStrings(new String[] {});
return;
}
@@ -220,7 +220,7 @@ public class UserSearchWorkflowSearchItem extends WorldEditorParameterSearchItem }
Collection<String> names =
Artifacts.artNames(teamDefHoldingVersions.getVersionsArtifacts(VersionReleaseType.Both));
- if (names.size() == 0) {
+ if (names.isEmpty()) {
versionCombo.setDataStrings(new String[] {});
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/notify/AtsNotificationNavigateItem.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/notify/AtsNotificationNavigateItem.java index 93a1b24a4c8..70edee92b70 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/notify/AtsNotificationNavigateItem.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/notify/AtsNotificationNavigateItem.java @@ -49,7 +49,7 @@ public class AtsNotificationNavigateItem extends XNavigateItemAction { AtsNotificationCheckTreeDialog diag = new AtsNotificationCheckTreeDialog(); if (diag.open() == 0) { - if (diag.getSelectedAtsNotifications().size() == 0) { + if (diag.getSelectedAtsNotifications().isEmpty()) { AWorkbench.popup("Error", "No Notifications Selected"); return; } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CancelMultipleWorkflows.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CancelMultipleWorkflows.java index 2d13da0162b..29ad16785ed 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CancelMultipleWorkflows.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CancelMultipleWorkflows.java @@ -45,7 +45,7 @@ public class CancelMultipleWorkflows extends Action { public void run() { try { Collection<StateMachineArtifact> smas = worldEditor.getWorldComposite().getXViewer().getSelectedSMAArtifacts(); - if (smas.size() == 0) { + if (smas.isEmpty()) { AWorkbench.popup("ERROR", "Must select one or more workflows"); return; } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CompleteMultipleWorkflows.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CompleteMultipleWorkflows.java index ea52a7c3f21..50cff53807e 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CompleteMultipleWorkflows.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/CompleteMultipleWorkflows.java @@ -46,7 +46,7 @@ public class CompleteMultipleWorkflows extends Action { public void run() {
try {
Collection<StateMachineArtifact> smas = worldEditor.getWorldComposite().getXViewer().getSelectedSMAArtifacts();
- if (smas.size() == 0) {
+ if (smas.isEmpty()) {
AWorkbench.popup("ERROR", "Must select one or more workflows");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/DuplicateWorkflowBlam.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/DuplicateWorkflowBlam.java index 9b4055692a8..51931ce1700 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/DuplicateWorkflowBlam.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/DuplicateWorkflowBlam.java @@ -76,7 +76,7 @@ public class DuplicateWorkflowBlam extends AbstractBlam { boolean duplicateWorkflow = variableMap.getString(DUPLICATE_METHOD).equals(DUPLICATE_WORKFLOW); String title = variableMap.getString(TITLE); - if (artifacts.size() == 0) { + if (artifacts.isEmpty()) { AWorkbench.popup("ERROR", "Must drag in Team Workflow to duplicate."); return; } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSimpleList.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSimpleList.java index 063652c471b..ca51f43d574 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSimpleList.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSimpleList.java @@ -64,7 +64,7 @@ public class ImportTasksFromSimpleList extends AbstractBlam { if (!title.equals("")) titles.add(title); } - if (artifacts.size() == 0) { + if (artifacts.isEmpty()) { AWorkbench.popup("ERROR", "Must drag in Team Workflow to add tasks."); return; } @@ -77,7 +77,7 @@ public class ImportTasksFromSimpleList extends AbstractBlam { AWorkbench.popup("ERROR", "Artifact MUST be Team Workflow"); return; } - if (titles == null || titles.size() == 0) { + if (titles == null || titles.isEmpty()) { AWorkbench.popup("ERROR", "Must enter title(s)."); return; } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSpreadsheet.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSpreadsheet.java index b7497fafe77..ff762703c3d 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSpreadsheet.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ImportTasksFromSpreadsheet.java @@ -101,7 +101,7 @@ public class ImportTasksFromSpreadsheet extends AbstractBlam { String filename = variableMap.getString(TASK_IMPORT_SPREADSHEET);
boolean emailPocs = variableMap.getBoolean(EMAIL_POCS);
- if (artifacts.size() == 0) {
+ if (artifacts.isEmpty()) {
AWorkbench.popup("ERROR", "Must drag in Team Workflow to add tasks.");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ReAssignATSObjectsToUser.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ReAssignATSObjectsToUser.java index 6d2c301a1c9..9eff4b12b9e 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ReAssignATSObjectsToUser.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/operation/ReAssignATSObjectsToUser.java @@ -72,7 +72,7 @@ public class ReAssignATSObjectsToUser extends AbstractBlam { atsArts.add(assignedArt); } } - if (atsArts.size() == 0) { + if (atsArts.isEmpty()) { AWorkbench.popup("ERROR", "Not workflows, tasks or reviews assigned to " + fromUser); return; } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/CreateActionArtifactChangeReportJob.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/CreateActionArtifactChangeReportJob.java index 9e3d85e646b..88fce97b488 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/CreateActionArtifactChangeReportJob.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/CreateActionArtifactChangeReportJob.java @@ -61,7 +61,7 @@ public class CreateActionArtifactChangeReportJob extends Job { public static IStatus runIt(IProgressMonitor monitor, String jobName, Collection<TeamWorkFlowArtifact> teamArts, String byAttribute) {
XResultData rd = new XResultData();
try {
- if (teamArts.size() == 0)
+ if (teamArts.isEmpty())
throw new OseeStateException("No Actions/Workflows Specified");
retrieveData(monitor, teamArts, byAttribute, rd);
if (rd.toString().equals(""))
@@ -123,7 +123,7 @@ public class CreateActionArtifactChangeReportJob extends Job { ChangeData changeData = teamArt.getBranchMgr().getChangeData(commitConfigArt);
for (Artifact modArt : changeData.getArtifacts(KindType.Artifact, ModificationType.NEW, ModificationType.MODIFIED)) {
List<String> attrStrs = modArt.getAttributesToStringList(byAttribute);
- if (attrStrs.size() == 0)
+ if (attrStrs.isEmpty())
attrStrs.add(EnumeratedAttribute.UNSPECIFIED_VALUE);
for (String attrStr : attrStrs)
rd.addRaw(AHTML.addRowMultiColumnTable(new String[] {teamArt.getHumanReadableId(), buildId,
@@ -131,7 +131,7 @@ public class CreateActionArtifactChangeReportJob extends Job { }
for (Artifact artChg : changeData.getArtifacts(KindType.Artifact, ModificationType.DELETED)) {
List<String> attrStrs = artChg.getAttributesToStringList(byAttribute);
- if (attrStrs.size() == 0)
+ if (attrStrs.isEmpty())
attrStrs.add(EnumeratedAttribute.UNSPECIFIED_VALUE);
for (String attrStr : attrStrs)
rd.addRaw(AHTML.addRowMultiColumnTable(new String[] {teamArt.getHumanReadableId(), buildId,
@@ -140,7 +140,7 @@ public class CreateActionArtifactChangeReportJob extends Job { for (Artifact artChg : changeData.getArtifacts(KindType.RelationOnly, ModificationType.NEW,
ModificationType.MODIFIED)) {
List<String> attrStrs = artChg.getAttributesToStringList(byAttribute);
- if (attrStrs.size() == 0)
+ if (attrStrs.isEmpty())
attrStrs.add(EnumeratedAttribute.UNSPECIFIED_VALUE);
for (String attrStr : attrStrs)
rd.addRaw(AHTML.addRowMultiColumnTable(new String[] {teamArt.getHumanReadableId(), buildId,
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/ExtendedStatusReportJob.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/ExtendedStatusReportJob.java index 13b91671bd1..710f40fbbb9 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/ExtendedStatusReportJob.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/report/ExtendedStatusReportJob.java @@ -53,7 +53,7 @@ public class ExtendedStatusReportJob extends Job { } public static IStatus runIt(IProgressMonitor monitor, final String jobName, Collection<? extends Artifact> teamArts) { - if (teamArts.size() == 0) { + if (teamArts.isEmpty()) { OseeLog.log(AtsPlugin.class, Level.SEVERE, "No Artifacts Returned"); return new Status(Status.ERROR, AtsPlugin.PLUGIN_ID, -1, "No Artifacts Returned", null); } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskComposite.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskComposite.java index e88b2d396f6..145e4e04a93 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskComposite.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskComposite.java @@ -150,7 +150,7 @@ public class TaskComposite extends Composite implements IOpenNewAtsTaskEditorSel public void handleDeleteTask() {
final ArrayList<TaskArtifact> items = getSelectedTaskArtifactItems();
- if (items.size() == 0) {
+ if (items.isEmpty()) {
AWorkbench.popup("ERROR", "No Tasks Selected");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskEditor.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskEditor.java index 7f687d23628..bc00fbfb547 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskEditor.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/task/TaskEditor.java @@ -283,7 +283,7 @@ public class TaskEditor extends AbstractArtifactEditor implements IDirtiableEdit public void run() {
try {
taskEditor.setPartName(itaskEditorProvider.getTaskEditorLabel(searchType));
- if (taskArts.size() == 0) {
+ if (taskArts.isEmpty()) {
taskEditor.setTableTitle(
"No Results Found - " + itaskEditorProvider.getTaskEditorLabel(searchType), true);
} else {
@@ -361,7 +361,7 @@ public class TaskEditor extends AbstractArtifactEditor implements IDirtiableEdit @Override
public double getManHoursPerDayPreference() throws OseeCoreException {
- if (tasks.size() == 0) return StateMachineArtifact.DEFAULT_HOURS_PER_WORK_DAY;
+ if (tasks.isEmpty()) return StateMachineArtifact.DEFAULT_HOURS_PER_WORK_DAY;
return tasks.iterator().next().getManHrsPerDayPreference();
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/AtsBranchManager.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/AtsBranchManager.java index 9851c7c3ebf..2ac0b2b9093 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/AtsBranchManager.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/AtsBranchManager.java @@ -485,7 +485,7 @@ public class AtsBranchManager { List<Branch> branches = BranchManager.getBranches(branchFilter);
- if (branches.size() == 0) {
+ if (branches.isEmpty()) {
return null;
} else if (branches.size() > 1) {
throw new MultipleBranchesExist(
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/DoesNotWorkItemAts.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/DoesNotWorkItemAts.java index 90ce804ce39..f3246a86c48 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/DoesNotWorkItemAts.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/DoesNotWorkItemAts.java @@ -513,7 +513,7 @@ public class DoesNotWorkItemAts extends XNavigateItemAction { //
// // Get all customizations
// List<String> customizations = user.getAttributesToStringList("XViewer Customization");
- // if (customizations.size() == 0 && custDefaults.size() == 0) continue;
+ // if (customizations.isEmpty() && custDefaults.isEmpty()) continue;
// Set<String> validGuids = new HashSet<String>();
// int currNumDefaults = custDefaults.getGuids().size();
// for (String custStr : new CopyOnWriteArrayList<String>(customizations)) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Import/ExcelAtsActionArtifactExtractor.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Import/ExcelAtsActionArtifactExtractor.java index 6ce3aa34acf..cb27be3fe28 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Import/ExcelAtsActionArtifactExtractor.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Import/ExcelAtsActionArtifactExtractor.java @@ -67,7 +67,7 @@ public class ExcelAtsActionArtifactExtractor { if (aData.title.equals("")) {
rd.logError("Row " + rowNum + "; Invalid Title");
}
- if (aData.actionableItems.size() == 0) {
+ if (aData.actionableItems.isEmpty()) {
rd.logError("Row " + rowNum + ": Must have at least one ActionableItem defined");
} else {
for (String actionableItemName : aData.actionableItems) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Overview.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Overview.java index e659ea2ab8d..5c04a7f11ee 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Overview.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/Overview.java @@ -213,7 +213,7 @@ public class Overview { public void addRelationTable(String name, IRelationEnumeration side, Artifact parent) {
try {
List<Artifact> arts = parent.getRelatedArtifacts(side);
- if (arts.size() == 0) {
+ if (arts.isEmpty()) {
return;
}
startBorderTable(false, name);
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/PromptChangeUtil.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/PromptChangeUtil.java index 394f7dc968c..f12cbd6ccc3 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/PromptChangeUtil.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/PromptChangeUtil.java @@ -128,7 +128,7 @@ public class PromptChangeUtil { return false;
}
Collection<User> users = uld.getUsersSelected();
- if (users.size() == 0) {
+ if (users.isEmpty()) {
AWorkbench.popup("ERROR", "Must have at least one assignee");
return false;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/SMAMetrics.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/SMAMetrics.java index f03e19cbf71..7aae34505dc 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/SMAMetrics.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/SMAMetrics.java @@ -65,7 +65,7 @@ public class SMAMetrics { this.manHoursPerDay = manHoursPerDay;
this.versionArtifact = versionArtifact;
this.estimatedReleaseDate = estimatedReleaseDate;
- if (artifacts.size() == 0) return;
+ if (artifacts.isEmpty()) return;
Set<Artifact> resolvedArts = new HashSet<Artifact>(artifacts);
for (Artifact art : artifacts) {
if (art instanceof GoalArtifact) {
@@ -196,14 +196,14 @@ public class SMAMetrics { }
public double getPercentCompleteByTeamWorkflow() throws OseeCoreException {
- if (getTeamArts().size() == 0) return 0;
+ if (getTeamArts().isEmpty()) return 0;
double completed = getCompletedTeamWorkflows().size();
if (completed == 0) return 0;
return completed / getTeamArts().size() * 100;
}
public double getPercentCompleteByWorkflow() throws OseeCoreException {
- if (smas.size() == 0) return 0;
+ if (smas.isEmpty()) return 0;
double completed = getCompletedWorkflows().size();
if (completed == 0) return 0;
return completed / smas.size() * 100;
@@ -220,7 +220,7 @@ public class SMAMetrics { }
public double getPercentCompleteByTaskWorkflow() throws OseeCoreException {
- if (getTaskArts().size() == 0) return 0;
+ if (getTaskArts().isEmpty()) return 0;
double completed = getCompletedTaskWorkflows().size();
if (completed == 0) return 0;
return completed / getTaskArts().size() * 100;
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/DecisionOption.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/DecisionOption.java index 0a7afe6fbdf..1743df150e0 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/DecisionOption.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/DecisionOption.java @@ -151,7 +151,7 @@ public class DecisionOption { OseeLog.log(AtsPlugin.class, Level.SEVERE, ex);
}
}
- if (followupRequired && assignees.size() == 0)
+ if (followupRequired && assignees.isEmpty())
return new Result("If followup is specified, must set assignees.\nShould be: <userid><userid>");
else if (!followupRequired && assignees.size() > 0)
return new Result("If completed is specified, don't specify assigness. Leave blank.\n");
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/DefectManager.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/DefectManager.java index 412b034d09a..44010fb0a7b 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/DefectManager.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/DefectManager.java @@ -55,7 +55,7 @@ public class DefectManager { }
public String getHtml() throws OseeCoreException {
- if (getDefectItems().size() == 0) {
+ if (getDefectItems().isEmpty()) {
return "";
}
StringBuffer sb = new StringBuffer();
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/XDefectViewer.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/XDefectViewer.java index 2c8161bef75..cf744709f9e 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/XDefectViewer.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/defect/XDefectViewer.java @@ -347,7 +347,7 @@ public class XDefectViewer extends XWidget implements IArtifactWidget, IFramewor public void handleDeleteDefect(boolean persist) {
final List<DefectItem> items = getSelectedDefectItems();
- if (items.size() == 0) {
+ if (items.isEmpty()) {
AWorkbench.popup("ERROR", "No Defects Selected");
return;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/ActionTeamVersionListDialog.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/ActionTeamVersionListDialog.java index d62e74b0613..176827df2b0 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/ActionTeamVersionListDialog.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/ActionTeamVersionListDialog.java @@ -84,7 +84,7 @@ public class ActionTeamVersionListDialog extends ActionTeamListDialog { } public void widgetSelected(SelectionEvent e) { - if (versionList.getSelected().size() == 0) + if (versionList.getSelected().isEmpty()) selectedVersion = null; else selectedVersion = (VersionArtifact) versionList.getSelected().iterator().next(); diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/TaskResolutionOptionRule.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/TaskResolutionOptionRule.java index 1d7a306d1b0..fe52f25d807 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/TaskResolutionOptionRule.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/dialog/TaskResolutionOptionRule.java @@ -53,7 +53,7 @@ public class TaskResolutionOptionRule extends WorkRuleDefinition { public static TaskResolutionOptionRule getTaskResolutionOptionRule(WorkPageDefinition workPageDefinition) throws OseeCoreException { List<WorkItemDefinition> wids = workPageDefinition.getWorkItemDefinitionsByType(TaskResolutionOptionRule.WORK_TYPE); - if (wids.size() == 0) return null; + if (wids.isEmpty()) return null; WorkItemDefinition workItemDefinition = wids.iterator().next(); if (workItemDefinition != null) { TaskResolutionOptionRule taskResolutionOptionRule = new TaskResolutionOptionRule(null, GUID.create(), null); diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/UserRoleManager.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/UserRoleManager.java index 442942976d0..ad645c4467b 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/UserRoleManager.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/UserRoleManager.java @@ -47,7 +47,7 @@ public class UserRoleManager { }
public String getHtml() throws OseeCoreException {
- if (getUserRoles().size() == 0) return "";
+ if (getUserRoles().isEmpty()) return "";
StringBuffer sb = new StringBuffer();
sb.append(AHTML.addSpace(1) + AHTML.getLabelStr(AHTML.LABEL_FONT, "Defects"));
sb.append(getTable());
@@ -144,7 +144,7 @@ public class UserRoleManager { if (!uRole.isCompleted() && uRole.getUser() != null) assignees.add(uRole.getUser());
}
// If roles are all completed, then still need to select a user to assign to SMA
- if (assignees.size() == 0) {
+ if (assignees.isEmpty()) {
if (getUserRoles(Role.Author).size() > 0)
for (UserRole role : getUserRoles(Role.Author))
assignees.add(role.getUser());
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/XUserRoleViewer.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/XUserRoleViewer.java index b46aff73734..01c3600c045 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/XUserRoleViewer.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/util/widgets/role/XUserRoleViewer.java @@ -211,7 +211,7 @@ public class XUserRoleViewer extends XWidget implements IArtifactWidget, IFramew public void handleDeleteUserRole(boolean persist) { final List<UserRole> items = getSelectedUserRoleItems(); - if (items.size() == 0) { + if (items.isEmpty()) { AWorkbench.popup("ERROR", "No Roles Selected"); return; } diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/editor/model/WorkflowDiagram.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/editor/model/WorkflowDiagram.java index 1684c7e0803..9a7ed5c0a26 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/editor/model/WorkflowDiagram.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/editor/model/WorkflowDiagram.java @@ -200,7 +200,7 @@ public class WorkflowDiagram extends ModelElement { // Validate transitions (each state must have a transition to or from
for (Shape shape : getChildren()) {
if (WorkPageShape.class.isAssignableFrom(shape.getClass())) {
- if (shape.getSourceConnections().size() == 0 && shape.getTargetConnections().size() == 0) {
+ if (shape.getSourceConnections().isEmpty() && shape.getTargetConnections().isEmpty()) {
return new Result("States must have at least one transition to or from. None found for " + shape);
}
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsAddDecisionReviewRule.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsAddDecisionReviewRule.java index 584948d5a47..72bf2bfd7b3 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsAddDecisionReviewRule.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsAddDecisionReviewRule.java @@ -148,7 +148,7 @@ public class AtsAddDecisionReviewRule extends WorkRuleDefinition { return Arrays.asList(new User[] {UserManager.getUser()});
}
Collection<User> users = UsersByIds.getUsers(value);
- if (users.size() == 0) {
+ if (users.isEmpty()) {
users.add(UserManager.getUser());
}
return users;
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsWorkDefinitions.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsWorkDefinitions.java index c0bf659e74b..7461b1be464 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsWorkDefinitions.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/item/AtsWorkDefinitions.java @@ -272,7 +272,7 @@ public class AtsWorkDefinitions implements IWorkDefinitionProvider { public static void addUpdateWorkItemToDefaultHeirarchy(Artifact art, SkynetTransaction transaction) throws OseeCoreException {
// Relate if not already related
- if (art.getRelatedArtifacts(CoreRelationTypes.WorkItem__Parent, Artifact.class).size() == 0) {
+ if (art.getRelatedArtifacts(CoreRelationTypes.WorkItem__Parent, Artifact.class).isEmpty()) {
if (art.isOfType(WorkPageDefinition.ARTIFACT_NAME)) {
relateIfNotRelated(AtsFolderUtil.getFolder(AtsFolder.WorkPages), art, transaction);
}
@@ -311,7 +311,7 @@ public class AtsWorkDefinitions implements IWorkDefinitionProvider { }
if (workItemDefinition instanceof WorkFlowDefinition) {
WorkFlowDefinition workFlowDefinition = (WorkFlowDefinition) workItemDefinition;
- if (workFlowDefinition.getPagesOrdered().size() == 0) {
+ if (workFlowDefinition.getPagesOrdered().isEmpty()) {
throw new OseeStateException("Work Flow must have at least one state.");
}
if (workFlowDefinition.getStartPage() == null) {
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/vue/Diagram.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/vue/Diagram.java index ca76867917a..22314792310 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/vue/Diagram.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/workflow/vue/Diagram.java @@ -34,7 +34,7 @@ public class Diagram { }
public Set<String> getPageNames() {
- if (nodeNames.size() == 0) {
+ if (nodeNames.isEmpty()) {
for (DiagramNode page : nodes)
nodeNames.add(page.getName());
}
@@ -56,7 +56,7 @@ public class Diagram { List<DiagramNode> foundPages = new ArrayList<DiagramNode>();
for (DiagramNode page : nodes)
if (page.getName().equals(pageName)) foundPages.add(page);
- if (foundPages.size() == 0) throw new OseeArgumentException(
+ if (foundPages.isEmpty()) throw new OseeArgumentException(
"Invalid node Name \"" + pageName + "\" from workflow => " + getId());
return foundPages;
}
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldComposite.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldComposite.java index c6f5c52b6d0..729d7838e5e 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldComposite.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldComposite.java @@ -135,7 +135,7 @@ public class WorldComposite extends ScrolledComposite implements IOpenNewAtsWorl customizeData)) {
setCustomizeData(customizeData);
}
- if (arts.size() == 0) {
+ if (arts.isEmpty()) {
setTableTitle("No Results Found - " + name, true);
} else {
setTableTitle(name, false);
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorParameterSearchItemProvider.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorParameterSearchItemProvider.java index 06e8bc43624..1a7522e70fe 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorParameterSearchItemProvider.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorParameterSearchItemProvider.java @@ -135,7 +135,7 @@ public class WorldEditorParameterSearchItemProvider extends WorldEditorProvider final Collection<? extends Artifact> artifacts;
worldEditor.getWorldComposite().getXViewer().clear(forcePend);
artifacts = worldParameterSearchItem.performSearchGetResults(searchType);
- if (artifacts.size() == 0) {
+ if (artifacts.isEmpty()) {
if (worldParameterSearchItem.isCancelled()) {
monitor.done();
worldEditor.setTableTitle("CANCELLED - " + selectedName, false);
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorUISearchItemProvider.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorUISearchItemProvider.java index 0ff1043f43a..012c201e6f4 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorUISearchItemProvider.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldEditorUISearchItemProvider.java @@ -126,7 +126,7 @@ public class WorldEditorUISearchItemProvider extends WorldEditorProvider { final Collection<Artifact> artifacts;
worldEditor.getWorldComposite().getXViewer().clear(forcePend);
artifacts = worldUISearchItem.performSearchGetResults(false, searchType);
- if (artifacts.size() == 0) {
+ if (artifacts.isEmpty()) {
if (worldUISearchItem.isCancelled()) {
worldEditor.setTableTitle("CANCELLED - " + selectedName, false);
return Status.CANCEL_STATUS;
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldXViewer.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldXViewer.java index 5cbcc503dab..383dcac1acc 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldXViewer.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/WorldXViewer.java @@ -146,7 +146,7 @@ public class WorldXViewer extends XViewer implements ISelectedAtsArtifacts, IArt return;
}
try {
- if (loadedArtifacts.getLoadedArtifacts().size() == 0) {
+ if (loadedArtifacts.getLoadedArtifacts().isEmpty()) {
return;
}
Displays.ensureInDisplayThread(new Runnable() {
@@ -388,7 +388,7 @@ public class WorldXViewer extends XViewer implements ISelectedAtsArtifacts, IArt openInAtsWorldEditorAction = new Action("Open in ATS World Editor", Action.AS_PUSH_BUTTON) {
@Override
public void run() {
- if (getSelectedArtifacts().size() == 0) {
+ if (getSelectedArtifacts().isEmpty()) {
AWorkbench.popup("Error", "No items selected");
return;
}
@@ -422,7 +422,7 @@ public class WorldXViewer extends XViewer implements ISelectedAtsArtifacts, IArt openInAtsTaskEditorAction = new Action("Open in ATS Task Editor", Action.AS_PUSH_BUTTON) {
@Override
public void run() {
- if (getSelectedTaskArtifacts().size() == 0) {
+ if (getSelectedTaskArtifacts().isEmpty()) {
AWorkbench.popup("Error", "No Tasks selected");
return;
}
@@ -624,7 +624,7 @@ public class WorldXViewer extends XViewer implements ISelectedAtsArtifacts, IArt public StateMachineArtifact getSelectedSMA() {
Object obj = null;
- if (getSelectedArtifactItems().size() == 0) {
+ if (getSelectedArtifactItems().isEmpty()) {
return null;
}
obj = getTree().getSelection()[0].getData();
@@ -725,7 +725,7 @@ public class WorldXViewer extends XViewer implements ISelectedAtsArtifacts, IArt @Override
public void handleDoubleClick() {
- if (getSelectedArtifactItems().size() == 0) {
+ if (getSelectedArtifactItems().isEmpty()) {
return;
}
Artifact art = getSelectedArtifactItems().iterator().next();
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/ArtifactTypesSearchItem.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/ArtifactTypesSearchItem.java index 7fa6b54c1f2..fb2b3772ede 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/ArtifactTypesSearchItem.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/ArtifactTypesSearchItem.java @@ -38,7 +38,7 @@ public class ArtifactTypesSearchItem extends WorldUISearchItem { @Override public Collection<Artifact> performSearch(SearchType searchType) throws OseeCoreException { - if (artifactTypes == null || artifactTypes.size() == 0) { + if (artifactTypes == null || artifactTypes.isEmpty()) { throw new OseeArgumentException("Inavlid search \"" + getName() + "\""); } return ArtifactQuery.getArtifactListFromTypes(artifactTypes, AtsUtil.getAtsBranch(), false); diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/MultipleHridSearchOperation.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/MultipleHridSearchOperation.java index 715722a9d3a..2fdad1828d9 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/MultipleHridSearchOperation.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/MultipleHridSearchOperation.java @@ -75,12 +75,12 @@ public class MultipleHridSearchOperation extends AbstractOperation { protected void doWork(IProgressMonitor monitor) throws Exception {
if (getUserEntry()) {
extractIds();
- if (ids.size() == 0) {
+ if (ids.isEmpty()) {
OseeLog.log(AtsPlugin.class, OseeLevel.SEVERE_POPUP, "Must Enter Valid Id");
return;
}
searchAndSplitResults();
- if (resultAtsArts.size() == 0 && resultNonAtsArts.size() == 0) {
+ if (resultAtsArts.isEmpty() && resultNonAtsArts.isEmpty()) {
OseeLog.log(AtsPlugin.class, OseeLevel.SEVERE_POPUP,
"Invalid HRID/Guid/Legacy PCR Id(s): " + Collections.toString(ids, ", "));
return;
diff --git a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/TaskSearchWorldSearchItem.java b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/TaskSearchWorldSearchItem.java index 7c0dcd927cf..b92aa6a7e74 100644 --- a/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/TaskSearchWorldSearchItem.java +++ b/plugins/org.eclipse.osee.ats/src/org/eclipse/osee/ats/world/search/TaskSearchWorldSearchItem.java @@ -104,12 +104,12 @@ public class TaskSearchWorldSearchItem extends TaskEditorParameterSearchItem { User user = getSelectedUser();
// If only user selected, handle that case separately
- if (verArt == null && teamDefs.size() == 0 && user != null) {
+ if (verArt == null && teamDefs.isEmpty() && user != null) {
return handleOnlyUserSelected();
} // If version specified, get workflows from targeted relation
if (verArt != null) {
for (Artifact art : verArt.getRelatedArtifacts(AtsRelationTypes.TeamWorkflowTargetedForVersion_Workflow)) {
- if (teamDefs.size() == 0) {
+ if (teamDefs.isEmpty()) {
workflows.add(art);
}
// Filter by team def if specified
@@ -184,13 +184,13 @@ public class TaskSearchWorldSearchItem extends TaskEditorParameterSearchItem { @Override
public Result isParameterSelectionValid() throws OseeCoreException {
- if (getSelectedUser() != null && isIncludeCompletedCancelledCheckbox() && getSelectedVersionArtifact() == null && getSelectedTeamDefinitions().size() == 0) {
+ if (getSelectedUser() != null && isIncludeCompletedCancelledCheckbox() && getSelectedVersionArtifact() == null && getSelectedTeamDefinitions().isEmpty()) {
// This case is unsupported and should be filtered out prior to this point
throw new OseeArgumentException("Unsupported User and Include Completed selected.");
}
// If only user selected, handle that case separately
- if (getSelectedVersionArtifact() == null && getSelectedTeamDefinitions().size() == 0 && getSelectedUser() != null) {
+ if (getSelectedVersionArtifact() == null && getSelectedTeamDefinitions().isEmpty() && getSelectedUser() != null) {
return Result.TrueResult;
}
@@ -260,7 +260,7 @@ public class TaskSearchWorldSearchItem extends TaskEditorParameterSearchItem { if (versionCombo != null) {
try {
Collection<TeamDefinitionArtifact> teamDefArts = getSelectedTeamDefinitions();
- if (teamDefArts.size() == 0) {
+ if (teamDefArts.isEmpty()) {
versionCombo.setDataStrings(new String[] {});
return;
}
@@ -272,7 +272,7 @@ public class TaskSearchWorldSearchItem extends TaskEditorParameterSearchItem { }
Collection<String> names =
Artifacts.artNames(teamDefHoldingVersions.getVersionsArtifacts(VersionReleaseType.Both));
- if (names.size() == 0) {
+ if (names.isEmpty()) {
versionCombo.setDataStrings(new String[] {});
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ConfigureCoverageMethodsAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ConfigureCoverageMethodsAction.java index d24d6708f4f..b2a893eba14 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ConfigureCoverageMethodsAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ConfigureCoverageMethodsAction.java @@ -104,7 +104,7 @@ public class ConfigureCoverageMethodsAction extends Action { coverageOptions = entryDiag.getEntry();
try {
CoverageOptionManager manager = new CoverageOptionManager(coverageOptions);
- if (manager.get().size() == 0) {
+ if (manager.get().isEmpty()) {
throw new OseeArgumentException("No options specified");
}
if (manager.get(CoverageOptionManager.Not_Covered.getName()) == null) {
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/DeleteCoverUnitAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/DeleteCoverUnitAction.java index dc93ce7fde9..2c561ca4ae3 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/DeleteCoverUnitAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/DeleteCoverUnitAction.java @@ -48,7 +48,7 @@ public class DeleteCoverUnitAction extends Action { @Override
public void run() {
- if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().size() == 0) {
+ if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().isEmpty()) {
AWorkbench.popup("Select Coverage Unit");
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditAssigneesAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditAssigneesAction.java index 5bbb6a849cd..e140a137260 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditAssigneesAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditAssigneesAction.java @@ -49,7 +49,7 @@ public class EditAssigneesAction extends Action { @Override
public void run() {
- if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().size() == 0) {
+ if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().isEmpty()) {
AWorkbench.popup("Select Coverage Unit(s)");
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java index 1d6d01c51d3..16834d9fb45 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageMethodAction.java @@ -49,7 +49,7 @@ public class EditCoverageMethodAction extends Action { @Override
public void run() {
- if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().size() == 0) {
+ if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().isEmpty()) {
AWorkbench.popup("Select Coverage Item(s)");
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageNotesAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageNotesAction.java index 1605cff4f02..74ae134b664 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageNotesAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditCoverageNotesAction.java @@ -46,7 +46,7 @@ public class EditCoverageNotesAction extends Action { @Override
public void run() {
- if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().size() == 0) {
+ if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().isEmpty()) {
AWorkbench.popup("Select Coverage Unit(s)");
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditRationaleAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditRationaleAction.java index 703ee95c3e4..1afed81fbb0 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditRationaleAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/EditRationaleAction.java @@ -46,7 +46,7 @@ public class EditRationaleAction extends Action { @Override
public void run() {
- if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().size() == 0) {
+ if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().isEmpty()) {
AWorkbench.popup("Select Coverage Item(s)");
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ViewSourceAction.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ViewSourceAction.java index 1e63e567b2a..0a9908a2c0f 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ViewSourceAction.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/action/ViewSourceAction.java @@ -40,7 +40,7 @@ public class ViewSourceAction extends Action { @Override
public void run() {
- if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().size() == 0) {
+ if (selectedCoverageEditorItem.getSelectedCoverageEditorItems().isEmpty()) {
AWorkbench.popup("Select Coverage Item");
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/CoverageEditorMergeTab.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/CoverageEditorMergeTab.java index e2fb654d1d0..836424a8cac 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/CoverageEditorMergeTab.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/CoverageEditorMergeTab.java @@ -156,7 +156,7 @@ public class CoverageEditorMergeTab extends FormPage implements ISaveable { private void handleImportSelected() {
Collection<IMergeItem> mergeItems = getSelectedMergeItems();
- if (mergeItems.size() == 0) {
+ if (mergeItems.isEmpty()) {
AWorkbench.popup("Select Items to Import via Import Column");
return;
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/params/CoverageParameters.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/params/CoverageParameters.java index 118beb1d63c..84aa2316cb1 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/params/CoverageParameters.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/params/CoverageParameters.java @@ -190,7 +190,7 @@ public class CoverageParameters { * CoverageItem is method specified
*/
public boolean isCoverageMethodMatch(ICoverage coverage) {
- if (coverageMethods.size() == 0 || !(coverage instanceof CoverageItem)) return true;
+ if (coverageMethods.isEmpty() || !(coverage instanceof CoverageItem)) return true;
if (coverageMethods.contains(((CoverageItem) coverage).getCoverageMethod())) {
return true;
}
@@ -279,7 +279,7 @@ public class CoverageParameters { private void updateShowAll() {
this.showAll =
- getSelectedCoverageMethods().size() == 0 && getAssignee() == null && !Strings.isValid(getNotesStr()) && !Strings.isValid(getNamespace()) && !Strings.isValid(getRationale()) && !Strings.isValid(getName());
+ getSelectedCoverageMethods().isEmpty() && getAssignee() == null && !Strings.isValid(getNotesStr()) && !Strings.isValid(getNamespace()) && !Strings.isValid(getRationale()) && !Strings.isValid(getName());
}
public boolean isShowAll() {
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xcover/CoverageXViewer.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xcover/CoverageXViewer.java index db0db7ad953..60ff12c7335 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xcover/CoverageXViewer.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xcover/CoverageXViewer.java @@ -89,7 +89,7 @@ public class CoverageXViewer extends XViewer implements ISelectedCoverageEditorI } private boolean isEditRationaleEnabled() { - if (xCoverageViewer.getSelectedCoverageItems().size() == 0) return false; + if (xCoverageViewer.getSelectedCoverageItems().isEmpty()) return false; for (ICoverage item : xCoverageViewer.getSelectedCoverageItems()) { if (!(item instanceof CoverageItem)) { return false; @@ -99,7 +99,7 @@ public class CoverageXViewer extends XViewer implements ISelectedCoverageEditorI } private boolean isEditMethodEnabled() { - if (xCoverageViewer.getSelectedCoverageItems().size() == 0) return false; + if (xCoverageViewer.getSelectedCoverageItems().isEmpty()) return false; for (ICoverage item : xCoverageViewer.getSelectedCoverageItems()) { if (!(item instanceof CoverageItem)) { return false; @@ -109,7 +109,7 @@ public class CoverageXViewer extends XViewer implements ISelectedCoverageEditorI } private boolean isDeleteCoverageUnitEnabled() { - if (xCoverageViewer.getSelectedCoverageItems().size() == 0) return false; + if (xCoverageViewer.getSelectedCoverageItems().isEmpty()) return false; for (ICoverage item : xCoverageViewer.getSelectedCoverageItems()) { if (!(item instanceof CoverageUnit)) { return false; @@ -119,7 +119,7 @@ public class CoverageXViewer extends XViewer implements ISelectedCoverageEditorI } private boolean isEditMetricsEnabled() { - if (xCoverageViewer.getSelectedCoverageItems().size() == 0) return false; + if (xCoverageViewer.getSelectedCoverageItems().isEmpty()) return false; for (ICoverage item : xCoverageViewer.getSelectedCoverageItems()) { if (!(item instanceof CoverageUnit)) { return false; diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xmerge/CoverageMergeXViewer.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xmerge/CoverageMergeXViewer.java index 3ef70d5e3ab..44f1d7cd14b 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xmerge/CoverageMergeXViewer.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/editor/xmerge/CoverageMergeXViewer.java @@ -77,7 +77,7 @@ public class CoverageMergeXViewer extends CoverageXViewer { }
private boolean isToggleImportEnabled() {
- if (xCoverageViewer.getSelectedCoverageItems().size() == 0) return false;
+ if (xCoverageViewer.getSelectedCoverageItems().isEmpty()) return false;
for (ICoverage item : xCoverageViewer.getSelectedCoverageItems()) {
if (item.isEditable().isFalse() || !(item instanceof IMergeItem) || !((IMergeItem) item).isImportAllowed()) {
return false;
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/event/CoverageEventManager.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/event/CoverageEventManager.java index 2e4f3bb0cc4..4c023548a26 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/event/CoverageEventManager.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/event/CoverageEventManager.java @@ -122,7 +122,7 @@ public class CoverageEventManager implements IArtifactListener, OseeMessagingSta public void unregister(CoverageEditor coverageEditor) throws OseeCoreException {
editors.remove(coverageEditor);
- if (editors.size() == 0) {
+ if (editors.isEmpty()) {
stopListeningForRemoteCoverageEvents();
stopListeneingForFrameworkEvents();
}
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/merge/MergeManager.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/merge/MergeManager.java index 030a407bda9..5ae02ad6b81 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/merge/MergeManager.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/merge/MergeManager.java @@ -47,7 +47,7 @@ public class MergeManager { for (ICoverage importCoverage : coverageImport.getChildren()) {
processImportCoverage(importCoverage, mergeItems, null);
}
- if (mergeItems.size() == 0) {
+ if (mergeItems.isEmpty()) {
mergeItems.add(new MessageMergeItem("Nothing to Import"));
}
return mergeItems;
@@ -446,7 +446,7 @@ public class MergeManager { break;
}
// If matches == 0, this is a deletion
- else if (matches.size() == 0) {
+ else if (matches.isEmpty()) {
groupMergeItems.add(new MergeItem(MergeType.Delete, packageItem, null, false));
}
// Else matches == 1, check the order; if different order, this is a Move_Due_To_Delete
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoveragePackageBase.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoveragePackageBase.java index 15de0e5d067..472eb6783ae 100644 --- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoveragePackageBase.java +++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/model/CoveragePackageBase.java @@ -113,7 +113,7 @@ public abstract class CoveragePackageBase implements ICoverage, ICoverageUnitPro } else {
nameStr = nameStr + "." + name;
}
- if (getCoverageUnits().size() == 0) {
+ if (getCoverageUnits().isEmpty()) {
CoverageUnit newCoverageUnit = new CoverageUnit(this, nameStr, "", coverageUnitFileContentsProvider);
newCoverageUnit.setFolder(true);
newCoverageUnit.setNamespace(nameStr);
diff --git a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/text/tool/Find.java b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/text/tool/Find.java index 4a8d25ac1c0..d82105d42aa 100644 --- a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/text/tool/Find.java +++ b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/text/tool/Find.java @@ -91,7 +91,7 @@ public class Find { List<File> files = Lib.recursivelyListFiles(new File(args[1]), Pattern.compile(args[2])); System.out.println("Searching " + files.size() + " files..."); - if (files.size() == 0) { + if (files.isEmpty()) { return; } diff --git a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyCountingMap.java b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyCountingMap.java index 25041c7a324..e6e6989aa6c 100644 --- a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyCountingMap.java +++ b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyCountingMap.java @@ -95,7 +95,7 @@ public class DoubleKeyCountingMap<KeyOne, KeyTwo> { HashMap<KeyTwo, MutableInteger> o = k1ToHashMap.get(k1); if (o != null) { value = o.remove(k2); - if (o.size() == 0) { + if (o.isEmpty()) { k1ToHashMap.remove(k1); } } @@ -142,7 +142,7 @@ public class DoubleKeyCountingMap<KeyOne, KeyTwo> { } public boolean isEmpty() { - return k1ToHashMap.size() == 0; + return k1ToHashMap.isEmpty(); } public Set<KeyOne> getKeySetOne() { diff --git a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyHashMap.java b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyHashMap.java index f72bfdb53ae..8b7c089e155 100644 --- a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyHashMap.java +++ b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/type/DoubleKeyHashMap.java @@ -69,7 +69,7 @@ public class DoubleKeyHashMap<KeyOne, KeyTwo, Value> { HashMap<KeyTwo, Value> o = k1ToHashMap.get(k1); if (o != null) { value = o.remove(k2); - if (o.size() == 0) { + if (o.isEmpty()) { k1ToHashMap.remove(k1); } } @@ -120,7 +120,7 @@ public class DoubleKeyHashMap<KeyOne, KeyTwo, Value> { } public boolean isEmpty() { - return k1ToHashMap.size() == 0; + return k1ToHashMap.isEmpty(); } public Set<KeyOne> getKeySetOne() { diff --git a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/util/xml/Jaxp.java b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/util/xml/Jaxp.java index ab23bae805e..16bf1ff7044 100644 --- a/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/util/xml/Jaxp.java +++ b/plugins/org.eclipse.osee.framework.jdk.core/src/org/eclipse/osee/framework/jdk/core/util/xml/Jaxp.java @@ -246,7 +246,7 @@ public class Jaxp { for (Element e : source) {
List<Element> children = getChildDirects(e, tag);
if (!children.isEmpty()) {
- if (path.size() == 0) {
+ if (path.isEmpty()) {
list.addAll(children);
} else {
findElementsInternal(children, childPath, list);
diff --git a/plugins/org.eclipse.osee.framework.manager.servlet/src/org/eclipse/osee/framework/manager/servlet/ClientInstallInfoServlet.java b/plugins/org.eclipse.osee.framework.manager.servlet/src/org/eclipse/osee/framework/manager/servlet/ClientInstallInfoServlet.java index 47696bf66c7..0d628173103 100644 --- a/plugins/org.eclipse.osee.framework.manager.servlet/src/org/eclipse/osee/framework/manager/servlet/ClientInstallInfoServlet.java +++ b/plugins/org.eclipse.osee.framework.manager.servlet/src/org/eclipse/osee/framework/manager/servlet/ClientInstallInfoServlet.java @@ -85,7 +85,7 @@ public class ClientInstallInfoServlet extends OseeHttpServlet { List<ClientInstallInfo> infos = getInfoEntry(key);
response.setStatus(HttpServletResponse.SC_OK);
response.setContentType("text/html");
- if (infos.size() == 0) {
+ if (infos.isEmpty()) {
response.getWriter().write("<html><body>No installations found</body></html>");
} else {
String html = InstallLinkPageGenerator.generate(infos, isCloseAllowed, isPromptAllowed);
diff --git a/plugins/org.eclipse.osee.framework.messaging/src/org/eclipse/osee/framework/messaging/services/internal/MonitorTimedOutServices.java b/plugins/org.eclipse.osee.framework.messaging/src/org/eclipse/osee/framework/messaging/services/internal/MonitorTimedOutServices.java index 5a280a5bba4..c9e235e295e 100644 --- a/plugins/org.eclipse.osee.framework.messaging/src/org/eclipse/osee/framework/messaging/services/internal/MonitorTimedOutServices.java +++ b/plugins/org.eclipse.osee.framework.messaging/src/org/eclipse/osee/framework/messaging/services/internal/MonitorTimedOutServices.java @@ -50,7 +50,7 @@ class MonitorTimedOutServices implements Runnable { Map<String, ServiceHealthPlusTimeout> innerMap = map.get(item.first, item.second);
innerMap.remove(item.key);
System.out.println(item.key);
- if(innerMap.size() == 0){
+ if(innerMap.isEmpty()){
map.remove(item.first, item.second);
System.out.println("removed " + item.first + item.second);
}
diff --git a/plugins/org.eclipse.osee.framework.plugin.core/src/org/eclipse/osee/framework/plugin/core/util/ExtensionPoints.java b/plugins/org.eclipse.osee.framework.plugin.core/src/org/eclipse/osee/framework/plugin/core/util/ExtensionPoints.java index 721c4c69260..105b7a80fba 100644 --- a/plugins/org.eclipse.osee.framework.plugin.core/src/org/eclipse/osee/framework/plugin/core/util/ExtensionPoints.java +++ b/plugins/org.eclipse.osee.framework.plugin.core/src/org/eclipse/osee/framework/plugin/core/util/ExtensionPoints.java @@ -102,7 +102,7 @@ public class ExtensionPoints { public static IConfigurationElement getExtensionElement(String extensionPointId, String elementName) {
List<IConfigurationElement> elements = ExtensionPoints.getExtensionElements(extensionPointId, elementName);
- if (elements.size() == 0) {
+ if (elements.isEmpty()) {
throw new IllegalArgumentException(
"no elements named " + elementName + " for " + extensionPointId + " where found.");
}
diff --git a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ArtifactQueryPerformanceTests.java b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ArtifactQueryPerformanceTests.java index 4c70b25596d..d21b43ad899 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ArtifactQueryPerformanceTests.java +++ b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ArtifactQueryPerformanceTests.java @@ -41,7 +41,7 @@ public class ArtifactQueryPerformanceTests { * public ArtifactQueryBuilder(Collection<Integer> artifactIds, Branch branch, boolean allowDeleted, ArtifactLoad
* loadLevel) {
* this(artifactIds, 0, null, null, null, branch, allowDeleted, loadLevel, true);
- * emptyCriteria = artifactIds.size() == 0;
+ * emptyCriteria = artifactIds.isEmpty();
* }
* public ArtifactQueryBuilder(Branch branch, ArtifactLoad loadLevel, boolean allowDeleted,
* AbstractArtifactSearchCriteria... criteria) {
@@ -51,7 +51,7 @@ public class ArtifactQueryPerformanceTests { * public ArtifactQueryBuilder(Branch branch, ArtifactLoad loadLevel, List<AbstractArtifactSearchCriteria> criteria)
* {
* this(null, 0, null, null, null, branch, false, loadLevel, true, toArray(criteria));
- * emptyCriteria = criteria.size() == 0;
+ * emptyCriteria = criteria.isEmpty();
* }
* public ArtifactQueryBuilder(ArtifactType artifactType, Branch branch, ArtifactLoad loadLevel,
* AbstractArtifactSearchCriteria... criteria) {
@@ -61,7 +61,7 @@ public class ArtifactQueryPerformanceTests { * public ArtifactQueryBuilder(ArtifactType artifactType, Branch branch, ArtifactLoad loadLevel,
* List<AbstractArtifactSearchCriteria> criteria) {
* this(null, 0, null, null, Arrays.asList(artifactType), branch, false, loadLevel, true, toArray(criteria));
- * emptyCriteria = criteria.size() == 0;
+ * emptyCriteria = criteria.isEmpty();
* }
*/
diff --git a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/Artifact_setAttributeValues.java b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/Artifact_setAttributeValues.java index 6fd8a86fbf7..d2be20bcea6 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/Artifact_setAttributeValues.java +++ b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/Artifact_setAttributeValues.java @@ -82,7 +82,7 @@ public class Artifact_setAttributeValues { artifact.setAttributeValues(StaticIdManager.STATIC_ID_ATTRIBUTE, emptySet);
artifact.persist();
- assertTrue(artifact.getAttributesToStringList(StaticIdManager.STATIC_ID_ATTRIBUTE).size() == 0);
+ assertTrue(artifact.getAttributesToStringList(StaticIdManager.STATIC_ID_ATTRIBUTE).isEmpty());
}
@org.junit.Test
diff --git a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ConflictTest.java b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ConflictTest.java index 01e605dd109..ae55f8f98fc 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ConflictTest.java +++ b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/ConflictTest.java @@ -103,7 +103,7 @@ public class ConflictTest { "(Intermittent failures - needs re-write) - Number of conflicts found is not equal to the number of conflicts expected",
ConflictTestManager.numberOfConflicts(), conflicts.size());
assertTrue(String.format("%d SevereLogs during test.", monitorLog.getSevereLogs().size()),
- monitorLog.getSevereLogs().size() == 0);
+ monitorLog.getSevereLogs().isEmpty());
}
/**
@@ -155,7 +155,7 @@ public class ConflictTest { fail(Lib.exceptionToString(ex));
}
assertTrue(String.format("%d SevereLogs during test.", monitorLog.getAllLogs().size()),
- monitorLog.getAllLogs().size() == 0);
+ monitorLog.getAllLogs().isEmpty());
}
public void checkCommitWithoutResolutionErrors() {
@@ -175,7 +175,7 @@ public class ConflictTest { }
assertTrue(String.format("%d SevereLogs during test.", monitorLog.getSevereLogs().size()),
- monitorLog.getSevereLogs().size() == 0);
+ monitorLog.getSevereLogs().isEmpty());
}
@org.junit.Test
diff --git a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/DeletionTest.java b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/DeletionTest.java index a2b8aa28b5e..bb22cb593fa 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/DeletionTest.java +++ b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/DeletionTest.java @@ -293,7 +293,7 @@ public class DeletionTest { assertTrue(String.format("%d SevereLogs during test.", monitorLog.getAllLogs().size()),
- monitorLog.getAllLogs().size() == 0);
+ monitorLog.getAllLogs().isEmpty());
if (DEBUG) {
fail("Deletion Test was run with tracing enabled to prevent stopping at a failure so no conditions were checked.");
}
diff --git a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/RelationDeletionTest.java b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/RelationDeletionTest.java index 732ce8e51b0..a2f58eed864 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/RelationDeletionTest.java +++ b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/RelationDeletionTest.java @@ -71,7 +71,7 @@ public class RelationDeletionTest { assertTrue("Child2 is not the first in the list and it should be.", children.get(0) == child2);
- assertTrue(monitor.toString(), monitor.getSevereLogs().size() == 0);
+ assertTrue(monitor.toString(), monitor.getSevereLogs().isEmpty());
}
private Artifact createArtifact(String type, Branch branch) throws OseeCoreException {
diff --git a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/StaticIdManagerTest.java b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/StaticIdManagerTest.java index 7774676f1fa..cd046fb6ca8 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/StaticIdManagerTest.java +++ b/plugins/org.eclipse.osee.framework.skynet.core.test/src/org/eclipse/osee/framework/skynet/core/test/cases/StaticIdManagerTest.java @@ -70,7 +70,7 @@ public class StaticIdManagerTest { for (Artifact artifact : artifacts) {
System.err.println("Search returned non-deleted " + artifact.getGuid());
}
- assertTrue("Expected 0 artifacts; Returned " + artifacts.size(), artifacts.size() == 0);
+ assertTrue("Expected 0 artifacts; Returned " + artifacts.size(), artifacts.isEmpty());
}
}
@@ -83,7 +83,7 @@ public class StaticIdManagerTest { public void testStaticIdsGettingCached() throws OseeCoreException {
String staticId = "org." + GUID.create();
Collection<Artifact> artifacts = ArtifactCache.getArtifactsByStaticId(staticId);
- assertTrue("Should be 0; Returned " + artifacts.size(), artifacts.size() == 0);
+ assertTrue("Should be 0; Returned " + artifacts.size(), artifacts.isEmpty());
Artifact art = ArtifactTypeManager.addArtifact(CoreArtifactTypes.GeneralData, BranchManager.getCommonBranch());
art.addAttribute(StaticIdManager.STATIC_ID_ATTRIBUTE, staticId);
art.persist();
diff --git a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/Artifact.java b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/Artifact.java index 6463f624420..b56590348e8 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/Artifact.java +++ b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/Artifact.java @@ -672,7 +672,7 @@ public class Artifact implements IArtifact, IAdaptable, Comparable<Artifact>, Na public <T> Attribute<T> getSoleAttribute(String attributeTypeName) throws OseeCoreException {
ensureAttributesLoaded();
List<Attribute<T>> soleAttributes = getAttributes(attributeTypeName);
- if (soleAttributes.size() == 0) {
+ if (soleAttributes.isEmpty()) {
return null;
} else if (soleAttributes.size() > 1) {
throw new MultipleAttributesExist(String.format(
@@ -720,7 +720,7 @@ public class Artifact implements IArtifact, IAdaptable, Comparable<Artifact>, Na */
public <T> T getSoleAttributeValue(String attributeTypeName) throws OseeCoreException {
List<Attribute<T>> soleAttributes = getAttributes(attributeTypeName);
- if (soleAttributes.size() == 0) {
+ if (soleAttributes.isEmpty()) {
if (!isAttributeTypeValid(attributeTypeName)) {
throw new OseeArgumentException(String.format(
"The attribute type %s is not valid for artifacts of type [%s]", attributeTypeName,
diff --git a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/StaticIdManager.java b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/StaticIdManager.java index 8062564fd13..553c1135448 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/StaticIdManager.java +++ b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/StaticIdManager.java @@ -38,7 +38,7 @@ public class StaticIdManager { */ public static void setSingletonAttributeValue(Artifact artifact, String staticId) throws OseeCoreException { List<Attribute<String>> attributes = artifact.getAttributes(STATIC_ID_ATTRIBUTE, staticId); - if (attributes.size() == 0) { + if (attributes.isEmpty()) { artifact.addAttribute(STATIC_ID_ATTRIBUTE, staticId); } else if (attributes.size() > 1) { // keep one of the attributes @@ -89,7 +89,7 @@ public class StaticIdManager { if (artifacts.size() > 0) { OseeLog.log(Activator.class, Level.FINE, "StaticId Load: [" + staticId + "][" + artifactType + "]"); } - if (queryIfNotFound && artifacts.size() == 0) { + if (queryIfNotFound && artifacts.isEmpty()) { artifacts = getArtifactsFromArtifactQuery(artifactType, staticId, branch); } return artifacts; @@ -98,7 +98,7 @@ public class StaticIdManager { public static Artifact getSingletonArtifactOrException(IArtifactType artifactType, String staticId, Branch branch) throws OseeCoreException { Set<Artifact> artifacts = getArtifactsFromArtifactCache(artifactType, staticId, branch, true); // Exception on problems - if (artifacts.size() == 0) { + if (artifacts.isEmpty()) { throw new ArtifactDoesNotExist("Can't find requested artifact \"" + staticId + "\""); } else if (artifacts.size() > 1) { throw new MultipleArtifactsExist("Expected 1 \"" + staticId + "\" artifact, retrieved " + artifacts.size()); @@ -137,7 +137,7 @@ public class StaticIdManager { */ private static Artifact getOrCreateSingletonArtifactHelper(IArtifactType artifactType, String staticId, IOseeBranch branch, boolean create) throws OseeCoreException { Set<Artifact> artifacts = getArtifactsFromArtifactCache(artifactType, staticId, branch, true); - if (artifacts.size() == 0 && create) { + if (artifacts.isEmpty() && create) { Artifact artifact = ArtifactTypeManager.addArtifact(artifactType, branch); setSingletonAttributeValue(artifact, staticId); return artifact; diff --git a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/search/ArtifactQueryBuilder.java b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/search/ArtifactQueryBuilder.java index cc19c76c5b3..0345f9e6bff 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/search/ArtifactQueryBuilder.java +++ b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/artifact/search/ArtifactQueryBuilder.java @@ -83,22 +83,22 @@ public class ArtifactQueryBuilder { */
public ArtifactQueryBuilder(Collection<Integer> artifactIds, IOseeBranch branch, boolean allowDeleted, ArtifactLoad loadLevel) {
this(artifactIds, 0, null, null, null, branch, null, allowDeleted, loadLevel, true);
- emptyCriteria = artifactIds.size() == 0;
+ emptyCriteria = artifactIds.isEmpty();
}
public ArtifactQueryBuilder(List<String> guidOrHrids, IOseeBranch branch, ArtifactLoad loadLevel) {
this(null, 0, guidOrHrids, null, null, branch, null, false, loadLevel, true);
- emptyCriteria = guidOrHrids.size() == 0;
+ emptyCriteria = guidOrHrids.isEmpty();
}
public ArtifactQueryBuilder(List<String> guidOrHrids, IOseeBranch branch, boolean allowDeleted, ArtifactLoad loadLevel) {
this(null, 0, guidOrHrids, null, null, branch, null, allowDeleted, loadLevel, true);
- emptyCriteria = guidOrHrids.size() == 0;
+ emptyCriteria = guidOrHrids.isEmpty();
}
public ArtifactQueryBuilder(List<String> guidOrHrids, TransactionRecord transactionId, boolean allowDeleted, ArtifactLoad loadLevel) throws OseeCoreException {
this(null, 0, guidOrHrids, null, null, transactionId.getBranch(), transactionId, allowDeleted, loadLevel, true);
- emptyCriteria = guidOrHrids.size() == 0;
+ emptyCriteria = guidOrHrids.isEmpty();
}
public ArtifactQueryBuilder(int artifactId, TransactionRecord transactionId, boolean allowDeleted, ArtifactLoad loadLevel) throws OseeCoreException {
@@ -115,7 +115,7 @@ public class ArtifactQueryBuilder { public ArtifactQueryBuilder(Collection<? extends IArtifactType> artifactTypes, IOseeBranch branch, ArtifactLoad loadLevel, boolean allowDeleted) {
this(null, 0, null, null, artifactTypes, branch, null, allowDeleted, loadLevel, true);
- emptyCriteria = artifactTypes.size() == 0;
+ emptyCriteria = artifactTypes.isEmpty();
}
public ArtifactQueryBuilder(IOseeBranch branch, ArtifactLoad loadLevel, boolean allowDeleted) {
@@ -129,7 +129,7 @@ public class ArtifactQueryBuilder { public ArtifactQueryBuilder(IOseeBranch branch, ArtifactLoad loadLevel, List<AbstractArtifactSearchCriteria> criteria) {
this(null, 0, null, null, null, branch, null, false, loadLevel, true, toArray(criteria));
- emptyCriteria = criteria.size() == 0;
+ emptyCriteria = criteria.isEmpty();
}
public ArtifactQueryBuilder(IArtifactType artifactType, IOseeBranch branch, ArtifactLoad loadLevel, AbstractArtifactSearchCriteria... criteria) {
@@ -139,7 +139,7 @@ public class ArtifactQueryBuilder { public ArtifactQueryBuilder(IArtifactType artifactType, IOseeBranch branch, ArtifactLoad loadLevel, List<AbstractArtifactSearchCriteria> criteria) {
this(null, 0, null, null, Arrays.asList(artifactType), branch, null, false, loadLevel, true, toArray(criteria));
- emptyCriteria = criteria.size() == 0;
+ emptyCriteria = criteria.isEmpty();
}
private ArtifactQueryBuilder(Collection<Integer> artifactIds, int artifactId, List<String> guidOrHrids, String guidOrHrid, Collection<? extends IArtifactType> artifactTypes, IOseeBranch branch, TransactionRecord transactionId, boolean allowDeleted, ArtifactLoad loadLevel, boolean tableOrderForward, AbstractArtifactSearchCriteria... criteria) {
@@ -432,7 +432,7 @@ public class ArtifactQueryBuilder { }
Collection<Artifact> artifacts = internalGetArtifacts(1, null, true);
- if (artifacts.size() == 0) {
+ if (artifacts.isEmpty()) {
throw new ArtifactDoesNotExist(getSoleExceptionMessage(artifacts.size()));
}
if (artifacts.size() > 1) {
diff --git a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/attribute/AttributeExtensionManager.java b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/attribute/AttributeExtensionManager.java index 1e020c5606f..96d393513d0 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/attribute/AttributeExtensionManager.java +++ b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/attribute/AttributeExtensionManager.java @@ -118,7 +118,7 @@ public class AttributeExtensionManager { }
}
}
- if (toReturn.size() == 0) {
+ if (toReturn.isEmpty()) {
throw new OseeStateException(String.format(
"No Objects loaded for [%s] with element names %s and attribute [%s]", extensionPointId,
Arrays.asList(elementNames), classNameAttribute));
diff --git a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/relation/RelationManager.java b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/relation/RelationManager.java index bfd9c32ebdb..889ec20a697 100644 --- a/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/relation/RelationManager.java +++ b/plugins/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/relation/RelationManager.java @@ -91,7 +91,7 @@ public class RelationManager { }
}
}
- if (relations.size() == 0) {
+ if (relations.isEmpty()) {
return null;
}
if (relations.size() > 1) {
diff --git a/plugins/org.eclipse.osee.framework.ui.admin/src/org/eclipse/osee/framework/ui/admin/dbtabletab/DbModel.java b/plugins/org.eclipse.osee.framework.ui.admin/src/org/eclipse/osee/framework/ui/admin/dbtabletab/DbModel.java index 96948be757f..a96872cf6ad 100644 --- a/plugins/org.eclipse.osee.framework.ui.admin/src/org/eclipse/osee/framework/ui/admin/dbtabletab/DbModel.java +++ b/plugins/org.eclipse.osee.framework.ui.admin/src/org/eclipse/osee/framework/ui/admin/dbtabletab/DbModel.java @@ -25,7 +25,7 @@ public class DbModel { } public Object getColumn(int num) { - if (columns.size() == 0 || num > columns.size()) + if (columns.isEmpty() || num > columns.size()) return ""; else return columns.get(num); diff --git a/plugins/org.eclipse.osee.framework.ui.service.control/src/org/eclipse/osee/framework/ui/service/control/data/ServiceNode.java b/plugins/org.eclipse.osee.framework.ui.service.control/src/org/eclipse/osee/framework/ui/service/control/data/ServiceNode.java index 09dd8ec60d2..988eb01f34e 100644 --- a/plugins/org.eclipse.osee.framework.ui.service.control/src/org/eclipse/osee/framework/ui/service/control/data/ServiceNode.java +++ b/plugins/org.eclipse.osee.framework.ui.service.control/src/org/eclipse/osee/framework/ui/service/control/data/ServiceNode.java @@ -103,7 +103,7 @@ public class ServiceNode extends TreeObject implements IJiniService { toReturn.add( (String) ((PropertyEntry)entry).getProperty("group", "OSEE Services")); } } - if (toReturn.size() == 0) { + if (toReturn.isEmpty()) { toReturn.add("Public"); } return toReturn; diff --git a/plugins/org.eclipse.osee.framework.ui.skynet.test/src/org/eclipse/osee/framework/ui/skynet/test/cases/PreviewAndMultiPreviewTest.java b/plugins/org.eclipse.osee.framework.ui.skynet.test/src/org/eclipse/osee/framework/ui/skynet/test/cases/PreviewAndMultiPreviewTest.java index dd77afebe48..b61a86b8e94 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet.test/src/org/eclipse/osee/framework/ui/skynet/test/cases/PreviewAndMultiPreviewTest.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet.test/src/org/eclipse/osee/framework/ui/skynet/test/cases/PreviewAndMultiPreviewTest.java @@ -245,8 +245,8 @@ public class PreviewAndMultiPreviewTest { WordTemplateRenderer renderer = new WordTemplateRenderer();
renderer.setOptions(null);
renderer.preview(newMultiArts);
- Assert.assertTrue(monitorLog.getLogsAtLevel(Level.WARNING).size() == 0);
- Assert.assertTrue(monitorLog.getLogsAtLevel(Level.SEVERE).size() == 0);
+ Assert.assertTrue(monitorLog.getLogsAtLevel(Level.WARNING).isEmpty());
+ Assert.assertTrue(monitorLog.getLogsAtLevel(Level.SEVERE).isEmpty());
} catch (OseeCoreException ex) {
OseeLog.log(PreviewWithChildWordHandler.class, Level.SEVERE, ex);
Assert.fail("Preview with children test failed.");
@@ -276,8 +276,8 @@ public class PreviewAndMultiPreviewTest { multiArt3.persist();
Arrays.asList(multiArt1, multiArt2, multiArt3);
RendererManager.previewInJob(artifacts);
- Assert.assertTrue(monitorLog.getLogsAtLevel(Level.WARNING).size() == 0);
- Assert.assertTrue(monitorLog.getLogsAtLevel(Level.SEVERE).size() == 0);
+ Assert.assertTrue(monitorLog.getLogsAtLevel(Level.WARNING).isEmpty());
+ Assert.assertTrue(monitorLog.getLogsAtLevel(Level.SEVERE).isEmpty());
} catch (OseeCoreException ex) {
OseeLog.log(PreviewWithChildWordHandler.class, Level.SEVERE, ex);
Assert.fail("Preview with children test failed.");
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/MassEditDirtyArtifactOperation.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/MassEditDirtyArtifactOperation.java index 2517dfe7025..2c1f20d5730 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/MassEditDirtyArtifactOperation.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/MassEditDirtyArtifactOperation.java @@ -33,7 +33,7 @@ public class MassEditDirtyArtifactOperation extends AbstractOperation implements @Override
protected void doWork(IProgressMonitor monitor) throws Exception {
Collection<Artifact> dirtyArts = ArtifactCache.getDirtyArtifacts();
- if (dirtyArts.size() == 0) {
+ if (dirtyArts.isEmpty()) {
AWorkbench.popup("No Dirty Artifacts Found");
return;
}
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassArtifactEditor.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassArtifactEditor.java index 882b99fae6a..5bc7a6b5cd1 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassArtifactEditor.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassArtifactEditor.java @@ -95,7 +95,7 @@ public class MassArtifactEditor extends AbstractArtifactEditor implements IActio accessibleArts.add(artifact);
}
}
- if (accessibleArts.size() == 0) {
+ if (accessibleArts.isEmpty()) {
AWorkbench.popup("ERROR", "No Artifacts to edit");
} else {
AWorkbench.getActivePage().openEditor(
@@ -256,7 +256,7 @@ public class MassArtifactEditor extends AbstractArtifactEditor implements IActio }
public Branch getBranch() {
- if (((MassArtifactEditorInput) getEditorInput()).getArtifacts().size() == 0) {
+ if (((MassArtifactEditorInput) getEditorInput()).getArtifacts().isEmpty()) {
return null;
}
return ((MassArtifactEditorInput) getEditorInput()).getArtifacts().iterator().next().getBranch();
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassContentProvider.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassContentProvider.java index bfbfb7cb9eb..63f0e7a15a8 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassContentProvider.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassContentProvider.java @@ -53,7 +53,7 @@ public class MassContentProvider implements ITreeContentProvider { } public void updateAll(final Collection<? extends Object> arts) { - if (arts.size() == 0) return; + if (arts.isEmpty()) return; Displays.ensureInDisplayThread(new Runnable() { public void run() { if (xViewer.getInput() == null) xViewer.setInput(rootSet); diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassXViewer.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassXViewer.java index cd8f47bce25..d2083c0823c 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassXViewer.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/artifact/massEditor/MassXViewer.java @@ -188,7 +188,7 @@ public class MassXViewer extends XViewer implements IFrameworkTransactionEventLi @Override
public void handleDoubleClick() {
- if (getSelectedArtifacts().size() == 0) return;
+ if (getSelectedArtifacts().isEmpty()) return;
Artifact art = getSelectedArtifacts().iterator().next();
RendererManager.openInJob(art, PresentationType.GENERALIZED_EDIT);
}
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/blam/BlamContributionManager.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/blam/BlamContributionManager.java index 165d504bf9f..b5e2b8ad829 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/blam/BlamContributionManager.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/blam/BlamContributionManager.java @@ -69,7 +69,7 @@ public class BlamContributionManager { // Add blams to categories
for (AbstractBlam blamOperation : BlamContributionManager.getBlamOperationsNameSort()) {
// If categories not specified, add to top level
- if (blamOperation.getCategories().size() == 0) {
+ if (blamOperation.getCategories().isEmpty()) {
new XNavigateItemBlam(blamOperationItems, blamOperation);
}
for (String category : blamOperation.getCategories()) {
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/commandHandlers/branch/commit/CommitHandler.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/commandHandlers/branch/commit/CommitHandler.java index 6e3095f465e..2b9ce264518 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/commandHandlers/branch/commit/CommitHandler.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/commandHandlers/branch/commit/CommitHandler.java @@ -54,7 +54,7 @@ public abstract class CommitHandler extends CommandHandler { final TransactionRecord transactionId = sourceBranch.getBaseTransaction();
boolean branchCommitted = false;
- if (!conflictManager.getRemainingConflicts().isEmpty()) { + if (!conflictManager.getRemainingConflicts().isEmpty()) {
String message =
"Commit stopped due to unresolved conflicts\n\nPossible Resolutions:\n Cancel commit and resolve at a later time\n Launch the Merge Manager to resolve conflicts";
final String fMessage;
@@ -100,7 +100,7 @@ public abstract class CommitHandler extends CommandHandler { Display.getDefault().syncExec(new Runnable() {
public void run() {
try {
- if (conflictManager.getOriginalConflicts().size() == 0) {
+ if (conflictManager.getOriginalConflicts().isEmpty()) {
MessageDialog dialog =
new MessageDialog(Display.getCurrent().getActiveShell(), "Commit Branch", null,
message.toString(), MessageDialog.QUESTION, new String[] {"Ok", "Cancel"}, 0);
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/group/GroupExplorer.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/group/GroupExplorer.java index 81385d4dc22..def21cde204 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/group/GroupExplorer.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/group/GroupExplorer.java @@ -324,7 +324,7 @@ public class GroupExplorer extends ViewPart implements IFrameworkTransactionEven return;
}
final List<GroupExplorerItem> items = getSelectedItems();
- if (items.size() == 0) {
+ if (items.isEmpty()) {
AWorkbench.popup("ERROR", "No Items Selected");
return;
}
@@ -346,7 +346,7 @@ public class GroupExplorer extends ViewPart implements IFrameworkTransactionEven private void handleDeleteGroup() throws OseeCoreException {
final ArrayList<GroupExplorerItem> items = getSelectedUniversalGroupItems();
- if (items.size() == 0) {
+ if (items.isEmpty()) {
AWorkbench.popup("ERROR", "No groups selected.");
return;
}
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/search/page/ArtifactSearchPage.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/search/page/ArtifactSearchPage.java index b06a80231db..64baa0d17de 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/search/page/ArtifactSearchPage.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/search/page/ArtifactSearchPage.java @@ -519,7 +519,7 @@ public class ArtifactSearchPage extends AbstractArtifactSearchViewPage implement @Override
public Object getFirstElement() {
- return collection.size() == 0 ? null : iterator().next();
+ return collection.isEmpty() ? null : iterator().next();
}
@SuppressWarnings("unchecked")
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerOptions.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerOptions.java index 2f3c73349ea..7e58091c263 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerOptions.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerOptions.java @@ -82,7 +82,7 @@ public class SkyWalkerOptions { } public String getExtendedName(Artifact artifact) throws OseeCoreException { - if (getSelectedShowAttributeTypes().size() == 0) { + if (getSelectedShowAttributeTypes().isEmpty()) { return ""; } else { StringBuffer sb = new StringBuffer(); diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerView.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerView.java index e47e9e764e6..5d6cb37948f 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerView.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/skywalker/SkyWalkerView.java @@ -304,7 +304,7 @@ public class SkyWalkerView extends ViewPart { // Add current artifact to history only if explore wasn't caused by going back in history
if (!fromHistory && viewer.getInput() != null) {
Artifact currArt = (Artifact) viewer.getInput();
- if (history.size() == 0) {
+ if (history.isEmpty()) {
history.add(currArt);
} else if (history.size() > 0 && !history.get(history.size() - 1).equals(currArt)) {
history.add(currArt);
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailGroup.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailGroup.java index 51a12176b4c..97b75ecb63b 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailGroup.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailGroup.java @@ -35,7 +35,7 @@ public class EmailGroup { } public boolean hasEmails() { - if (emails.size() == 0) return false; + if (emails.isEmpty()) return false; for (String str : emails) { if (EmailUtil.isEmailValid(str)) return true; } diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailUserGroups.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailUserGroups.java index 54f0091b584..840be09f8d6 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailUserGroups.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/email/EmailUserGroups.java @@ -91,7 +91,7 @@ public class EmailUserGroups extends XNavigateItemAction { }
}
}
- if (emails.size() == 0) {
+ if (emails.isEmpty()) {
AWorkbench.popup("Error", "No emails configured.");
return;
}
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/matrix/Matrix.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/matrix/Matrix.java index 154e318bb8e..ea9a6881e22 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/matrix/Matrix.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/util/matrix/Matrix.java @@ -72,7 +72,7 @@ public class Matrix { // of them and print them at the end of the report for (String name : nameToItem.keySet()) { System.out.println("nameToValues.get(name) *" + nameToValues.get(name) + "*"); - if (nameToValues.get(name) == null || nameToValues.get(name).size() == 0) + if (nameToValues.get(name) == null || nameToValues.get(name).isEmpty()) noValueNames.add(name); else names.add(name); diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/XRadioButtons.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/XRadioButtons.java index 4344812d011..a0a383ea893 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/XRadioButtons.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/XRadioButtons.java @@ -272,7 +272,7 @@ public class XRadioButtons extends XWidget { } public IStatus isValid() { - if (isRequiredEntry() && getSelectedNames().size() == 0) { + if (isRequiredEntry() && getSelectedNames().isEmpty()) { return new Status(IStatus.ERROR, SkynetGuiPlugin.PLUGIN_ID, getLabel() + " must have at least one selection."); } return Status.OK_STATUS; diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/workflow/WorkItemDefinitionFactory.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/workflow/WorkItemDefinitionFactory.java index 29cf4417088..7dcf6956ab4 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/workflow/WorkItemDefinitionFactory.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/workflow/WorkItemDefinitionFactory.java @@ -101,14 +101,14 @@ public class WorkItemDefinitionFactory { List<Artifact> parentArts =
ArtifactQuery.getArtifactListFromAttribute(WorkItemAttributes.WORK_ID.getAttributeTypeName(),
parentWorkflowId, BranchManager.getCommonBranch());
- if (parentArts == null || parentArts.size() == 0) {
+ if (parentArts == null || parentArts.isEmpty()) {
throw new IllegalArgumentException("Can't access parentWorkflowId " + parentWorkflowId);
}
Artifact parentArt = parentArts.iterator().next();
List<Artifact> childArts =
ArtifactQuery.getArtifactListFromAttribute(WorkItemAttributes.WORK_ID.getAttributeTypeName(),
childWorkflowId, BranchManager.getCommonBranch());
- if (childArts == null || childArts.size() == 0) {
+ if (childArts == null || childArts.isEmpty()) {
throw new IllegalArgumentException("Can't access childWorkflowId " + childWorkflowId);
}
Artifact childArt = childArts.iterator().next();
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/HistoryXViewer.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/HistoryXViewer.java index dd3d6606cd1..527a570d2ce 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/HistoryXViewer.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/HistoryXViewer.java @@ -42,7 +42,7 @@ public class HistoryXViewer extends XViewer { @Override
public void handleDoubleClick() {
try {
- if (getSelectedChanges().size() == 0) {
+ if (getSelectedChanges().isEmpty()) {
return;
}
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/XHistoryWidget.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/XHistoryWidget.java index 14745eddef8..e6587398104 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/XHistoryWidget.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xHistory/XHistoryWidget.java @@ -243,7 +243,7 @@ public class XHistoryWidget extends XWidget implements IActionable { Displays.ensureInDisplayThread(new Runnable() {
public void run() {
if (loadHistory) {
- if (changes.size() == 0) {
+ if (changes.isEmpty()) {
extraInfoLabel.setText(NO_HISTORY);
xHistoryViewer.setInput(changes);
} else {
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xmerge/MergeXWidget.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xmerge/MergeXWidget.java index fca48b7cf06..6a2adf41261 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xmerge/MergeXWidget.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xmerge/MergeXWidget.java @@ -688,7 +688,7 @@ public class MergeXWidget extends XWidget implements IAdaptable { applyPreviousMerge(branchIds.get(dialog.getSelection()));
}
}
- if (selections.size() == 0) {
+ if (selections.isEmpty()) {
new MessageDialog(Display.getCurrent().getActiveShell().getShell(),
"Apply Prior Merge Resolution", null, "This Source Branch has had No Prior Merges", 2,
new String[] {"OK"}, 1).open();
diff --git a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xviewer/skynet/SkynetUserArtifactCustomizeDefaults.java b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xviewer/skynet/SkynetUserArtifactCustomizeDefaults.java index 9e4a97c320a..482fbdaa7c7 100644 --- a/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xviewer/skynet/SkynetUserArtifactCustomizeDefaults.java +++ b/plugins/org.eclipse.osee.framework.ui.skynet/src/org/eclipse/osee/framework/ui/skynet/widgets/xviewer/skynet/SkynetUserArtifactCustomizeDefaults.java @@ -84,7 +84,7 @@ public class SkynetUserArtifactCustomizeDefaults { public void save() { try { - if (defaultGuids.size() == 0) { + if (defaultGuids.isEmpty()) { user.deleteSoleAttribute(XVIEWER_DEFAULT_ATTRIBUTE); } else { user.setSoleAttributeValue(XVIEWER_DEFAULT_ATTRIBUTE, getDefaultCustomizationXml()); diff --git a/plugins/org.eclipse.osee.ote.core/src/org/eclipse/osee/ote/core/framework/saxparse/ElementHandlers.java b/plugins/org.eclipse.osee.ote.core/src/org/eclipse/osee/ote/core/framework/saxparse/ElementHandlers.java index 64baccd40be..32b916e3d06 100644 --- a/plugins/org.eclipse.osee.ote.core/src/org/eclipse/osee/ote/core/framework/saxparse/ElementHandlers.java +++ b/plugins/org.eclipse.osee.ote.core/src/org/eclipse/osee/ote/core/framework/saxparse/ElementHandlers.java @@ -41,7 +41,7 @@ public abstract class ElementHandlers { }
void endElementFound(String uri, String localName, String name, String content) throws SAXException {
- if(listeners.size() == 0) return;
+ if(listeners.isEmpty()) return;
Object obj = createEndElementFoundObject(uri, localName, name, content);
for(IBaseSaxElementListener listener:listeners){
listener.onEndElement(obj);
@@ -49,7 +49,7 @@ public abstract class ElementHandlers { }
void startElementFound(String uri, String localName, String name, Attributes attributes) throws SAXException {
- if(listeners.size() == 0) return;
+ if(listeners.isEmpty()) return;
Object obj = createStartElementFoundObject(uri, localName, name, attributes);
for(IBaseSaxElementListener listener:listeners){
listener.onStartElement(obj);
diff --git a/plugins/org.eclipse.osee.ote.ui.define/src/org/eclipse/osee/ote/ui/define/viewers/XViewerDataManager.java b/plugins/org.eclipse.osee.ote.ui.define/src/org/eclipse/osee/ote/ui/define/viewers/XViewerDataManager.java index 0e37295ff4c..0b617214888 100644 --- a/plugins/org.eclipse.osee.ote.ui.define/src/org/eclipse/osee/ote/ui/define/viewers/XViewerDataManager.java +++ b/plugins/org.eclipse.osee.ote.ui.define/src/org/eclipse/osee/ote/ui/define/viewers/XViewerDataManager.java @@ -69,7 +69,7 @@ public class XViewerDataManager { }
public void addArtifacts(IProgressMonitor monitor, final List<Artifact> artifacts) throws OseeCoreException, AttributeDoesNotExist {
- if (branchMap.size() == 0) {
+ if (branchMap.isEmpty()) {
if (xViewer.getXViewerFactory() instanceof MassXViewerFactory) {
((MassXViewerFactory) xViewer.getXViewerFactory()).registerAllAttributeColumnsForArtifacts(artifacts, true);
}
@@ -268,6 +268,6 @@ public class XViewerDataManager { }
public boolean isEmpty() {
- return branchMap.size() == 0;
+ return branchMap.isEmpty();
}
}
diff --git a/plugins/org.eclipse.osee.ote.ui.test.manager/src/org/eclipse/osee/ote/ui/test/manager/pages/scriptTable/xscript/XScriptTableLabelProvider.java b/plugins/org.eclipse.osee.ote.ui.test.manager/src/org/eclipse/osee/ote/ui/test/manager/pages/scriptTable/xscript/XScriptTableLabelProvider.java index 76b83c118e7..a7b3ffb24ce 100644 --- a/plugins/org.eclipse.osee.ote.ui.test.manager/src/org/eclipse/osee/ote/ui/test/manager/pages/scriptTable/xscript/XScriptTableLabelProvider.java +++ b/plugins/org.eclipse.osee.ote.ui.test.manager/src/org/eclipse/osee/ote/ui/test/manager/pages/scriptTable/xscript/XScriptTableLabelProvider.java @@ -34,7 +34,7 @@ public class XScriptTableLabelProvider extends XViewerLabelProvider { public XScriptTableLabelProvider(XScriptTable viewer) {
super(viewer);
- if (statusImage.size() == 0) {
+ if (statusImage.isEmpty()) {
statusImage.put(ScriptStatusEnum.NOT_CONNECTED, ImageManager.getImage(OteTestManagerImage.ALERT_OBJ));
statusImage.put(ScriptStatusEnum.READY, ImageManager.getImage(OteTestManagerImage.SCRIPT_READY_SM));
statusImage.put(ScriptStatusEnum.IN_QUEUE, ImageManager.getImage(OteTestManagerImage.SCRIPT_IN_QUEUE_SM));
|