Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjphillips2008-06-02 21:24:02 +0000
committerjphillips2008-06-02 21:24:02 +0000
commit4030df336ffcfc927c6a937d8c04d67ee964d94e (patch)
treea465da5da2e84e133da260bc8238f1d66ae1fabe
parent20828c6959ddc2ea45234e5c30219d07ccd4bfab (diff)
downloadorg.eclipse.osee-4030df336ffcfc927c6a937d8c04d67ee964d94e.tar.gz
org.eclipse.osee-4030df336ffcfc927c6a937d8c04d67ee964d94e.tar.xz
org.eclipse.osee-4030df336ffcfc927c6a937d8c04d67ee964d94e.zip
-rw-r--r--org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/revision/RevisionManager.java16
1 files changed, 4 insertions, 12 deletions
diff --git a/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/revision/RevisionManager.java b/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/revision/RevisionManager.java
index c2064365611..9f3d939cac9 100644
--- a/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/revision/RevisionManager.java
+++ b/org.eclipse.osee.framework.skynet.core/src/org/eclipse/osee/framework/skynet/core/revision/RevisionManager.java
@@ -420,7 +420,6 @@ public class RevisionManager implements PersistenceManager, IEventReceiver {
ArrayList<Change> changes = new ArrayList<Change>();
Set<Integer> artIds = new HashSet<Integer>();
- //Artifact changes must be ran before attribute changes so new artifacts can be displayed as artifact changes not attribute changes.
loadNewOrDeletedArtifactChanges(sourceBranch, transactionIdNumber, artIds, changes);
loadAttributeChanges(sourceBranch, transactionIdNumber, artIds, changes);
loadRelationChanges(sourceBranch, transactionIdNumber, artIds, changes);
@@ -463,7 +462,7 @@ public class RevisionManager implements PersistenceManager, IEventReceiver {
//We do not want to display artifacts that were new and then deleted
if (!artifactChanges.containsKey(artId)) {
- artIds.add(artId);
+ artIds.add(artId);
changes.add(artifactChanged);
artifactChanges.put(artId, artifactChanged);
} else {
@@ -522,7 +521,6 @@ public class RevisionManager implements PersistenceManager, IEventReceiver {
Map<Integer, Change> mightNeedWasValue = new HashMap<Integer, Change>();
ConnectionHandlerStatement connectionHandlerStatement = null;
boolean hasBranch = sourceBranch != null;
- Set<Integer> attributeArtIds = new HashSet<Integer>();
TransactionId sourceHeadTransactionId;
TransactionId sourceEndTransactionId;
@@ -559,22 +557,16 @@ public class RevisionManager implements PersistenceManager, IEventReceiver {
int modType = resultSet.getInt("mod_type");
String isValue = resultSet.getString("is_value");
- //New artifacts are displayed as artifact changes not attribute changes
- if (!artIds.contains(artId)) {
attributeChanged =
new AttributeChanged(sourceBranch, artTypeId, sourceGamma, artId, sourceEndTransactionId,
- sourceHeadTransactionId,
- hasBranch ? ModificationType.NEW : ModificationType.getMod(modType), ChangeType.OUTGOING,
- isValue, "", attrId, attrTypeId);
+ sourceHeadTransactionId, hasBranch ? ModificationType.NEW : ModificationType.getMod(modType),
+ ChangeType.OUTGOING, isValue, "", attrId, attrTypeId);
changes.add(attributeChanged);
mightNeedWasValue.put(attrId, attributeChanged);
- attributeArtIds.add(artId);
- }
+ artIds.add(artId);
}
- artIds.addAll(attributeArtIds);
-
//Load was values for branch change reports only
if (hasBranch && !artIds.isEmpty()) {
String BRANCH_ATTRIBUTE_WAS_CHANGE =

Back to the top